Skip to contentSkip to conversation

misc: Keep FSL_IFC available on PowerPC as well

PATCH In review Tom Rini 3 participants 8 messages Jan 28 – Jan 29 Char and misc drivers

lore
Share & tools
lore

Tom Rini

author
#0 lore raw

PATCH 1/1 misc: Keep FSL_IFC available on PowerPC as well

This symbol is used on a number of PowerPC platforms as well, so make it available there again.

Fixes 424b324165ea ("armv7: Add CPLD support via IFC to the ls1021a-iot board.")

---
Cc: Mateus Lima Alves <[email protected]>
Cc: Peng Fan <[email protected]>

---
 drivers/misc/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/misc/Kconfig +1 -1
index be7fdab56d14..a0aa290480eb 100644
@@ -695,7 +695,7 @@ config ESM_PMIC
 
 config FSL_IFC
 	bool "Freescale Integrated Flash Controller"
-	depends on ARM
+	depends on ARM || PPC
 	help
 	  This driver is for the Integrated Flash Controller(IFC) module
 	  available in Freescale SoCs. This controller allows to handle
Signature · 1 line
2.43.0
#1 lore raw

Hi Tom,

Indeed, there are a lot of PPC targets that try to use this symbol, but as Peng Fan reported before, his CI reported a build failure.

Quoted 20 lines · Peng Fan
Quoted 3 lines · Mateus Lima Alves

This patch adds CPLD support via IFC to the ls1021a-iot board.

CI report build failure.

CC drivers/video/hitachi-tx10d07vm0baa.o
In file included from drivers/misc/fsl_ifc.c:8:
include/fsl_ifc.h:16:10: fatal error: asm/ppc.h: No such file or directory
16 | #include <asm/ppc.h>

      |          ^~~~~~~~~~~

compilation terminated.
make[3]: *** [scripts/Makefile.build:271: drivers/misc/fsl_ifc.o] Error 1 make[2]: *** [scripts/Makefile.build:492: drivers/misc] Error 2 make[2]: *** Waiting for unfinished jobs....

  CC      drivers/rtc/ht1380.o
  CC      drivers/video/hitachi_tx18d42vm_lcd.o
  CC      drivers/rtc/i2c_rtc_emul.o
Quoted 6 lines

make[1]: *** [Makefile:2191: drivers] Error 2
make: *** [Makefile:362: __build_one_by_one] Error 2 Cleaning up project directory and file based variables

Regards
Peng

Is that okay now Peng Fan?

If so, then my v2 patch would have worked.

BR,
Mateus

Quoted 30 lines · Tom Rini

This symbol is used on a number of PowerPC platforms as well, so make it available there again.

Fixes 424b324165ea ("armv7: Add CPLD support via IFC to the ls1021a-iot

board.")

---
Cc: Mateus Lima Alves <[email protected]>
Cc: Peng Fan <[email protected]>

---
 drivers/misc/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/misc/Kconfig +1 -2
index be7fdab56d14..a0aa290480eb 100644
@@ -695,7 +695,7 @@ config ESM_PMIC
 
 config FSL_IFC
        bool "Freescale Integrated Flash Controller"
-       depends on ARM
+       depends on ARM || PPC
        help
          This driver is for the Integrated Flash Controller(IFC) module
          available in Freescale SoCs. This controller allows to handle
--

2.43.0

author
#2 lore raw
Quoted 4 lines · Mateus Lima

Hi Tom,

Indeed, there are a lot of PPC targets that try to use this symbol, but as Peng Fan reported before, his CI reported a build failure.

Yes, I'm not sure what the particular problem there was with your previous patch / Peng's setup:
https://source.denx.de/u-boot/u-boot/-/pipelines/29116
(the failure is because we need
https://patchwork.ozlabs.org/project/uboot/list/?series=488348&state=*
merged to master).

Quoted 70 lines · Peng Fan
Quoted 21 lines · Mateus Lima Alves
Quoted 3 lines

This patch adds CPLD support via IFC to the ls1021a-iot board.

CI report build failure.

CC drivers/video/hitachi-tx10d07vm0baa.o
In file included from drivers/misc/fsl_ifc.c:8:
include/fsl_ifc.h:16:10: fatal error: asm/ppc.h: No such file or directory
16 | #include <asm/ppc.h>

      |          ^~~~~~~~~~~

compilation terminated.
make[3]: *** [scripts/Makefile.build:271: drivers/misc/fsl_ifc.o] Error 1 make[2]: *** [scripts/Makefile.build:492: drivers/misc] Error 2 make[2]: *** Waiting for unfinished jobs....

  CC      drivers/rtc/ht1380.o
  CC      drivers/video/hitachi_tx18d42vm_lcd.o
  CC      drivers/rtc/i2c_rtc_emul.o
Quoted 6 lines

make[1]: *** [Makefile:2191: drivers] Error 2
make: *** [Makefile:362: __build_one_by_one] Error 2 Cleaning up project directory and file based variables

Regards
Peng

Is that okay now Peng Fan?

If so, then my v2 patch would have worked.

BR,
Mateus

Quoted 30 lines · Tom Rini

This symbol is used on a number of PowerPC platforms as well, so make it available there again.

Fixes 424b324165ea ("armv7: Add CPLD support via IFC to the ls1021a-iot

board.")

---
Cc: Mateus Lima Alves <[email protected]>
Cc: Peng Fan <[email protected]>

---
 drivers/misc/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/misc/Kconfig +1 -2
index be7fdab56d14..a0aa290480eb 100644
@@ -695,7 +695,7 @@ config ESM_PMIC
 
 config FSL_IFC
        bool "Freescale Integrated Flash Controller"
-       depends on ARM
+       depends on ARM || PPC
        help
          This driver is for the Integrated Flash Controller(IFC) module
          available in Freescale SoCs. This controller allows to handle
--

2.43.0

Signature · 1 line
Tom
#3 lore raw

I understand, Tom, I'm just asking Peng Fan if this won't break his build, as he mentioned earlier.

And please, Tom and Peng Fan, forgive me if I made any mistakes in the patch submission procedure, it's my first contribution to the project and I truly admire you for maintaining such a large project.

I hope to learn from you and contribute more to the community.

BR,
Mateus

Quoted 94 lines · Tom Rini
Quoted 3 lines · Mateus Lima

Hi Tom,

Indeed, there are a lot of PPC targets that try to use this symbol, but

as

Quoted 1 line

Peng Fan reported before, his CI reported a build failure.

Yes, I'm not sure what the particular problem there was with your previous patch / Peng's setup:
https://source.denx.de/u-boot/u-boot/-/pipelines/29116
(the failure is because we need
https://patchwork.ozlabs.org/project/uboot/list/?series=488348&state=*
merged to master).

Quoted 6 lines · Peng Fan
Quoted 4 lines · Mateus Lima Alves
Quoted 2 lines

This patch adds CPLD support via IFC to the ls1021a-iot board.

Quoted 7 lines
Quoted 7 lines
Quoted 1 line

CI report build failure.

CC drivers/video/hitachi-tx10d07vm0baa.o
In file included from drivers/misc/fsl_ifc.c:8:
include/fsl_ifc.h:16:10: fatal error: asm/ppc.h: No such file or

directory

Quoted 4 lines
Quoted 4 lines
   16 | #include <asm/ppc.h>
      |          ^~~~~~~~~~~

compilation terminated.
make[3]: *** [scripts/Makefile.build:271: drivers/misc/fsl_ifc.o]

Error 1

Quoted 14 lines
Quoted 6 lines

make[2]: *** [scripts/Makefile.build:492: drivers/misc] Error 2 make[2]: *** Waiting for unfinished jobs....

  CC      drivers/rtc/ht1380.o
  CC      drivers/video/hitachi_tx18d42vm_lcd.o
  CC      drivers/rtc/i2c_rtc_emul.o
Quoted 6 lines

make[1]: *** [Makefile:2191: drivers] Error 2
make: *** [Makefile:362: __build_one_by_one] Error 2 Cleaning up project directory and file based variables

Regards
Peng

Quoted 10 lines

Is that okay now Peng Fan?

If so, then my v2 patch would have worked.

BR,
Mateus

Quoted 1 line · Tom Rini

This symbol is used on a number of PowerPC platforms as well, so make

it

Quoted 3 lines
Quoted 3 lines

available there again.

Fixes 424b324165ea ("armv7: Add CPLD support via IFC to the

ls1021a-iot

Quoted 15 lines
Quoted 15 lines

board.")

---
Cc: Mateus Lima Alves <[email protected]>
Cc: Peng Fan <[email protected]>

---
 drivers/misc/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/misc/Kconfig +0 -0
index be7fdab56d14..a0aa290480eb 100644
@@ -695,7 +695,7 @@ config ESM_PMIC
 
Quoted 6 lines

drivers/misc/Kconfig config ESM_PMIC

Quoted 6 lines
drivers/misc/Kconfig +1 -1
 config FSL_IFC
        bool "Freescale Integrated Flash Controller"
-       depends on ARM
+       depends on ARM || PPC
        help
          This driver is for the Integrated Flash Controller(IFC)

module

Quoted 5 lines
Quoted 5 lines
drivers/misc/Kconfig +0 -1
          available in Freescale SoCs. This controller allows to handle
--

2.43.0

--
Tom

author
#4 lore raw
Quoted 8 lines · Mateus Lima

I understand, Tom, I'm just asking Peng Fan if this won't break his build, as he mentioned earlier.

And please, Tom and Peng Fan, forgive me if I made any mistakes in the patch submission procedure, it's my first contribution to the project and I truly admire you for maintaining such a large project.

I hope to learn from you and contribute more to the community.

Yes, thank you for the contribution. I'm really just lamenting that the error here is one that we can't catch in CI at this point in time.

Signature · 1 line
Tom
Acked-by on v1 1/1
#5 lore raw
In reply to Tom Rini
Quoted 8 lines

Subject: [PATCH] misc: Keep FSL_IFC available on PowerPC as well

This symbol is used on a number of PowerPC platforms as well, so make it available there again.

Fixes 424b324165ea ("armv7: Add CPLD support via IFC to the

ls1021a-iot board.")

Tom, I not have patches for fsl-qoirq queue. Would you please directly pick up?

Thanks
Peng.

Quoted 22 lines

---
Cc: Mateus Lima Alves <[email protected]>
Cc: Peng Fan <[email protected]>

---
 drivers/misc/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/misc/Kconfig index renamed from drivers/misc/Kconfig +0 -0

be7fdab56d14..a0aa290480eb 100644

drivers/misc/Kconfig +1 -2
@@ -695,7 +695,7 @@ config ESM_PMIC
 
 config FSL_IFC
 	bool "Freescale Integrated Flash Controller"
-	depends on ARM
+	depends on ARM || PPC
 	help
 	  This driver is for the Integrated Flash Controller(IFC) module
 	  available in Freescale SoCs. This controller allows to handle
--

2.43.0

author
#6 lore raw
Quoted 5 lines · Peng Fan
Quoted 5 lines

Subject: [PATCH] misc: Keep FSL_IFC available on PowerPC as well

This symbol is used on a number of PowerPC platforms as well, so make it available there again.

Quoted 8 lines
Quoted 3 lines
Fixes 424b324165ea ("armv7: Add CPLD support via IFC to the

ls1021a-iot board.")

Tom, I not have patches for fsl-qoirq queue. Would you please directly pick up?

Will do.

Signature · 1 line
Tom
author
#7 lore raw
In reply to Tom Rini
Quoted 4 lines · Tom Rini

This symbol is used on a number of PowerPC platforms as well, so make it available there again.

Applied to u-boot/master, thanks!

[1/1] misc: Keep FSL_IFC available on PowerPC as well

      commit: 3f6b113291c714b19c3acc1b3f07b5a249b0ee05
Signature · 1 line
Tom