edac: i82443bxgx: remove driver that has been marked broken since 2007
PATCH 1/1 edac: i82443bxgx: remove driver that has been marked broken since 2007
The history of this driver is pretty amusing. It was marked broken in 2007 in commit 28f96eeafc89 ("drivers/edac-new-i82443bxgz-mc-driver:
mark as broken"). It was then fixed in 2008 in commit 53a2fe5804e8 ("edac: make i82443bxgx_edac coexist with intel_agp"), but the dependency on BROKEN was never removed. Given that this was never fixed in the last ~18 years, it is obvious there is no demand for this driver. Remove it and move the former maintainer to the CREDITS file.
--- CREDITS | 4 + MAINTAINERS | 6 - drivers/edac/Kconfig | 8 - drivers/edac/Makefile | 1 - drivers/edac/i82443bxgx_edac.c | 462 --------------------------------- 5 files changed, 4 insertions(+), 477 deletions(-) delete mode 100644 drivers/edac/i82443bxgx_edac.c
CREDITS +4 -0
@@ -3771,6 +3771,10 @@ S: 10 Stockalls Place S: Minto, NSW, 2566 S: Australia +N: Tim Small +E: [email protected] +D: Intel 82443BX/GX (440BX/GX chipset) EDAC driver + N: Stephen Smalley E: [email protected] D: portions of the Linux Security Module (LSM) framework and security modules
MAINTAINERS +0 -6
@@ -9098,12 +9098,6 @@ L: [email protected] S: Maintained F: drivers/edac/i7core_edac.c -EDAC-I82443BXGX -M: Tim Small <[email protected]> -L: [email protected] -S: Maintained -F: drivers/edac/i82443bxgx_edac.c - EDAC-I82975X M: "Arvind R." <[email protected]> L: [email protected]
drivers/edac/Kconfig +0 -8
@@ -150,14 +150,6 @@ config EDAC_E752X Support for error detection and correction on the Intel E7520, E7525, E7320 server chipsets. -config EDAC_I82443BXGX - tristate "Intel 82443BX/GX (440BX/GX)" - depends on PCI && X86_32 - depends on BROKEN - help - Support for error detection and correction on the Intel - 82443BX/GX memory controllers (440BX/GX chipsets). - config EDAC_I82875P tristate "Intel 82875p (D82875P, E7210)" depends on PCI && X86_32
drivers/edac/Makefile +0 -1
@@ -38,7 +38,6 @@ obj-$(CONFIG_EDAC_PND2) += pnd2_edac.o obj-$(CONFIG_EDAC_IGEN6) += igen6_edac.o obj-$(CONFIG_EDAC_E7XXX) += e7xxx_edac.o obj-$(CONFIG_EDAC_E752X) += e752x_edac.o -obj-$(CONFIG_EDAC_I82443BXGX) += i82443bxgx_edac.o obj-$(CONFIG_EDAC_I82875P) += i82875p_edac.o obj-$(CONFIG_EDAC_I82975X) += i82975x_edac.o obj-$(CONFIG_EDAC_I3000) += i3000_edac.o
drivers/edac/i82443bxgx_edac.c deleted +0 -462
462 lines not on this page · raw message
Signature · 1 line
2.43.0
Borislav Petkov
maintainerQuoted 9 lines · Ethan Nelson-Moore
The history of this driver is pretty amusing. It was marked broken in 2007 in commit
28f96eeafc89("drivers/edac-new-i82443bxgz-mc-driver:
mark as broken"). It was then fixed in 2008 in commit53a2fe5804e8("edac: makei82443bxgx_edaccoexist withintel_agp"), but the dependency on BROKEN was never removed. Given that this was never fixed in the last ~18 years, it is obvious there is no demand for this driver. Remove it and move the former maintainer to the CREDITS file.Signed-off-by Ethan Nelson-Moore <[email protected]>
Quoted 8 lines
--- CREDITS | 4 + MAINTAINERS | 6 - drivers/edac/Kconfig | 8 - drivers/edac/Makefile | 1 - drivers/edac/i82443bxgx_edac.c | 462 --------------------------------- 5 files changed, 4 insertions(+), 477 deletions(-) delete mode 100644 drivers/edac/i82443bxgx_edac.c
I couldn't care less about supporting a chipset in Pentium II or III.
Tony?
Signature · 4 lines
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquetteLuck, Tony
maintainerQuoted 3 lines
I couldn't care less about supporting a chipset in Pentium II or III.
Tony?
Nor me.
Very old systems (prior to Sandybridge Xeon) had EDAC drivers written by community (mostly HPC folks - they called it "project bluesmoke").
Intel began taking an interest starting with sb_edac.c
-Tony
Borislav Petkov
maintainerQuoted 10 lines · Tony
Quoted 3 lines
I couldn't care less about supporting a chipset in Pentium II or III.
Tony?
Nor me.
Very old systems (prior to Sandybridge Xeon) had EDAC drivers written by community (mostly HPC folks - they called it "project bluesmoke").
Intel began taking an interest starting with
sb_edac.c
Right.
And regarding this particular driver, I haven't heard of anyone using it. So lemme remove it. If someone complains we can always resurrect it.
Thx.
Signature · 4 lines
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquetteA message that is not in the archive (sent off-list or not yet received): [email protected]
Hi, Tim,
Quoted 1 line · Tim Small
This particular driver did apparently get used by Akamai quite heavily and widely but all ancient history now. The Radisys r82600 edac driver
r82600_edac.cwas closely related hardware from the same era, and can probably go too (although being embedded hardware, it's possible its production lifespan was considerably longer).
Thanks for your input.
I can't even find any information online about the Radisys 82600 (note for anyone else trying: not r82600) beyond its own documentation and one reference to its use in a Nokia 2G GSM base station:
https://www.scribd.com/document/50855914/AS7-C
I'll send a patch to remove its driver.
Ethan