tools/intel_display_crc: fix DRM device selection
PATCH 1/1 tools/intel_display_crc: fix DRM device selection
Initialize DRM device fd to -1 to allow automatic DRM device selection in igt_debugfs_path(). By the looks of it, this has been broken for years.
While at it, make the context variable local and initialize using designated initializers.
--- tools/intel_display_crc.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
tools/intel_display_crc.c +4 -4
@@ -83,14 +83,14 @@ static void print_crcs(display_crc_t *ctx)igt_pipe_crc_free (pipe_crc); } -static display_crc_t ctx; -int main (int argc,char **argv) { +display_crc_t ctx = { + .fd =-1 , + .n_crcs =1 , + };int opt; - ctx.n_crcs =1 ; -while ((opt =getopt (argc, argv,"p:n:" )) !=-1 ) {switch (opt) {case 'p' :
Signature · 1 line
2.47.3
Hi Jani,
Quoted 8 lines · Jani Nikula
Initialize DRM device fd to -1 to allow automatic DRM device selection in
igt_debugfs_path(). By the looks of it, this has been broken for years.While at it, make the context variable local and initialize using designated initializers.
Signed-off-by Jani Nikula <[email protected]>
LGTM
Regards,
Kamil
Quoted 30 lines
--- tools/intel_display_crc.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)tools/intel_display_crc.c +4
-4@@ -83,14 +83,14 @@ static void print_crcs(display_crc_t *ctx)igt_pipe_crc_free (pipe_crc); } -static display_crc_t ctx; -int main (int argc,char **argv) { +display_crc_t ctx = { + .fd =-1 , + .n_crcs =1 , + };int opt; - ctx.n_crcs =1 ; -while ((opt =getopt (argc, argv,"p:n:" )) !=-1 ) {switch (opt) {case 'p' :Signature · 1 line
2.47.3
Patchwork
CI✗ Fi.CI.BAT: failure for tools/intel_display_crc: fix DRM device selection
In reply to Jani Nikula== Series Details ==
== Series Details ==
Series: tools/intel_display_crc: fix DRM device selection
URL : https://patchwork.freedesktop.org/series/160849/
State : failure
== Summary ==
Series 160849 revision 1 was fully merged or fully failed: no git log