Skip to contentSkip to conversation

pinctrl: fix kismet issues with GENERIC_PINCTRL

PATCH In review Conor Dooley 2 participants 2 messages Jan 30 – Feb 3

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pinctrl: fix kismet issues with GENERIC_PINCTRL

From: Conor Dooley <[email protected]>

lkp reported that GENERIC_PINCTRL can be select when its dependencies are not. Swap the "depends on" out for "select", as is used in other parts of the pinctrl core that are expected to be selected by drivers.

Fixes 43722575e5cd ("pinctrl: add generic functions + pins mapper")
---
 drivers/pinctrl/Kconfig | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/pinctrl/Kconfig +3 -3
index 6cc5e214f4f3..afecd9407f53 100644
@@ -27,9 +27,9 @@ config GENERIC_PINCONF
 
 config GENERIC_PINCTRL
 	bool
-	depends on GENERIC_PINCONF
-	depends on GENERIC_PINCTRL_GROUPS
-	depends on GENERIC_PINMUX_FUNCTIONS
+	select GENERIC_PINCONF
+	select GENERIC_PINCTRL_GROUPS
+	select GENERIC_PINMUX_FUNCTIONS
 
 config DEBUG_PINCTRL
 	bool "Debug PINCTRL calls"
Signature · 1 line
2.51.0
maintainer
#1 lore raw
Quoted 10 lines · Conor Dooley

From: Conor Dooley <[email protected]>

lkp reported that GENERIC_PINCTRL can be select when its dependencies are not. Swap the "depends on" out for "select", as is used in other parts of the pinctrl core that are expected to be selected by drivers.

Fixes 43722575e5cd ("pinctrl: add generic functions + pins mapper")

Patch applied!

Yours,
Linus Walleij