Skip to contentSkip to conversation

dt-bindings: mtd: cdns,hp-nfc: Add dma-coherent property

PATCH Applied Dinh Nguyen 3 participants 4 messages Jan 31 – Feb 3

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dt-bindings: mtd: cdns,hp-nfc: Add dma-coherent property

From: Khairul Anuar Romli <[email protected]>

The Cadence HP NAND Flash Controller on supports DMA transactions through a coherent interconnect. In previous generations SoC (Stratix10 and Agilex) the interconnect was non-coherent, hence there is no need for dma-coherent property to be presence. In Agilex 5, the architecture has changed. It introduced a coherent interconnect that supports cache-coherent DMA.

---
 Documentation/devicetree/bindings/mtd/cdns,hp-nfc.yaml | 2 ++
 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/mtd/cdns,hp-nfc.yaml +2 -0
index 73dc69cee4d8..367257a227b1 100644
@@ -40,6 +40,8 @@ properties:
   dmas:
     maxItems: 1
 
+  dma-coherent: true
+
   iommus:
     maxItems: 1
 
Signature · 1 line
2.42.0.411.g813d9a9188
#1 lore raw
Quoted 10 lines · Dinh Nguyen

From: Khairul Anuar Romli <[email protected]>

The Cadence HP NAND Flash Controller on supports DMA transactions through a coherent interconnect. In previous generations SoC (Stratix10 and Agilex) the interconnect was non-coherent, hence there is no need for dma-coherent property to be presence. In Agilex 5, the architecture has changed. It introduced a coherent interconnect that supports cache-coherent DMA.

Why does this v1 have an ack?

Quoted 22 lines
---
 Documentation/devicetree/bindings/mtd/cdns,hp-nfc.yaml | 2 ++
 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/mtd/cdns,hp-nfc.yaml +2 -0
index 73dc69cee4d8..367257a227b1 100644
@@ -40,6 +40,8 @@ properties:
   dmas:
     maxItems: 1
 
+  dma-coherent: true
+
   iommus:
     maxItems: 1
 
Signature · 1 line
2.42.0.411.g813d9a9188
#2 lore raw
Quoted 9 lines · Conor Dooley
Quoted 8 lines · Dinh Nguyen

From: Khairul Anuar Romli <[email protected]>

The Cadence HP NAND Flash Controller on supports DMA transactions through a coherent interconnect. In previous generations SoC (Stratix10 and Agilex) the interconnect was non-coherent, hence there is no need for dma-coherent property to be presence. In Agilex 5, the architecture has changed. It introduced a coherent interconnect that supports cache-coherent DMA.

Quoted 5 lines
Quoted 2 lines

Why does this v1 have an ack?

I respun this patch based on the mtd tree so that the mtd maintainers can take it. I had originally applied it to my tree, but avoid merge conflicts, I'm going to submit it through mtd. This patch is the same as this[1].

Sorry for any confusion.

Dinh
[1] https://lore.kernel.org/linux-devicetree/[email protected]/

maintainer Applied
#3 lore raw
In reply to Dinh Nguyen
Quoted 8 lines · Dinh Nguyen

The Cadence HP NAND Flash Controller on supports DMA transactions through a coherent interconnect. In previous generations SoC (Stratix10 and Agilex) the interconnect was non-coherent, hence there is no need for dma-coherent property to be presence. In Agilex 5, the architecture has changed. It introduced a coherent interconnect that supports cache-coherent DMA.

[...]

Applied to mtd/next, thanks!

[1/1] dt-bindings: mtd: cdns,hp-nfc: Add dma-coherent property

      commit: 875382759298650c96192bf2c12e2d1e4575de92

Patche(s) should be available on mtd/linux.git and will be part of the next PR (provided that no robot complains by then).

Kind regards,
Miquèl