char: remove unnecessary module_init/exit functions
Subsystems (2)
PATCH 1/1 char: remove unnecessary module_init/exit functions
Two char drivers have unnecessary module_init and module_exit functions that are empty or just print a message. Remove them. Note that if a module_init function exists, a module_exit function must also exist; otherwise, the module cannot be unloaded.
Signed-off-by Ethan Nelson-Moore <[email protected]>
--- drivers/char/agp/backend.c | 16 ---------------- drivers/char/nsc_gpio.c | 14 -------------- 2 files changed, 30 deletions(-)
drivers/char/agp/backend.c +0 -16
@@ -323,18 +323,6 @@ int agp_try_unsupported_boot;EXPORT_SYMBOL (agp_off);EXPORT_SYMBOL (agp_try_unsupported_boot); -static int __init agp_init (void ) -{ -if (!agp_off) -printk (KERN_INFO "Linux agpgart interface v%d.%d\n" , -AGPGART_VERSION_MAJOR ,AGPGART_VERSION_MINOR ); -return 0 ; -} - -static void __exit agp_exit(void) -{ -} -#ifndef MODULE static __init int agp_setup (char *s) {
@@ -351,7 +339,3 @@ MODULE_AUTHOR("Dave Jones, Jeff Hartmann");MODULE_DESCRIPTION ("AGP GART driver" );MODULE_LICENSE ("GPL and additional rights" );MODULE_ALIAS_MISCDEV (AGPGART_MINOR ); - -module_init (agp_init); -module_exit (agp_exit); -
drivers/char/nsc_gpio.c +0 -14
@@ -121,20 +121,6 @@ EXPORT_SYMBOL(nsc_gpio_write);EXPORT_SYMBOL (nsc_gpio_read);EXPORT_SYMBOL (nsc_gpio_dump); -static int __init nsc_gpio_init (void ) -{ - printk(KERN_DEBUG NAME " initializing\n"); -return 0 ; -} - -static void __exit nsc_gpio_cleanup(void) -{ - printk(KERN_DEBUG NAME " cleanup\n"); -} - -module_init (nsc_gpio_init); -module_exit (nsc_gpio_cleanup); -MODULE_AUTHOR ("Jim Cromie <[email protected]>" );MODULE_DESCRIPTION ("NatSemi GPIO Common Methods" );MODULE_LICENSE ("GPL" );
Signature · 1 line
2.43.0