Skip to contentSkip to conversation

iio: magn: mmc5633: Fix Kconfig for combination of I3C as module and driver builtin

PATCH In review Jonathan Cameron 2 participants 2 messages Jan 31 IIO

lore
Share & tools
lore

Jonathan Cameron

author maintainer
#0 lore raw

PATCH 1/1 iio: magn: mmc5633: Fix Kconfig for combination of I3C as module and driver builtin

From: Jonathan Cameron <[email protected]>

Fix based on similar fix in:
commit 83b645ee43f7 ("hwmon: tmp108: fix I3C dependency")

Note to keep things simple I'm now requiring I2C.
That can probably be relaxed in future, but I want to reduce the test set of builds for now given this is blocker for the main IIO pull request.

Fixes e559c8641460 ("iio: magn: mmc5633: Ensure REGMAP_I2C / I3C not build if I2C / I3C is not.")

---

Note this is already on the IIO togreg branch given very short timing. Any review much appreciated!

 drivers/iio/magnetometer/Kconfig | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/iio/magnetometer/Kconfig +3 -2
index 2b81b22c9550..9345fb6d5317 100644
@@ -141,9 +141,10 @@ config MMC35240
 
 config MMC5633
 	tristate "MEMSIC MMC5633 3-axis magnetic sensor"
-	select REGMAP_I2C if I2C
+	select REGMAP_I2C
 	select REGMAP_I3C if I3C
-	depends on I2C || I3C
+	depends on I2C
+	depends on I3C || !I3C
 	help
 	  Say yes here to build support for the MEMSIC MMC5633 3-axis
 	  magnetic sensor.
Signature · 1 line
2.52.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 10 lines · Jonathan Cameron

From: Jonathan Cameron <[email protected]>

Fix based on similar fix in:
commit 83b645ee43f7 ("hwmon: tmp108: fix I3C dependency")

Note to keep things simple I'm now requiring I2C.
That can probably be relaxed in future, but I want to reduce the test set of builds for now given this is blocker for the main IIO pull request.

Quoted 8 lines
Fixes e559c8641460 ("iio: magn: mmc5633: Ensure REGMAP_I2C / I3C not build if I2C / I3C is not.")

---

Note this is already on the IIO togreg branch given very short timing. Any review much appreciated!

Thank you for quick fix.

Quoted 24 lines
 drivers/iio/magnetometer/Kconfig | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/iio/magnetometer/Kconfig +3 -3
index 2b81b22c9550..9345fb6d5317 100644
@@ -141,9 +141,10 @@ config MMC35240
 
 config MMC5633
 	tristate "MEMSIC MMC5633 3-axis magnetic sensor"
-	select REGMAP_I2C if I2C
+	select REGMAP_I2C
 	select REGMAP_I3C if I3C
-	depends on I2C || I3C
+	depends on I2C
+	depends on I3C || !I3C
 	help
 	  Say yes here to build support for the MEMSIC MMC5633 3-axis
 	  magnetic sensor.
--

2.52.0