dt-bindings: dma: snps,dw-axi-dmac: add dma-coherent property
Subsystems (3)
PATCH 1/1 dt-bindings: dma: snps,dw-axi-dmac: add dma-coherent property
From: Khairul Anuar Romli <[email protected]>
The Synopsys DesignWare AXI DMA Controller on Agilex5, the controller operates on a cache-coherent AXI interface, where DMA transactions are automatically kept coherent with the CPU caches. In previous generations SoC (Stratix10 and Agilex) the interconnect was non-coherent, hence there is no need for dma-coherent property to be presence. In Agilex 5, the architecture has changed. It introduced a coherent interconnect that supports cache-coherent DMA.
--- Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml | 2 ++ 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml +2 -0
@@ -68,6 +68,8 @@ properties: dma-noncoherent: true + dma-coherent: true + resets: minItems: 1 maxItems: 2
Signature · 1 line
2.42.0.411.g813d9a9188
Quoted 10 lines · Dinh Nguyen
From: Khairul Anuar Romli <[email protected]>
The Synopsys DesignWare AXI DMA Controller on Agilex5, the controller operates on a cache-coherent AXI interface, where DMA transactions are automatically kept coherent with the CPU caches. In previous generations SoC (Stratix10 and Agilex) the interconnect was non-coherent, hence there is no need for dma-coherent property to be presence. In Agilex 5, the architecture has changed. It introduced a coherent interconnect that supports cache-coherent DMA.
Quoted 2 lines
Signed-off-by Khairul Anuar Romli <[email protected]>Reviewed-by Rob Herring (Arm) <[email protected]>
Why does this v1 have an ack?
Quoted 22 lines
Signed-off-by Dinh Nguyen <[email protected]>--- Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml | 2 ++ 1 file changed, 2 insertions(+)Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml +2
-0@@ -68,6 +68,8 @@ properties: dma-noncoherent: true + dma-coherent: true + resets: minItems: 1 maxItems: 2Signature · 1 line
2.42.0.411.g813d9a9188
Quoted 11 lines · Conor Dooley
Quoted 10 lines · Dinh Nguyen
From: Khairul Anuar Romli <[email protected]>
The Synopsys DesignWare AXI DMA Controller on Agilex5, the controller operates on a cache-coherent AXI interface, where DMA transactions are automatically kept coherent with the CPU caches. In previous generations SoC (Stratix10 and Agilex) the interconnect was non-coherent, hence there is no need for dma-coherent property to be presence. In Agilex 5, the architecture has changed. It introduced a coherent interconnect that supports cache-coherent DMA.
Quoted 5 lines
Quoted 2 lines
Signed-off-by Khairul Anuar Romli <[email protected]>Reviewed-by Rob Herring (Arm) <[email protected]>Why does this v1 have an ack?
I respun this patch based on the dmaengine tree so that the dma engine maintainer can take it. I had originally applied it to my tree, but avoid potential merge conflicts, I'm going to submit it through dma. This patch is the same as this[1].
Sorry for any confusion.
Dinh
[1] https://lore.kernel.org/linux-devicetree/[email protected]/
Quoted 17 lines · Dinh Nguyen
Quoted 14 lines · Conor Dooley
Quoted 12 lines · Dinh Nguyen
From: Khairul Anuar Romli <[email protected]>
The Synopsys DesignWare AXI DMA Controller on Agilex5, the controller operates on a cache-coherent AXI interface, where DMA transactions are automatically kept coherent with the CPU caches. In previous generations SoC (Stratix10 and Agilex) the interconnect was non-coherent, hence there is no need for dma-coherent property to be presence. In Agilex 5, the architecture has changed. It introduced a coherent interconnect that supports cache-coherent DMA.
Signed-off-by Khairul Anuar Romli <[email protected]>Reviewed-by Rob Herring (Arm) <[email protected]>
Quoted 7 lines
Quoted 2 lines
Why does this v1 have an ack?
I respun this patch based on the dmaengine tree so that the dma engine maintainer can take it. I had originally applied it to my tree, but avoid potential merge conflicts, I'm going to submit it through dma. This patch is the same as this[1].
In the future, please note this or carry on the version number from the series it was originally in.
Quoted 5 lines
Sorry for any confusion.
Dinh
[1] https://lore.kernel.org/linux-devicetree/[email protected]/
Quoted 9 lines · Dinh Nguyen
The Synopsys DesignWare AXI DMA Controller on Agilex5, the controller operates on a cache-coherent AXI interface, where DMA transactions are automatically kept coherent with the CPU caches. In previous generations SoC (Stratix10 and Agilex) the interconnect was non-coherent, hence there is no need for dma-coherent property to be presence. In Agilex 5, the architecture has changed. It introduced a coherent interconnect that supports cache-coherent DMA.
[...]
Applied, thanks!
[1/1] dt-bindings: dma: snps,dw-axi-dmac: add dma-coherent property
commit: ff7cbcca2b32c6e079941e577c41c74036861d5a
Best regards,
Signature · 1 line
~Vinod