percpu-add-double-free-check-to-pcpu_free_area.patch removed from -mm tree
The quilt patch titled
Subject: percpu: add double free check to pcpu_free_area()
has been removed from the -mm tree. Its filename was
percpu-add-double-free-check-to-pcpu_free_area.patch
This patch was dropped because it was merged into the mm-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
------------------------------------------------------
From: Dennis Zhou <[email protected]>
Subject: percpu: add double free check to pcpu_free_area()
Date: Fri, 23 Jan 2026 12:55:35 -0800
Percpu memory provides access via offsets into the percpu address space. Offsets are essentially fixed for the lifetime of a chunk and therefore require all users be good samaritans. If a user improperly handles the lifetime of the percpu object, it can result in corruption in a couple of ways:
- immediate double free - breaks percpu metadata accounting
- free after subsequent allocation
- corruption due to multiple owner problem (either prior owner still writes or future allocation happens)
- potential for oops if the percpu pages are reclaimed as the subsequent allocation isn't pinning the pages down
- can lead to page->private pointers pointing to freed chunks
Sebastian noticed that if this happens, none of the memory debugging facilities add additional information [1].
This patch aims to catch invalid free scenarios within valid chunks. To better guard free_percpu(), we can either add a magic number or some tracking facility to the percpu subsystem in a separate patch.
The invalid free check in pcpu_free_area() validates that the allocation's starting bit is set in both alloc_map and bound_map. The alloc_map bit test ensures the area is allocated while the bound_map bit test checks we are freeing from the beginning of an allocation. We choose not to check the validity of the offset as that is encoded in page->private being a valid chunk.
pcpu_stats_area_dealloc() is moved later to only be on the happy path so stats are only updated on valid frees.
---
mm/percpu.c | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-)
mm/percpu.c renamed from mm/percpu.c~percpu-add-double-free-check-to-pcpu_free_area +14 -1
@@ -1279,12 +1279,16 @@ static int pcpu_free_area(struct pcpu_chint bit_off, bits, end, oslot, freed;lockdep_assert_held (&pcpu_lock); -pcpu_stats_area_dealloc (chunk); oslot =pcpu_chunk_slot (chunk); bit_off = off /PCPU_MIN_ALLOC_SIZE ; +/* check invalid free */ +if (!test_bit (bit_off, chunk->alloc_map) || + !test_bit (bit_off, chunk->bound_map)) +return 0 ; +/* find end index */ end =find_next_bit (chunk->bound_map,pcpu_chunk_map_bits (chunk), bit_off +1 );
@@ -1303,6 +1307,8 @@ static int pcpu_free_area(struct pcpu_chpcpu_chunk_relocate (chunk, oslot); +pcpu_stats_area_dealloc (chunk); +return freed; }
@@ -2242,6 +2248,13 @@ void free_percpu(void __percpu *ptr)spin_lock_irqsave (&pcpu_lock, flags); size =pcpu_free_area (chunk, off); +if (size ==0 ) { +spin_unlock_irqrestore (&pcpu_lock, flags); + +/* invalid percpu free */ +WARN_ON_ONCE (1 ); +return ; + }pcpu_alloc_tag_free_hook (chunk, off, size);
_
Patches currently in -mm which might be from [email protected] are