Skip to contentSkip to conversation

bpf/verifier: Expand the usage scenarios of bpf_kptr_xchg

PATCH Superseded Chengkaitao 2 participants 7 messages Feb 2 – Feb 3

Subsystems (4)

v4 of 7 Superseded Latest is v7 →

lore
Share & tools
lore
#0 lore raw

v4 cover bpf/verifier: Expand the usage scenarios of bpf_kptr_xchg

From: Chengkaitao <[email protected]>

When using bpf_kptr_xchg, we triggered the following error:
31: (85) call bpf_kptr_xchg#194
function calls are not allowed while holding a lock
bpf_kptr_xchg can now be used in lock-held contexts, so we extended its usage scope in [patch 1/2].

When writing test cases using bpf_kptr_xchg and bpf_rbtree_*, the following approach must be followed:

	bpf_spin_lock(&lock);
	rb_n = bpf_rbtree_root(&root);
	while (rb_n && can_loop) {
		rb_n = bpf_rbtree_remove(&root, rb_n);
		if (!rb_n)
			goto fail;

		tnode = container_of(rb_n, struct tree_node, node);
		node_data = bpf_kptr_xchg(&tnode->node_data, NULL);
		if (!node_data)
			goto fail;

		data = node_data->data;
		/* use data to do something */

		node_data = bpf_kptr_xchg(&tnode->node_data, node_data);
		if (node_data)
			goto fail;

		bpf_rbtree_add(&root, rb_n, less);

		if (lookup_key < tnode->key)
			rb_n = bpf_rbtree_left(&root, rb_n);
		else
			rb_n = bpf_rbtree_right(&root, rb_n);
	}
	bpf_spin_unlock(&lock);

The above illustrates a lock-remove-read-add-unlock workflow, which exhibits lower performance. To address this, we introduced support for a streamlined lock-read-unlock operation in [patch 2/2].

Changes in v4:
- Fix the dead logic issue in the test case
Changes in v3:
- Fix compilation errors
Changes in v2:
- Allow using bpf_kptr_xchg even if the NON_OWN_REF flag is set
- Add test case

Link to V3:
https://lore.kernel.org/all/[email protected]/
Link to V2:
https://lore.kernel.org/all/[email protected]/
Link to V1:
https://lore.kernel.org/all/[email protected]/

Chengkaitao (3):
bpf/verifier: allow calling bpf_kptr_xchg while holding a lock bpf/verifier: allow using bpf_kptr_xchg even if the NON_OWN_REF flag
is set
selftests/bpf: Add supplementary tests for bpf_kptr_xchg

 kernel/bpf/verifier.c                         |   7 +-
 .../testing/selftests/bpf/prog_tests/rbtree.c |   6 +
 tools/testing/selftests/bpf/progs/bpf_misc.h  |   4 +
 .../selftests/bpf/progs/rbtree_search_kptr.c  | 167 ++++++++++++++++++
 4 files changed, 182 insertions(+), 2 deletions(-)
 create mode 100644 tools/testing/selftests/bpf/progs/rbtree_search_kptr.c
Signature · 1 line
2.50.1 (Apple Git-155)
#1 lore raw

PATCH v4 1/3 bpf/verifier: allow calling bpf_kptr_xchg while holding a lock

From: Chengkaitao <[email protected]>

For the following scenario:

struct tree_node {
    struct bpf_rb_node node;
    struct request __kptr *req;
    u64 key;
};

struct bpf_rb_root tree_root __contains(tree_node, node); struct bpf_spin_lock tree_lock;

If we need to traverse all nodes in the rbtree, retrieve the __kptr pointer from each node, and read kernel data from the referenced object, using bpf_kptr_xchg appears unavoidable.

This patch skips the BPF verifier checks for bpf_kptr_xchg when called while holding a lock.

---
 kernel/bpf/verifier.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
kernel/bpf/verifier.c +2 -1
index 3135643d5695..05a6a6606b6c 100644
@@ -20387,7 +20387,8 @@ static int do_check_insn(struct bpf_verifier_env *env, bool *do_print_state)
 
 			if (env->cur_state->active_locks) {
 				if ((insn->src_reg == BPF_REG_0 &&
-				     insn->imm != BPF_FUNC_spin_unlock) ||
+				     insn->imm != BPF_FUNC_spin_unlock &&
+				     insn->imm != BPF_FUNC_kptr_xchg) ||
 				    (insn->src_reg == BPF_PSEUDO_KFUNC_CALL &&
 				     (insn->off != 0 || !kfunc_spin_allowed(insn->imm)))) {
 					verbose(env,
Signature · 1 line
2.50.1 (Apple Git-155)
#2 lore raw

Re: [PATCH v4 1/3] bpf/verifier: allow calling bpf_kptr_xchg while holding a lock

Quoted 12 lines · Chengkaitao

From: Chengkaitao <[email protected]>

For the following scenario:

struct tree_node {
    struct bpf_rb_node node;
    struct request __kptr *req;
    u64 key;
};

struct bpf_rb_root tree_root __contains(tree_node, node); struct bpf_spin_lock tree_lock;

Quoted 8 lines

If we need to traverse all nodes in the rbtree, retrieve the __kptr pointer from each node, and read kernel data from the referenced object, using bpf_kptr_xchg appears unavoidable.

This patch skips the BPF verifier checks for bpf_kptr_xchg when called while holding a lock.

You ignored earlier feedback. This is not ok.

pw-bot: cr

#3 lore raw

Re: [PATCH v4 1/3] bpf/verifier: allow calling bpf_kptr_xchg while holding a lock

Quoted 18 lines · Alexei Starovoitov
Quoted 16 lines · Chengkaitao

From: Chengkaitao <[email protected]>

For the following scenario:

struct tree_node {
    struct bpf_rb_node node;
    struct request __kptr *req;
    u64 key;
};

struct bpf_rb_root tree_root __contains(tree_node, node); struct bpf_spin_lock tree_lock;

If we need to traverse all nodes in the rbtree, retrieve the __kptr pointer from each node, and read kernel data from the referenced object, using bpf_kptr_xchg appears unavoidable.

Quoted 7 lines
Quoted 4 lines

This patch skips the BPF verifier checks for bpf_kptr_xchg when called while holding a lock.

You ignored earlier feedback. This is not ok.

It's my full name. Every region has its own customs and traditions, so this isn't an essential change.

Signature · 2 lines
Yours,
Chengkaitao
#4 lore raw

Re: [PATCH v4 1/3] bpf/verifier: allow calling bpf_kptr_xchg while holding a lock

Quoted 24 lines · Chengkaitao
Quoted 21 lines · Alexei Starovoitov
Quoted 19 lines · Chengkaitao

From: Chengkaitao <[email protected]>

For the following scenario:

struct tree_node {
    struct bpf_rb_node node;
    struct request __kptr *req;
    u64 key;
};

struct bpf_rb_root tree_root __contains(tree_node, node); struct bpf_spin_lock tree_lock;

If we need to traverse all nodes in the rbtree, retrieve the __kptr pointer from each node, and read kernel data from the referenced object, using bpf_kptr_xchg appears unavoidable.

This patch skips the BPF verifier checks for bpf_kptr_xchg when called while holding a lock.

Quoted 6 lines
Quoted 4 lines
Quoted 1 line

You ignored earlier feedback. This is not ok.

It's my full name. Every region has its own customs and traditions, so this isn't an essential change.

We cannot accept your patch then.
SOB has to be "Firstname Lastname"

#5 lore raw

PATCH v4 2/3 bpf/verifier: allow using bpf_kptr_xchg even if the NON_OWN_REF flag is set

In reply to Chengkaitao

From: Chengkaitao <[email protected]>

When traversing an rbtree using bpf_rbtree_left/right, if bpf_kptr_xchg is used to access the __kptr pointer contained in a node, it currently requires first removing the node with bpf_rbtree_remove and clearing the NON_OWN_REF flag, then re-adding the node to the original rbtree with bpf_rbtree_add after usage. This process significantly degrades rbtree traversal performance. The patch enables accessing __kptr pointers with the NON_OWN_REF flag set while holding the lock, eliminating the need for this remove-read-readd sequence.

---
 kernel/bpf/verifier.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
kernel/bpf/verifier.c +3 -1
index 05a6a6606b6c..bb3ff4bbb3a2 100644
@@ -9260,7 +9260,8 @@ static const struct bpf_reg_types timer_types = { .types = { PTR_TO_MAP_VALUE }
 static const struct bpf_reg_types kptr_xchg_dest_types = {
 	.types = {
 		PTR_TO_MAP_VALUE,
-		PTR_TO_BTF_ID | MEM_ALLOC
+		PTR_TO_BTF_ID | MEM_ALLOC,
+		PTR_TO_BTF_ID | MEM_ALLOC | NON_OWN_REF
 	}
 };
 static const struct bpf_reg_types dynptr_types = {
@@ -9420,6 +9421,7 @@ static int check_reg_type(struct bpf_verifier_env *env, u32 regno,
 	}
 	case PTR_TO_BTF_ID | MEM_ALLOC:
 	case PTR_TO_BTF_ID | MEM_PERCPU | MEM_ALLOC:
+	case PTR_TO_BTF_ID | MEM_ALLOC | NON_OWN_REF:
 		if (meta->func_id != BPF_FUNC_spin_lock && meta->func_id != BPF_FUNC_spin_unlock &&
 		    meta->func_id != BPF_FUNC_kptr_xchg) {
 			verifier_bug(env, "unimplemented handling of MEM_ALLOC");
Signature · 1 line
2.50.1 (Apple Git-155)
#6 lore raw

PATCH v4 3/3 selftests/bpf: Add supplementary tests for bpf_kptr_xchg

In reply to Chengkaitao

From: Chengkaitao <[email protected]>

1. Allow using bpf_kptr_xchg while holding a lock.
2. When the rb_node contains a __kptr pointer, we do not need to perform a remove-read-add operation.

This patch implements the following workflow:
1. Construct a rbtree with 16 elements.
2. Traverse the rbtree, locate the kptr pointer in the target node, and read the content pointed to by the pointer.
3. Remove all nodes from the rbtree.

---
 .../testing/selftests/bpf/prog_tests/rbtree.c |   6 +
 tools/testing/selftests/bpf/progs/bpf_misc.h  |   4 +
 .../selftests/bpf/progs/rbtree_search_kptr.c  | 167 ++++++++++++++++++
 3 files changed, 177 insertions(+)
 create mode 100644 tools/testing/selftests/bpf/progs/rbtree_search_kptr.c
tools/testing/selftests/bpf/prog_tests/rbtree.c +6 -0
index d8f3d7a45fe9..a854fb38e418 100644
@@ -9,6 +9,7 @@
 #include "rbtree_btf_fail__wrong_node_type.skel.h"
 #include "rbtree_btf_fail__add_wrong_type.skel.h"
 #include "rbtree_search.skel.h"
+#include "rbtree_search_kptr.skel.h"
 
 static void test_rbtree_add_nodes(void)
 {
@@ -193,3 +194,8 @@ void test_rbtree_search(void)
 {
 	RUN_TESTS(rbtree_search);
 }
+
+void test_rbtree_search_kptr(void)
+{
+	RUN_TESTS(rbtree_search_kptr);
+}
tools/testing/selftests/bpf/progs/bpf_misc.h +4 -0
index c9bfbe1bafc1..0904fe14ad1d 100644
@@ -188,6 +188,10 @@
 #define POINTER_VALUE	0xbadcafe
 #define TEST_DATA_LEN	64
 
+#ifndef __aligned
+#define __aligned(x) __attribute__((aligned(x)))
+#endif
+
 #ifndef __used
 #define __used __attribute__((used))
 #endif
tools/testing/selftests/bpf/progs/rbtree_search_kptr.c new file +167 -0

167 lines not on this page · raw message

Signature · 1 line
2.50.1 (Apple Git-155)