Skip to contentSkip to conversation

gpib: Fix fluke driver s390 compile issue

PATCH New Dave Penkler 1 participant 1 message Feb 2 GPIB drivers

lore
Share & tools
lore

Dave Penkler

author maintainer
#0 lore raw

PATCH 1/1 gpib: Fix fluke driver s390 compile issue

The following errors were reported for a s390 randconfig build of the fluke gpib driver:

Quoted 1 line
Quoted 1 line

drivers/gpib/eastwood/fluke_gpib.c:1002:23: error: call to undeclared function 'ioremap'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]

    1002 |         nec_priv->mmiobase = ioremap(e_priv->gpib_iomem_res->start,
         |                              ^
Quoted 1 line
Quoted 1 line

drivers/gpib/eastwood/fluke_gpib.c:1002:21: error: incompatible integer to pointer conversion assigning to 'void *' from 'int' [-Wint-conversion]

    1002 |         nec_priv->mmiobase = ioremap(e_priv->gpib_iomem_res->start,
         |                            ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    1003 |                                      resource_size(e_priv->gpib_iomem_res));
         |                                      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/gpib/eastwood/fluke_gpib.c:1036:33: error: incompatible integer to pointer conversion assigning to 'void *' from 'int' [-Wint-conversion]
    1036 |         e_priv->write_transfer_counter = ioremap(e_priv->write_transfer_counter_res->start,
         |                                        ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    1037 |                                                  resource_size(e_priv->write_transfer_counter_res));
         |                                                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Add HAS_IOMEM dependency to Kconfig for fluke driver option

Suggested-by Arnd Bergmann <[email protected]>
Reported-by kernel test robot <[email protected]>
Closes https://lore.kernel.org/oe-kbuild-all/[email protected]/ open here
Fixes baf8855c9160 ("staging: gpib: fix address space mixup")
Signed-off-by Dave Penkler <[email protected]>
---
 drivers/gpib/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/gpib/Kconfig +1 -0
index eeb50956ce85..d43a28c62ed7 100644
@@ -122,6 +122,7 @@ config GPIB_FLUKE
 	depends on OF
        select GPIB_COMMON
        select GPIB_NEC7210
+       depends on HAS_IOMEM
        help
          GPIB driver for Fluke based cda devices.
Signature · 1 line
2.52.0