Skip to contentSkip to conversation

phy: GOOGLE_USB: add TYPEC dependency

PATCH Applied Arnd Bergmann 3 participants 3 messages Feb 2 – Feb 4 Generic PHY framework

lore
Share & tools
lore

Arnd Bergmann

author
#0 lore raw

PATCH 1/1 phy: GOOGLE_USB: add TYPEC dependency

From: Arnd Bergmann <[email protected]>

With CONFIG_TYPEC=m, this driver cannot be built-in:

arm-linux-gnueabi/bin/arm-linux-gnueabi-ld: drivers/phy/phy-google-usb.o: in function `google_usb_phy_remove':
phy-google-usb.c:(.text+0x24): undefined reference to `typec_switch_unregister'

Add CONFIG_TYPEC as a hard dependency here to force a clean build. In theory, compile-testing with CONFIG_TYPEC=n would also work, but that seems pointless.

Fixes cbce66669c82 ("phy: Add Google Tensor SoC USB PHY driver")
Signed-off-by Arnd Bergmann <[email protected]>
---
 drivers/phy/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/phy/Kconfig +1 -0
index 142e7b0ef2ef..02467dfd4fb0 100644
@@ -50,6 +50,7 @@ config GENERIC_PHY_MIPI_DPHY
 config PHY_GOOGLE_USB
 	tristate "Google Tensor SoC USB PHY driver"
 	select GENERIC_PHY
+	depends on TYPEC
 	help
 	  Enable support for the USB PHY on Google Tensor SoCs, starting with
 	  the G5 generation (Laguna). This driver provides the PHY interfaces
Signature · 1 line
2.39.5
reviewer Reviewed-by on v1 1/1
#1 lore raw
Quoted 22 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

With CONFIG_TYPEC=m, this driver cannot be built-in:

arm-linux-gnueabi/bin/arm-linux-gnueabi-ld: drivers/phy/phy-google-usb.o: in function `google_usb_phy_remove':
phy-google-usb.c:(.text+0x24): undefined reference to `typec_switch_unregister'

Add CONFIG_TYPEC as a hard dependency here to force a clean build. In theory, compile-testing with CONFIG_TYPEC=n would also work, but that seems pointless.

Fixes cbce66669c82 ("phy: Add Google Tensor SoC USB PHY driver")
Signed-off-by Arnd Bergmann <[email protected]>
---
  drivers/phy/Kconfig | 1 +
  1 file changed, 1 insertion(+)
drivers/phy/Kconfig +0 -0
index 142e7b0ef2ef..02467dfd4fb0 100644

drivers/phy/Kconfig config GENERIC_PHY_MIPI_DPHY · line 56

Quoted 7 lines
drivers/phy/Kconfig +1 -0
@@ -50,6 +50,7 @@ config GENERIC_PHY_MIPI_DPHY
  config PHY_GOOGLE_USB
  	tristate "Google Tensor SoC USB PHY driver"
  	select GENERIC_PHY
+	depends on TYPEC
  	help
  	  Enable support for the USB PHY on Google Tensor SoCs, starting with
  	  the G5 generation (Laguna). This driver provides the PHY interfaces
Reviewed-by Neil Armstrong <[email protected]>

Thanks,
Neil

maintainer Applied
#2 lore raw
In reply to Arnd Bergmann
Quoted 10 lines · Arnd Bergmann

With CONFIG_TYPEC=m, this driver cannot be built-in:

arm-linux-gnueabi/bin/arm-linux-gnueabi-ld: drivers/phy/phy-google-usb.o: in function `google_usb_phy_remove':
phy-google-usb.c:(.text+0x24): undefined reference to `typec_switch_unregister'

Add CONFIG_TYPEC as a hard dependency here to force a clean build. In theory, compile-testing with CONFIG_TYPEC=n would also work, but that seems pointless.

[...]

Applied, thanks!

[1/1] phy: GOOGLE_USB: add TYPEC dependency

      commit: 8a13968460004d21dd0ca457b06fccfdfdfafd6c

Best regards,

Signature · 1 line
~Vinod