pinctrl: polarfire: restore GENERIC_PINCONF dependency
Subsystems (2)
PATCH 1/1 pinctrl: polarfire: restore GENERIC_PINCONF dependency
From: Arnd Bergmann <[email protected]>
Changing over to the new CONFIG_GENERIC_PINCTRL dropped the GENERIC_PINCONF option, causing a build failure:
WARNING: unmet direct dependencies detected for GENERIC_PINCTRL
Depends on [n]: PINCTRL [=y] && GENERIC_PINCONF [=y] && GENERIC_PINCTRL_GROUPS [=n] && GENERIC_PINMUX_FUNCTIONS [=n] Selected by [y]:
- PINCTRL_POLARFIRE_SOC [=y] && PINCTRL [=y] && (ARCH_MICROCHIP [=y] || COMPILE_TEST [=y]) && OF [=y]drivers/pinctrl/microchip/pinctrl-mpfs-mssio.c:296:29: error: 'pinctrl_generic_get_group_count' undeclared here (not in a function)
296 | .get_groups_count = pinctrl_generic_get_group_count,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Select both GENERIC_PINCTRL and GENERIC_PINCONF to address this.
--- drivers/pinctrl/microchip/Kconfig | 3 +++ 1 file changed, 3 insertions(+)
drivers/pinctrl/microchip/Kconfig +3 -0
@@ -12,6 +12,9 @@ config PINCTRL_POLARFIRE_SOC bool "Polarfire SoC pinctrl drivers" depends on ARCH_MICROCHIP || COMPILE_TEST depends on OF + select GENERIC_PINCONF select GENERIC_PINCTRL + select GENERIC_PINCTRL_GROUPS + select GENERIC_PINMUX_FUNCTIONS help This selects the pinctrl drivers for Microchip Polarfire SoC.
Signature · 1 line
2.39.5
Quoted 11 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
Changing over to the new
CONFIG_GENERIC_PINCTRLdropped theGENERIC_PINCONFoption, causing a build failure:WARNING: unmet direct dependencies detected for
GENERIC_PINCTRL
Depends on [n]: PINCTRL [=y] &&GENERIC_PINCONF[=y] &&GENERIC_PINCTRL_GROUPS[=n] &&GENERIC_PINMUX_FUNCTIONS[=n] Selected by [y]:
-PINCTRL_POLARFIRE_SOC[=y] && PINCTRL [=y] && (ARCH_MICROCHIP[=y] ||COMPILE_TEST[=y]) && OF [=y]drivers/pinctrl/microchip/pinctrl-mpfs-mssio.c:296:29: error: 'pinctrl_generic_get_group_count' undeclared here (not in a function)
296 | .get_groups_count =pinctrl_generic_get_group_count,
Quoted 6 lines
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~Select both
GENERIC_PINCTRLandGENERIC_PINCONFto address this.Fixes 488d704ed7b7 ("pinctrl: add polarfire soc mssio pinctrl driver")Signed-off-by Arnd Bergmann <[email protected]>
Does this show up with
https://lore.kernel.org/all/20260130-stoop-gleeful-29f2c525bd48@spud/
applied?
I considered what you have here, went with what I linked cos it matches the other pinctrl core options.
Quoted 21 lines
--- drivers/pinctrl/microchip/Kconfig | 3 +++ 1 file changed, 3 insertions(+)drivers/pinctrl/microchip/Kconfig +3
-0@@ -12,6 +12,9 @@ config PINCTRL_POLARFIRE_SOC bool "Polarfire SoC pinctrl drivers" depends on ARCH_MICROCHIP || COMPILE_TEST depends on OF + select GENERIC_PINCONF select GENERIC_PINCTRL + select GENERIC_PINCTRL_GROUPS + select GENERIC_PINMUX_FUNCTIONS help This selects the pinctrl drivers for Microchip Polarfire SoC.Signature · 1 line
2.39.5
Arnd Bergmann
Reviewed-byQuoted 9 lines · Conor Dooley
Quoted 4 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
Fixes 488d704ed7b7 ("pinctrl: add polarfire soc mssio pinctrl driver")Signed-off-by Arnd Bergmann <[email protected]>Does this show up with
https://lore.kernel.org/all/20260130-stoop-gleeful-29f2c525bd48@spud/
applied?
I'm sure that's fine as well.
Quoted 2 lines
I considered what you have here, went with what I linked cos it matches the other pinctrl core options.
Same here, I also thought about both options, but picked the other one ;-)
Looking at both again, I agree that your version is better, so feel free to add
to that one.
Arnd
Linus Walleij
maintainerQuoted 5 lines · Conor Dooley
Does this show up with
https://lore.kernel.org/all/20260130-stoop-gleeful-29f2c525bd48@spud/
applied?
I considered what you have here, went with what I linked cos it matches the other pinctrl core options.
I've applied this one now.
Yours,
Linus Walleij