dpll: Core improvements and ice E825-C SyncE support

From: Ivan Vecera <[email protected]>
Sent: Tuesday, February 3, 2026 6:40 PM

Extend the DPLL core to support associating a DPLL pin with a firmware node. This association is required to allow other subsystems (such as network drivers) to locate and request specific DPLL pins defined in the Device Tree or ACPI.

* Add a .fwnode field to the struct dpll_pin
* Introduce dpll_pin_fwnode_set() helper to allow the provider driver to associate a pin with a fwnode after the pin has been allocated
* Introduce fwnode_dpll_pin_find() helper to allow consumers to search for a registered DPLL pin using its associated fwnode handle
* Ensure the fwnode reference is properly released in dpll_pin_put()

Reviewed-by Aleksandr Loktionov <[email protected]>

Reviewed-by Vadim Fedorenko <[email protected]>

Signed-off-by Ivan Vecera <[email protected]>

---
v4:
* fixed fwnode_dpll_pin_find() return value description
---

drivers/dpll/dpll_core.c | 49 ++++++++++++++++++++++++++++++++++++++++
drivers/dpll/dpll_core.h |  2 ++
include/linux/dpll.h     | 11 +++++++++
3 files changed, 62 insertions(+)

drivers/dpll/dpll_core.c +23 -0

index 8879a72351561..f04ed7195cadd 100644
@@ -10,6 +10,7 @@
 
 #include <linux/device.h>
 #include <linux/err.h>
+#include <linux/property.h>
 #include <linux/slab.h>
 #include <linux/string.h>
 

@@ -595,12 +596,60 @@ void dpll_pin_put(struct dpll_pin *pin)
 		xa_destroy(&pin->parent_refs);
 		xa_destroy(&pin->ref_sync_pins);
 		dpll_pin_prop_free(&pin->prop);
+		fwnode_handle_put(pin->fwnode);
 		kfree_rcu(pin, rcu);
 	}
 	mutex_unlock(&dpll_lock);
 }
 EXPORT_SYMBOL_GPL(dpll_pin_put);
 
+/**
+ * dpll_pin_fwnode_set - set dpll pin firmware node reference
+ * @pin: pointer to a dpll pin
+ * @fwnode: firmware node handle
+ *
+ * Set firmware node handle for the given dpll pin.
+ */
+void dpll_pin_fwnode_set(struct dpll_pin *pin, struct fwnode_handle
 *fwnode)
+{
+	mutex_lock(&dpll_lock);
+	fwnode_handle_put(pin->fwnode); /* Drop fwnode previously set */
+	pin->fwnode = fwnode_handle_get(fwnode);
+	mutex_unlock(&dpll_lock);
+}
+EXPORT_SYMBOL_GPL(dpll_pin_fwnode_set);
+
+/**
+ * fwnode_dpll_pin_find - find dpll pin by firmware node reference
+ * @fwnode: reference to firmware node
+ *
+ * Get existing object of a pin that is associated with given firmware

node
+ * reference.
+ *
+ * Context: Acquires a lock (dpll_lock)
+ * Return:
+ * * valid dpll_pin pointer on success
+ * * NULL when no such pin exists
+ */

drivers/dpll/dpll_core.c +19 -0

+struct dpll_pin *fwnode_dpll_pin_find(struct fwnode_handle *fwnode)
+{
+	struct dpll_pin *pin, *ret = NULL;
+	unsigned long index;
+
+	mutex_lock(&dpll_lock);
+	xa_for_each(&dpll_pin_xa, index, pin) {
+		if (pin->fwnode == fwnode) {
+			ret = pin;
+			refcount_inc(&ret->refcount);
+			break;
+		}
+	}
+	mutex_unlock(&dpll_lock);
+
+	return ret;
+}
+EXPORT_SYMBOL_GPL(fwnode_dpll_pin_find);
+

static int
__dpll_pin_register(struct dpll_device *dpll, struct dpll_pin *pin,
const struct dpll_pin_ops *ops, void *priv, void *cookie)

drivers/dpll/dpll_core.h +2 -0

index 8ce969bbeb64e..d3e17ff0ecef0 100644
@@ -42,6 +42,7 @@ struct dpll_device {
 * @pin_idx:		index of a pin given by dev driver
 * @clock_id:		clock_id of creator
 * @module:		module of creator
+ * @fwnode:		optional reference to firmware node
 * @dpll_refs:		hold referencees to dplls pin was registered with
 * @parent_refs:	hold references to parent pins pin was registered with
 * @ref_sync_pins:	hold references to pins for Reference SYNC feature

@@ -54,6 +55,7 @@ struct dpll_pin {
 	u32 pin_idx;
 	u64 clock_id;
 	struct module *module;
+	struct fwnode_handle *fwnode;
 	struct xarray dpll_refs;
 	struct xarray parent_refs;
 	struct xarray ref_sync_pins;

include/linux/dpll.h +3 -0

index c6d0248fa5273..f2e8660e90cdf 100644
@@ -16,6 +16,7 @@
 struct dpll_device;
 struct dpll_pin;
 struct dpll_pin_esync;
+struct fwnode_handle;
 
 struct dpll_device_ops {
 	int (*mode_get)(const struct dpll_device *dpll, void *dpll_priv,

@@ -178,6 +179,8 @@ void dpll_netdev_pin_clear(struct net_device *dev);
 size_t dpll_netdev_pin_handle_size(const struct net_device *dev);
 int dpll_netdev_add_pin_handle(struct sk_buff *msg,
 			       const struct net_device *dev);
+
+struct dpll_pin *fwnode_dpll_pin_find(struct fwnode_handle *fwnode);
 #else

static inline void
dpll_netdev_pin_set(struct net_device *dev, struct dpll_pin *dpll_pin) { }

include/linux/dpll.h +6 -0

@@ -193,6 +196,12 @@ dpll_netdev_add_pin_handle(struct sk_buff *msg, const
 struct net_device *dev)
 {
 	return 0;
 }
+
+static inline struct dpll_pin *
+fwnode_dpll_pin_find(struct fwnode_handle *fwnode)
+{
+	return NULL;
+}
 #endif
 

struct dpll_device *

include/linux/dpll.h +2 -0

@@ -218,6 +227,8 @@ void dpll_pin_unregister(struct dpll_device *dpll,
 struct dpll_pin *pin,
 
 void dpll_pin_put(struct dpll_pin *pin);
 
+void dpll_pin_fwnode_set(struct dpll_pin *pin, struct fwnode_handle
 *fwnode);
+

int dpll_pin_on_pin_register(struct dpll_pin *parent, struct dpll_pin *pin,

			     const struct dpll_pin_ops *ops, void *priv);

--
2.52.0

From: Intel-wired-lan <[email protected]> On Behalf Of Ivan Vecera
Sent: Tuesday, February 3, 2026 6:40 PM

Associate the registered DPLL pin with its firmware node by calling dpll_pin_fwnode_set().

This links the created pin object to its corresponding DT/ACPI node in the DPLL core. Consequently, this enables consumer drivers (such as network drivers) to locate and request this specific pin using the fwnode_dpll_pin_find() helper.

Reviewed-by Aleksandr Loktionov <[email protected]>

Signed-off-by Ivan Vecera <[email protected]>

---
drivers/dpll/zl3073x/dpll.c | 1 +

1 file changed, 1 insertion(+)

drivers/dpll/zl3073x/dpll.c +1 -0

index 7d8ed948b9706..9eed21088adac 100644
@@ -1485,6 +1485,7 @@ zl3073x_dpll_pin_register(struct zl3073x_dpll_pin
 *pin, u32 index)
 		rc = PTR_ERR(pin->dpll_pin);
 		goto err_pin_get;
 	}
+	dpll_pin_fwnode_set(pin->dpll_pin, props->fwnode);
 
 	if (zl3073x_dpll_is_input_pin(pin))

		ops = &zl3073x_dpll_input_pin_ops;

--
2.52.0

From: Ivan Vecera <[email protected]>
Sent: Tuesday, February 3, 2026 6:40 PM

From: Petr Oros <[email protected]>

Currently, the DPLL subsystem reports events (creation, deletion, changes) to userspace via Netlink. However, there is no mechanism for other kernel components to be notified of these events directly.

Add a raw notifier chain to the DPLL core protected by dpll_lock. This allows other kernel subsystems or drivers to register callbacks and receive notifications when DPLL devices or pins are created, deleted, or modified.

Define the following:
- Registration helpers: {,un}register_dpll_notifier()
- Event types: DPLL_DEVICE_CREATED, DPLL_PIN_CREATED, etc.
- Context structures: dpll_{device,pin}_notifier_info to pass relevant data to the listeners.

The notification chain is invoked alongside the existing Netlink event generation to ensure in-kernel listeners are kept in sync with the subsystem state.

Reviewed-by Vadim Fedorenko <[email protected]>

Co-developed-by Ivan Vecera <[email protected]>

Signed-off-by Ivan Vecera <[email protected]>

Signed-off-by Petr Oros <[email protected]>

---

drivers/dpll/dpll_core.c    | 57 +++++++++++++++++++++++++++++++++++++
drivers/dpll/dpll_core.h    |  4 +++
drivers/dpll/dpll_netlink.c |  6 ++++
include/linux/dpll.h        | 29 +++++++++++++++++++
4 files changed, 96 insertions(+)

drivers/dpll/dpll_core.c +57 -0

index f04ed7195cadd..b05fe2ba46d91 100644
@@ -23,6 +23,8 @@ DEFINE_MUTEX(dpll_lock);
 DEFINE_XARRAY_FLAGS(dpll_device_xa, XA_FLAGS_ALLOC);
 DEFINE_XARRAY_FLAGS(dpll_pin_xa, XA_FLAGS_ALLOC);
 
+static RAW_NOTIFIER_HEAD(dpll_notifier_chain);
+
 static u32 dpll_device_xa_id;
 static u32 dpll_pin_xa_id;
 

@@ -46,6 +48,39 @@ struct dpll_pin_registration {
 	void *cookie;
 };
 
+static int call_dpll_notifiers(unsigned long action, void *info)
+{
+	lockdep_assert_held(&dpll_lock);
+	return raw_notifier_call_chain(&dpll_notifier_chain, action, info);
+}
+
+void dpll_device_notify(struct dpll_device *dpll, unsigned long action)
+{
+	struct dpll_device_notifier_info info = {
+		.dpll = dpll,
+		.id = dpll->id,
+		.idx = dpll->device_idx,
+		.clock_id = dpll->clock_id,
+		.type = dpll->type,
+	};
+
+	call_dpll_notifiers(action, &info);
+}
+
+void dpll_pin_notify(struct dpll_pin *pin, unsigned long action)
+{
+	struct dpll_pin_notifier_info info = {
+		.pin = pin,
+		.id = pin->id,
+		.idx = pin->pin_idx,
+		.clock_id = pin->clock_id,
+		.fwnode = pin->fwnode,
+		.prop = &pin->prop,
+	};
+
+	call_dpll_notifiers(action, &info);
+}
+
 struct dpll_device *dpll_device_get_by_id(int id)
 {
 	if (xa_get_mark(&dpll_device_xa, id, DPLL_REGISTERED))

@@ -539,6 +574,28 @@ void dpll_netdev_pin_clear(struct net_device *dev)
 }
 EXPORT_SYMBOL(dpll_netdev_pin_clear);
 
+int register_dpll_notifier(struct notifier_block *nb)
+{
+	int ret;
+
+	mutex_lock(&dpll_lock);
+	ret = raw_notifier_chain_register(&dpll_notifier_chain, nb);
+	mutex_unlock(&dpll_lock);
+	return ret;
+}
+EXPORT_SYMBOL_GPL(register_dpll_notifier);
+
+int unregister_dpll_notifier(struct notifier_block *nb)
+{
+	int ret;
+
+	mutex_lock(&dpll_lock);
+	ret = raw_notifier_chain_unregister(&dpll_notifier_chain, nb);
+	mutex_unlock(&dpll_lock);
+	return ret;
+}
+EXPORT_SYMBOL_GPL(unregister_dpll_notifier);
+
 /**
 * dpll_pin_get - find existing or create new dpll pin
 * @clock_id: clock_id of creator

drivers/dpll/dpll_core.h +4 -0

index d3e17ff0ecef0..b7b4bb251f739 100644
@@ -91,4 +91,8 @@ struct dpll_pin_ref *dpll_xa_ref_dpll_first(struct
 xarray *xa_refs);
 extern struct xarray dpll_device_xa;
 extern struct xarray dpll_pin_xa;
 extern struct mutex dpll_lock;
+
+void dpll_device_notify(struct dpll_device *dpll, unsigned long action);
+void dpll_pin_notify(struct dpll_pin *pin, unsigned long action);
+

#endif

drivers/dpll/dpll_netlink.c +2 -0

index 904199ddd1781..83cbd64abf5a4 100644
@@ -761,17 +761,20 @@ dpll_device_event_send(enum dpll_cmd event, struct
 dpll_device *dpll)
 
 int dpll_device_create_ntf(struct dpll_device *dpll)
 {
+	dpll_device_notify(dpll, DPLL_DEVICE_CREATED);
 	return dpll_device_event_send(DPLL_CMD_DEVICE_CREATE_NTF, dpll);
 }
 
 int dpll_device_delete_ntf(struct dpll_device *dpll)
 {
+	dpll_device_notify(dpll, DPLL_DEVICE_DELETED);
 	return dpll_device_event_send(DPLL_CMD_DEVICE_DELETE_NTF, dpll);
 }
 

static int
__dpll_device_change_ntf(struct dpll_device *dpll) {

drivers/dpll/dpll_netlink.c +1 -0

+	dpll_device_notify(dpll, DPLL_DEVICE_CHANGED);

	return dpll_device_event_send(DPLL_CMD_DEVICE_CHANGE_NTF, dpll);
}

drivers/dpll/dpll_netlink.c +3 -0

@@ -829,16 +832,19 @@ dpll_pin_event_send(enum dpll_cmd event, struct
 dpll_pin *pin)
 
 int dpll_pin_create_ntf(struct dpll_pin *pin)
 {
+	dpll_pin_notify(pin, DPLL_PIN_CREATED);
 	return dpll_pin_event_send(DPLL_CMD_PIN_CREATE_NTF, pin);
 }
 
 int dpll_pin_delete_ntf(struct dpll_pin *pin)
 {
+	dpll_pin_notify(pin, DPLL_PIN_DELETED);
 	return dpll_pin_event_send(DPLL_CMD_PIN_DELETE_NTF, pin);
 }
 
 int __dpll_pin_change_ntf(struct dpll_pin *pin)
 {
+	dpll_pin_notify(pin, DPLL_PIN_CHANGED);
 	return dpll_pin_event_send(DPLL_CMD_PIN_CHANGE_NTF, pin);
 }

include/linux/dpll.h +25 -0

index f2e8660e90cdf..8ed90dfc65f05 100644
@@ -11,6 +11,7 @@
 #include <linux/device.h>
 #include <linux/netlink.h>
 #include <linux/netdevice.h>
+#include <linux/notifier.h>
 #include <linux/rtnetlink.h>
 
 struct dpll_device;

@@ -172,6 +173,30 @@ struct dpll_pin_properties {
 	u32 phase_gran;
 };
 
+#define DPLL_DEVICE_CREATED	1
+#define DPLL_DEVICE_DELETED	2
+#define DPLL_DEVICE_CHANGED	3
+#define DPLL_PIN_CREATED	4
+#define DPLL_PIN_DELETED	5
+#define DPLL_PIN_CHANGED	6
+
+struct dpll_device_notifier_info {
+	struct dpll_device *dpll;
+	u32 id;
+	u32 idx;
+	u64 clock_id;
+	enum dpll_type type;
+};
+
+struct dpll_pin_notifier_info {
+	struct dpll_pin *pin;
+	u32 id;
+	u32 idx;
+	u64 clock_id;
+	const struct fwnode_handle *fwnode;
+	const struct dpll_pin_properties *prop;
+};
+
 #if IS_ENABLED(CONFIG_DPLL)

void dpll_netdev_pin_set(struct net_device *dev, struct dpll_pin *dpll_pin);
void dpll_netdev_pin_clear(struct net_device *dev);

include/linux/dpll.h +4 -1

@@ -242,4 +267,8 @@ int dpll_device_change_ntf(struct dpll_device *dpll);
 
 int dpll_pin_change_ntf(struct dpll_pin *pin);
 
+int register_dpll_notifier(struct notifier_block *nb);
+
+int unregister_dpll_notifier(struct notifier_block *nb);
+
 #endif
--

2.52.0

-----Original Message-----
From: Intel-wired-lan <[email protected]> On Behalf Of Ivan Vecera
Sent: Tuesday, February 3, 2026 6:40 PM
To: [email protected]
Cc: Eric Dumazet <[email protected]>; Nguyen, Anthony L <[email protected]>; Leon Romanovsky <[email protected]>; Lobakin, Aleksander <[email protected]>; linux- [email protected]; Kitszel, Przemyslaw <[email protected]>; Kubalewski, Arkadiusz <[email protected]>; [email protected]; Jakub Kicinski <[email protected]>; Paolo Abeni <[email protected]>; Jiri Pirko <[email protected]>; Richard Cochran <[email protected]>; Prathosh Satish <[email protected]>; Vadim Fedorenko <[email protected]>; Mark Bloch <[email protected]>; linux- [email protected]; Tariq Toukan <[email protected]>; Andrew Lunn <[email protected]>; Jonathan Lemon <[email protected]>; Saeed Mahameed <[email protected]>; David S. Miller <[email protected]>
Subject: [Intel-wired-lan] [PATCH net-next v5 3/9] dpll: Add notifier chain for dpll events

From: Petr Oros <[email protected]>

Currently, the DPLL subsystem reports events (creation, deletion, changes) to userspace via Netlink. However, there is no mechanism for other kernel components to be notified of these events directly.

Add a raw notifier chain to the DPLL core protected by dpll_lock. This allows other kernel subsystems or drivers to register callbacks and receive notifications when DPLL devices or pins are created, deleted, or modified.

Define the following:
- Registration helpers: {,un}register_dpll_notifier()
- Event types: DPLL_DEVICE_CREATED, DPLL_PIN_CREATED, etc.
- Context structures: dpll_{device,pin}_notifier_info to pass relevant
data to the listeners.

The notification chain is invoked alongside the existing Netlink event generation to ensure in-kernel listeners are kept in sync with the subsystem state.

Reviewed-by Vadim Fedorenko <[email protected]>

Co-developed-by Ivan Vecera <[email protected]>

Signed-off-by Ivan Vecera <[email protected]>

Signed-off-by Petr Oros <[email protected]>

---
 drivers/dpll/dpll_core.c    | 57
+++++++++++++++++++++++++++++++++++++
 drivers/dpll/dpll_core.h    |  4 +++
 drivers/dpll/dpll_netlink.c |  6 ++++
 include/linux/dpll.h        | 29 +++++++++++++++++++
 4 files changed, 96 insertions(+)

drivers/dpll/dpll_core.c index renamed from drivers/dpll/dpll_core.c +0 -0

f04ed7195cadd..b05fe2ba46d91 100644

drivers/dpll/dpll_core.c +2 -0

@@ -23,6 +23,8 @@ DEFINE_MUTEX(dpll_lock);
 DEFINE_XARRAY_FLAGS(dpll_device_xa, XA_FLAGS_ALLOC);
 DEFINE_XARRAY_FLAGS(dpll_pin_xa, XA_FLAGS_ALLOC);
 
+static RAW_NOTIFIER_HEAD(dpll_notifier_chain);
+

--
2.52.0

From: Ivan Vecera <[email protected]>
Sent: Tuesday, February 3, 2026 6:40 PM

Allow drivers to register DPLL pins without manually specifying a pin index.

Currently, drivers must provide a unique pin index when calling dpll_pin_get(). This works well for hardware-mapped pins but creates friction for drivers handling virtual pins or those without a strict hardware indexing scheme.

Introduce DPLL_PIN_IDX_UNSPEC (U32_MAX). When a driver passes this value as the pin index:
1. The core allocates a unique index using an IDA
2. The allocated index is mapped to a range starting above INT_MAX

This separation ensures that dynamically allocated indices never collide with standard driver-provided hardware indices, which are assumed to be within the 0 to INT_MAX range. The index is automatically freed when the pin is released in dpll_pin_put().

Reviewed-by Aleksandr Loktionov <[email protected]>

Signed-off-by Ivan Vecera <[email protected]>

---
v2:
* fixed integer overflow in dpll_pin_idx_free()
---
drivers/dpll/dpll_core.c | 48 ++++++++++++++++++++++++++++++++++++++--
include/linux/dpll.h | 2 ++

2 files changed, 48 insertions(+), 2 deletions(-)

drivers/dpll/dpll_core.c +10 -0

index b05fe2ba46d91..59081cf2c73ae 100644
@@ -10,6 +10,7 @@
 
 #include <linux/device.h>
 #include <linux/err.h>
+#include <linux/idr.h>
 #include <linux/property.h>
 #include <linux/slab.h>
 #include <linux/string.h>

@@ -24,6 +25,7 @@ DEFINE_XARRAY_FLAGS(dpll_device_xa, XA_FLAGS_ALLOC);
 DEFINE_XARRAY_FLAGS(dpll_pin_xa, XA_FLAGS_ALLOC);
 
 static RAW_NOTIFIER_HEAD(dpll_notifier_chain);
+static DEFINE_IDA(dpll_pin_idx_ida);
 
 static u32 dpll_device_xa_id;
 static u32 dpll_pin_xa_id;

@@ -464,6 +466,36 @@ void dpll_device_unregister(struct dpll_device *dpll,
 }
 EXPORT_SYMBOL_GPL(dpll_device_unregister);
 
+static int dpll_pin_idx_alloc(u32 *pin_idx)
+{
+	int ret;
+
+	if (!pin_idx)
+		return -EINVAL;
+
+	/* Alloc unique number from IDA. Number belongs to <0, INT_MAX>

range */

drivers/dpll/dpll_core.c +22 -0

+	ret = ida_alloc(&dpll_pin_idx_ida, GFP_KERNEL);
+	if (ret < 0)
+		return ret;
+
+	/* Map the value to dynamic pin index range <INT_MAX+1, U32_MAX> */
+	*pin_idx = (u32)ret + INT_MAX + 1;
+
+	return 0;
+}
+
+static void dpll_pin_idx_free(u32 pin_idx)
+{
+	if (pin_idx <= INT_MAX)
+		return; /* Not a dynamic pin index */
+
+	/* Map the index value from dynamic pin index range to IDA range and
+	 * free it.
+	 */
+	pin_idx -= (u32)INT_MAX + 1;
+	ida_free(&dpll_pin_idx_ida, pin_idx);
+}
+

static void dpll_pin_prop_free(struct dpll_pin_properties *prop)

{
	kfree(prop->package_label);

drivers/dpll/dpll_core.c +11 -2

@@ -521,9 +553,18 @@ dpll_pin_alloc(u64 clock_id, u32 pin_idx, struct
 module *module,
 	struct dpll_pin *pin;
 	int ret;
 
+	if (pin_idx == DPLL_PIN_IDX_UNSPEC) {
+		ret = dpll_pin_idx_alloc(&pin_idx);
+		if (ret)
+			return ERR_PTR(ret);
+	} else if (pin_idx > INT_MAX) {
+		return ERR_PTR(-EINVAL);
+	}
 	pin = kzalloc(sizeof(*pin), GFP_KERNEL);
-	if (!pin)
-		return ERR_PTR(-ENOMEM);
+	if (!pin) {
+		ret = -ENOMEM;
+		goto err_pin_alloc;
+	}
 	pin->pin_idx = pin_idx;
 	pin->clock_id = clock_id;

	pin->module = module;

drivers/dpll/dpll_core.c +0 -0

@@ -551,6 +592,8 @@ dpll_pin_alloc(u64 clock_id, u32 pin_idx, struct
 module *module,
 	dpll_pin_prop_free(&pin->prop);

err_pin_prop:

	kfree(pin);

drivers/dpll/dpll_core.c +2 -0

+err_pin_alloc:
+	dpll_pin_idx_free(pin_idx);

	return ERR_PTR(ret);
}

drivers/dpll/dpll_core.c +1 -0

@@ -654,6 +697,7 @@ void dpll_pin_put(struct dpll_pin *pin)
 		xa_destroy(&pin->ref_sync_pins);
 		dpll_pin_prop_free(&pin->prop);
 		fwnode_handle_put(pin->fwnode);
+		dpll_pin_idx_free(pin->pin_idx);
 		kfree_rcu(pin, rcu);
 	}
 	mutex_unlock(&dpll_lock);

include/linux/dpll.h +2 -0

index 8ed90dfc65f05..8fff048131f1d 100644
@@ -240,6 +240,8 @@ int dpll_device_register(struct dpll_device *dpll,
 enum dpll_type type,
 void dpll_device_unregister(struct dpll_device *dpll,
 			    const struct dpll_device_ops *ops, void *priv);
 
+#define DPLL_PIN_IDX_UNSPEC	U32_MAX
+

struct dpll_pin *
dpll_pin_get(u64 clock_id, u32 dev_driver_id, struct module *module,

	     const struct dpll_pin_properties *prop);

--
2.52.0

From: Ivan Vecera <[email protected]>
Sent: Tuesday, February 3, 2026 6:40 PM

Add parsing for the "mux" string in the 'connection-type' pin property mapping it to DPLL_PIN_TYPE_MUX.

Recognizing this type in the driver allows these pins to be taken as parent pins for pin-on-pin pins coming from different modules (e.g. network drivers).

Reviewed-by Aleksandr Loktionov <[email protected]>

Signed-off-by Ivan Vecera <[email protected]>

---
drivers/dpll/zl3073x/prop.c | 2 ++

1 file changed, 2 insertions(+)

drivers/dpll/zl3073x/prop.c +2 -0

index 4ed153087570b..ad1f099cbe2b5 100644
@@ -249,6 +249,8 @@ struct zl3073x_pin_props *zl3073x_pin_props_get(struct
 zl3073x_dev *zldev,
 			props->dpll_props.type = DPLL_PIN_TYPE_INT_OSCILLATOR;
 		else if (!strcmp(type, "synce"))
 			props->dpll_props.type = DPLL_PIN_TYPE_SYNCE_ETH_PORT;
+		else if (!strcmp(type, "mux"))
+			props->dpll_props.type = DPLL_PIN_TYPE_MUX;
 		else
 			dev_warn(zldev->dev,

"Unknown or unsupported pin type '%s'\n",
--
2.52.0

From: Ivan Vecera <[email protected]>
Sent: Tuesday, February 3, 2026 6:40 PM

Refactor the reference counting mechanism for DPLL devices and pins to improve consistency and prevent potential lifetime issues.

Introduce internal helpers __dpll_{device,pin}_{hold,put}() to centralize reference management.

Update the internal XArray reference helpers (dpll_xa_ref_*) to automatically grab a reference to the target object when it is added to a list, and release it when removed. This ensures that objects linked internally (e.g., pins referenced by parent pins) are properly kept alive without relying on the caller to manually manage the count.

Consequently, remove the now redundant manual refcount_inc/dec calls in dpll_pin_on_pin_{,un}register()`, as ownership is now correctly handled by the dpll_xa_ref_* functions.

Additionally, ensure that dpll_device_{,un}register()` takes/releases a reference to the device, ensuring the device object remains valid for the duration of its registration.

Reviewed-by Aleksandr Loktionov <[email protected]>

Signed-off-by Ivan Vecera <[email protected]>

---
drivers/dpll/dpll_core.c | 74 +++++++++++++++++++++++++++-------------

1 file changed, 50 insertions(+), 24 deletions(-)

drivers/dpll/dpll_core.c +39 -0

index 59081cf2c73ae..f6ab4f0cad84d 100644
@@ -83,6 +83,45 @@ void dpll_pin_notify(struct dpll_pin *pin, unsigned
 long action)
 	call_dpll_notifiers(action, &info);
 }
 
+static void __dpll_device_hold(struct dpll_device *dpll)
+{
+	refcount_inc(&dpll->refcount);
+}
+
+static void __dpll_device_put(struct dpll_device *dpll)
+{
+	if (refcount_dec_and_test(&dpll->refcount)) {
+		ASSERT_DPLL_NOT_REGISTERED(dpll);
+		WARN_ON_ONCE(!xa_empty(&dpll->pin_refs));
+		xa_destroy(&dpll->pin_refs);
+		xa_erase(&dpll_device_xa, dpll->id);
+		WARN_ON(!list_empty(&dpll->registration_list));
+		kfree(dpll);
+	}
+}
+
+static void __dpll_pin_hold(struct dpll_pin *pin)
+{
+	refcount_inc(&pin->refcount);
+}
+
+static void dpll_pin_idx_free(u32 pin_idx);
+static void dpll_pin_prop_free(struct dpll_pin_properties *prop);
+
+static void __dpll_pin_put(struct dpll_pin *pin)
+{
+	if (refcount_dec_and_test(&pin->refcount)) {
+		xa_erase(&dpll_pin_xa, pin->id);
+		xa_destroy(&pin->dpll_refs);
+		xa_destroy(&pin->parent_refs);
+		xa_destroy(&pin->ref_sync_pins);
+		dpll_pin_prop_free(&pin->prop);
+		fwnode_handle_put(pin->fwnode);
+		dpll_pin_idx_free(pin->pin_idx);
+		kfree_rcu(pin, rcu);
+	}
+}
+
 struct dpll_device *dpll_device_get_by_id(int id)
 {

if (xa_get_mark(&dpll_device_xa, id, DPLL_REGISTERED))

drivers/dpll/dpll_core.c +1 -0

@@ -152,6 +191,7 @@ dpll_xa_ref_pin_add(struct xarray *xa_pins, struct
 dpll_pin *pin,
 	reg->ops = ops;
 	reg->priv = priv;
 	reg->cookie = cookie;
+	__dpll_pin_hold(pin);
 	if (ref_exists)
 		refcount_inc(&ref->refcount);

	list_add_tail(&reg->list, &ref->registration_list);

drivers/dpll/dpll_core.c +1 -0

@@ -174,6 +214,7 @@ static int dpll_xa_ref_pin_del(struct xarray *xa_pins,
 struct dpll_pin *pin,
 		if (WARN_ON(!reg))
 			return -EINVAL;
 		list_del(&reg->list);
+		__dpll_pin_put(pin);
 		kfree(reg);
 		if (refcount_dec_and_test(&ref->refcount)) {

			xa_erase(xa_pins, i);

drivers/dpll/dpll_core.c +1 -0

@@ -231,6 +272,7 @@ dpll_xa_ref_dpll_add(struct xarray *xa_dplls, struct
 dpll_device *dpll,
 	reg->ops = ops;
 	reg->priv = priv;
 	reg->cookie = cookie;
+	__dpll_device_hold(dpll);
 	if (ref_exists)
 		refcount_inc(&ref->refcount);

	list_add_tail(&reg->list, &ref->registration_list);

drivers/dpll/dpll_core.c +1 -0

@@ -253,6 +295,7 @@ dpll_xa_ref_dpll_del(struct xarray *xa_dplls, struct
 dpll_device *dpll,
 		if (WARN_ON(!reg))
 			return;
 		list_del(&reg->list);
+		__dpll_device_put(dpll);
 		kfree(reg);
 		if (refcount_dec_and_test(&ref->refcount)) {

			xa_erase(xa_dplls, i);

drivers/dpll/dpll_core.c +1 -1

@@ -323,8 +366,8 @@ dpll_device_get(u64 clock_id, u32 device_idx, struct
 module *module)
 		if (dpll->clock_id == clock_id &&
 		    dpll->device_idx == device_idx &&
 		    dpll->module == module) {
+			__dpll_device_hold(dpll);
 			ret = dpll;
-			refcount_inc(&ret->refcount);
 			break;
 		}

	}

drivers/dpll/dpll_core.c +2 -8

@@ -347,14 +390,7 @@ EXPORT_SYMBOL_GPL(dpll_device_get);
 void dpll_device_put(struct dpll_device *dpll)
 {
 	mutex_lock(&dpll_lock);
-	if (refcount_dec_and_test(&dpll->refcount)) {
-		ASSERT_DPLL_NOT_REGISTERED(dpll);
-		WARN_ON_ONCE(!xa_empty(&dpll->pin_refs));
-		xa_destroy(&dpll->pin_refs);
-		xa_erase(&dpll_device_xa, dpll->id);
-		WARN_ON(!list_empty(&dpll->registration_list));
-		kfree(dpll);
-	}
+	__dpll_device_put(dpll);
 	mutex_unlock(&dpll_lock);
 }
 EXPORT_SYMBOL_GPL(dpll_device_put);

@@ -416,6 +452,7 @@ int dpll_device_register(struct dpll_device *dpll,
 enum dpll_type type,
 	reg->ops = ops;
 	reg->priv = priv;
 	dpll->type = type;
+	__dpll_device_hold(dpll);
 	first_registration = list_empty(&dpll->registration_list);
 	list_add_tail(&reg->list, &dpll->registration_list);

	if (!first_registration) {

drivers/dpll/dpll_core.c +2 -1

@@ -455,6 +492,7 @@ void dpll_device_unregister(struct dpll_device *dpll,
 		return;
 	}
 	list_del(&reg->list);
+	__dpll_device_put(dpll);
 	kfree(reg);
 
 	if (!list_empty(&dpll->registration_list)) {

@@ -666,8 +704,8 @@ dpll_pin_get(u64 clock_id, u32 pin_idx, struct module
 *module,
 		if (pos->clock_id == clock_id &&
 		    pos->pin_idx == pin_idx &&
 		    pos->module == module) {
+			__dpll_pin_hold(pos);
 			ret = pos;
-			refcount_inc(&ret->refcount);
 			break;
 		}

	}

drivers/dpll/dpll_core.c +2 -11

@@ -690,16 +728,7 @@ EXPORT_SYMBOL_GPL(dpll_pin_get);
 void dpll_pin_put(struct dpll_pin *pin)
 {
 	mutex_lock(&dpll_lock);
-	if (refcount_dec_and_test(&pin->refcount)) {
-		xa_erase(&dpll_pin_xa, pin->id);
-		xa_destroy(&pin->dpll_refs);
-		xa_destroy(&pin->parent_refs);
-		xa_destroy(&pin->ref_sync_pins);
-		dpll_pin_prop_free(&pin->prop);
-		fwnode_handle_put(pin->fwnode);
-		dpll_pin_idx_free(pin->pin_idx);
-		kfree_rcu(pin, rcu);
-	}
+	__dpll_pin_put(pin);
 	mutex_unlock(&dpll_lock);
 }
 EXPORT_SYMBOL_GPL(dpll_pin_put);

@@ -740,8 +769,8 @@ struct dpll_pin *fwnode_dpll_pin_find(struct
 fwnode_handle *fwnode)
 	mutex_lock(&dpll_lock);
 	xa_for_each(&dpll_pin_xa, index, pin) {
 		if (pin->fwnode == fwnode) {
+			__dpll_pin_hold(pin);
 			ret = pin;
-			refcount_inc(&ret->refcount);
 			break;
 		}

	}

drivers/dpll/dpll_core.c +0 -1

@@ -893,7 +922,6 @@ int dpll_pin_on_pin_register(struct dpll_pin *parent,
 struct dpll_pin *pin,
 	ret = dpll_xa_ref_pin_add(&pin->parent_refs, parent, ops, priv,
 pin);
 	if (ret)
 		goto unlock;
-	refcount_inc(&pin->refcount);
 	xa_for_each(&parent->dpll_refs, i, ref) {

		ret = __dpll_pin_register(ref->dpll, pin, ops, priv, parent);
		if (ret) {

drivers/dpll/dpll_core.c +0 -1

@@ -913,7 +941,6 @@ int dpll_pin_on_pin_register(struct dpll_pin *parent,
 struct dpll_pin *pin,
 					      parent);
 			dpll_pin_delete_ntf(pin);
 		}
-	refcount_dec(&pin->refcount);
 	dpll_xa_ref_pin_del(&pin->parent_refs, parent, ops, priv, pin);

unlock:

	mutex_unlock(&dpll_lock);

drivers/dpll/dpll_core.c +0 -1

@@ -940,7 +967,6 @@ void dpll_pin_on_pin_unregister(struct dpll_pin
 *parent, struct dpll_pin *pin,
 	mutex_lock(&dpll_lock);
 	dpll_pin_delete_ntf(pin);
 	dpll_xa_ref_pin_del(&pin->parent_refs, parent, ops, priv, pin);
-	refcount_dec(&pin->refcount);
 	xa_for_each(&pin->dpll_refs, i, ref)
 		__dpll_pin_unregister(ref->dpll, pin, ops, priv, parent);

	mutex_unlock(&dpll_lock);

--
2.52.0

From: Intel-wired-lan <[email protected]> On Behalf Of Ivan Vecera
Sent: Tuesday, February 3, 2026 6:40 PM

Add support for the REF_TRACKER infrastructure to the DPLL subsystem.

When enabled, this allows developers to track and debug reference counting leaks or imbalances for dpll_device and dpll_pin objects. It records stack traces for every get/put operation and exposes this information via debugfs at:
/sys/kernel/debug/ref_tracker/dpll_device_* /sys/kernel/debug/ref_tracker/dpll_pin_*

The following API changes are made to support this:
1. dpll_device_get() / dpll_device_put() now accept a 'dpll_tracker *' (which is a typedef to 'struct ref_tracker *' when enabled, or an empty struct otherwise).
2. dpll_pin_get() / dpll_pin_put() and fwnode_dpll_pin_find() similarly accept the tracker argument.
3. Internal registration structures now hold a tracker to associate the reference held by the registration with the specific owner.

All existing in-tree drivers (ice, mlx5, ptp_ocp, zl3073x) are updated to pass NULL for the new tracker argument, maintaining current behavior while enabling future debugging capabilities.

Reviewed-by Aleksandr Loktionov <[email protected]>

Co-developed-by Petr Oros <[email protected]>

Signed-off-by Petr Oros <[email protected]>

Signed-off-by Ivan Vecera <[email protected]>

---
v5:
* fixed typo
v4:
* added missing tracker parameter to fwnode_dpll_pin_find() stub v3:
* added Kconfig dependency on STACKTRACE_SUPPORT and DEBUG_KERNEL
---

drivers/dpll/Kconfig                          | 15 +++
drivers/dpll/dpll_core.c                      | 98 ++++++++++++++-----
drivers/dpll/dpll_core.h                      |  5 +
drivers/dpll/zl3073x/dpll.c                   | 12 +--
drivers/net/ethernet/intel/ice/ice_dpll.c     | 14 +--
.../net/ethernet/mellanox/mlx5/core/dpll.c    | 13 +--
drivers/ptp/ptp_ocp.c                         | 15 +--
include/linux/dpll.h                          | 21 ++--
8 files changed, 139 insertions(+), 54 deletions(-)

drivers/dpll/Kconfig +0 -0

index ade872c915ac6..be98969f040ab 100644
@@ -8,6 +8,21 @@ menu "DPLL device support"

config DPLL
bool

drivers/dpll/Kconfig +15 -0

+config DPLL_REFCNT_TRACKER
+	bool "DPLL reference count tracking"
+	depends on DEBUG_KERNEL && STACKTRACE_SUPPORT && DPLL
+	select REF_TRACKER
+	help
+	  Enable reference count tracking for DPLL devices and pins.
+	  This helps debugging reference leaks and use-after-free bugs
+	  by recording stack traces for each get/put operation.
+
+	  The tracking information is exposed via debugfs at:
+	    /sys/kernel/debug/ref_tracker/dpll_device_*
+	    /sys/kernel/debug/ref_tracker/dpll_pin_*
+
+	  If unsure, say N.
+

source "drivers/dpll/zl3073x/Kconfig"

endmenu

drivers/dpll/dpll_core.c +40 -4

index f6ab4f0cad84d..627a5b39a0efd 100644
@@ -41,6 +41,7 @@ struct dpll_device_registration {
 	struct list_head list;
 	const struct dpll_device_ops *ops;
 	void *priv;
+	dpll_tracker tracker;
 };
 
 struct dpll_pin_registration {

@@ -48,6 +49,7 @@ struct dpll_pin_registration {
 	const struct dpll_pin_ops *ops;
 	void *priv;
 	void *cookie;
+	dpll_tracker tracker;
 };
 
 static int call_dpll_notifiers(unsigned long action, void *info)

@@ -83,33 +85,68 @@ void dpll_pin_notify(struct dpll_pin *pin, unsigned
 long action)
 	call_dpll_notifiers(action, &info);
 }
 
-static void __dpll_device_hold(struct dpll_device *dpll)
+static void dpll_device_tracker_alloc(struct dpll_device *dpll,
+				      dpll_tracker *tracker)
 {
+#ifdef CONFIG_DPLL_REFCNT_TRACKER
+	ref_tracker_alloc(&dpll->refcnt_tracker, tracker, GFP_KERNEL);
+#endif
+}
+
+static void dpll_device_tracker_free(struct dpll_device *dpll,
+				     dpll_tracker *tracker)
+{
+#ifdef CONFIG_DPLL_REFCNT_TRACKER
+	ref_tracker_free(&dpll->refcnt_tracker, tracker);
+#endif
+}
+
+static void __dpll_device_hold(struct dpll_device *dpll, dpll_tracker
 *tracker)
+{
+	dpll_device_tracker_alloc(dpll, tracker);
 	refcount_inc(&dpll->refcount);
 }
 
-static void __dpll_device_put(struct dpll_device *dpll)
+static void __dpll_device_put(struct dpll_device *dpll, dpll_tracker
 *tracker)
 {
+	dpll_device_tracker_free(dpll, tracker);
 	if (refcount_dec_and_test(&dpll->refcount)) {
 		ASSERT_DPLL_NOT_REGISTERED(dpll);
 		WARN_ON_ONCE(!xa_empty(&dpll->pin_refs));
 		xa_destroy(&dpll->pin_refs);
 		xa_erase(&dpll_device_xa, dpll->id);
 		WARN_ON(!list_empty(&dpll->registration_list));
+		ref_tracker_dir_exit(&dpll->refcnt_tracker);
 		kfree(dpll);
 	}
 }
 
-static void __dpll_pin_hold(struct dpll_pin *pin)
+static void dpll_pin_tracker_alloc(struct dpll_pin *pin, dpll_tracker
 *tracker)
 {
+#ifdef CONFIG_DPLL_REFCNT_TRACKER
+	ref_tracker_alloc(&pin->refcnt_tracker, tracker, GFP_KERNEL);
+#endif
+}
+
+static void dpll_pin_tracker_free(struct dpll_pin *pin, dpll_tracker
 *tracker)
+{
+#ifdef CONFIG_DPLL_REFCNT_TRACKER
+	ref_tracker_free(&pin->refcnt_tracker, tracker);
+#endif
+}
+
+static void __dpll_pin_hold(struct dpll_pin *pin, dpll_tracker *tracker)
+{
+	dpll_pin_tracker_alloc(pin, tracker);
 	refcount_inc(&pin->refcount);
 }
 
 static void dpll_pin_idx_free(u32 pin_idx);
 static void dpll_pin_prop_free(struct dpll_pin_properties *prop);
 
-static void __dpll_pin_put(struct dpll_pin *pin)
+static void __dpll_pin_put(struct dpll_pin *pin, dpll_tracker *tracker)

{

drivers/dpll/dpll_core.c +1 -0

+	dpll_pin_tracker_free(pin, tracker);

	if (refcount_dec_and_test(&pin->refcount)) {
		xa_erase(&dpll_pin_xa, pin->id);
		xa_destroy(&pin->dpll_refs);

drivers/dpll/dpll_core.c +2 -1

@@ -118,6 +155,7 @@ static void __dpll_pin_put(struct dpll_pin *pin)
 		dpll_pin_prop_free(&pin->prop);
 		fwnode_handle_put(pin->fwnode);
 		dpll_pin_idx_free(pin->pin_idx);
+		ref_tracker_dir_exit(&pin->refcnt_tracker);
 		kfree_rcu(pin, rcu);
 	}
 }

@@ -191,7 +229,7 @@ dpll_xa_ref_pin_add(struct xarray *xa_pins, struct
 dpll_pin *pin,
 	reg->ops = ops;
 	reg->priv = priv;
 	reg->cookie = cookie;
-	__dpll_pin_hold(pin);
+	__dpll_pin_hold(pin, &reg->tracker);
 	if (ref_exists)
 		refcount_inc(&ref->refcount);

	list_add_tail(&reg->list, &ref->registration_list);

drivers/dpll/dpll_core.c +1 -1

@@ -214,7 +252,7 @@ static int dpll_xa_ref_pin_del(struct xarray *xa_pins,
 struct dpll_pin *pin,
 		if (WARN_ON(!reg))
 			return -EINVAL;
 		list_del(&reg->list);
-		__dpll_pin_put(pin);
+		__dpll_pin_put(pin, &reg->tracker);
 		kfree(reg);
 		if (refcount_dec_and_test(&ref->refcount)) {

			xa_erase(xa_pins, i);

drivers/dpll/dpll_core.c +1 -1

@@ -272,7 +310,7 @@ dpll_xa_ref_dpll_add(struct xarray *xa_dplls, struct
 dpll_device *dpll,
 	reg->ops = ops;
 	reg->priv = priv;
 	reg->cookie = cookie;
-	__dpll_device_hold(dpll);
+	__dpll_device_hold(dpll, &reg->tracker);
 	if (ref_exists)
 		refcount_inc(&ref->refcount);

	list_add_tail(&reg->list, &ref->registration_list);

drivers/dpll/dpll_core.c +1 -1

@@ -295,7 +333,7 @@ dpll_xa_ref_dpll_del(struct xarray *xa_dplls, struct
 dpll_device *dpll,
 		if (WARN_ON(!reg))
 			return;
 		list_del(&reg->list);
-		__dpll_device_put(dpll);
+		__dpll_device_put(dpll, &reg->tracker);
 		kfree(reg);
 		if (refcount_dec_and_test(&ref->refcount)) {

			xa_erase(xa_dplls, i);

drivers/dpll/dpll_core.c +1 -0

@@ -337,6 +375,7 @@ dpll_device_alloc(const u64 clock_id, u32 device_idx,
 struct module *module)
 		return ERR_PTR(ret);
 	}
 	xa_init_flags(&dpll->pin_refs, XA_FLAGS_ALLOC);
+	ref_tracker_dir_init(&dpll->refcnt_tracker, 128, "dpll_device");
 
 	return dpll;

}

drivers/dpll/dpll_core.c +1 -0

@@ -346,6 +385,7 @@ dpll_device_alloc(const u64 clock_id, u32 device_idx,
 struct module *module)
 * @clock_id: clock_id of creator
 * @device_idx: idx given by device driver
 * @module: reference to registering module
+ * @tracker: tracking object for the acquired reference
 *
 * Get existing object of a dpll device, unique for given arguments.

* Create new if doesn't exist yet.

drivers/dpll/dpll_core.c +0 -0

@@ -356,7 +396,8 @@ dpll_device_alloc(const u64 clock_id, u32 device_idx,
 struct module *module)
 * * ERR_PTR(X) - error
 */

struct dpll_device *

drivers/dpll/dpll_core.c +2 -1

-dpll_device_get(u64 clock_id, u32 device_idx, struct module *module)
+dpll_device_get(u64 clock_id, u32 device_idx, struct module *module,
+		dpll_tracker *tracker)

{
	struct dpll_device *dpll, *ret = NULL;
	unsigned long index;

drivers/dpll/dpll_core.c +6 -2

@@ -366,13 +407,17 @@ dpll_device_get(u64 clock_id, u32 device_idx, struct
 module *module)
 		if (dpll->clock_id == clock_id &&
 		    dpll->device_idx == device_idx &&
 		    dpll->module == module) {
-			__dpll_device_hold(dpll);
+			__dpll_device_hold(dpll, tracker);
 			ret = dpll;
 			break;
 		}
 	}
-	if (!ret)
+	if (!ret) {
 		ret = dpll_device_alloc(clock_id, device_idx, module);
+		if (!IS_ERR(ret))
+			dpll_device_tracker_alloc(ret, tracker);
+	}
+
 	mutex_unlock(&dpll_lock);
 

	return ret;

drivers/dpll/dpll_core.c +4 -3

@@ -382,15 +427,16 @@ EXPORT_SYMBOL_GPL(dpll_device_get);
 /**
 * dpll_device_put - decrease the refcount and free memory if possible
 * @dpll: dpll_device struct pointer
+ * @tracker: tracking object for the acquired reference
 *
 * Context: Acquires a lock (dpll_lock)
 * Drop reference for a dpll device, if all references are gone, delete
 * dpll device object.
 */
-void dpll_device_put(struct dpll_device *dpll)
+void dpll_device_put(struct dpll_device *dpll, dpll_tracker *tracker)
 {
 	mutex_lock(&dpll_lock);
-	__dpll_device_put(dpll);
+	__dpll_device_put(dpll, tracker);
 	mutex_unlock(&dpll_lock);
 }
 EXPORT_SYMBOL_GPL(dpll_device_put);

@@ -452,7 +498,7 @@ int dpll_device_register(struct dpll_device *dpll,
 enum dpll_type type,
 	reg->ops = ops;
 	reg->priv = priv;
 	dpll->type = type;
-	__dpll_device_hold(dpll);
+	__dpll_device_hold(dpll, &reg->tracker);
 	first_registration = list_empty(&dpll->registration_list);
 	list_add_tail(&reg->list, &dpll->registration_list);

	if (!first_registration) {

drivers/dpll/dpll_core.c +2 -1

@@ -492,7 +538,7 @@ void dpll_device_unregister(struct dpll_device *dpll,
 		return;
 	}
 	list_del(&reg->list);
-	__dpll_device_put(dpll);
+	__dpll_device_put(dpll, &reg->tracker);
 	kfree(reg);
 
 	if (!list_empty(&dpll->registration_list)) {

@@ -622,6 +668,7 @@ dpll_pin_alloc(u64 clock_id, u32 pin_idx, struct
 module *module,
 			      &dpll_pin_xa_id, GFP_KERNEL);
 	if (ret < 0)
 		goto err_xa_alloc;
+	ref_tracker_dir_init(&pin->refcnt_tracker, 128, "dpll_pin");
 	return pin;

err_xa_alloc:

	xa_destroy(&pin->dpll_refs);

drivers/dpll/dpll_core.c +1 -0

@@ -683,6 +730,7 @@ EXPORT_SYMBOL_GPL(unregister_dpll_notifier);
 * @pin_idx: idx given by dev driver
 * @module: reference to registering module
 * @prop: dpll pin properties
+ * @tracker: tracking object for the acquired reference
 *
 * Get existing object of a pin (unique for given arguments) or create

new
* if doesn't exist yet.

drivers/dpll/dpll_core.c +0 -0

@@ -694,7 +742,7 @@ EXPORT_SYMBOL_GPL(unregister_dpll_notifier);
 */

struct dpll_pin *
dpll_pin_get(u64 clock_id, u32 pin_idx, struct module *module,

drivers/dpll/dpll_core.c +1 -1

-	     const struct dpll_pin_properties *prop)
+	     const struct dpll_pin_properties *prop, dpll_tracker *tracker)

{
	struct dpll_pin *pos, *ret = NULL;
	unsigned long i;

drivers/dpll/dpll_core.c +5 -2

@@ -704,13 +752,16 @@ dpll_pin_get(u64 clock_id, u32 pin_idx, struct
 module *module,
 		if (pos->clock_id == clock_id &&
 		    pos->pin_idx == pin_idx &&
 		    pos->module == module) {
-			__dpll_pin_hold(pos);
+			__dpll_pin_hold(pos, tracker);
 			ret = pos;
 			break;
 		}
 	}
-	if (!ret)
+	if (!ret) {
 		ret = dpll_pin_alloc(clock_id, pin_idx, module, prop);
+		if (!IS_ERR(ret))
+			dpll_pin_tracker_alloc(ret, tracker);
+	}
 	mutex_unlock(&dpll_lock);
 

	return ret;

drivers/dpll/dpll_core.c +1 -0

@@ -720,15 +771,16 @@ EXPORT_SYMBOL_GPL(dpll_pin_get);
 /**
 * dpll_pin_put - decrease the refcount and free memory if possible
 * @pin: pointer to a pin to be put
+ * @tracker: tracking object for the acquired reference
 *
 * Drop reference for a pin, if all references are gone, delete pin

object.
*
* Context: Acquires a lock (dpll_lock)
*/

drivers/dpll/dpll_core.c +1 -1

-void dpll_pin_put(struct dpll_pin *pin)
+void dpll_pin_put(struct dpll_pin *pin, dpll_tracker *tracker)

{
	mutex_lock(&dpll_lock);

drivers/dpll/dpll_core.c +1 -1

-	__dpll_pin_put(pin);
+	__dpll_pin_put(pin, tracker);

	mutex_unlock(&dpll_lock);
}

EXPORT_SYMBOL_GPL(dpll_pin_put);

drivers/dpll/dpll_core.c +1 -0

@@ -752,6 +804,7 @@ EXPORT_SYMBOL_GPL(dpll_pin_fwnode_set);
 /**
 * fwnode_dpll_pin_find - find dpll pin by firmware node reference
 * @fwnode: reference to firmware node
+ * @tracker: tracking object for the acquired reference
 *
 * Get existing object of a pin that is associated with given firmware

node
* reference.

drivers/dpll/dpll_core.c +3 -2

@@ -761,7 +814,8 @@ EXPORT_SYMBOL_GPL(dpll_pin_fwnode_set);
 * * valid dpll_pin pointer on success
 * * NULL when no such pin exists
 */
-struct dpll_pin *fwnode_dpll_pin_find(struct fwnode_handle *fwnode)
+struct dpll_pin *fwnode_dpll_pin_find(struct fwnode_handle *fwnode,
+				      dpll_tracker *tracker)
 {
 	struct dpll_pin *pin, *ret = NULL;
 	unsigned long index;

@@ -769,7 +823,7 @@ struct dpll_pin *fwnode_dpll_pin_find(struct
 fwnode_handle *fwnode)
 	mutex_lock(&dpll_lock);
 	xa_for_each(&dpll_pin_xa, index, pin) {
 		if (pin->fwnode == fwnode) {
-			__dpll_pin_hold(pin);
+			__dpll_pin_hold(pin, tracker);
 			ret = pin;
 			break;

		}

drivers/dpll/dpll_core.h +2 -0

index b7b4bb251f739..71ac88ef20172 100644
@@ -10,6 +10,7 @@
 #include <linux/dpll.h>
 #include <linux/list.h>
 #include <linux/refcount.h>
+#include <linux/ref_tracker.h>
 #include "dpll_nl.h"
 
 #define DPLL_REGISTERED		XA_MARK_1

@@ -23,6 +24,7 @@
 * @type:		type of a dpll
 * @pin_refs:		stores pins registered within a dpll
 * @refcount:		refcount
+ * @refcnt_tracker:	ref_tracker directory for debugging reference

leaks
* @registration_list: list of registered ops and priv data of dpll
owners
**/
struct dpll_device {

drivers/dpll/dpll_core.h +2 -0

@@ -33,6 +35,7 @@ struct dpll_device {
 	enum dpll_type type;
 	struct xarray pin_refs;
 	refcount_t refcount;
+	struct ref_tracker_dir refcnt_tracker;
 	struct list_head registration_list;
 };
 

@@ -48,6 +51,7 @@ struct dpll_device {
 * @ref_sync_pins:	hold references to pins for Reference SYNC feature
 * @prop:		pin properties copied from the registerer
 * @refcount:		refcount
+ * @refcnt_tracker:	ref_tracker directory for debugging reference

leaks
* @rcu: rcu_head for kfree_rcu()
**/
struct dpll_pin {

drivers/dpll/dpll_core.h +1 -0

@@ -61,6 +65,7 @@ struct dpll_pin {
 	struct xarray ref_sync_pins;
 	struct dpll_pin_properties prop;
 	refcount_t refcount;
+	struct ref_tracker_dir refcnt_tracker;
 	struct rcu_head rcu;
 };
 

drivers/dpll/zl3073x/dpll.c +1 -1

index 9eed21088adac..8788bcab7ec53 100644
@@ -1480,7 +1480,7 @@ zl3073x_dpll_pin_register(struct zl3073x_dpll_pin
 *pin, u32 index)
 
 	/* Create or get existing DPLL pin */
 	pin->dpll_pin = dpll_pin_get(zldpll->dev->clock_id, index,
 THIS_MODULE,
-				     &props->dpll_props);
+				     &props->dpll_props, NULL);
 	if (IS_ERR(pin->dpll_pin)) {

		rc = PTR_ERR(pin->dpll_pin);
		goto err_pin_get;

drivers/dpll/zl3073x/dpll.c +0 -0

@@ -1503,7 +1503,7 @@ zl3073x_dpll_pin_register(struct zl3073x_dpll_pin
 *pin, u32 index)
 	return 0;
 

err_register:

drivers/dpll/zl3073x/dpll.c +1 -1

-	dpll_pin_put(pin->dpll_pin);
+	dpll_pin_put(pin->dpll_pin, NULL);

err_prio_get:

	pin->dpll_pin = NULL;

err_pin_get:

drivers/dpll/zl3073x/dpll.c +2 -2

@@ -1534,7 +1534,7 @@ zl3073x_dpll_pin_unregister(struct zl3073x_dpll_pin
 *pin)
 	/* Unregister the pin */
 	dpll_pin_unregister(zldpll->dpll_dev, pin->dpll_pin, ops, pin);
 
-	dpll_pin_put(pin->dpll_pin);
+	dpll_pin_put(pin->dpll_pin, NULL);
 	pin->dpll_pin = NULL;
 }

@@ -1708,7 +1708,7 @@ zl3073x_dpll_device_register(struct zl3073x_dpll
 *zldpll)
 				       dpll_mode_refsel);
 
 	zldpll->dpll_dev = dpll_device_get(zldev->clock_id, zldpll->id,
-					   THIS_MODULE);
+					   THIS_MODULE, NULL);
 	if (IS_ERR(zldpll->dpll_dev)) {
 		rc = PTR_ERR(zldpll->dpll_dev);

		zldpll->dpll_dev = NULL;

drivers/dpll/zl3073x/dpll.c +2 -2

@@ -1720,7 +1720,7 @@ zl3073x_dpll_device_register(struct zl3073x_dpll
 *zldpll)
 				  zl3073x_prop_dpll_type_get(zldev, zldpll->id),
 				  &zl3073x_dpll_device_ops, zldpll);
 	if (rc) {
-		dpll_device_put(zldpll->dpll_dev);
+		dpll_device_put(zldpll->dpll_dev, NULL);
 		zldpll->dpll_dev = NULL;
 	}

@@ -1743,7 +1743,7 @@ zl3073x_dpll_device_unregister(struct zl3073x_dpll
 *zldpll)
 
 	dpll_device_unregister(zldpll->dpll_dev, &zl3073x_dpll_device_ops,
 			       zldpll);
-	dpll_device_put(zldpll->dpll_dev);
+	dpll_device_put(zldpll->dpll_dev, NULL);
 	zldpll->dpll_dev = NULL;
 }

drivers/net/ethernet/intel/ice/ice_dpll.c +1 -1

index 53b54e395a2ed..64b7b045ecd58 100644
@@ -2814,7 +2814,7 @@ static void ice_dpll_release_pins(struct
 ice_dpll_pin *pins, int count)
 	int i;
 
 	for (i = 0; i < count; i++)
-		dpll_pin_put(pins[i].pin);
+		dpll_pin_put(pins[i].pin, NULL);
 }
 

/**

drivers/net/ethernet/intel/ice/ice_dpll.c +1 -1

@@ -2840,7 +2840,7 @@ ice_dpll_get_pins(struct ice_pf *pf, struct
 ice_dpll_pin *pins,
 
 	for (i = 0; i < count; i++) {
 		pins[i].pin = dpll_pin_get(clock_id, i + start_idx,
 THIS_MODULE,
-					   &pins[i].prop);
+					   &pins[i].prop, NULL);
 		if (IS_ERR(pins[i].pin)) {

			ret = PTR_ERR(pins[i].pin);
			goto release_pins;

drivers/net/ethernet/intel/ice/ice_dpll.c +0 -0

@@ -2851,7 +2851,7 @@ ice_dpll_get_pins(struct ice_pf *pf, struct
 ice_dpll_pin *pins,
 

release_pins:

	while (--i >= 0)

drivers/net/ethernet/intel/ice/ice_dpll.c +1 -1

-		dpll_pin_put(pins[i].pin);
+		dpll_pin_put(pins[i].pin, NULL);

	return ret;
}

drivers/net/ethernet/intel/ice/ice_dpll.c +1 -1

@@ -3037,7 +3037,7 @@ static void ice_dpll_deinit_rclk_pin(struct ice_pf
 *pf)
 	if (WARN_ON_ONCE(!vsi || !vsi->netdev))
 		return;
 	dpll_netdev_pin_clear(vsi->netdev);
-	dpll_pin_put(rclk->pin);
+	dpll_pin_put(rclk->pin, NULL);
 }
 

/**

drivers/net/ethernet/intel/ice/ice_dpll.c +1 -1

@@ -3247,7 +3247,7 @@ ice_dpll_deinit_dpll(struct ice_pf *pf, struct
 ice_dpll *d, bool cgu)
 {
 	if (cgu)
 		dpll_device_unregister(d->dpll, d->ops, d);
-	dpll_device_put(d->dpll);
+	dpll_device_put(d->dpll, NULL);
 }
 

/**

drivers/net/ethernet/intel/ice/ice_dpll.c +1 -1

@@ -3271,7 +3271,7 @@ ice_dpll_init_dpll(struct ice_pf *pf, struct
 ice_dpll *d, bool cgu,
 	u64 clock_id = pf->dplls.clock_id;
 	int ret;
 
-	d->dpll = dpll_device_get(clock_id, d->dpll_idx, THIS_MODULE);
+	d->dpll = dpll_device_get(clock_id, d->dpll_idx, THIS_MODULE, NULL);
 	if (IS_ERR(d->dpll)) {
 		ret = PTR_ERR(d->dpll);

		dev_err(ice_pf_to_dev(pf),

drivers/net/ethernet/intel/ice/ice_dpll.c +1 -1

@@ -3287,7 +3287,7 @@ ice_dpll_init_dpll(struct ice_pf *pf, struct
 ice_dpll *d, bool cgu,
 		ice_dpll_update_state(pf, d, true);
 		ret = dpll_device_register(d->dpll, type, ops, d);
 		if (ret) {
-			dpll_device_put(d->dpll);
+			dpll_device_put(d->dpll, NULL);
 			return ret;
 		}

		d->ops = ops;

drivers/net/ethernet/mellanox/mlx5/core/dpll.c +1 -1

index 3ea8a1766ae28..541d83e5d7183 100644
@@ -438,7 +438,7 @@ static int mlx5_dpll_probe(struct auxiliary_device
 *adev,
 	auxiliary_set_drvdata(adev, mdpll);
 
 	/* Multiple mdev instances might share one DPLL device. */
-	mdpll->dpll = dpll_device_get(clock_id, 0, THIS_MODULE);
+	mdpll->dpll = dpll_device_get(clock_id, 0, THIS_MODULE, NULL);
 	if (IS_ERR(mdpll->dpll)) {
 		err = PTR_ERR(mdpll->dpll);

		goto err_free_mdpll;

drivers/net/ethernet/mellanox/mlx5/core/dpll.c +2 -1

@@ -451,7 +451,8 @@ static int mlx5_dpll_probe(struct auxiliary_device
 *adev,
 
 	/* Multiple mdev instances might share one DPLL pin. */
 	mdpll->dpll_pin = dpll_pin_get(clock_id, mlx5_get_dev_index(mdev),
-				       THIS_MODULE, &mlx5_dpll_pin_properties);
+				       THIS_MODULE, &mlx5_dpll_pin_properties,
+				       NULL);
 	if (IS_ERR(mdpll->dpll_pin)) {
 		err = PTR_ERR(mdpll->dpll_pin);

		goto err_unregister_dpll_device;

drivers/net/ethernet/mellanox/mlx5/core/dpll.c +0 -0

@@ -479,11 +480,11 @@ static int mlx5_dpll_probe(struct auxiliary_device
 *adev,
 	dpll_pin_unregister(mdpll->dpll, mdpll->dpll_pin,
 			    &mlx5_dpll_pins_ops, mdpll);

err_put_dpll_pin:

drivers/net/ethernet/mellanox/mlx5/core/dpll.c +1 -1

-	dpll_pin_put(mdpll->dpll_pin);
+	dpll_pin_put(mdpll->dpll_pin, NULL);

err_unregister_dpll_device:

	dpll_device_unregister(mdpll->dpll, &mlx5_dpll_device_ops, mdpll);

err_put_dpll_device:

drivers/net/ethernet/mellanox/mlx5/core/dpll.c +1 -1

-	dpll_device_put(mdpll->dpll);
+	dpll_device_put(mdpll->dpll, NULL);

err_free_mdpll:

	kfree(mdpll);
	return err;

drivers/net/ethernet/mellanox/mlx5/core/dpll.c +2 -2

@@ -499,9 +500,9 @@ static void mlx5_dpll_remove(struct auxiliary_device
 *adev)
 	destroy_workqueue(mdpll->wq);
 	dpll_pin_unregister(mdpll->dpll, mdpll->dpll_pin,
 			    &mlx5_dpll_pins_ops, mdpll);
-	dpll_pin_put(mdpll->dpll_pin);
+	dpll_pin_put(mdpll->dpll_pin, NULL);
 	dpll_device_unregister(mdpll->dpll, &mlx5_dpll_device_ops, mdpll);
-	dpll_device_put(mdpll->dpll);
+	dpll_device_put(mdpll->dpll, NULL);
 	kfree(mdpll);
 

mlx5_dpll_synce_status_set(mdev,

drivers/ptp/ptp_ocp.c +1 -1

index 65fe05cac8c42..f39b3966b3e8c 100644
@@ -4788,7 +4788,7 @@ ptp_ocp_probe(struct pci_dev *pdev, const struct
 pci_device_id *id)
 	devlink_register(devlink);
 
 	clkid = pci_get_dsn(pdev);
-	bp->dpll = dpll_device_get(clkid, 0, THIS_MODULE);
+	bp->dpll = dpll_device_get(clkid, 0, THIS_MODULE, NULL);
 	if (IS_ERR(bp->dpll)) {
 		err = PTR_ERR(bp->dpll);

		dev_err(&pdev->dev, "dpll_device_alloc failed\n");

drivers/ptp/ptp_ocp.c +2 -1

@@ -4800,7 +4800,8 @@ ptp_ocp_probe(struct pci_dev *pdev, const struct
 pci_device_id *id)
 		goto out;
 
 	for (i = 0; i < OCP_SMA_NUM; i++) {
-		bp->sma[i].dpll_pin = dpll_pin_get(clkid, i, THIS_MODULE, &bp-
 >sma[i].dpll_prop);
+		bp->sma[i].dpll_pin = dpll_pin_get(clkid, i, THIS_MODULE,
+						   &bp->sma[i].dpll_prop, NULL);
 		if (IS_ERR(bp->sma[i].dpll_pin)) {

			err = PTR_ERR(bp->sma[i].dpll_pin);
			goto out_dpll;

drivers/ptp/ptp_ocp.c +1 -1

@@ -4809,7 +4810,7 @@ ptp_ocp_probe(struct pci_dev *pdev, const struct
 pci_device_id *id)
 		err = dpll_pin_register(bp->dpll, bp->sma[i].dpll_pin,
 &dpll_pins_ops,
 					&bp->sma[i]);
 		if (err) {
-			dpll_pin_put(bp->sma[i].dpll_pin);
+			dpll_pin_put(bp->sma[i].dpll_pin, NULL);
 			goto out_dpll;

		}
	}

drivers/ptp/ptp_ocp.c +0 -0

@@ -4819,9 +4820,9 @@ ptp_ocp_probe(struct pci_dev *pdev, const struct
 pci_device_id *id)

out_dpll:

	while (i--) {
		dpll_pin_unregister(bp->dpll, bp->sma[i].dpll_pin,

&dpll_pins_ops, &bp->sma[i]);

drivers/ptp/ptp_ocp.c +1 -1

-		dpll_pin_put(bp->sma[i].dpll_pin);
+		dpll_pin_put(bp->sma[i].dpll_pin, NULL);

	}

drivers/ptp/ptp_ocp.c +1 -1

-	dpll_device_put(bp->dpll);
+	dpll_device_put(bp->dpll, NULL);

out:

	ptp_ocp_detach(bp);

out_disable:

drivers/ptp/ptp_ocp.c +2 -2

@@ -4842,11 +4843,11 @@ ptp_ocp_remove(struct pci_dev *pdev)
 	for (i = 0; i < OCP_SMA_NUM; i++) {
 		if (bp->sma[i].dpll_pin) {
 			dpll_pin_unregister(bp->dpll, bp->sma[i].dpll_pin,
 &dpll_pins_ops, &bp->sma[i]);
-			dpll_pin_put(bp->sma[i].dpll_pin);
+			dpll_pin_put(bp->sma[i].dpll_pin, NULL);
 		}
 	}
 	dpll_device_unregister(bp->dpll, &dpll_ops, bp);
-	dpll_device_put(bp->dpll);
+	dpll_device_put(bp->dpll, NULL);
 	devlink_unregister(devlink);
 	ptp_ocp_detach(bp);

	pci_disable_device(pdev);

include/linux/dpll.h +9 -1

index 8fff048131f1d..2ce295b46b8cd 100644
@@ -18,6 +18,7 @@ struct dpll_device;
 struct dpll_pin;
 struct dpll_pin_esync;
 struct fwnode_handle;
+struct ref_tracker;
 
 struct dpll_device_ops {
 	int (*mode_get)(const struct dpll_device *dpll, void *dpll_priv,

@@ -173,6 +174,12 @@ struct dpll_pin_properties {
 	u32 phase_gran;
 };
 
+#ifdef CONFIG_DPLL_REFCNT_TRACKER
+typedef struct ref_tracker *dpll_tracker;
+#else
+typedef struct {} dpll_tracker;
+#endif
+
 #define DPLL_DEVICE_CREATED	1
 #define DPLL_DEVICE_DELETED	2
 #define DPLL_DEVICE_CHANGED	3

@@ -205,7 +212,8 @@ size_t dpll_netdev_pin_handle_size(const struct
 net_device *dev);
 int dpll_netdev_add_pin_handle(struct sk_buff *msg,
 			       const struct net_device *dev);
 
-struct dpll_pin *fwnode_dpll_pin_find(struct fwnode_handle *fwnode);
+struct dpll_pin *fwnode_dpll_pin_find(struct fwnode_handle *fwnode,
+				      dpll_tracker *tracker);
 #else

static inline void
dpll_netdev_pin_set(struct net_device *dev, struct dpll_pin *dpll_pin) { }

include/linux/dpll.h +0 -0

@@ -223,16 +231,17 @@ dpll_netdev_add_pin_handle(struct sk_buff *msg,
 const struct net_device *dev)
 }
 

static inline struct dpll_pin *

include/linux/dpll.h +1 -1

-fwnode_dpll_pin_find(struct fwnode_handle *fwnode)
+fwnode_dpll_pin_find(struct fwnode_handle *fwnode, dpll_tracker *tracker)

{
	return NULL;
}

#endif

struct dpll_device *

include/linux/dpll.h +3 -2

-dpll_device_get(u64 clock_id, u32 dev_driver_id, struct module *module);
+dpll_device_get(u64 clock_id, u32 dev_driver_id, struct module *module,
+		dpll_tracker *tracker);
 
-void dpll_device_put(struct dpll_device *dpll);
+void dpll_device_put(struct dpll_device *dpll, dpll_tracker *tracker);

int dpll_device_register(struct dpll_device *dpll, enum dpll_type type,

			 const struct dpll_device_ops *ops, void *priv);

include/linux/dpll.h +0 -0

@@ -244,7 +253,7 @@ void dpll_device_unregister(struct dpll_device *dpll,
 

struct dpll_pin *
dpll_pin_get(u64 clock_id, u32 dev_driver_id, struct module *module,

include/linux/dpll.h +1 -1

-	     const struct dpll_pin_properties *prop);
+	     const struct dpll_pin_properties *prop, dpll_tracker *tracker);

int dpll_pin_register(struct dpll_device *dpll, struct dpll_pin *pin,

		      const struct dpll_pin_ops *ops, void *priv);

include/linux/dpll.h +1 -1

@@ -252,7 +261,7 @@ int dpll_pin_register(struct dpll_device *dpll, struct
 dpll_pin *pin,
 void dpll_pin_unregister(struct dpll_device *dpll, struct dpll_pin *pin,
 			 const struct dpll_pin_ops *ops, void *priv);
 
-void dpll_pin_put(struct dpll_pin *pin);
+void dpll_pin_put(struct dpll_pin *pin, dpll_tracker *tracker);
 

void dpll_pin_fwnode_set(struct dpll_pin *pin, struct fwnode_handle *fwnode);

--
2.52.0

From: Ivan Vecera <[email protected]>
Sent: Tuesday, February 3, 2026 6:40 PM

Update existing DPLL drivers to utilize the DPLL reference count tracking infrastructure.

Add dpll_tracker fields to the drivers' internal device and pin structures. Pass pointers to these trackers when calling dpll_device_get/put() and dpll_pin_get/put().

This allows developers to inspect the specific references held by this driver via debugfs when CONFIG_DPLL_REFCNT_TRACKER is enabled, aiding in the debugging of resource leaks.

Reviewed-by Aleksandr Loktionov <[email protected]>

Signed-off-by Ivan Vecera <[email protected]>

---

drivers/dpll/zl3073x/dpll.c                    | 14 ++++++++------
drivers/dpll/zl3073x/dpll.h                    |  2 ++
drivers/net/ethernet/intel/ice/ice_dpll.c      | 15 ++++++++-------
drivers/net/ethernet/intel/ice/ice_dpll.h      |  4 ++++
drivers/net/ethernet/mellanox/mlx5/core/dpll.c | 15 +++++++++------
drivers/ptp/ptp_ocp.c                          | 17 ++++++++++-------
6 files changed, 41 insertions(+), 26 deletions(-)

drivers/dpll/zl3073x/dpll.c +3 -1

index 8788bcab7ec53..a99d143a7acde 100644
@@ -29,6 +29,7 @@
 * @list: this DPLL pin list entry
 * @dpll: DPLL the pin is registered to
 * @dpll_pin: pointer to registered dpll_pin
+ * @tracker: tracking object for the acquired reference
 * @label: package label
 * @dir: pin direction
 * @id: pin id

@@ -44,6 +45,7 @@ struct zl3073x_dpll_pin {
 	struct list_head	list;
 	struct zl3073x_dpll	*dpll;
 	struct dpll_pin		*dpll_pin;
+	dpll_tracker		tracker;
 	char			label[8];
 	enum dpll_pin_direction	dir;
 	u8			id;

@@ -1480,7 +1482,7 @@ zl3073x_dpll_pin_register(struct zl3073x_dpll_pin
 *pin, u32 index)
 
 	/* Create or get existing DPLL pin */
 	pin->dpll_pin = dpll_pin_get(zldpll->dev->clock_id, index,
 THIS_MODULE,
-				     &props->dpll_props, NULL);
+				     &props->dpll_props, &pin->tracker);
 	if (IS_ERR(pin->dpll_pin)) {

		rc = PTR_ERR(pin->dpll_pin);
		goto err_pin_get;

drivers/dpll/zl3073x/dpll.c +0 -0

@@ -1503,7 +1505,7 @@ zl3073x_dpll_pin_register(struct zl3073x_dpll_pin
 *pin, u32 index)
 	return 0;
 

err_register:

drivers/dpll/zl3073x/dpll.c +1 -1

-	dpll_pin_put(pin->dpll_pin, NULL);
+	dpll_pin_put(pin->dpll_pin, &pin->tracker);

err_prio_get:

	pin->dpll_pin = NULL;

err_pin_get:

drivers/dpll/zl3073x/dpll.c +2 -2

@@ -1534,7 +1536,7 @@ zl3073x_dpll_pin_unregister(struct zl3073x_dpll_pin
 *pin)
 	/* Unregister the pin */
 	dpll_pin_unregister(zldpll->dpll_dev, pin->dpll_pin, ops, pin);
 
-	dpll_pin_put(pin->dpll_pin, NULL);
+	dpll_pin_put(pin->dpll_pin, &pin->tracker);
 	pin->dpll_pin = NULL;
 }

@@ -1708,7 +1710,7 @@ zl3073x_dpll_device_register(struct zl3073x_dpll
 *zldpll)
 				       dpll_mode_refsel);
 
 	zldpll->dpll_dev = dpll_device_get(zldev->clock_id, zldpll->id,
-					   THIS_MODULE, NULL);
+					   THIS_MODULE, &zldpll->tracker);
 	if (IS_ERR(zldpll->dpll_dev)) {
 		rc = PTR_ERR(zldpll->dpll_dev);

		zldpll->dpll_dev = NULL;

drivers/dpll/zl3073x/dpll.c +2 -2

@@ -1720,7 +1722,7 @@ zl3073x_dpll_device_register(struct zl3073x_dpll
 *zldpll)
 				  zl3073x_prop_dpll_type_get(zldev, zldpll->id),
 				  &zl3073x_dpll_device_ops, zldpll);
 	if (rc) {
-		dpll_device_put(zldpll->dpll_dev, NULL);
+		dpll_device_put(zldpll->dpll_dev, &zldpll->tracker);
 		zldpll->dpll_dev = NULL;
 	}

@@ -1743,7 +1745,7 @@ zl3073x_dpll_device_unregister(struct zl3073x_dpll
 *zldpll)
 
 	dpll_device_unregister(zldpll->dpll_dev, &zl3073x_dpll_device_ops,
 			       zldpll);
-	dpll_device_put(zldpll->dpll_dev, NULL);
+	dpll_device_put(zldpll->dpll_dev, &zldpll->tracker);
 	zldpll->dpll_dev = NULL;
 }

drivers/dpll/zl3073x/dpll.h +2 -0

index e8c39b44b356c..c65c798c37927 100644
@@ -18,6 +18,7 @@
 * @check_count: periodic check counter
 * @phase_monitor: is phase offset monitor enabled
 * @dpll_dev: pointer to registered DPLL device
+ * @tracker: tracking object for the acquired reference
 * @lock_status: last saved DPLL lock status
 * @pins: list of pins
 * @change_work: device change notification work

@@ -31,6 +32,7 @@ struct zl3073x_dpll {
 	u8				check_count;
 	bool				phase_monitor;
 	struct dpll_device		*dpll_dev;
+	dpll_tracker			tracker;
 	enum dpll_lock_status		lock_status;
 	struct list_head		pins;
 	struct work_struct		change_work;

drivers/net/ethernet/intel/ice/ice_dpll.c +1 -1

index 64b7b045ecd58..4eca62688d834 100644
@@ -2814,7 +2814,7 @@ static void ice_dpll_release_pins(struct
 ice_dpll_pin *pins, int count)
 	int i;
 
 	for (i = 0; i < count; i++)
-		dpll_pin_put(pins[i].pin, NULL);
+		dpll_pin_put(pins[i].pin, &pins[i].tracker);
 }
 

/**

drivers/net/ethernet/intel/ice/ice_dpll.c +1 -1

@@ -2840,7 +2840,7 @@ ice_dpll_get_pins(struct ice_pf *pf, struct
 ice_dpll_pin *pins,
 
 	for (i = 0; i < count; i++) {
 		pins[i].pin = dpll_pin_get(clock_id, i + start_idx,
 THIS_MODULE,
-					   &pins[i].prop, NULL);
+					   &pins[i].prop, &pins[i].tracker);
 		if (IS_ERR(pins[i].pin)) {

			ret = PTR_ERR(pins[i].pin);
			goto release_pins;

drivers/net/ethernet/intel/ice/ice_dpll.c +0 -0

@@ -2851,7 +2851,7 @@ ice_dpll_get_pins(struct ice_pf *pf, struct
 ice_dpll_pin *pins,
 

release_pins:

	while (--i >= 0)

drivers/net/ethernet/intel/ice/ice_dpll.c +1 -1

-		dpll_pin_put(pins[i].pin, NULL);
+		dpll_pin_put(pins[i].pin, &pins[i].tracker);

	return ret;
}

drivers/net/ethernet/intel/ice/ice_dpll.c +1 -1

@@ -3037,7 +3037,7 @@ static void ice_dpll_deinit_rclk_pin(struct ice_pf
 *pf)
 	if (WARN_ON_ONCE(!vsi || !vsi->netdev))
 		return;
 	dpll_netdev_pin_clear(vsi->netdev);
-	dpll_pin_put(rclk->pin, NULL);
+	dpll_pin_put(rclk->pin, &rclk->tracker);
 }
 

/**

drivers/net/ethernet/intel/ice/ice_dpll.c +1 -1

@@ -3247,7 +3247,7 @@ ice_dpll_deinit_dpll(struct ice_pf *pf, struct
 ice_dpll *d, bool cgu)
 {
 	if (cgu)
 		dpll_device_unregister(d->dpll, d->ops, d);
-	dpll_device_put(d->dpll, NULL);
+	dpll_device_put(d->dpll, &d->tracker);
 }
 

/**

drivers/net/ethernet/intel/ice/ice_dpll.c +2 -1

@@ -3271,7 +3271,8 @@ ice_dpll_init_dpll(struct ice_pf *pf, struct
 ice_dpll *d, bool cgu,
 	u64 clock_id = pf->dplls.clock_id;
 	int ret;
 
-	d->dpll = dpll_device_get(clock_id, d->dpll_idx, THIS_MODULE, NULL);
+	d->dpll = dpll_device_get(clock_id, d->dpll_idx, THIS_MODULE,
+				  &d->tracker);
 	if (IS_ERR(d->dpll)) {
 		ret = PTR_ERR(d->dpll);

		dev_err(ice_pf_to_dev(pf),

drivers/net/ethernet/intel/ice/ice_dpll.c +1 -1

@@ -3287,7 +3288,7 @@ ice_dpll_init_dpll(struct ice_pf *pf, struct
 ice_dpll *d, bool cgu,
 		ice_dpll_update_state(pf, d, true);
 		ret = dpll_device_register(d->dpll, type, ops, d);
 		if (ret) {
-			dpll_device_put(d->dpll, NULL);
+			dpll_device_put(d->dpll, &d->tracker);
 			return ret;
 		}

		d->ops = ops;

drivers/net/ethernet/intel/ice/ice_dpll.h +4 -0

index c0da03384ce91..63fac6510df6e 100644
@@ -23,6 +23,7 @@ enum ice_dpll_pin_sw {
 /** ice_dpll_pin - store info about pins
 * @pin: dpll pin structure
 * @pf: pointer to pf, which has registered the dpll_pin
+ * @tracker: reference count tracker
 * @idx: ice pin private idx
 * @num_parents: hols number of parent pins
 * @parent_idx: hold indexes of parent pins

@@ -37,6 +38,7 @@ enum ice_dpll_pin_sw {
 struct ice_dpll_pin {
 	struct dpll_pin *pin;
 	struct ice_pf *pf;
+	dpll_tracker tracker;
 	u8 idx;
 	u8 num_parents;
 	u8 parent_idx[ICE_DPLL_RCLK_NUM_MAX];

@@ -58,6 +60,7 @@ struct ice_dpll_pin {
 /** ice_dpll - store info required for DPLL control
 * @dpll: pointer to dpll dev
 * @pf: pointer to pf, which has registered the dpll_device
+ * @tracker: reference count tracker
 * @dpll_idx: index of dpll on the NIC
 * @input_idx: currently selected input index
 * @prev_input_idx: previously selected input index

@@ -76,6 +79,7 @@ struct ice_dpll_pin {
 struct ice_dpll {
 	struct dpll_device *dpll;
 	struct ice_pf *pf;
+	dpll_tracker tracker;
 	u8 dpll_idx;
 	u8 input_idx;
 	u8 prev_input_idx;

drivers/net/ethernet/mellanox/mlx5/core/dpll.c +4 -1

index 541d83e5d7183..3981dd81d4c17 100644
@@ -9,7 +9,9 @@
 */
 struct mlx5_dpll {
 	struct dpll_device *dpll;
+	dpll_tracker dpll_tracker;
 	struct dpll_pin *dpll_pin;
+	dpll_tracker pin_tracker;
 	struct mlx5_core_dev *mdev;
 	struct workqueue_struct *wq;
 	struct delayed_work work;

@@ -438,7 +440,8 @@ static int mlx5_dpll_probe(struct auxiliary_device
 *adev,
 	auxiliary_set_drvdata(adev, mdpll);
 
 	/* Multiple mdev instances might share one DPLL device. */
-	mdpll->dpll = dpll_device_get(clock_id, 0, THIS_MODULE, NULL);
+	mdpll->dpll = dpll_device_get(clock_id, 0, THIS_MODULE,
+				      &mdpll->dpll_tracker);
 	if (IS_ERR(mdpll->dpll)) {
 		err = PTR_ERR(mdpll->dpll);

		goto err_free_mdpll;

drivers/net/ethernet/mellanox/mlx5/core/dpll.c +1 -1

@@ -452,7 +455,7 @@ static int mlx5_dpll_probe(struct auxiliary_device
 *adev,
 	/* Multiple mdev instances might share one DPLL pin. */
 	mdpll->dpll_pin = dpll_pin_get(clock_id, mlx5_get_dev_index(mdev),
 				       THIS_MODULE, &mlx5_dpll_pin_properties,
-				       NULL);
+				       &mdpll->pin_tracker);
 	if (IS_ERR(mdpll->dpll_pin)) {
 		err = PTR_ERR(mdpll->dpll_pin);

		goto err_unregister_dpll_device;

drivers/net/ethernet/mellanox/mlx5/core/dpll.c +0 -0

@@ -480,11 +483,11 @@ static int mlx5_dpll_probe(struct auxiliary_device
 *adev,
 	dpll_pin_unregister(mdpll->dpll, mdpll->dpll_pin,
 			    &mlx5_dpll_pins_ops, mdpll);

err_put_dpll_pin:

drivers/net/ethernet/mellanox/mlx5/core/dpll.c +1 -1

-	dpll_pin_put(mdpll->dpll_pin, NULL);
+	dpll_pin_put(mdpll->dpll_pin, &mdpll->pin_tracker);

err_unregister_dpll_device:

	dpll_device_unregister(mdpll->dpll, &mlx5_dpll_device_ops, mdpll);

err_put_dpll_device:

drivers/net/ethernet/mellanox/mlx5/core/dpll.c +1 -1

-	dpll_device_put(mdpll->dpll, NULL);
+	dpll_device_put(mdpll->dpll, &mdpll->dpll_tracker);

err_free_mdpll:

	kfree(mdpll);
	return err;

drivers/net/ethernet/mellanox/mlx5/core/dpll.c +2 -2

@@ -500,9 +503,9 @@ static void mlx5_dpll_remove(struct auxiliary_device
 *adev)
 	destroy_workqueue(mdpll->wq);
 	dpll_pin_unregister(mdpll->dpll, mdpll->dpll_pin,
 			    &mlx5_dpll_pins_ops, mdpll);
-	dpll_pin_put(mdpll->dpll_pin, NULL);
+	dpll_pin_put(mdpll->dpll_pin, &mdpll->pin_tracker);
 	dpll_device_unregister(mdpll->dpll, &mlx5_dpll_device_ops, mdpll);
-	dpll_device_put(mdpll->dpll, NULL);
+	dpll_device_put(mdpll->dpll, &mdpll->dpll_tracker);
 	kfree(mdpll);
 

mlx5_dpll_synce_status_set(mdev,

drivers/ptp/ptp_ocp.c +3 -1

index f39b3966b3e8c..1b16a9c3d7fdc 100644
@@ -285,6 +285,7 @@ struct ptp_ocp_sma_connector {
 	u8	default_fcn;
 	struct dpll_pin		   *dpll_pin;
 	struct dpll_pin_properties dpll_prop;
+	dpll_tracker		   tracker;
 };
 
 struct ocp_attr_group {

@@ -383,6 +384,7 @@ struct ptp_ocp {
 	struct ptp_ocp_sma_connector sma[OCP_SMA_NUM];
 	const struct ocp_sma_op *sma_op;
 	struct dpll_device *dpll;
+	dpll_tracker tracker;
 	int signals_nr;
 	int freq_in_nr;
 };

@@ -4788,7 +4790,7 @@ ptp_ocp_probe(struct pci_dev *pdev, const struct
 pci_device_id *id)
 	devlink_register(devlink);
 
 	clkid = pci_get_dsn(pdev);
-	bp->dpll = dpll_device_get(clkid, 0, THIS_MODULE, NULL);
+	bp->dpll = dpll_device_get(clkid, 0, THIS_MODULE, &bp->tracker);
 	if (IS_ERR(bp->dpll)) {
 		err = PTR_ERR(bp->dpll);

		dev_err(&pdev->dev, "dpll_device_alloc failed\n");

drivers/ptp/ptp_ocp.c +2 -1

@@ -4801,7 +4803,8 @@ ptp_ocp_probe(struct pci_dev *pdev, const struct
 pci_device_id *id)
 
 	for (i = 0; i < OCP_SMA_NUM; i++) {
 		bp->sma[i].dpll_pin = dpll_pin_get(clkid, i, THIS_MODULE,
-						   &bp->sma[i].dpll_prop, NULL);
+						   &bp->sma[i].dpll_prop,
+						   &bp->sma[i].tracker);
 		if (IS_ERR(bp->sma[i].dpll_pin)) {
 			err = PTR_ERR(bp->sma[i].dpll_pin);

			goto out_dpll;

drivers/ptp/ptp_ocp.c +1 -1

@@ -4810,7 +4813,7 @@ ptp_ocp_probe(struct pci_dev *pdev, const struct
 pci_device_id *id)
 		err = dpll_pin_register(bp->dpll, bp->sma[i].dpll_pin,
 &dpll_pins_ops,
 					&bp->sma[i]);
 		if (err) {
-			dpll_pin_put(bp->sma[i].dpll_pin, NULL);
+			dpll_pin_put(bp->sma[i].dpll_pin, &bp->sma[i].tracker);
 			goto out_dpll;

		}
	}

drivers/ptp/ptp_ocp.c +0 -0

@@ -4820,9 +4823,9 @@ ptp_ocp_probe(struct pci_dev *pdev, const struct
 pci_device_id *id)

out_dpll:

	while (i--) {
		dpll_pin_unregister(bp->dpll, bp->sma[i].dpll_pin,

&dpll_pins_ops, &bp->sma[i]);

drivers/ptp/ptp_ocp.c +1 -1

-		dpll_pin_put(bp->sma[i].dpll_pin, NULL);
+		dpll_pin_put(bp->sma[i].dpll_pin, &bp->sma[i].tracker);

	}

drivers/ptp/ptp_ocp.c +1 -1

-	dpll_device_put(bp->dpll, NULL);
+	dpll_device_put(bp->dpll, &bp->tracker);

out:

	ptp_ocp_detach(bp);

out_disable:

drivers/ptp/ptp_ocp.c +2 -2

@@ -4843,11 +4846,11 @@ ptp_ocp_remove(struct pci_dev *pdev)
 	for (i = 0; i < OCP_SMA_NUM; i++) {
 		if (bp->sma[i].dpll_pin) {
 			dpll_pin_unregister(bp->dpll, bp->sma[i].dpll_pin,
 &dpll_pins_ops, &bp->sma[i]);
-			dpll_pin_put(bp->sma[i].dpll_pin, NULL);
+			dpll_pin_put(bp->sma[i].dpll_pin, &bp->sma[i].tracker);
 		}
 	}
 	dpll_device_unregister(bp->dpll, &dpll_ops, bp);
-	dpll_device_put(bp->dpll, NULL);
+	dpll_device_put(bp->dpll, &bp->tracker);
 	devlink_unregister(devlink);
 	ptp_ocp_detach(bp);

	pci_disable_device(pdev);

--
2.52.0