Skip to contentSkip to conversation

rust_binder: return p from rust_binder_transaction_target_node()

PATCH In review Alice Ryhl 3 participants 6 messages Jan 28 – Feb 3 Android drivers

lore
Share & tools
lore

Alice Ryhl

author maintainer
#0 lore raw

PATCH 1/1 rust_binder: return p from rust_binder_transaction_target_node()

Somehow this got changed to NULL when I ported this to upstream it. No idea how that happened.

Fixes c1ea31205edf ("rust_binder: add binder_transaction tracepoint")

---
Commit not yet upstream, so cc stable not required.

---
 drivers/android/binder/rust_binder.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/android/binder/rust_binder.h +1 -1
index e68ba7a23c34de4688fa7d34341b0585b5dba7e9..d2284726c025190415239acfa07728caa814d260 100644
@@ -79,7 +79,7 @@ static inline rust_binder_node rust_binder_transaction_target_node(rust_binder_t
 
 	if (p)
 		p = p + RUST_BINDER_LAYOUT.n.arc_offset;
-	return NULL;
+	return p;
 }
 
 static inline rust_binder_process rust_binder_transaction_to_proc(rust_binder_transaction t)

---
base-commit: e94865ca2340e9eaec08716dfad645e9f719eedd
change-id: 20260128-binder-fix-target-node-null-02fcb98f0200

Best regards,

Signature · 1 line
Alice Ryhl <[email protected]>
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 31 lines · Alice Ryhl

Somehow this got changed to NULL when I ported this to upstream it. No idea how that happened.

Fixes c1ea31205edf ("rust_binder: add binder_transaction tracepoint")

---
Commit not yet upstream, so cc stable not required.

---
 drivers/android/binder/rust_binder.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/android/binder/rust_binder.h +1 -2
index e68ba7a23c34de4688fa7d34341b0585b5dba7e9..d2284726c025190415239acfa07728caa814d260 100644
@@ -79,7 +79,7 @@ static inline rust_binder_node rust_binder_transaction_target_node(rust_binder_t
 
 	if (p)
 		p = p + RUST_BINDER_LAYOUT.n.arc_offset;
-	return NULL;
+	return p;
 }
 
 static inline rust_binder_process rust_binder_transaction_to_proc(rust_binder_transaction t)
 
---

base-commit: e94865ca2340e9eaec08716dfad645e9f719eedd
change-id: 20260128-binder-fix-target-node-null-02fcb98f0200

Quoted 4 lines

Best regards,

Signature · 1 line
Alice Ryhl <[email protected]>
#2 lore raw
In reply to Alice Ryhl
Quoted 28 lines · Alice Ryhl

Somehow this got changed to NULL when I ported this to upstream it. No idea how that happened.

Fixes c1ea31205edf ("rust_binder: add binder_transaction tracepoint")

---
Commit not yet upstream, so cc stable not required.

---
 drivers/android/binder/rust_binder.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/android/binder/rust_binder.h +1 -2
index e68ba7a23c34de4688fa7d34341b0585b5dba7e9..d2284726c025190415239acfa07728caa814d260 100644
@@ -79,7 +79,7 @@ static inline rust_binder_node rust_binder_transaction_target_node(rust_binder_t
 
 	if (p)
 		p = p + RUST_BINDER_LAYOUT.n.arc_offset;
-	return NULL;
+	return p;
 }
 
 static inline rust_binder_process rust_binder_transaction_to_proc(rust_binder_transaction t)
 
---
Quoted 2 lines

base-commit: e94865ca2340e9eaec08716dfad645e9f719eedd
change-id: 20260128-binder-fix-target-node-null-02fcb98f0200

Does not apply at all, what tree was this made against?

thanks,

greg k-h

author maintainer
#3 lore raw
Quoted 26 lines · Greg Kroah-Hartman
Quoted 25 lines · Alice Ryhl

Somehow this got changed to NULL when I ported this to upstream it. No idea how that happened.

Fixes c1ea31205edf ("rust_binder: add binder_transaction tracepoint")

---
Commit not yet upstream, so cc stable not required.

---
 drivers/android/binder/rust_binder.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/android/binder/rust_binder.h +1 -1
index e68ba7a23c34de4688fa7d34341b0585b5dba7e9..d2284726c025190415239acfa07728caa814d260 100644
@@ -79,7 +79,7 @@ static inline rust_binder_node rust_binder_transaction_target_node(rust_binder_t
 
 	if (p)
 		p = p + RUST_BINDER_LAYOUT.n.arc_offset;
-	return NULL;
+	return p;
 }
 
Quoted 7 lines
Quoted 5 lines
drivers/android/binder/rust_binder.h +0 -1
 static inline rust_binder_process rust_binder_transaction_to_proc(rust_binder_transaction t)
 
---

base-commit: e94865ca2340e9eaec08716dfad645e9f719eedd
change-id: 20260128-binder-fix-target-node-null-02fcb98f0200

Does not apply at all, what tree was this made against?

This applies on char-misc-next. It's a fix for commit c1ea31205edf, which currently only exists in that branch.

Alice

#4 lore raw
Quoted 29 lines · Alice Ryhl
Quoted 28 lines · Greg Kroah-Hartman
Quoted 27 lines · Alice Ryhl

Somehow this got changed to NULL when I ported this to upstream it. No idea how that happened.

Fixes c1ea31205edf ("rust_binder: add binder_transaction tracepoint")

---
Commit not yet upstream, so cc stable not required.

---
 drivers/android/binder/rust_binder.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/android/binder/rust_binder.h +1 -1
index e68ba7a23c34de4688fa7d34341b0585b5dba7e9..d2284726c025190415239acfa07728caa814d260 100644
@@ -79,7 +79,7 @@ static inline rust_binder_node rust_binder_transaction_target_node(rust_binder_t
 
 	if (p)
 		p = p + RUST_BINDER_LAYOUT.n.arc_offset;
-	return NULL;
+	return p;
 }
 
 static inline rust_binder_process rust_binder_transaction_to_proc(rust_binder_transaction t)
Quoted 8 lines
Quoted 5 lines
Quoted 3 lines

---
base-commit: e94865ca2340e9eaec08716dfad645e9f719eedd
change-id: 20260128-binder-fix-target-node-null-02fcb98f0200

Does not apply at all, what tree was this made against?

This applies on char-misc-next. It's a fix for commit c1ea31205edf, which currently only exists in that branch.

Our emails crossed, my fault, I was looking at the wrong tree. Now applied, thanks!

greg k-h

#5 lore raw
In reply to Greg Kroah-Hartman
Quoted 26 lines · Greg Kroah-Hartman
Quoted 25 lines · Alice Ryhl

Somehow this got changed to NULL when I ported this to upstream it. No idea how that happened.

Fixes c1ea31205edf ("rust_binder: add binder_transaction tracepoint")

---
Commit not yet upstream, so cc stable not required.

---
 drivers/android/binder/rust_binder.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/android/binder/rust_binder.h +1 -1
index e68ba7a23c34de4688fa7d34341b0585b5dba7e9..d2284726c025190415239acfa07728caa814d260 100644
@@ -79,7 +79,7 @@ static inline rust_binder_node rust_binder_transaction_target_node(rust_binder_t
 
 	if (p)
 		p = p + RUST_BINDER_LAYOUT.n.arc_offset;
-	return NULL;
+	return p;
 }
 
Quoted 7 lines
Quoted 5 lines
drivers/android/binder/rust_binder.h +0 -1
 static inline rust_binder_process rust_binder_transaction_to_proc(rust_binder_transaction t)
 
---

base-commit: e94865ca2340e9eaec08716dfad645e9f719eedd
change-id: 20260128-binder-fix-target-node-null-02fcb98f0200

Does not apply at all, what tree was this made against?

Ugh, I was looking at the wrong tree, nevermind, my fault...

greg k-h