Skip to contentSkip to conversation

amd-xgbe: do not select NET_SELFTESTS when INET is disabled

PATCH In review Raju Rangoju 1 participant 1 message Feb 4

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v3 1/4 amd-xgbe: do not select NET_SELFTESTS when INET is disabled

AMD_XGBE currently selects NET_SELFTESTS unconditionally. Since select does not honor dependencies, this can force-enable NET_SELFTESTS even when INET is disabled (e.g. INET=n randconfig builds).

Fixes build issue when INET is disabled.

Fixes 862a64c83faf ("amd-xgbe: introduce support ethtool selftest")

---
Changes since v2:
- CC maintainer

Changes since v1:
- Added this patch to address the build failure reported by the kernel test robot.

 drivers/net/ethernet/amd/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/amd/Kconfig +1 -1
index d54dca3074eb..45e8d698781c 100644
@@ -165,7 +165,7 @@ config AMD_XGBE
 	select CRC32
 	select PHYLIB
 	select AMD_XGBE_HAVE_ECC if X86
-	select NET_SELFTESTS
+	imply NET_SELFTESTS
 	help
 	  This driver supports the AMD 10GbE Ethernet device found on an
 	  AMD SoC.
Signature · 1 line
2.34.1