staging: greybus: resolved checkpatch checks for light.c
Subsystems (3)
PATCH v3 4/4 staging: greybus: resolved checkpatch checks for light.c
Added comment to mutex declarations, to resolve checkpatch.pl checks.
Signed-off-by Rachit Dhar <[email protected]>
--- drivers/staging/greybus/light.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/greybus/light.c +2 -2
@@ -37,7 +37,7 @@ struct gb_channel {bool releasing;bool strobe_state;bool active; -struct mutex lock; +struct mutex lock;/* protects gb_channel->active */ };struct gb_light {
@@ -59,7 +59,7 @@ struct gb_lights {struct gb_connection *connection;u8 lights_count;struct gb_light *lights; -struct mutex lights_lock; +struct mutex lights_lock;/* protects gb_lights->lights */ };static void gb_lights_channel_free (struct gb_channel *channel);
Signature · 1 line
2.43.0
Hey Rachit,
Thanks for the patch. And the sending corrections along the path.
Quoted 21 lines · Rachit Dhar
Added comment to mutex declarations, to resolve checkpatch.pl checks.
Signed-off-by Rachit Dhar <[email protected]>--- drivers/staging/greybus/light.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/staging/greybus/light.c +1
-1@@ -37,7 +37,7 @@ struct gb_channel {bool releasing;bool strobe_state;bool active; -struct mutex lock; +struct mutex lock;/* protects gb_channel->active */ };struct gb_light {
drivers/staging/greybus/light.c struct gb_lights { · line 64
Quoted 7 lines
drivers/staging/greybus/light.c +1
-1@@ -59,7 +59,7 @@ struct gb_lights {struct gb_connection *connection;u8 lights_count;struct gb_light *lights; -struct mutex lights_lock; +struct mutex lights_lock;/* protects gb_lights->lights */ };
This LGTM.
Acked-by Rui Miguel Silva <[email protected]>
Cheers,
Rui
Quoted 3 lines
drivers/staging/greybus/light.c +0
-0static void gb_lights_channel_free (struct gb_channel *channel);Signature · 1 line
2.43.0