staging: rtl8723bs: remove unnecessary boolean comparison
PATCH 1/1 staging: rtl8723bs: remove unnecessary boolean comparison
Remove explicit comprassion to true in boolean expression to follow Linux kernel coding style.
--- drivers/staging/rtl8723bs/core/rtw_ap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8723bs/core/rtw_ap.c +1 -1
@@ -1157,7 +1157,7 @@ int rtw_acl_add_sta(struct adapter *padapter, u8 *addr) paclnode = list_entry(plist, struct rtw_wlan_acl_node, list);if (!memcmp (paclnode->addr, addr,ETH_ALEN )) { -if (paclnode->valid == true) { +if (paclnode->valid) { added = true;break ; }
Signature · 1 line
2.52.0
Quoted 2 lines · Nikolay Kulikov
Remove explicit comprassion to true in boolean expression to follow Linux kernel coding style.
You misspelt comparison as "comprassion".
Quoted 3 lines
Signed-off-by Nikolay Kulikov <[email protected]>---
Thanks,
ET
Thanks for the review!
I'll fix it and send v2.
Regards, Nikolay
пт, 6 февр. 2026 г. в 22:22, Ethan Tidmore <[email protected]>:
Quoted 14 lines · Nikolay Kulikov
Quoted 2 lines
Remove explicit comprassion to true in boolean expression to follow Linux kernel coding style.
You misspelt comparison as "comprassion".
Quoted 3 lines
Signed-off-by Nikolay Kulikov <[email protected]>---
Thanks,
ET
PATCH v2 1/1 staging: rtl8723bs: remove unnecessary boolean comparison
In reply to Nikolay KulikovRemove explicit comparison to true in boolean expression to follow Linux kernel coding style.
---
Changes in v2:
- Fixed typo in commit message
drivers/staging/rtl8723bs/core/rtw_ap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8723bs/core/rtw_ap.c +1 -1
@@ -1157,7 +1157,7 @@ int rtw_acl_add_sta(struct adapter *padapter, u8 *addr) paclnode = list_entry(plist, struct rtw_wlan_acl_node, list);if (!memcmp (paclnode->addr, addr,ETH_ALEN )) { -if (paclnode->valid == true) { +if (paclnode->valid) { added = true;break ; }
Signature · 1 line
2.53.0
Quoted 5 lines · Nikolay Kulikov
Remove explicit comparison to true in boolean expression to follow Linux kernel coding style.
Signed-off-by Nikolay Kulikov <[email protected]>---
LGTM.
Thanks,
ET