Skip to contentSkip to conversation

staging: rtl8723bs: remove unnecessary boolean comparison

PATCH Superseded Nikolay Kulikov 2 participants 5 messages Feb 5 – Feb 14 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: rtl8723bs: remove unnecessary boolean comparison

Remove explicit comprassion to true in boolean expression to follow Linux kernel coding style.

---
 drivers/staging/rtl8723bs/core/rtw_ap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8723bs/core/rtw_ap.c +1 -1
index 477fe238add4..82f05dacf41c 100644
@@ -1157,7 +1157,7 @@ int rtw_acl_add_sta(struct adapter *padapter, u8 *addr)
 		paclnode = list_entry(plist, struct rtw_wlan_acl_node, list);
 
 		if (!memcmp(paclnode->addr, addr, ETH_ALEN)) {
-			if (paclnode->valid == true) {
+			if (paclnode->valid) {
 				added = true;
 				break;
 			}
Signature · 1 line
2.52.0
#1 lore raw
Quoted 2 lines · Nikolay Kulikov

Remove explicit comprassion to true in boolean expression to follow Linux kernel coding style.

You misspelt comparison as "comprassion".

Quoted 3 lines

---

Thanks,

ET

author
#2 lore raw

Thanks for the review!
I'll fix it and send v2.

Regards, Nikolay

пт, 6 февр. 2026 г. в 22:22, Ethan Tidmore <[email protected]>:

Quoted 14 lines · Nikolay Kulikov
Quoted 2 lines

Remove explicit comprassion to true in boolean expression to follow Linux kernel coding style.

You misspelt comparison as "comprassion".

Quoted 3 lines

---

Thanks,

ET

#3 lore raw

PATCH v2 1/1 staging: rtl8723bs: remove unnecessary boolean comparison

In reply to Nikolay Kulikov

Remove explicit comparison to true in boolean expression to follow Linux kernel coding style.

---

Changes in v2:
- Fixed typo in commit message

 drivers/staging/rtl8723bs/core/rtw_ap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8723bs/core/rtw_ap.c +1 -1
index 67197c7d4a4d..e23b86e66cb5 100644
@@ -1157,7 +1157,7 @@ int rtw_acl_add_sta(struct adapter *padapter, u8 *addr)
 		paclnode = list_entry(plist, struct rtw_wlan_acl_node, list);
 
 		if (!memcmp(paclnode->addr, addr, ETH_ALEN)) {
-			if (paclnode->valid == true) {
+			if (paclnode->valid) {
 				added = true;
 				break;
 			}
Signature · 1 line
2.53.0