Skip to contentSkip to conversation

l2test: Fix not being able to use -X ext-flowctl

PATCH Applied Luiz Augusto von Dentz 3 participants 3 messages Feb 6 Bluetooth drivers

lore
Share & tools
lore

Luiz Augusto von Dentz

author maintainer
#0 lore raw

PATCH 1/1 l2test: Fix not being able to use -X ext-flowctl

From: Luiz Augusto von Dentz <[email protected]>

-X ext-flowctl requires using setsockopt(BT_MODE, BT_MODE_EXT_FLOWCTL) but instead the code was attempting to use L2CAP_OPTIONS to read the current l2cap_options which is not support when the address type if not BDADDR_BREDR.

---
 tools/l2test.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/l2test.c +1 -1
index 5825314b9834..7eecf1364492 100644
@@ -289,7 +289,7 @@ static int getopts(int sk, struct l2cap_options *opts, bool connected)
 
 	memset(opts, 0, sizeof(*opts));
 
-	if (bdaddr_type == BDADDR_BREDR || rfcmode) {
+	if (bdaddr_type == BDADDR_BREDR) {
 		optlen = sizeof(*opts);
 		return getsockopt(sk, SOL_L2CAP, L2CAP_OPTIONS, opts, &optlen);
 	}
Signature · 1 line
2.52.0
#1 lore raw

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=1051705

---Test result---

Test Summary:

CheckPatch                    PENDING   0.40 seconds
GitLint                       PENDING   0.49 seconds
BuildEll                      PASS      17.67 seconds
BluezMake                     PASS      631.38 seconds
MakeCheck                     PASS      18.24 seconds
MakeDistcheck                 PASS      217.45 seconds
CheckValgrind                 PASS      278.03 seconds
CheckSmatch                   PASS      312.23 seconds
bluezmakeextell               PASS      166.72 seconds
IncrementalBuild              PENDING   0.43 seconds
ScanBuild                     PASS      925.76 seconds

Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:

##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:

##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series Output:

---
Regards,
Linux Bluetooth

#2 lore raw
In reply to Luiz Augusto von Dentz
This patch was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <[email protected]>:

Hello:

This patch was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <[email protected]>:

Quoted 8 lines · On Fri, 6 Feb 2026 14:03:45 -0500 you wrote:

From: Luiz Augusto von Dentz <[email protected]>

-X ext-flowctl requires using setsockopt(BT_MODE, BT_MODE_EXT_FLOWCTL) but instead the code was attempting to use L2CAP_OPTIONS to read the current l2cap_options which is not support when the address type if not BDADDR_BREDR.

[...]

Here is the summary with links:
- [BlueZ,v1] l2test: Fix not being able to use -X ext-flowctl

    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=6704b44cce88

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html