staging: greybus: gbphy: Replace sprintf() with sysfs_emit()
PATCH v3 1/1 staging: greybus: gbphy: Replace sprintf() with sysfs_emit()
Replace sprintf() with sysfs_emit() in the protocol_id_show() sysfs attribute function. This code is safe as-is, but replace sprintf() with sysfs_emit() because we are trying to get rid of calls to sprintf() as part of kernel hardening; sysfs_emit() is more appropriate in this context.
---
This was compile-tested only (no VM/hardware used)
Changes in v2:
- Subject: change to imperative "Replace" (was "Replaced").
- Wording and line breaks adjusted in the commit body for clarity.
Changes in v3:
- Clarify what "safe" means (buffer is PAGE_SIZE) per Dan Carpenter's suggestion.
- Reflow lines to avoid awkward breaks.
--- drivers/staging/greybus/gbphy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/greybus/gbphy.c +1 -1
@@ -31,7 +31,7 @@ static ssize_t protocol_id_show(struct device *dev, {struct gbphy_device *gbphy_dev =to_gbphy_dev (dev); -return sprintf (buf,"0x%02x\n" , gbphy_dev->cport_desc->protocol_id); +return sysfs_emit (buf,"0x%02x\n" , gbphy_dev->cport_desc->protocol_id); }static DEVICE_ATTR_RO (protocol_id);
base-commit: de0674d9bc69699c497477d45172493393ae9007
Signature · 1 line
2.44.0
Greg Kroah-Hartman
maintainerQuoted 27 lines · Neel Bullywon
Replace
sprintf()withsysfs_emit()in theprotocol_id_show()sysfs attribute function. This code is safe as-is, but replacesprintf()withsysfs_emit()because we are trying to get rid of calls tosprintf()as part of kernel hardening;sysfs_emit()is more appropriate in this context.Signed-off-by Neel Bullywon <[email protected]>---
This was compile-tested only (no VM/hardware used)Changes in v2:
- Subject: change to imperative "Replace" (was "Replaced").
- Wording and line breaks adjusted in the commit body for clarity.Changes in v3:
- Clarify what "safe" means (buffer isPAGE_SIZE) per Dan Carpenter's suggestion.
- Reflow lines to avoid awkward breaks.--- drivers/staging/greybus/gbphy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/staging/greybus/gbphy.c +0
-0
drivers/staging/greybus/gbphy.c static ssize_t protocol_id_show(struct device *dev, · line 34
Quoted 5 lines
drivers/staging/greybus/gbphy.c +1
-1@@ -31,7 +31,7 @@ static ssize_t protocol_id_show(struct device *dev, {struct gbphy_device *gbphy_dev =to_gbphy_dev (dev); -return sprintf (buf,"0x%02x\n" , gbphy_dev->cport_desc->protocol_id); +return sysfs_emit (buf,"0x%02x\n" , gbphy_dev->cport_desc->protocol_id);
For new sysfs files, using sysfs_emit() is fine, but for existing ones, using sprintf() is also ok, just leave them as-is please.
thanks,
greg k-h