Skip to contentSkip to conversation

staging: rtl8723bs: fix whitespace issues in hal_com.c

PATCH In review Ö. Efe D. 4 participants 7 messages Feb 2 – Feb 7 Staging

lore
Share & tools
lore

Ö. Efe D.

author
#0 lore raw

PATCH 1/1 staging: rtl8723bs: fix whitespace issues in hal_com.c

Remove spaces before tabs in comments to fix checkpatch warnings:
"please, no space before tabs"

---
 drivers/staging/rtl8723bs/hal/hal_com.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)
drivers/staging/rtl8723bs/hal/hal_com.c +8 -8
index 70b5b289f9cb..10c34228a595 100644
@@ -362,8 +362,8 @@ static void _TwoOutPipeMapping(struct adapter *padapter, bool bWIFICfg)
 
 	if (bWIFICfg) { /* WMM */
 
-		/* 	BK,	BE,	VI,	VO,	BCN,	CMD, MGT, HIGH, HCCA */
-		/*   0,		1,	0,	1,	0,	0,	0,	0,		0	}; */
+		/*	BK,	BE,	VI,	VO,	BCN,	CMD, MGT, HIGH, HCCA */
+		/*	0,	1,	0,	1,	0,	0,	0,	0,	0	}; */
 		/* 0:ep_0 num, 1:ep_1 num */
 
 		pdvobjpriv->Queue2Pipe[0] = pdvobjpriv->RtOutPipe[1];/* VO */
@@ -379,8 +379,8 @@ static void _TwoOutPipeMapping(struct adapter *padapter, bool bWIFICfg)
 	} else { /* typical setting */
 
 
-		/* BK,	BE,	VI,	VO,	BCN,	CMD, MGT, HIGH, HCCA */
-		/*   1,		1,	0,	0,	0,	0,	0,	0,		0	}; */
+		/*	BK,	BE,	VI,	VO,	BCN,	CMD, MGT, HIGH, HCCA */
+		/*	1,	1,	0,	0,	0,	0,	0,	0,	0	}; */
 		/* 0:ep_0 num, 1:ep_1 num */
 
 		pdvobjpriv->Queue2Pipe[0] = pdvobjpriv->RtOutPipe[0];/* VO */
@@ -403,8 +403,8 @@ static void _ThreeOutPipeMapping(struct adapter *padapter, bool bWIFICfg)
 
 	if (bWIFICfg) { /* for WMM */
 
-		/* 	BK,	BE,	VI,	VO,	BCN,	CMD, MGT, HIGH, HCCA */
-		/*   1,		2,	1,	0,	0,	0,	0,	0,		0	}; */
+		/*	BK,	BE,	VI,	VO,	BCN,	CMD, MGT, HIGH, HCCA */
+		/*	1,	2,	1,	0,	0,	0,	0,	0,	0	}; */
 		/* 0:H, 1:N, 2:L */
 
 		pdvobjpriv->Queue2Pipe[0] = pdvobjpriv->RtOutPipe[0];/* VO */
@@ -420,8 +420,8 @@ static void _ThreeOutPipeMapping(struct adapter *padapter, bool bWIFICfg)
 	} else { /* typical setting */
 
 
-		/* 	BK,	BE,	VI,	VO,	BCN,	CMD, MGT, HIGH, HCCA */
-		/*   2,		2,	1,	0,	0,	0,	0,	0,		0	}; */
+		/*	BK,	BE,	VI,	VO,	BCN,	CMD, MGT, HIGH, HCCA */
+		/*	2,	2,	1,	0,	0,	0,	0,	0,	0	}; */
 		/* 0:H, 1:N, 2:L */
 
 		pdvobjpriv->Queue2Pipe[0] = pdvobjpriv->RtOutPipe[0];/* VO */
Signature · 1 line
2.52.0
#1 lore raw

Hello Ömer,

I wanted to share a brief observation regarding the patch titled:

“Remove spaces before tabs in comments to fix checkpatch warnings”

Looking at the diff, the change is limited to whitespace alignment inside comments. There is no functional change, no meaningful impact on readability, and no effect on build or runtime behavior.

Given that scope, describing the change as a “fix” feels slightly misleading. From a reader’s point of view, this appears closer to a cosmetic or comment cleanup driven by checkpatch preferences rather than a fix addressing an actual issue.

This is not to say the change is invalid, but clearer framing would help set expectations when scanning patches on the list and later when looking at history or blame output.

Thanks for sharing the patch.

Quoted 59 lines

2026. 2. 2. 오전 5:19, Ö. Efe D. <[email protected]> 작성:

Remove spaces before tabs in comments to fix checkpatch warnings:
"please, no space before tabs"

---
drivers/staging/rtl8723bs/hal/hal_com.c | 16 ++++++++--------

1 file changed, 8 insertions(+), 8 deletions(-)
drivers/staging/rtl8723bs/hal/hal_com.c +8 -9
index 70b5b289f9cb..10c34228a595 100644
@@ -362,8 +362,8 @@ static void _TwoOutPipeMapping(struct adapter *padapter, bool bWIFICfg)
 
   if (bWIFICfg) { /* WMM */
 
-        /*    BK,    BE,    VI,    VO,    BCN,    CMD, MGT, HIGH, HCCA */
-        /*   0,        1,    0,    1,    0,    0,    0,    0,        0    }; */
+        /*    BK,    BE,    VI,    VO,    BCN,    CMD, MGT, HIGH, HCCA */
+        /*    0,    1,    0,    1,    0,    0,    0,    0,    0    }; */
       /* 0:ep_0 num, 1:ep_1 num */
 
       pdvobjpriv->Queue2Pipe[0] = pdvobjpriv->RtOutPipe[1];/* VO */
@@ -379,8 +379,8 @@ static void _TwoOutPipeMapping(struct adapter *padapter, bool bWIFICfg)
   } else { /* typical setting */
 
 
-        /* BK,    BE,    VI,    VO,    BCN,    CMD, MGT, HIGH, HCCA */
-        /*   1,        1,    0,    0,    0,    0,    0,    0,        0    }; */
+        /*    BK,    BE,    VI,    VO,    BCN,    CMD, MGT, HIGH, HCCA */
+        /*    1,    1,    0,    0,    0,    0,    0,    0,    0    }; */
       /* 0:ep_0 num, 1:ep_1 num */
 
       pdvobjpriv->Queue2Pipe[0] = pdvobjpriv->RtOutPipe[0];/* VO */
@@ -403,8 +403,8 @@ static void _ThreeOutPipeMapping(struct adapter *padapter, bool bWIFICfg)
 
   if (bWIFICfg) { /* for WMM */
 
-        /*    BK,    BE,    VI,    VO,    BCN,    CMD, MGT, HIGH, HCCA */
-        /*   1,        2,    1,    0,    0,    0,    0,    0,        0    }; */
+        /*    BK,    BE,    VI,    VO,    BCN,    CMD, MGT, HIGH, HCCA */
+        /*    1,    2,    1,    0,    0,    0,    0,    0,    0    }; */
       /* 0:H, 1:N, 2:L */
 
       pdvobjpriv->Queue2Pipe[0] = pdvobjpriv->RtOutPipe[0];/* VO */
@@ -420,8 +420,8 @@ static void _ThreeOutPipeMapping(struct adapter *padapter, bool bWIFICfg)
   } else { /* typical setting */
 
 
-        /*    BK,    BE,    VI,    VO,    BCN,    CMD, MGT, HIGH, HCCA */
-        /*   2,        2,    1,    0,    0,    0,    0,    0,        0    }; */
+        /*    BK,    BE,    VI,    VO,    BCN,    CMD, MGT, HIGH, HCCA */
+        /*    2,    2,    1,    0,    0,    0,    0,    0,    0    }; */
       /* 0:H, 1:N, 2:L */
 
       pdvobjpriv->Queue2Pipe[0] = pdvobjpriv->RtOutPipe[0];/* VO */
--
Quoted 3 lines

2.52.0

---
Best regards,
Mehmet Samet Duman
Author of Project Tick
https://projecttick.org
https://github.com/Project-Tick

#2 lore raw
Quoted 6 lines · M.samet Duman

Hello Ömer,

I wanted to share a brief observation regarding the patch titled:

“Remove spaces before tabs in comments to fix checkpatch warnings”

That's not the title. Why would you mention the title and then get it wrong? I'm so puzzled by this review. Is it AI generated? Please only use AI if there are bugs, don't use AI to comment on the commit message.

https://staticthinking.wordpress.com/2026/01/27/no-ai-slop/

Line wrap your emails at 72 characters?

regards,
dan carpenter

#3 lore raw
Quoted 8 lines · Dan Carpenter
Quoted 6 lines · M.samet Duman

Hello Ömer,

I wanted to share a brief observation regarding the patch titled:

“Remove spaces before tabs in comments to fix checkpatch warnings”

Quoted 6 lines

That's not the title. Why would you mention the title and then get it wrong? I'm so puzzled by this review. Is it AI generated? Please only use AI if there are bugs, don't use AI to comment on the commit message.

https://staticthinking.wordpress.com/2026/01/27/no-ai-slop/

Oh that's so good, mind if I add it to my bot responses for when it detects this type of thing?

thanks,

greg k-h

#4 lore raw
Quoted 14 lines · Greg Kroah-Hartman
Quoted 13 lines · Dan Carpenter
Quoted 6 lines · M.samet Duman

Hello Ömer,

I wanted to share a brief observation regarding the patch titled:

“Remove spaces before tabs in comments to fix checkpatch warnings”

That's not the title. Why would you mention the title and then get it wrong? I'm so puzzled by this review. Is it AI generated? Please only use AI if there are bugs, don't use AI to comment on the commit message.

Quoted 4 lines
Quoted 1 line

https://staticthinking.wordpress.com/2026/01/27/no-ai-slop/

Oh that's so good, mind if I add it to my bot responses for when it detects this type of thing?

Go ahead. Absolutely. :)

regards,
dan carpenter

#5 lore raw
In reply to Ö. Efe D.
Quoted 13 lines · Ö. Efe D.

Remove spaces before tabs in comments to fix checkpatch warnings:
"please, no space before tabs"

---
 drivers/staging/rtl8723bs/hal/hal_com.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)
drivers/staging/rtl8723bs/hal/hal_com.c +0 -0
index 70b5b289f9cb..10c34228a595 100644

drivers/staging/rtl8723bs/hal/hal_com.c static void _TwoOutPipeMapping(struct adapter *padapter, bool bWIFICfg) · line 366

Quoted 7 lines
drivers/staging/rtl8723bs/hal/hal_com.c +2 -2
@@ -362,8 +362,8 @@ static void _TwoOutPipeMapping(struct adapter *padapter, bool bWIFICfg)
 
 	if (bWIFICfg) { /* WMM */
 
-		/* 	BK,	BE,	VI,	VO,	BCN,	CMD, MGT, HIGH, HCCA */
-		/*   0,		1,	0,	1,	0,	0,	0,	0,		0	}; */
+		/*	BK,	BE,	VI,	VO,	BCN,	CMD, MGT, HIGH, HCCA */
+		/*	0,	1,	0,	1,	0,	0,	0,	0,	0	}; */

These things are supposed to be aligned so that the commas on the top line are the same as on the bottom line. It's a table. But it's messed up both before and after.

regards,
dan carpenter

#6 lore raw
In reply to Ö. Efe D.
Quoted 24 lines · Ö. Efe D.

Remove spaces before tabs in comments to fix checkpatch warnings:
"please, no space before tabs"

---
 drivers/staging/rtl8723bs/hal/hal_com.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)
drivers/staging/rtl8723bs/hal/hal_com.c +2 -2
index 70b5b289f9cb..10c34228a595 100644
@@ -362,8 +362,8 @@ static void _TwoOutPipeMapping(struct adapter *padapter, bool bWIFICfg)
 
 	if (bWIFICfg) { /* WMM */
 
-		/* 	BK,	BE,	VI,	VO,	BCN,	CMD, MGT, HIGH, HCCA */
-		/*   0,		1,	0,	1,	0,	0,	0,	0,		0	}; */
+		/*	BK,	BE,	VI,	VO,	BCN,	CMD, MGT, HIGH, HCCA */
+		/*	0,	1,	0,	1,	0,	0,	0,	0,	0	}; */
 		/* 0:ep_0 num, 1:ep_1 num */
 
 		pdvobjpriv->Queue2Pipe[0] = pdvobjpriv->RtOutPipe[1];/* VO */

drivers/staging/rtl8723bs/hal/hal_com.c static void _TwoOutPipeMapping(struct adapter *padapter, bool bWIFICfg) · line 383

Quoted 7 lines
drivers/staging/rtl8723bs/hal/hal_com.c +2 -2
@@ -379,8 +379,8 @@ static void _TwoOutPipeMapping(struct adapter *padapter, bool bWIFICfg)
 	} else { /* typical setting */
 
 
-		/* BK,	BE,	VI,	VO,	BCN,	CMD, MGT, HIGH, HCCA */
-		/*   1,		1,	0,	0,	0,	0,	0,	0,		0	}; */
+		/*	BK,	BE,	VI,	VO,	BCN,	CMD, MGT, HIGH, HCCA */
+		/*	1,	1,	0,	0,	0,	0,	0,	0,	0	}; */

As Dan said, this patch is correct in that it fixes the coding style issue, but now the table looks just as bad as before. How about fixing this up properly so that it both looks correct, AND fixes the coding style warning at the same time?

thanks,

greg k-h