Skip to contentSkip to conversation

tests/kms_plane: Refine clamping and modifier skips

PATCH Superseded Pranay Samala 2 participants 3 messages Feb 9 – Feb 10

v4 of 5 Superseded Latest is v5 →

lore
Share & tools
lore
#0 lore raw

v4 cover tests/kms_plane: Refine clamping and modifier skips

These changes avoid running source clamping tests on cursor planes and skip modifier subtests that are not supported on the target display platform.

Pranay Samala (2):
tests/kms_plane: Skip cursor plane for source clamping tests/kms_plane: Skip unsupported modifiers

 tests/kms_plane.c | 22 ++++++++++++++++------
 1 file changed, 16 insertions(+), 6 deletions(-)
Signature · 1 line
2.34.1
#1 lore raw

PATCH v4 1/2 tests/kms_plane: Skip cursor plane for source clamping

Avoid running source clamping tests on cursor plane, which do not support clamping.

v4: Add a short comment (Jeevan)

---
 tests/kms_plane.c | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)
tests/kms_plane.c +4 -6
index 2be10f032..22c45ae5e 100644
@@ -1090,12 +1090,6 @@ static void test_format_plane(data_t *data, enum pipe pipe,
 	bool result = true;
 	bool found = false;
 
-	/*
-	 * No clamping test for cursor plane
-	 */
-	if (data->crop != 0 && plane->type == DRM_PLANE_TYPE_CURSOR)
-		igt_skip("Clamping is invalid for the cursor plane.\n");
-
 	for (int i = 0; i < plane->format_mod_count; i++) {
 		if (data->mod == plane->modifiers[i]) {
 			found = true;
@@ -1288,6 +1282,10 @@ test_pixel_formats(data_t *data, enum pipe pipe)
 	for_each_plane_on_pipe(&data->display, pipe, plane) {
 		if (skip_plane(data, plane))
 			continue;
+		/* Cursor planes do not support cropping, skip generating subtest on cursor plane */
+		if (data->crop != 0 && plane->type == DRM_PLANE_TYPE_CURSOR)
+			continue;
+
 		igt_dynamic_f("pipe-%s-plane-%u", kmstest_pipe_name(pipe), plane->index)
 			test_format_plane(data, pipe, output, plane, &primary_fb);
 	}
Signature · 1 line
2.34.1
Reviewed-by on v4 1/2
#2 lore raw

RE: [PATCH i-g-t v4 1/2] tests/kms_plane: Skip cursor plane for source clamping

Quoted 14 lines

-----Original Message-----
From: igt-dev <[email protected]> On Behalf Of Pranay Samala
Sent: Monday, February 9, 2026 2:02 PM
To: [email protected]
Cc: B S, Karthik <[email protected]>; Joshi, Kunal1 <[email protected]>; Lattannavar, Sameer <[email protected]>; Samala, Pranay <[email protected]>
Subject: [PATCH i-g-t v4 1/2] tests/kms_plane: Skip cursor plane for source clamping

Quoted 4 lines

Avoid running source clamping tests on cursor plane, which do not support clamping.

v4: Add a short comment (Jeevan)

Please make this v2: no v4.
With this change Patch LGT.

Quoted 41 lines
---
 tests/kms_plane.c | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)
tests/kms_plane.c index renamed from tests/kms_plane.c +0 -0

2be10f032..22c45ae5e 100644

tests/kms_plane.c +0 -6
@@ -1090,12 +1090,6 @@ static void test_format_plane(data_t *data, enum
 pipe pipe,
 	bool result = true;
 	bool found = false;
 
-	/*
-	 * No clamping test for cursor plane
-	 */
-	if (data->crop != 0 && plane->type == DRM_PLANE_TYPE_CURSOR)
-		igt_skip("Clamping is invalid for the cursor plane.\n");
-
 	for (int i = 0; i < plane->format_mod_count; i++) {
 		if (data->mod == plane->modifiers[i]) {
tests/kms_plane.c +1 -0
 			found = true;
@@ -1288,6 +1282,10 @@ test_pixel_formats(data_t *data, enum pipe pipe)
 	for_each_plane_on_pipe(&data->display, pipe, plane) {
 		if (skip_plane(data, plane))
 			continue;
+		/* Cursor planes do not support cropping, skip generating

subtest on cursor plane */

tests/kms_plane.c +1 -0
+		if (data->crop != 0 && plane->type ==

DRM_PLANE_TYPE_CURSOR)

tests/kms_plane.c +2 -0
+			continue;
+
 		igt_dynamic_f("pipe-%s-plane-%u",

kmstest_pipe_name(pipe), plane->index)
test_format_plane(data, pipe, output, plane,
&primary_fb);
}
--
2.34.1