Skip to contentSkip to conversation

ufs: core: support UFSHCI 4.1 CQ entry tag

PATCH Applied [email protected] 4 participants 5 messages Feb 10 – Feb 28

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 ufs: core: support UFSHCI 4.1 CQ entry tag

From: Peter Wang <[email protected]>

The UFSHCI 4.1 specification introduces a new completion queue(CQ) entry format, allowing the tag to be obtained directly.

---
 drivers/ufs/core/ufs-mcq.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
drivers/ufs/core/ufs-mcq.c +6 -1
index ad0ada57959a..a4d0f8834314 100644
@@ -273,13 +273,18 @@ void ufshcd_mcq_write_cqis(struct ufs_hba *hba, u32 val, int i)
 EXPORT_SYMBOL_GPL(ufshcd_mcq_write_cqis);
 
 /*
- * Current MCQ specification doesn't provide a Task Tag or its equivalent in
+ * UFSHCI 4.0 MCQ specification doesn't provide a Task Tag or its equivalent in
  * the Completion Queue Entry. Find the Task Tag using an indirect method.
+ * UFSHCI 4.1 and above can directly return the Task Tag in the Completion Queue
+ * Entry.
  */
 static int ufshcd_mcq_get_tag(struct ufs_hba *hba, struct cq_entry *cqe)
 {
 	u64 addr;
 
+	if (hba->ufs_version >= ufshci_version(4, 1))
+		return cqe->task_tag;
+
 	/* sizeof(struct utp_transfer_cmd_desc) must be a multiple of 128 */
 	BUILD_BUG_ON(sizeof(struct utp_transfer_cmd_desc) & GENMASK(6, 0));
 
Signature · 1 line
2.45.2
#3 lore raw
In reply to [email protected]
Quoted 3 lines

The UFSHCI 4.1 specification introduces a new completion queue(CQ) entry format, allowing the tag to be obtained directly.

Applied to 7.1/scsi-staging, thanks!

Signature · 1 line
Martin K. Petersen