Skip to contentSkip to conversation

staging: rtl8723bs: remove explicit comparisons to false in rtw_ap.c

PATCH In review Haroen Tmimi 2 participants 3 messages Feb 10 Staging

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 staging: rtl8723bs: remove explicit comparisons to false in rtw_ap.c

Fix checkpatch.pl checks regarding error prone boolean comparisons. Replace explicit comparisons to false with the logical NOT operator to improve readability and match kernel coding style.

These instances were remaining after recent cleanups in this file.

---
Changes in v2:
Fixed syntax error: Moved NOT operator '!' to the correct position.

 drivers/staging/rtl8723bs/core/rtw_ap.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/rtl8723bs/core/rtw_ap.c +2 -2
index ebe73abab892..0192543cdec0 100644
@@ -1013,10 +1013,10 @@ int rtw_check_beacon_data(struct adapter *padapter, u8 *pbuf,  int len)
 
 		rtw_ht_use_default_setting(padapter);
 
-		if (pmlmepriv->htpriv.sgi_20m == false)
+		if (!pmlmepriv->htpriv.sgi_20m)
 			pht_cap->cap_info &= cpu_to_le16(~(IEEE80211_HT_CAP_SGI_20));
 
-		if (pmlmepriv->htpriv.sgi_40m == false)
+		if (!pmlmepriv->htpriv.sgi_40m)
 			pht_cap->cap_info &= cpu_to_le16(~(IEEE80211_HT_CAP_SGI_40));
 
 		if (!TEST_FLAG(pmlmepriv->htpriv.ldpc_cap, LDPC_HT_ENABLE_RX))
Signature · 1 line
2.53.0
Reviewed-by on v2 1/1
#1 lore raw
Quoted 7 lines · Haroen Tmimi

Fix checkpatch.pl checks regarding error prone boolean comparisons. Replace explicit comparisons to false with the logical NOT operator to improve readability and match kernel coding style.

These instances were remaining after recent cleanups in this file.

Please slow down, there is no rush here. Wait 24h between submitting revisions. This gives a chance for other people to review your code.

LGTM.

Thanks,

ET

#2 lore raw

I tend to work in a dedicated block of some hours, so my apologies for rushing. I will keep it in mind for next time.
Thanks for all the help.

Kind regards,

Haroen Tmimi

Op di 10 feb 2026 om 19:54 schreef Ethan Tidmore <[email protected]>:

Quoted 20 lines · Haroen Tmimi
Quoted 7 lines

Fix checkpatch.pl checks regarding error prone boolean comparisons. Replace explicit comparisons to false with the logical NOT operator to improve readability and match kernel coding style.

These instances were remaining after recent cleanups in this file.

Please slow down, there is no rush here. Wait 24h between submitting revisions. This gives a chance for other people to review your code.

LGTM.

Thanks,

ET