staging: rtl8723bs: remove NDIS_802_11_RATES typedef
PATCH 1/1 staging: rtl8723bs: remove NDIS_802_11_RATES typedef
The kernel coding style discourages typedefs, especially those that hide array types. Remove the NDIS_802_11_RATES typedef and replace its users with explicit unsigned char arrays.
No functional changes.
--- drivers/staging/rtl8723bs/include/wlan_bssdef.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8723bs/include/wlan_bssdef.h +1 -1
@@ -16,7 +16,7 @@#define NDIS_802_11_LENGTH_RATES_EX 16typedef unsigned char NDIS_802_11_MAC_ADDRESS [6 ]; -typedef unsigned char NDIS_802_11_RATES [NDIS_802_11_LENGTH_RATES ];/* Set of 8 data rates */ +unsigned char NDIS_802_11_RATES [NDIS_802_11_LENGTH_RATES ];/* Set of 8 data rates */ typedef unsigned char NDIS_802_11_RATES_EX [NDIS_802_11_LENGTH_RATES_EX ];/* Set of 16 data rates */ struct ndis_802_11_ssid {
Signature · 1 line
2.43.0
Quoted 8 lines · Ethan Luna
The kernel coding style discourages typedefs, especially those that hide array types. Remove the
NDIS_802_11_RATEStypedef and replace its users with explicit unsigned char arrays.No functional changes.
Signed-off-by Ethan Luna <[email protected]>---
You sent the exact same patch twice. As far as I can tell I don't see a difference between them? However, had this been a revision, please only send them every 24 hours.
Quoted 8 lines
drivers/staging/rtl8723bs/include/wlan_bssdef.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/staging/rtl8723bs/include/wlan_bssdef.h +0
-0
drivers/staging/rtl8723bs/include/wlan_bssdef.h line 22
Quoted 8 lines
drivers/staging/rtl8723bs/include/wlan_bssdef.h +1
-1@@ -16,7 +16,7 @@#define NDIS_802_11_LENGTH_RATES_EX 16typedef unsigned char NDIS_802_11_MAC_ADDRESS [6 ]; -typedef unsigned char NDIS_802_11_RATES [NDIS_802_11_LENGTH_RATES ];/* Set of 8 data rates */ +unsigned char NDIS_802_11_RATES [NDIS_802_11_LENGTH_RATES ];/* Set of 8 data rates */ typedef unsigned char NDIS_802_11_RATES_EX [NDIS_802_11_LENGTH_RATES_EX ];/* Set of 16 data rates */ struct ndis_802_11_ssid {
By removing the typedef you made this a global char array, just remove the line entirely. And actually replace the users of this typedef. Which you said you did in your patch notes?
Thanks,
ET
kernel test robot
build botkernel test robot noticed the following build errors:
Hi Ethan,
kernel test robot noticed the following build errors:
[auto build test ERROR on staging/staging-testing]
url: https://github.com/intel-lab-lkp/linux/commits/Ethan-Luna/staging-rtl8723bs-remove-NDIS_802_11_RATES-typedef/20260211-104321 base: staging/staging-testing patch link: https://lore.kernel.org/r/20260211024115.31339-1-trunixcodes%40zohomail.com patch subject: [PATCH] staging: rtl8723bs: remove NDIS_802_11_RATES typedef config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20260213/[email protected]/config) compiler: alpha-linux-gcc (GCC) 15.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260213/[email protected]/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
All errors (new ones prefixed by >>):
>> alpha-linux-ld: drivers/staging/rtl8723bs/core/rtw_btcoex.o:(.sbss+0x0): multiple definition of `NDIS_802_11_RATES'; drivers/staging/rtl8723bs/core/rtw_ap.o:(.sbss+0x2): first defined here
alpha-linux-ld: drivers/staging/rtl8723bs/core/rtw_cmd.o:(.sbss+0x8): multiple definition of `NDIS_802_11_RATES'; drivers/staging/rtl8723bs/core/rtw_ap.o:(.sbss+0x2): first defined here
alpha-linux-ld: drivers/staging/rtl8723bs/core/rtw_efuse.o:(.sbss+0xd): multiple definition of `NDIS_802_11_RATES'; drivers/staging/rtl8723bs/core/rtw_ap.o:(.sbss+0x2): first defined here
alpha-linux-ld: drivers/staging/rtl8723bs/core/rtw_io.o:(.sbss+0x0): multiple definition of `NDIS_802_11_RATES'; drivers/staging/rtl8723bs/core/rtw_ap.o:(.sbss+0x2): first defined here
alpha-linux-ld: drivers/staging/rtl8723bs/core/rtw_ioctl_set.o:(.sbss+0x0): multiple definition of `NDIS_802_11_RATES'; drivers/staging/rtl8723bs/core/rtw_ap.o:(.sbss+0x2): first defined here
alpha-linux-ld: drivers/staging/rtl8723bs/core/rtw_ieee80211.o:(.sbss+0x0): multiple definition of `NDIS_802_11_RATES'; drivers/staging/rtl8723bs/core/rtw_ap.o:(.sbss+0x2): first defined here
alpha-linux-ld: drivers/staging/rtl8723bs/core/rtw_mlme.o:(.sbss+0x3): multiple definition of `NDIS_802_11_RATES'; drivers/staging/rtl8723bs/core/rtw_ap.o:(.sbss+0x2): first defined here
alpha-linux-ld: drivers/staging/rtl8723bs/core/rtw_mlme_ext.o:(.sbss+0x7): multiple definition of `NDIS_802_11_RATES'; drivers/staging/rtl8723bs/core/rtw_ap.o:(.sbss+0x2): first defined here
alpha-linux-ld: drivers/staging/rtl8723bs/core/rtw_pwrctrl.o:(.sbss+0xc): multiple definition of `NDIS_802_11_RATES'; drivers/staging/rtl8723bs/core/rtw_ap.o:(.sbss+0x2): first defined here
alpha-linux-ld: drivers/staging/rtl8723bs/core/rtw_recv.o:(.sbss+0xe): multiple definition of `NDIS_802_11_RATES'; drivers/staging/rtl8723bs/core/rtw_ap.o:(.sbss+0x2): first defined here
alpha-linux-ld: drivers/staging/rtl8723bs/core/rtw_security.o:(.sbss+0x20): multiple definition of `NDIS_802_11_RATES'; drivers/staging/rtl8723bs/core/rtw_ap.o:(.sbss+0x2): first defined here
alpha-linux-ld: drivers/staging/rtl8723bs/core/rtw_sta_mgt.o:(.sbss+0x9): multiple definition of `NDIS_802_11_RATES'; drivers/staging/rtl8723bs/core/rtw_ap.o:(.sbss+0x2): first defined here
alpha-linux-ld: drivers/staging/rtl8723bs/core/rtw_wlan_util.o:(.sbss+0x0): multiple definition of `NDIS_802_11_RATES'; drivers/staging/rtl8723bs/core/rtw_ap.o:(.sbss+0x2): first defined here
alpha-linux-ld: drivers/staging/rtl8723bs/core/rtw_xmit.o:(.sbss+0x1a): multiple definition of `NDIS_802_11_RATES'; drivers/staging/rtl8723bs/core/rtw_ap.o:(.sbss+0x2): first defined here
alpha-linux-ld: drivers/staging/rtl8723bs/hal/hal_intf.o:(.sbss+0x0): multiple definition of `NDIS_802_11_RATES'; drivers/staging/rtl8723bs/core/rtw_ap.o:(.sbss+0x2): first defined here
alpha-linux-ld: drivers/staging/rtl8723bs/hal/hal_com.o:(.sbss+0x0): multiple definition of `NDIS_802_11_RATES'; drivers/staging/rtl8723bs/core/rtw_ap.o:(.sbss+0x2): first defined here
alpha-linux-ld: drivers/staging/rtl8723bs/hal/hal_com_phycfg.o:(.sbss+0x0): multiple definition of `NDIS_802_11_RATES'; drivers/staging/rtl8723bs/core/rtw_ap.o:(.sbss+0x2): first defined here
alpha-linux-ld: drivers/staging/rtl8723bs/hal/hal_btcoex.o:(.sbss+0x3): multiple definition of `NDIS_802_11_RATES'; drivers/staging/rtl8723bs/core/rtw_ap.o:(.sbss+0x2): first defined here
alpha-linux-ld: drivers/staging/rtl8723bs/hal/hal_sdio.o:(.sbss+0x0): multiple definition of `NDIS_802_11_RATES'; drivers/staging/rtl8723bs/core/rtw_ap.o:(.sbss+0x2): first defined here
alpha-linux-ld: drivers/staging/rtl8723bs/hal/hal_pwr_seq.o:(.sbss+0x0): multiple definition of `NDIS_802_11_RATES'; drivers/staging/rtl8723bs/core/rtw_ap.o:(.sbss+0x2): first defined here
alpha-linux-ld: drivers/staging/rtl8723bs/hal/HalPhyRf.o:(.sbss+0x0): multiple definition of `NDIS_802_11_RATES'; drivers/staging/rtl8723bs/core/rtw_ap.o:(.sbss+0x2): first defined here
alpha-linux-ld: drivers/staging/rtl8723bs/hal/HalPwrSeqCmd.o:(.sbss+0x0): multiple definition of `NDIS_802_11_RATES'; drivers/staging/rtl8723bs/core/rtw_ap.o:(.sbss+0x2): first defined here
alpha-linux-ld: drivers/staging/rtl8723bs/hal/odm.o:(.sbss+0x0): multiple definition of `NDIS_802_11_RATES'; drivers/staging/rtl8723bs/core/rtw_ap.o:(.sbss+0x2): first defined here
alpha-linux-ld: drivers/staging/rtl8723bs/hal/odm_CfoTracking.o:(.sbss+0x0): multiple definition of `NDIS_802_11_RATES'; drivers/staging/rtl8723bs/core/rtw_ap.o:(.sbss+0x2): first defined here
alpha-linux-ld: drivers/staging/rtl8723bs/hal/odm_DIG.o:(.sbss+0x0): multiple definition of `NDIS_802_11_RATES'; drivers/staging/rtl8723bs/core/rtw_ap.o:(.sbss+0x2): first defined here
alpha-linux-ld: drivers/staging/rtl8723bs/hal/odm_DynamicBBPowerSaving.o:(.sbss+0x0): multiple definition of `NDIS_802_11_RATES'; drivers/staging/rtl8723bs/core/rtw_ap.o:(.sbss+0x2): first defined here
alpha-linux-ld: drivers/staging/rtl8723bs/hal/odm_DynamicTxPower.o:(.sbss+0x0): multiple definition of `NDIS_802_11_RATES'; drivers/staging/rtl8723bs/core/rtw_ap.o:(.sbss+0x2): first defined here
alpha-linux-ld: drivers/staging/rtl8723bs/hal/odm_EdcaTurboCheck.o:(.sbss+0x0): multiple definition of `NDIS_802_11_RATES'; drivers/staging/rtl8723bs/core/rtw_ap.o:(.sbss+0x2): first defined here
alpha-linux-ld: drivers/staging/rtl8723bs/hal/odm_HWConfig.o:(.sbss+0x0): multiple definition of `NDIS_802_11_RATES'; drivers/staging/rtl8723bs/core/rtw_ap.o:(.sbss+0x2): first defined here
alpha-linux-ld: drivers/staging/rtl8723bs/hal/odm_RegConfig8723B.o:(.sbss+0x0): multiple definition of `NDIS_802_11_RATES'; drivers/staging/rtl8723bs/core/rtw_ap.o:(.sbss+0x2): first defined here
alpha-linux-ld: drivers/staging/rtl8723bs/hal/rtl8723b_cmd.o:(.sbss+0x0): multiple definition of `NDIS_802_11_RATES'; drivers/staging/rtl8723bs/core/rtw_ap.o:(.sbss+0x2): first defined here
alpha-linux-ld: drivers/staging/rtl8723bs/hal/rtl8723b_dm.o:(.sbss+0x0): multiple definition of `NDIS_802_11_RATES'; drivers/staging/rtl8723bs/core/rtw_ap.o:(.sbss+0x2): first defined here
alpha-linux-ld: drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.o:(.sbss+0x2): multiple definition of `NDIS_802_11_RATES'; drivers/staging/rtl8723bs/core/rtw_ap.o:(.sbss+0x2): first defined here
alpha-linux-ld: drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.o:(.sbss+0x0): multiple definition of `NDIS_802_11_RATES'; drivers/staging/rtl8723bs/core/rtw_ap.o:(.sbss+0x2): first defined here
alpha-linux-ld: drivers/staging/rtl8723bs/hal/rtl8723b_rf6052.o:(.sbss+0x0): multiple definition of `NDIS_802_11_RATES'; drivers/staging/rtl8723bs/core/rtw_ap.o:(.sbss+0x2): first defined here
alpha-linux-ld: drivers/staging/rtl8723bs/hal/rtl8723b_rxdesc.o:(.sbss+0x0): multiple definition of `NDIS_802_11_RATES'; drivers/staging/rtl8723bs/core/rtw_ap.o:(.sbss+0x2): first defined here
alpha-linux-ld: drivers/staging/rtl8723bs/hal/rtl8723bs_recv.o:(.sbss+0x3): multiple definition of `NDIS_802_11_RATES'; drivers/staging/rtl8723bs/core/rtw_ap.o:(.sbss+0x2): first defined here
alpha-linux-ld: drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.o:(.sbss+0x2): multiple definition of `NDIS_802_11_RATES'; drivers/staging/rtl8723bs/core/rtw_ap.o:(.sbss+0x2): first defined here
alpha-linux-ld: drivers/staging/rtl8723bs/hal/sdio_halinit.o:(.sbss+0x0): multiple definition of `NDIS_802_11_RATES'; drivers/staging/rtl8723bs/core/rtw_ap.o:(.sbss+0x2): first defined here
alpha-linux-ld: drivers/staging/rtl8723bs/hal/sdio_ops.o:(.sbss+0x0): multiple definition of `NDIS_802_11_RATES'; drivers/staging/rtl8723bs/core/rtw_ap.o:(.sbss+0x2): first defined here
alpha-linux-ld: drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.o:(.sbss+0x1c): multiple definition of `NDIS_802_11_RATES'; drivers/staging/rtl8723bs/core/rtw_ap.o:(.sbss+0x2): first defined here
alpha-linux-ld: drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.o:(.sbss+0x18): multiple definition of `NDIS_802_11_RATES'; drivers/staging/rtl8723bs/core/rtw_ap.o:(.sbss+0x2): first defined here
alpha-linux-ld: drivers/staging/rtl8723bs/hal/HalHWImg8723B_BB.o:(.sbss+0x0): multiple definition of `NDIS_802_11_RATES'; drivers/staging/rtl8723bs/core/rtw_ap.o:(.sbss+0x2): first defined here
alpha-linux-ld: drivers/staging/rtl8723bs/hal/HalHWImg8723B_MAC.o:(.sbss+0x0): multiple definition of `NDIS_802_11_RATES'; drivers/staging/rtl8723bs/core/rtw_ap.o:(.sbss+0x2): first defined here
alpha-linux-ld: drivers/staging/rtl8723bs/hal/HalHWImg8723B_RF.o:(.sbss+0x0): multiple definition of `NDIS_802_11_RATES'; drivers/staging/rtl8723bs/core/rtw_ap.o:(.sbss+0x2): first defined here
alpha-linux-ld: drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.o:(.sbss+0x0): multiple definition of `NDIS_802_11_RATES'; drivers/staging/rtl8723bs/core/rtw_ap.o:(.sbss+0x2): first defined here
alpha-linux-ld: drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.o:(.sbss+0x9): multiple definition of `NDIS_802_11_RATES'; drivers/staging/rtl8723bs/core/rtw_ap.o:(.sbss+0x2): first defined here
alpha-linux-ld: drivers/staging/rtl8723bs/os_dep/osdep_service.o:(.sbss+0x0): multiple definition of `NDIS_802_11_RATES'; drivers/staging/rtl8723bs/core/rtw_ap.o:(.sbss+0x2): first defined here
alpha-linux-ld: drivers/staging/rtl8723bs/os_dep/os_intfs.o:(.sbss+0x44): multiple definition of `NDIS_802_11_RATES'; drivers/staging/rtl8723bs/core/rtw_ap.o:(.sbss+0x2): first defined here
alpha-linux-ld: drivers/staging/rtl8723bs/os_dep/sdio_intf.o:(.sbss+0x0): multiple definition of `NDIS_802_11_RATES'; drivers/staging/rtl8723bs/core/rtw_ap.o:(.sbss+0x2): first defined here
alpha-linux-ld: drivers/staging/rtl8723bs/os_dep/sdio_ops_linux.o:(.sbss+0x0): multiple definition of `NDIS_802_11_RATES'; drivers/staging/rtl8723bs/core/rtw_ap.o:(.sbss+0x2): first defined here
alpha-linux-ld: drivers/staging/rtl8723bs/os_dep/wifi_regd.o:(.sbss+0x0): multiple definition of `NDIS_802_11_RATES'; drivers/staging/rtl8723bs/core/rtw_ap.o:(.sbss+0x2): first defined here
alpha-linux-ld: drivers/staging/rtl8723bs/os_dep/xmit_linux.o:(.sbss+0x0): multiple definition of `NDIS_802_11_RATES'; drivers/staging/rtl8723bs/core/rtw_ap.o:(.sbss+0x2): first defined here
Signature · 2 lines
0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki