Skip to contentSkip to conversation

dt-bindings: mmc: dwcmshc-sdhci: Fix resets array validation

PATCH Superseded [email protected] 2 participants 2 messages Feb 14

Subsystems (2)
Device tree bindings MMC, SD and SDIO

v2 of 4 Superseded Latest is v4 →

lore
Share & tools
lore

[email protected]

author
#0 lore raw

PATCH v2 1/1 dt-bindings: mmc: dwcmshc-sdhci: Fix resets array validation

From: Huan He <[email protected]>

The binding defines tuple-style reset-names items for some compatibles, which implicitly enforces a fixed array length via JSON Schema.

Defining global maxItems for resets and reset-names causes these constraints to be intersected via allOf, resulting in an effective minItems equal to the global maxItems. This leads to dtbs_check failures reporting reset arrays as too short, even when the DTS provides the correct number of entries.

Fixes 30009a21f257 ("dt-bindings: mmc: sdhci-of-dwcmshc: Add Eswin EIC7700")
Signed-off-by Pritesh Patel <[email protected]>
Signed-off-by Huan He <[email protected]>

---
Changes in v2:
- Keep the global maxItems constraints and add minItems: 4 for both resets and reset-names properties
- Update commit message

- Link to v1: https://lore.kernel.org/all/[email protected]/

---
 Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml | 2 ++
 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml +2 -0
index 7e7c55dc2440..f268f3b6f153 100644
@@ -50,9 +50,11 @@ properties:
     maxItems: 1
 
   resets:
+    minItems: 4
     maxItems: 5
 
   reset-names:
+    minItems: 4
     maxItems: 5
 
   rockchip,txclk-tapnum:
Signature · 1 line
2.25.1
#1 lore raw
Quoted 32 lines · On Sat, Feb 14, 2026 at 02:34:50PM +0800, [email protected] wrote:

From: Huan He <[email protected]>

The binding defines tuple-style reset-names items for some compatibles, which implicitly enforces a fixed array length via JSON Schema.

Defining global maxItems for resets and reset-names causes these constraints to be intersected via allOf, resulting in an effective minItems equal to the global maxItems. This leads to dtbs_check failures reporting reset arrays as too short, even when the DTS provides the correct number of entries.

Fixes 30009a21f257 ("dt-bindings: mmc: sdhci-of-dwcmshc: Add Eswin EIC7700")
Signed-off-by Pritesh Patel <[email protected]>
Signed-off-by Huan He <[email protected]>

---
Changes in v2:
- Keep the global maxItems constraints and add minItems: 4 for both resets and reset-names properties
- Update commit message

- Link to v1: https://lore.kernel.org/all/[email protected]/

---
 Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml | 2 ++
 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml +0 -0
index 7e7c55dc2440..f268f3b6f153 100644

Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml properties: · line 58

Quoted 9 lines
Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml +2 -0
@@ -50,9 +50,11 @@ properties:
     maxItems: 1
 
   resets:
+    minItems: 4
     maxItems: 5
 
   reset-names:
+    minItems: 4
     maxItems: 5

You miss to update now minItems: 5 in one of the "if:" cases. Otherwise please explain why that device(s) should have now 4 or 5 resets.

Best regards,
Krzysztof