wifi: iwlwifi: Clean dangling pointer in tx path
PATCH 1/1 wifi: iwlwifi: Clean dangling pointer in tx path
From: Ben Greear <[email protected]>
If iwl_txq_gen2_build_tfd fails, we return -1, which will cause calling code to dispose of the skb one way or another. Remove any reference to that skb from the txq entries so that nothing will try to access it later.
Signed-off-by Ben Greear <[email protected]>
--- drivers/net/wireless/intel/iwlwifi/pcie/gen1_2/tx-gen2.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/net/wireless/intel/iwlwifi/pcie/gen1_2/tx-gen2.c +2 -0
@@ -773,6 +773,8 @@ int iwl_txq_gen2_tx(struct iwl_trans *trans, struct sk_buff *skb, tfd =iwl_txq_gen2_build_tfd (trans, txq, dev_cmd, skb, out_meta);if (!tfd) { + txq->entries[idx].skb =NULL ; + txq->entries[idx].cmd =NULL ;spin_unlock (&txq->lock);return -1 ; }
Signature · 1 line
2.47.0