nilfs2: fix i_xattr comment to note it is unused
PATCH RESEND 1/1 nilfs2: fix i_xattr comment to note it is unused
NILFS2 does not currently support extended attributes. Update the comment for @i_xattr in struct nilfs_inode_info to clarify that it is reserved but unused.
--- fs/nilfs2/nilfs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/nilfs2/nilfs.h +1 -1
@@ -27,7 +27,7 @@* @i_state: dynamic state flags * @i_bmap: pointer on i_bmap_data * @i_bmap_data: raw block mapping -* @i_xattr: <TODO> +* @i_xattr: reserved for xattr object (unused) * @i_dir_start_lookup: page index of last successful search * @i_cno: checkpoint number for GC inode * @i_assoc_inode: associated inode (B-tree node cache holder or back pointer)
Signature · 8 lines
2.50.1 Amazon Web Services EMEA SARL, 38 avenue John F. Kennedy, L-1855 Luxembourg, R.C.S. Luxembourg B186284 Amazon Web Services EMEA SARL, Irish Branch, One Burlington Plaza, Burlington Road, Dublin 4, Ireland, branch registration number 908705
Quoted 9 lines · Yuto Ohnuki
NILFS2 does not currently support extended attributes. Update the comment for @i_xattr in struct
nilfs_inode_infoto clarify that it is reserved but unused.Signed-off-by Yuto Ohnuki <[email protected]>--- fs/nilfs2/nilfs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Thank you.
Viacheslav, could you please pick this up directly and queue it for the next cycle (with the following Acked-by tag)?
There's been discussion about removing the on-disk inode xattr field to implement atime, so if it's no longer needed for that reason, you can drop it.
However, since this is an on-memory inode field, I think it's okay to leave the field itself in place until its handling is decided.
Regards,
Ryusuke Konishi
Quoted 25 lines
fs/nilfs2/nilfs.h +1
-2@@ -27,7 +27,7 @@* @i_state: dynamic state flags * @i_bmap: pointer on i_bmap_data * @i_bmap_data: raw block mapping -* @i_xattr: <TODO> +* @i_xattr: reserved for xattr object (unused) * @i_dir_start_lookup: page index of last successful search * @i_cno: checkpoint number for GC inode * @i_assoc_inode: associated inode (B-tree node cache holder or back pointer) -- 2.50.1
Amazon Web Services EMEA SARL, 38 avenue John F. Kennedy, L-1855 Luxembourg,
R.C.S. Luxembourg B186284Amazon Web Services EMEA SARL, Irish Branch, One Burlington Plaza, Burlington Road, Dublin 4, Ireland, branch registration number 908705