Skip to contentSkip to conversation

RDMA/uverbs: select CONFIG_DMA_SHARED_BUFFER

PATCH Applied Arnd Bergmann 2 participants 3 messages Feb 16 – Feb 23 InfiniBand

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 RDMA/uverbs: select CONFIG_DMA_SHARED_BUFFER

From: Arnd Bergmann <[email protected]>

The addition of dmabuf support in uverbs means that it is no longer possible to build infiniband support if that is disabled:

arm-linux-gnueabi-ld: drivers/infiniband/core/ib_core_uverbs.o: in function `rdma_user_mmap_entry_remove.part.0':
ib_core_uverbs.c:(.text+0x508): undefined reference to dma_buf_move_notify' (dma_buf_move_notify): Unknown destination type (ARM/Thumb) in drivers/infiniband/core/ib_core_uverbs.o ib_core_uverbs.c:(.text+0x518): undefined reference to dma_resv_wait_timeout' (dma_resv_wait_timeout): Unknown destination type (ARM/Thumb) in drivers/infiniband/core/ib_core_uverbs.o

Select this from Kconfig, as we do for the other users.

Fixes 0ac6f4056c4a ("RDMA/uverbs: Add DMABUF object type and operations")
---
 drivers/infiniband/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/infiniband/Kconfig +1 -0
index 794b9778816b..78ac2ff5befd 100644
@@ -6,6 +6,7 @@ menuconfig INFINIBAND
 	depends on INET
 	depends on m || IPV6 != m
 	depends on !ALPHA
+	select DMA_SHARED_BUFFER
 	select IRQ_POLL
 	select DIMLIB
 	help
Signature · 1 line
2.39.5
Reviewed-by on v1 1/1
#1 lore raw
Quoted 11 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

The addition of dmabuf support in uverbs means that it is no longer possible to build infiniband support if that is disabled:

arm-linux-gnueabi-ld: drivers/infiniband/core/ib_core_uverbs.o: in function `rdma_user_mmap_entry_remove.part.0':
ib_core_uverbs.c:(.text+0x508): undefined reference to dma_buf_move_notify' (dma_buf_move_notify): Unknown destination type (ARM/Thumb) in drivers/infiniband/core/ib_core_uverbs.o ib_core_uverbs.c:(.text+0x518): undefined reference to dma_resv_wait_timeout' (dma_resv_wait_timeout): Unknown destination type (ARM/Thumb) in drivers/infiniband/core/ib_core_uverbs.o

Quoted 8 lines

Select this from Kconfig, as we do for the other users.

Fixes 0ac6f4056c4a ("RDMA/uverbs: Add DMABUF object type and operations")
---
 drivers/infiniband/Kconfig | 1 +
 1 file changed, 1 insertion(+)

It looks reasonable to me. dma-buf is becoming a first‑class citizen in the RDMA world.

Thanks,

#2 lore raw
In reply to Arnd Bergmann
Quoted 10 lines · Arnd Bergmann

The addition of dmabuf support in uverbs means that it is no longer possible to build infiniband support if that is disabled:

arm-linux-gnueabi-ld: drivers/infiniband/core/ib_core_uverbs.o: in function `rdma_user_mmap_entry_remove.part.0':
ib_core_uverbs.c:(.text+0x508): undefined reference to dma_buf_move_notify' (dma_buf_move_notify): Unknown destination type (ARM/Thumb) in drivers/infiniband/core/ib_core_uverbs.o ib_core_uverbs.c:(.text+0x518): undefined reference to dma_resv_wait_timeout' (dma_resv_wait_timeout): Unknown destination type (ARM/Thumb) in drivers/infiniband/core/ib_core_uverbs.o

[...]

Applied, thanks!

[1/1] RDMA/uverbs: select CONFIG_DMA_SHARED_BUFFER

      https://git.kernel.org/rdma/rdma/c/16cb1a64dce567

Best regards,

Signature · 1 line
Leon Romanovsky <[email protected]>