Skip to contentSkip to conversation

hwmon (bt1-pvt) Remove not-going-to-be-supported code for Baikal SoC

PATCH In review Andy Shevchenko 2 participants 3 messages Feb 20 – Feb 23

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 hwmon (bt1-pvt) Remove not-going-to-be-supported code for Baikal SoC

As noticed in the discussion [1] the Baikal SoC and platforms are not going to be finalized, hence remove stale code.

---
 .../bindings/hwmon/baikal,bt1-pvt.yaml        |  105 --
 Documentation/hwmon/bt1-pvt.rst               |  117 --
 Documentation/hwmon/index.rst                 |    1 -
 drivers/hwmon/Kconfig                         |   26 -
 drivers/hwmon/Makefile                        |    1 -
 drivers/hwmon/bt1-pvt.c                       | 1171 -----------------
 drivers/hwmon/bt1-pvt.h                       |  247 ----
 7 files changed, 1668 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/hwmon/baikal,bt1-pvt.yaml
 delete mode 100644 Documentation/hwmon/bt1-pvt.rst
 delete mode 100644 drivers/hwmon/bt1-pvt.c
 delete mode 100644 drivers/hwmon/bt1-pvt.h
Documentation/devicetree/bindings/hwmon/baikal,bt1-pvt.yaml deleted +0 -105
deleted file mode 100644
index 5d3ce641fcde..000000000000
@@ -1,105 +0,0 @@
-# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
-# Copyright (C) 2020 BAIKAL ELECTRONICS, JSC
-%YAML 1.2
----
-$id: http://devicetree.org/schemas/hwmon/baikal,bt1-pvt.yaml#
-$schema: http://devicetree.org/meta-schemas/core.yaml#
-
-title: Baikal-T1 PVT Sensor
-
-maintainers:
-  - Serge Semin <[email protected]>
-
-description: |
-  Baikal-T1 SoC provides an embedded process, voltage and temperature
-  sensor to monitor an internal SoC environment (chip temperature, supply
-  voltage and process monitor) and on time detect critical situations,
-  which may cause the system instability and even damages. The IP-block
-  is based on the Analog Bits PVT sensor, but is equipped with a dedicated
-  control wrapper, which provides a MMIO registers-based access to the
-  sensor core functionality (APB3-bus based) and exposes an additional
-  functions like thresholds/data ready interrupts, its status and masks,
-  measurements timeout. Its internal structure is depicted on the next
-  diagram:
-
-     Analog Bits core                     Bakal-T1 PVT control block
-  +--------------------+                  +------------------------+
-  | Temperature sensor |-+         +------| Sensors control        |
-  |--------------------| |<---En---|      |------------------------|
-  | Voltage sensor     |-|<--Mode--| +--->| Sampled data           |
-  |--------------------| |<--Trim--+ |    |------------------------|
-  | Low-Vt sensor      |-|           | +--| Thresholds comparator  |
-  |--------------------| |---Data----| |  |------------------------|
-  | High-Vt sensor     |-|           | +->| Interrupts status      |
-  |--------------------| |--Valid--+-+ |  |------------------------|
-  | Standard-Vt sensor |-+         +---+--| Interrupts mask        |
-  +--------------------+                  |------------------------|
-           ^                              | Interrupts timeout     |
-           |                              +------------------------+
-           |                                        ^  ^
-  Rclk-----+----------------------------------------+  |
-  APB3-------------------------------------------------+
-
-  This bindings describes the external Baikal-T1 PVT control interfaces
-  like MMIO registers space, interrupt request number and clocks source.
-  These are then used by the corresponding hwmon device driver to
-  implement the sysfs files-based access to the sensors functionality.
-
-properties:
-  compatible:
-    const: baikal,bt1-pvt
-
-  reg:
-    maxItems: 1
-
-  interrupts:
-    maxItems: 1
-
-  clocks:
-    items:
-      - description: PVT reference clock
-      - description: APB3 interface clock
-
-  clock-names:
-    items:
-      - const: ref
-      - const: pclk
-
-  "#thermal-sensor-cells":
-    description: Baikal-T1 can be referenced as the CPU thermal-sensor
-    const: 0
-
-  baikal,pvt-temp-offset-millicelsius:
-    description: |
-      Temperature sensor trimming factor. It can be used to manually adjust the
-      temperature measurements within 7.130 degrees Celsius.
-    default: 0
-    minimum: 0
-    maximum: 7130
-
-additionalProperties: false
-
-required:
-  - compatible
-  - reg
-  - interrupts
-  - clocks
-  - clock-names
-
-examples:
-  - |
-    #include <dt-bindings/interrupt-controller/mips-gic.h>
-
-    pvt@1f200000 {
-      compatible = "baikal,bt1-pvt";
-      reg = <0x1f200000 0x1000>;
-      #thermal-sensor-cells = <0>;
-
-      interrupts = <GIC_SHARED 31 IRQ_TYPE_LEVEL_HIGH>;
-
-      baikal,pvt-temp-offset-millicelsius = <1000>;
-
-      clocks = <&ccu_sys>, <&ccu_sys>;
-      clock-names = "ref", "pclk";
-    };
-...
Documentation/hwmon/bt1-pvt.rst deleted +0 -117

117 lines not on this page · raw message

Documentation/hwmon/index.rst +0 -1
index d91dbb20c7dc..d860de4a0b75 100644
@@ -52,7 +52,6 @@ Hardware Monitoring Kernel Drivers
    bcm54140
    bel-pfe
    bpa-rs600
-   bt1-pvt
    cgbc-hwmon
    chipcap2
    coretemp
drivers/hwmon/Kconfig +0 -26
index 41c381764c2b..03d393ff5955 100644
@@ -457,32 +457,6 @@ config SENSORS_ATXP1
 	  This driver can also be built as a module. If so, the module
 	  will be called atxp1.
 
-config SENSORS_BT1_PVT
-	tristate "Baikal-T1 Process, Voltage, Temperature sensor driver"
-	depends on MIPS_BAIKAL_T1 || COMPILE_TEST
-	select POLYNOMIAL
-	help
-	  If you say yes here you get support for Baikal-T1 PVT sensor
-	  embedded into the SoC.
-
-	  This driver can also be built as a module. If so, the module will be
-	  called bt1-pvt.
-
-config SENSORS_BT1_PVT_ALARMS
-	bool "Enable Baikal-T1 PVT sensor alarms"
-	depends on SENSORS_BT1_PVT
-	help
-	  Baikal-T1 PVT IP-block provides threshold registers for each
-	  supported sensor. But the corresponding interrupts might be
-	  generated by the thresholds comparator only in synchronization with
-	  a data conversion. Additionally there is only one sensor data can
-	  be converted at a time. All of these makes the interface impossible
-	  to be used for the hwmon alarms implementation without periodic
-	  switch between the PVT sensors. By default the data conversion is
-	  performed on demand from the user-space. If this config is enabled
-	  the data conversion will be periodically performed and the data will be
-	  saved in the internal driver cache.
-
 config SENSORS_CGBC
 	tristate "Congatec Board Controller Sensors"
 	depends on MFD_CGBC
drivers/hwmon/Makefile +0 -1
index eade8e3b1bde..9d3659123ad5 100644
@@ -58,7 +58,6 @@ obj-$(CONFIG_SENSORS_ASPEED_G6) += aspeed-g6-pwm-tach.o
 obj-$(CONFIG_SENSORS_ASUS_ROG_RYUJIN)	+= asus_rog_ryujin.o
 obj-$(CONFIG_SENSORS_ATXP1)	+= atxp1.o
 obj-$(CONFIG_SENSORS_AXI_FAN_CONTROL) += axi-fan-control.o
-obj-$(CONFIG_SENSORS_BT1_PVT)	+= bt1-pvt.o
 obj-$(CONFIG_SENSORS_CGBC)	+= cgbc-hwmon.o
 obj-$(CONFIG_SENSORS_CHIPCAP2) += chipcap2.o
 obj-$(CONFIG_SENSORS_CORETEMP)	+= coretemp.o
drivers/hwmon/bt1-pvt.c deleted +0 -1171

1,171 lines not on this page · raw message

drivers/hwmon/bt1-pvt.h deleted +0 -247

247 lines not on this page · raw message

Signature · 1 line
2.50.1
#1 lore raw
Quoted 2 lines · Andy Shevchenko

As noticed in the discussion [1] the Baikal SoC and platforms are not going to be finalized, hence remove stale code.

It seems the same message was sent twice. There are no differences at all between them.

Please, use the first one
https://lore.kernel.org/r/[email protected]

Signature · 2 lines
With Best Regards,
Andy Shevchenko
maintainer Acked-by on v1 1/1
#2 lore raw
In reply to Andy Shevchenko
Quoted 5 lines · Andy Shevchenko

As noticed in the discussion [1] the Baikal SoC and platforms are not going to be finalized, hence remove stale code.

Quoted 14 lines
---
 .../bindings/hwmon/baikal,bt1-pvt.yaml        |  105 --
 Documentation/hwmon/bt1-pvt.rst               |  117 --
 Documentation/hwmon/index.rst                 |    1 -
 drivers/hwmon/Kconfig                         |   26 -
 drivers/hwmon/Makefile                        |    1 -
 drivers/hwmon/bt1-pvt.c                       | 1171 -----------------
 drivers/hwmon/bt1-pvt.h                       |  247 ----
 7 files changed, 1668 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/hwmon/baikal,bt1-pvt.yaml
 delete mode 100644 Documentation/hwmon/bt1-pvt.rst
 delete mode 100644 drivers/hwmon/bt1-pvt.c
 delete mode 100644 drivers/hwmon/bt1-pvt.h