Crypto : Fix Null deref in scatterwalk_pagedone
Subsystems (2)
PATCH 1/1 Crypto : Fix Null deref in scatterwalk_pagedone
sg_next can return NULL which causes NULL deref in scatterwalk_start
--- include/crypto/scatterwalk.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
include/crypto/scatterwalk.h +2 -1
@@ -78,7 +78,8 @@ static inline void scatterwalk_pagedone(struct scatter_walk *walk, int out, page =sg_page (walk->sg) + ((walk->offset -1 ) >>PAGE_SHIFT );flush_dcache_page (page); } - +if (sg_next (walk->sg) ==NULL ) +return ;if (more && walk->offset >= walk->sg->offset + walk->sg->length)scatterwalk_start (walk,sg_next (walk->sg)); }
Signature · 1 line
2.43.0
Greg KH
maintainerQuoted 2 lines · Manas
sg_nextcan return NULL which causes NULL deref inscatterwalk_start
How can it return NULL in this case?
Quoted 4 lines
Reported-by Manas Ghandat <[email protected]>Reported-by Rakshit Awasthi <[email protected]>Signed-off-by Manas Ghandat <[email protected]>Signed-off-by Rakshit Awasthi <[email protected]>
Reported by isn't needed if you sign off on a patch. But you got the order wrong here for the signed off by lines, please read the documentation.
<formletter>
This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.
</formletter>
Quoted 16 lines · Manas
sg_nextcan return NULL which causes NULL deref inscatterwalk_startReported-by Manas Ghandat <[email protected]>Reported-by Rakshit Awasthi <[email protected]>Signed-off-by Manas Ghandat <[email protected]>Signed-off-by Rakshit Awasthi <[email protected]>--- include/crypto/scatterwalk.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)include/crypto/scatterwalk.h +0
-0
include/crypto/scatterwalk.h static inline void scatterwalk_pagedone(struct scatter_walk *walk, int out, · line 84
Quoted 8 lines
include/crypto/scatterwalk.h +2
-1@@ -78,7 +78,8 @@ static inline void scatterwalk_pagedone(struct scatter_walk *walk, int out, page =sg_page (walk->sg) + ((walk->offset -1 ) >>PAGE_SHIFT );flush_dcache_page (page); } - +if (sg_next (walk->sg) ==NULL ) +return ;if (more && walk->offset >= walk->sg->offset + walk->sg->length)scatterwalk_start (walk,sg_next (walk->sg));
First, this patch doesn't apply to the mainline kernel. This seems to be a patch against an older version.
Second, 'sg_next(walk->sg)' returning NULL during the line 'scatterwalk_start(walk, sg_next(walk->sg));' means that the end of the scatterlist has been reached, despite more data needing to be processed. For example, this could happen if some in-kernel user asked to encrypt 200 bytes from a scatterlist containing only 100 bytes. But that would be a bug in the code that requested the invalid encryption operation in the first place, not here. It would need to be fixed there.
What is the full call stack of the crash? That would point to what actually needs to be fixed.
- Eric