wifi: ath10k: use non devm for nvmem_cell_get
PATCH 1/1 wifi: ath10k: use non devm for nvmem_cell_get
There's absolutely no need to extend the lifetime of cell to post removal of the driver. It's only used in this function.
Signed-off-by Rosen Penev <[email protected]>
--- drivers/net/wireless/ath/ath10k/core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/net/wireless/ath/ath10k/core.c +2 -1
@@ -1981,13 +1981,14 @@ static int ath10k_download_cal_nvmem(struct ath10k *ar, const char *cell_name)size_t len;int ret; - cell =devm_nvmem_cell_get (ar->dev, cell_name); + cell =nvmem_cell_get (ar->dev, cell_name);if (IS_ERR (cell)) { ret =PTR_ERR (cell);return ret; } buf =nvmem_cell_read (cell, &len); +nvmem_cell_put (cell);if (IS_ERR (buf))return PTR_ERR (buf);
--
2.53.0
Quoted 5 lines · Rosen Penev
There's absolutely no need to extend the lifetime of cell to post removal of the driver. It's only used in this function.
Signed-off-by Rosen Penev <[email protected]>
Reviewed-by Loic Poulain <[email protected]>
Quoted 28 lines
--- drivers/net/wireless/ath/ath10k/core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/net/wireless/ath/ath10k/core.c +2
-2@@ -1981,13 +1981,14 @@ static int ath10k_download_cal_nvmem(struct ath10k *ar, const char *cell_name)size_t len;int ret; - cell =devm_nvmem_cell_get (ar->dev, cell_name); + cell =nvmem_cell_get (ar->dev, cell_name);if (IS_ERR (cell)) { ret =PTR_ERR (cell);return ret; } buf =nvmem_cell_read (cell, &len); +nvmem_cell_put (cell);if (IS_ERR (buf))return PTR_ERR (buf); --2.53.0