Skip to contentSkip to conversation

Patch "printk, vt, fbcon: Remove console_conditional_schedule()" has been added to the 6.12-stable tree

DISCUSSION Helge Deller 2 participants 5 messages Feb 21 – Feb 24 1 message not in the archive Stable branch

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

Hi Sasha,

Quoted 10 lines · Sasha Levin

This is a note to let you know that I've just added the patch titled

printk, vt, fbcon: Remove console_conditional_schedule()

to the 6.12-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
printk-vt-fbcon-remove-console_conditional_schedule.patch
and it can be found in the queue-6.12 subdirectory.

I suggest not to backport this patch at all.
We don't know yet, if it may have side effects. Even more in older kernels.

So, please drop it.
Same for the other fbdev patches starting with "fbcon:". Those are just cleanups.

Helge

#2 lore raw
Quoted 1 line · Helge Deller

Hi Sasha,

Hi Helge,

Quoted 11 lines · Sasha Levin
Quoted 10 lines

This is a note to let you know that I've just added the patch titled

printk, vt, fbcon: Remove console_conditional_schedule()

to the 6.12-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
printk-vt-fbcon-remove-console_conditional_schedule.patch
and it can be found in the queue-6.12 subdirectory.

Quoted 6 lines

I suggest not to backport this patch at all.
We don't know yet, if it may have side effects. Even more in older kernels.

So, please drop it.
Same for the other fbdev patches starting with "fbcon:". Those are just cleanups.

I would need it for PREEMPT_RT in v6.6 and v6.12 to get rid of the mentioned problem. Any suggestions?
One idea would be to make the removed functions a NOP in the PREEMPT_RT case if you prefer not to backport it at all.

Quoted 1 line

Helge

Sebastian

#3 lore raw

Hello Sebastian,

Quoted 15 lines · Sebastian Andrzej Siewior
Quoted 14 lines · Helge Deller
Quoted 10 lines · Sasha Levin

This is a note to let you know that I've just added the patch titled

printk, vt, fbcon: Remove console_conditional_schedule()

to the 6.12-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
printk-vt-fbcon-remove-console_conditional_schedule.patch
and it can be found in the queue-6.12 subdirectory.

I suggest not to backport this patch at all.
We don't know yet, if it may have side effects. Even more in older kernels.

Quoted 6 lines
Quoted 3 lines

So, please drop it.
Same for the other fbdev patches starting with "fbcon:". Those are just cleanups.

I would need it for PREEMPT_RT in v6.6 and v6.12 to get rid of the mentioned problem. Any suggestions?

Just to be sure: I assume you want this patch backported:
8e9bf8b9e8c0 ("printk, vt, fbcon: Remove console_conditional_schedule()") Not the other ones starting with "fbcon". Right?
So, we talk about one patch only.

Quoted 2 lines

One idea would be to make the removed functions a NOP in the PREEMPT_RT case if you prefer not to backport it at all.

I'm not generally against backporting the patch above.
I'm only hesitant, because can we really be sure it will not produce any lockups in the older kernel either? If you think it's safe, I too prefer to backport it as is.

Helge

#4 lore raw
Quoted 1 line · Helge Deller

Hello Sebastian,

Hi Helge,

Quoted 4 lines

Just to be sure: I assume you want this patch backported:
8e9bf8b9e8c0 ("printk, vt, fbcon: Remove console_conditional_schedule()") Not the other ones starting with "fbcon". Right?
So, we talk about one patch only.

Correct, only this one.

Quoted 5 lines
Quoted 2 lines

One idea would be to make the removed functions a NOP in the PREEMPT_RT case if you prefer not to backport it at all.

I'm not generally against backporting the patch above. I'm only hesitant, because can we really be sure it will not produce any lockups in the older kernel either?

Not without trying. There is this scheduling point since v4.5-rc1 and this should go to v6.12+ and based on this I don't see any problem with it. Older kernel will be v6.12, v6.18 and v6.19.

Quoted 1 line

If you think it's safe, I too prefer to backport it as is.

Okay. Then a backport as is it is :)

Quoted 1 line

Helge

Sebastian

#5 lore raw
Quoted 17 lines · Sebastian Andrzej Siewior
Quoted 1 line · Helge Deller

Hello Sebastian,

Hi Helge,

Quoted 4 lines

Just to be sure: I assume you want this patch backported:
8e9bf8b9e8c0 ("printk, vt, fbcon: Remove console_conditional_schedule()") Not the other ones starting with "fbcon". Right?
So, we talk about one patch only.

Correct, only this one.

Quoted 5 lines
Quoted 2 lines

One idea would be to make the removed functions a NOP in the PREEMPT_RT case if you prefer not to backport it at all.

I'm not generally against backporting the patch above. I'm only hesitant, because can we really be sure it will not produce any lockups in the older kernel either?

Quoted 7 lines

Not without trying. There is this scheduling point since v4.5-rc1 and this should go to v6.12+ and based on this I don't see any problem with it. Older kernel will be v6.12, v6.18 and v6.19.

Quoted 1 line

If you think it's safe, I too prefer to backport it as is.

Okay. Then a backport as is it is :)

Ok, fine with me.
Sasha, can you please re-add (in case you dropped it already): ? 8e9bf8b9e8c0 ("printk, vt, fbcon: Remove console_conditional_schedule()")

Thanks,
Helge