Skip to contentSkip to conversation

libarchive: backport libarchive ptest to whinlatter

PATCH In review Pratik Farkase 2 participants 2 messages Feb 24 – Mar 6

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 libarchive: backport libarchive ptest to whinlatter

Backport ptest implementation from master branch to enable comprehensive testing of libarchive functionality in the whinlatter release.

The implementation builds and installs five test suites:
libarchive_test, bsdtar_test, bsdcpio_test, bsdcat_test, and bsdunzip_test, along with their test data files.

Test executables for bsdtar, bsdcpio, bsdcat, and bsdunzip are provided via symlinks to the installed binaries.

All tests on qemux86-64 pass:
libarchive_test: 689 tests
bsdtar_test: 76 tests
bsdcpio_test: 49 tests
bsdcat_test: 18 tests
bsdunzip_test: 8 tests

This backport ensures the whinlatter branch has the same comprehensive test coverage as master, improving quality assurance and catching regressions early.

---
 .../distro/include/ptest-packagelists.inc     |  1 +
 .../libarchive/libarchive/run-ptest           | 10 ++++++
 .../libarchive/libarchive_3.8.5.bb            | 31 +++++++++++++++++--
 3 files changed, 40 insertions(+), 2 deletions(-)
 create mode 100755 meta/recipes-extended/libarchive/libarchive/run-ptest
meta/conf/distro/include/ptest-packagelists.inc +1 -0
index 06d113e264..a70ad52f72 100644
@@ -28,6 +28,7 @@ PTESTS_FAST = "\
     icu \
     json-c \
     json-glib \
+    libarchive \
     libconvert-asn1-perl \
     libexif \
     libgpg-error\
meta/recipes-extended/libarchive/libarchive/run-ptest new file +10 -0
new file mode 100755
index 0000000000..36d982917c
@@ -0,0 +1,10 @@
+#!/bin/sh
+
+for t in libarchive_test bsdtar_test bsdcpio_test bsdcat_test bsdunzip_test; do
+    ./$t
+    if [ $? -eq 0 ]; then
+        echo "PASS: $t"
+    else
+        echo "FAIL: $t"
+    fi
+done
meta/recipes-extended/libarchive/libarchive_3.8.5.bb +29 -2
index fcfaf5d231..b074617141 100644
@@ -29,12 +29,15 @@ PACKAGECONFIG[zstd] = "--with-zstd,--without-zstd,zstd,"
 
 EXTRA_OECONF += "--enable-largefile --without-iconv"
 
-SRC_URI = "https://libarchive.org/downloads/libarchive-${PV}.tar.gz"
+SRC_URI = "https://libarchive.org/downloads/libarchive-${PV}.tar.gz \
+           file://run-ptest \
+          "
+
 UPSTREAM_CHECK_URI = "https://www.libarchive.org/"
 
 SRC_URI[sha256sum] = "8a60f3a7bfd59c54ce82ae805a93dba65defd04148c3333b7eaa2102f03b7ffd"
 
-inherit autotools update-alternatives pkgconfig
+inherit autotools update-alternatives pkgconfig ptest
 
 CPPFLAGS += "-I${WORKDIR}/extra-includes"
 
@@ -62,3 +65,27 @@ ALTERNATIVE_LINK_NAME[cpio] = "${base_bindir}/cpio"
 ALTERNATIVE_TARGET[cpio] = "${bindir}/bsdcpio"
 
 BBCLASSEXTEND = "native nativesdk"
+
+do_compile_ptest() {
+    oe_runmake check TESTS=
+}
+
+do_install_ptest() {
+    install -d ${D}${PTEST_PATH}
+
+    for test in libarchive_test bsdtar_test bsdcpio_test bsdcat_test bsdunzip_test; do
+            ${B}/libtool --mode=install install -m 0755 ${B}/$test ${D}${PTEST_PATH}/$test
+    done
+
+    for dir in libarchive tar cpio cat unzip; do
+            install -d ${D}${PTEST_PATH}/$dir/test
+            cp -r ${S}/$dir/test/* ${D}${PTEST_PATH}/$dir/test/
+    done
+
+    ln -sf ${bindir}/bsdtar ${D}${PTEST_PATH}/bsdtar
+    ln -sf ${bindir}/bsdcpio ${D}${PTEST_PATH}/bsdcpio
+    ln -sf ${bindir}/bsdcat ${D}${PTEST_PATH}/bsdcat
+    ln -sf ${bindir}/bsdunzip ${D}${PTEST_PATH}/bsdunzip
+}
+
+RDEPENDS:${PN}-ptest += "bsdtar bsdcpio"
Signature · 1 line
2.43.0
#1 lore raw
Quoted 17 lines · Pratik Farkase via lists.openembedded.org

Backport ptest implementation from master branch to enable comprehensive testing of libarchive functionality in the whinlatter release.

The implementation builds and installs five test suites:
libarchive_test, bsdtar_test, bsdcpio_test, bsdcat_test, and bsdunzip_test, along with their test data files.

Test executables for bsdtar, bsdcpio, bsdcat, and bsdunzip are provided via symlinks to the installed binaries.

All tests on qemux86-64 pass:
libarchive_test: 689 tests
bsdtar_test: 76 tests
bsdcpio_test: 49 tests
bsdcat_test: 18 tests
bsdunzip_test: 8 tests

Quoted 5 lines

This backport ensures the whinlatter branch has the same comprehensive test coverage as master, improving quality assurance and catching regressions early.

Hello,

I'm sorry but we decided that standalone tests like this one are not acceptable for stable inclusion.

For more detail, see "Clarification on ptest/selftest backports for stable branches"
https://lore.kernel.org/openembedded-core/[email protected]/T/#u

Regards,

Signature · 2 lines
Yoann Congal
Smile ECS