Skip to contentSkip to conversation

xe_exec_balancer: Report skip when test is unable to run

PATCH In review Matt Roper 3 participants 8 messages Feb 24 – Feb 25

lore
Share & tools
lore

Matt Roper

author
#0 lore raw

PATCH 1/1 xe_exec_balancer: Report skip when test is unable to run

The xe_exec_balancer tests require two engines of the same class to be able to execute. Many Intel platforms today do not have two engines of any class so the test bails out and does not do anything, however it returns a 'pass' result in this case which is misleading since the test was unable to exercise the relevant kernel/hardware functionality. Adjust the subtests to track whether they found engines capable of performing the testing; if not, return a 'skip' result that more accurately reflects that nothing was tested.

---
 tests/intel/xe_exec_balancer.c | 178 +++++++++++++++++++++++----------
 1 file changed, 124 insertions(+), 54 deletions(-)
tests/intel/xe_exec_balancer.c +124 -54
index 98e09961e..9cd641b4e 100644
@@ -32,7 +32,7 @@
  *	of a class simultaneously
  * Test category: functionality test
  */
-static void test_all_active(int fd, int gt, int class)
+static bool test_all_active(int fd, int gt, int class)
 {
 	uint32_t vm;
 	uint64_t addr = 0x1a0000;
@@ -58,7 +58,7 @@ static void test_all_active(int fd, int gt, int class)
 
 	num_placements = xe_gt_fill_engines_by_class(fd, gt, class, eci);
 	if (num_placements < 2)
-		return;
+		return false;
 
 	vm = xe_vm_create(fd, 0, 0);
 	bo_size = sizeof(*data) * num_placements;
@@ -110,6 +110,8 @@ static void test_all_active(int fd, int gt, int class)
 	munmap(data, bo_size);
 	gem_close(fd, bo);
 	xe_vm_destroy(fd, vm);
+
+	return true;
 }
 
 #define MAX_N_EXEC_QUEUES	16
@@ -156,7 +158,7 @@ static void test_all_active(int fd, int gt, int class)
  * @parallel-userptr-invalidate:	parallel userptr invalidate
  * @parallel-userptr-invalidate-race:	parallel userptr invalidate racy
  */
-static void
+static bool
 test_exec(int fd, int gt, int class, int n_exec_queues, int n_execs,
 	  unsigned int flags)
 {
@@ -186,7 +188,7 @@ test_exec(int fd, int gt, int class, int n_exec_queues, int n_execs,
 
 	num_placements = xe_gt_fill_engines_by_class(fd, gt, class, eci);
 	if (num_placements < 2)
-		return;
+		return false;
 
 	vm = xe_vm_create(fd, 0, 0);
 	bo_size = sizeof(*data) * n_execs;
@@ -326,6 +328,8 @@ test_exec(int fd, int gt, int class, int n_exec_queues, int n_execs,
 		free(data);
 	}
 	xe_vm_destroy(fd, vm);
+
+	return true;
 }
 
 /**
@@ -365,7 +369,7 @@ test_exec(int fd, int gt, int class, int n_exec_queues, int n_execs,
  * @parallel-userptr-invalidate-race:	parallel userptr invalidate racy
  */
 
-static void
+static bool
 test_cm(int fd, int gt, int class, int n_exec_queues, int n_execs,
 	unsigned int flags)
 {
@@ -399,7 +403,7 @@ test_cm(int fd, int gt, int class, int n_exec_queues, int n_execs,
 
 	num_placements = xe_gt_fill_engines_by_class(fd, gt, class, eci);
 	if (num_placements < 2)
-		return;
+		return false;
 
 	vm = xe_vm_create(fd, DRM_XE_VM_CREATE_FLAG_LR_MODE, 0);
 	bo_size = sizeof(*data) * n_execs;
@@ -557,6 +561,8 @@ test_cm(int fd, int gt, int class, int n_exec_queues, int n_execs,
 		free(data);
 	}
 	xe_vm_destroy(fd, vm);
+
+	return true;
 }
 
 
@@ -591,76 +597,140 @@ int igt_main()
 	igt_fixture()
 		fd = drm_open_driver(DRIVER_XE);
 
-	igt_subtest("virtual-all-active")
-		xe_for_each_gt(fd, gt)
+	igt_subtest("virtual-all-active") {
+		bool has_necessary_engines = false;
+
+		xe_for_each_gt(fd, gt) {
 			xe_for_each_engine_class(class)
-				test_all_active(fd, gt, class);
+				has_necessary_engines |=
+					test_all_active(fd, gt, class);
+		}
+		igt_require(has_necessary_engines);
+	}
 
 	for (const struct section *s = sections; s->name; s++) {
-		igt_subtest_f("once-%s", s->name)
-			xe_for_each_gt(fd, gt)
+		igt_subtest_f("once-%s", s->name) {
+			bool has_necessary_engines = false;
+
+			xe_for_each_gt(fd, gt) {
 				xe_for_each_engine_class(class)
-					test_exec(fd, gt, class, 1, 1,
-						  s->flags);
+					has_necessary_engines |=
+						test_exec(fd, gt, class, 1, 1, s->flags);
+			}
+			igt_require(has_necessary_engines);
+		}
+
+		igt_subtest_f("twice-%s", s->name) {
+			bool has_necessary_engines = false;
 
-		igt_subtest_f("twice-%s", s->name)
-			xe_for_each_gt(fd, gt)
+			xe_for_each_gt(fd, gt) {
 				xe_for_each_engine_class(class)
-					test_exec(fd, gt, class, 1, 2,
-						  s->flags);
+					has_necessary_engines |=
+						test_exec(fd, gt, class, 1, 2, s->flags);
+			}
+			igt_require(has_necessary_engines);
+		}
+
+		igt_subtest_f("many-%s", s->name) {
+			bool has_necessary_engines = false;
 
-		igt_subtest_f("many-%s", s->name)
-			xe_for_each_gt(fd, gt)
+			xe_for_each_gt(fd, gt) {
 				xe_for_each_engine_class(class)
-					test_exec(fd, gt, class, 1,
-						  s->flags & (REBIND | INVALIDATE) ?
-						  64 : 1024,
-						  s->flags);
+					has_necessary_engines |=
+						test_exec(fd, gt, class, 1,
+							  s->flags & (REBIND | INVALIDATE) ?
+							  64 : 1024,
+							  s->flags);
+			}
+			igt_require(has_necessary_engines);
+		}
 
-		igt_subtest_f("many-execqueues-%s", s->name)
-			xe_for_each_gt(fd, gt)
+		igt_subtest_f("many-execqueues-%s", s->name) {
+			bool has_necessary_engines = false;
+
+			xe_for_each_gt(fd, gt) {
 				xe_for_each_engine_class(class)
-					test_exec(fd, gt, class, 16,
-						  s->flags & (REBIND | INVALIDATE) ?
-						  64 : 1024,
-						  s->flags);
+					has_necessary_engines |=
+						test_exec(fd, gt, class, 16,
+							  s->flags & (REBIND | INVALIDATE) ?
+							  64 : 1024,
+							  s->flags);
+			}
+			igt_require(has_necessary_engines);
+		}
+
+		igt_subtest_f("no-exec-%s", s->name) {
+			bool has_necessary_engines = false;
 
-		igt_subtest_f("no-exec-%s", s->name)
-			xe_for_each_gt(fd, gt)
+			xe_for_each_gt(fd, gt) {
 				xe_for_each_engine_class(class)
-					test_exec(fd, gt, class, 1, 0,
-						  s->flags);
+					has_necessary_engines |=
+						test_exec(fd, gt, class, 1, 0,
+							  s->flags);
+			}
+			igt_require(has_necessary_engines);
+		}
 
-		igt_subtest_f("once-cm-%s", s->name)
-			xe_for_each_gt(fd, gt)
+		igt_subtest_f("once-cm-%s", s->name) {
+			bool has_necessary_engines = false;
+
+			xe_for_each_gt(fd, gt) {
 				xe_for_each_engine_class(class)
-					test_cm(fd, gt, class, 1, 1, s->flags);
+					has_necessary_engines |=
+						test_cm(fd, gt, class, 1, 1, s->flags);
+			}
+			igt_require(has_necessary_engines);
+		}
+
+		igt_subtest_f("twice-cm-%s", s->name) {
+			bool has_necessary_engines = false;
 
-		igt_subtest_f("twice-cm-%s", s->name)
-			xe_for_each_gt(fd, gt)
+			xe_for_each_gt(fd, gt) {
 				xe_for_each_engine_class(class)
-					test_cm(fd, gt, class, 1, 2, s->flags);
+					has_necessary_engines |=
+						test_cm(fd, gt, class, 1, 2, s->flags);
+			}
+			igt_require(has_necessary_engines);
+		}
+
+		igt_subtest_f("many-cm-%s", s->name) {
+			bool has_necessary_engines = false;
 
-		igt_subtest_f("many-cm-%s", s->name)
-			xe_for_each_gt(fd, gt)
+			xe_for_each_gt(fd, gt) {
 				xe_for_each_engine_class(class)
-					test_cm(fd, gt, class, 1,
-						s->flags & (REBIND | INVALIDATE) ?
-						64 : 1024,
-						s->flags);
+					has_necessary_engines |=
+						test_cm(fd, gt, class, 1,
+							s->flags & (REBIND | INVALIDATE) ?
+							64 : 1024,
+							s->flags);
+			}
+			igt_require(has_necessary_engines);
+		}
 
-		igt_subtest_f("many-execqueues-cm-%s", s->name)
-			xe_for_each_gt(fd, gt)
+		igt_subtest_f("many-execqueues-cm-%s", s->name) {
+			bool has_necessary_engines = false;
+
+			xe_for_each_gt(fd, gt) {
 				xe_for_each_engine_class(class)
-					test_cm(fd, gt, class, 16,
-						s->flags & (REBIND | INVALIDATE) ?
-						64 : 1024,
-						s->flags);
+					has_necessary_engines |=
+						test_cm(fd, gt, class, 16,
+							s->flags & (REBIND | INVALIDATE) ?
+							64 : 1024,
+							s->flags);
+			}
+			igt_require(has_necessary_engines);
+		}
+
+		igt_subtest_f("no-exec-cm-%s", s->name) {
+			bool has_necessary_engines = false;
 
-		igt_subtest_f("no-exec-cm-%s", s->name)
-			xe_for_each_gt(fd, gt)
+			xe_for_each_gt(fd, gt) {
 				xe_for_each_engine_class(class)
-					test_cm(fd, gt, class, 1, 0, s->flags);
+					has_necessary_engines |=
+						test_cm(fd, gt, class, 1, 0, s->flags);
+			}
+			igt_require(has_necessary_engines);
+		}
 	}
 
 	igt_fixture()
Signature · 1 line
2.53.0
#1 lore raw

✗ Xe.CI.BAT: failure for xe_exec_balancer: Report skip when test is unable to run

== Series Details ==

== Series Details ==

Series: xe_exec_balancer: Report skip when test is unable to run
URL : https://patchwork.freedesktop.org/series/162088/
State : failure

== Summary ==

CI Bug Log - changes from XEIGT_8769_BAT -> XEIGTPW_14611_BAT
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with XEIGTPW_14611_BAT absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes
introduced in XEIGTPW_14611_BAT, please notify your bug team ([email protected]) to allow them to document this new failure mode, which will reduce false positives in CI.

Participating hosts (13 -> 14)
------------------------------

Additional (1): bat-bmg-3

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in XEIGTPW_14611_BAT:

### IGT changes ###

#### Possible regressions ####

* igt@xe_multigpu_svm@mgpu-xgpu-access-basic:
- bat-bmg-3: NOTRUN -> [ABORT][1]
[1]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_14611/bat-bmg-3/igt@[email protected]

Build changes
-------------

* IGT: IGT_8769 -> IGTPW_14611
* Linux: xe-4607-189174b3312588d97dc467dca7cfb9dce42ab81b -> xe-4609-4caa4c7d4ff7bd4d24bca8e795773e460eb8bbfe

IGTPW_14611: 14611
IGT_8769: 8769
xe-4607-189174b3312588d97dc467dca7cfb9dce42ab81b: 189174b3312588d97dc467dca7cfb9dce42ab81b xe-4609-4caa4c7d4ff7bd4d24bca8e795773e460eb8bbfe: 4caa4c7d4ff7bd4d24bca8e795773e460eb8bbfe

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_14611/index.html

author
#2 lore raw

Re: ✗ Xe.CI.BAT: failure for xe_exec_balancer: Report skip when test is unable to run

Quoted 35 lines · Patchwork

== Series Details ==

Series: xe_exec_balancer: Report skip when test is unable to run
URL : https://patchwork.freedesktop.org/series/162088/
State : failure

== Summary ==

CI Bug Log - changes from XEIGT_8769_BAT -> XEIGTPW_14611_BAT
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with XEIGTPW_14611_BAT absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes
introduced in XEIGTPW_14611_BAT, please notify your bug team ([email protected]) to allow them to document this new failure mode, which will reduce false positives in CI.

Participating hosts (13 -> 14)
------------------------------

Additional (1): bat-bmg-3

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in XEIGTPW_14611_BAT:

Quoted 7 lines

### IGT changes ###

#### Possible regressions ####

* igt@xe_multigpu_svm@mgpu-xgpu-access-basic:
- bat-bmg-3: NOTRUN -> [ABORT][1]
[1]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_14611/bat-bmg-3/igt@[email protected]

Known issue https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/7414
(it can appear on multiple tests, not just the compute-square test the ticket there indicates).

Matt

Quoted 18 lines

Build changes
-------------

* IGT: IGT_8769 -> IGTPW_14611
* Linux: xe-4607-189174b3312588d97dc467dca7cfb9dce42ab81b -> xe-4609-4caa4c7d4ff7bd4d24bca8e795773e460eb8bbfe

IGTPW_14611: 14611
IGT_8769: 8769
xe-4607-189174b3312588d97dc467dca7cfb9dce42ab81b: 189174b3312588d97dc467dca7cfb9dce42ab81b xe-4609-4caa4c7d4ff7bd4d24bca8e795773e460eb8bbfe: 4caa4c7d4ff7bd4d24bca8e795773e460eb8bbfe

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_14611/index.html

Signature · 4 lines
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation
#3 lore raw

✗ i915.CI.BAT: failure for xe_exec_balancer: Report skip when test is unable to run

In reply to Matt Roper
== Series Details ==

== Series Details ==

Series: xe_exec_balancer: Report skip when test is unable to run
URL : https://patchwork.freedesktop.org/series/162088/
State : failure

== Summary ==

CI Bug Log - changes from IGT_8769 -> IGTPW_14611
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with IGTPW_14611 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes
introduced in IGTPW_14611, please notify your bug team ([email protected]) to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_14611/index.html

Participating hosts (43 -> 40)
------------------------------

Missing (3): bat-dg2-13 fi-snb-2520m bat-adls-6

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_14611:

### IGT changes ###

#### Possible regressions ####

* igt@gem_lmem_swapping@parallel-random-engines:
- bat-dg2-9: [PASS][1] -> [ABORT][2] +1 other test abort
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_8769/bat-dg2-9/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_14611/bat-dg2-9/igt@[email protected]

* igt@gem_lmem_swapping@parallel-random-engines@lmem0:
- bat-dg2-8: [PASS][3] -> [ABORT][4] +1 other test abort
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_8769/bat-dg2-8/igt@gem_lmem_swapping@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_14611/bat-dg2-8/igt@gem_lmem_swapping@[email protected]

Known issues
------------

Here are the changes found in IGTPW_14611 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@i915_selftest@live:
- bat-mtlp-8: [PASS][5] -> [DMESG-FAIL][6] ([i915#12061]) +1 other test dmesg-fail
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_8769/bat-mtlp-8/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_14611/bat-mtlp-8/igt@[email protected]

* igt@i915_selftest@live@workarounds:
- bat-atsm-1: NOTRUN -> [DMESG-FAIL][7] ([i915#12061]) +1 other test dmesg-fail
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_14611/bat-atsm-1/igt@i915_selftest@[email protected]
- bat-arls-6: [PASS][8] -> [DMESG-FAIL][9] ([i915#12061]) +1 other test dmesg-fail
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_8769/bat-arls-6/igt@i915_selftest@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_14611/bat-arls-6/igt@i915_selftest@[email protected]

#### Possible fixes ####

* igt@gem_lmem_swapping@parallel-random-engines:
- bat-atsm-1: [ABORT][10] -> [PASS][11] +1 other test pass
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_8769/bat-atsm-1/igt@[email protected]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_14611/bat-atsm-1/igt@[email protected]

* igt@i915_selftest@live@workarounds:
- bat-dg2-14: [DMESG-FAIL][12] ([i915#12061]) -> [PASS][13] +1 other test pass
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_8769/bat-dg2-14/igt@i915_selftest@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_14611/bat-dg2-14/igt@i915_selftest@[email protected]

[i915#12061]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12061

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_8769 -> IGTPW_14611
* Linux: CI_DRM_18038 -> CI_DRM_18040

CI-20190529: 20190529
CI_DRM_18038: 189174b3312588d97dc467dca7cfb9dce42ab81b @ git://anongit.freedesktop.org/gfx-ci/linux
CI_DRM_18040: 4caa4c7d4ff7bd4d24bca8e795773e460eb8bbfe @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_14611: 14611
IGT_8769: 8769

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_14611/index.html

author
#4 lore raw

Re: ✗ i915.CI.BAT: failure for xe_exec_balancer: Report skip when test is unable to run

Quoted 44 lines · Patchwork

== Series Details ==

Series: xe_exec_balancer: Report skip when test is unable to run
URL : https://patchwork.freedesktop.org/series/162088/
State : failure

== Summary ==

CI Bug Log - changes from IGT_8769 -> IGTPW_14611
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with IGTPW_14611 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes
introduced in IGTPW_14611, please notify your bug team ([email protected]) to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_14611/index.html

Participating hosts (43 -> 40)
------------------------------

Missing (3): bat-dg2-13 fi-snb-2520m bat-adls-6

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_14611:

### IGT changes ###

#### Possible regressions ####

* igt@gem_lmem_swapping@parallel-random-engines:
- bat-dg2-9: [PASS][1] -> [ABORT][2] +1 other test abort
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_8769/bat-dg2-9/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_14611/bat-dg2-9/igt@[email protected]

Quoted 4 lines

* igt@gem_lmem_swapping@parallel-random-engines@lmem0:
- bat-dg2-8: [PASS][3] -> [ABORT][4] +1 other test abort
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_8769/bat-dg2-8/igt@gem_lmem_swapping@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_14611/bat-dg2-8/igt@gem_lmem_swapping@[email protected]

Known issue https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/15759

Matt

Quoted 56 lines

Known issues
------------

Here are the changes found in IGTPW_14611 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@i915_selftest@live:
- bat-mtlp-8: [PASS][5] -> [DMESG-FAIL][6] ([i915#12061]) +1 other test dmesg-fail
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_8769/bat-mtlp-8/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_14611/bat-mtlp-8/igt@[email protected]

* igt@i915_selftest@live@workarounds:
- bat-atsm-1: NOTRUN -> [DMESG-FAIL][7] ([i915#12061]) +1 other test dmesg-fail
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_14611/bat-atsm-1/igt@i915_selftest@[email protected]
- bat-arls-6: [PASS][8] -> [DMESG-FAIL][9] ([i915#12061]) +1 other test dmesg-fail
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_8769/bat-arls-6/igt@i915_selftest@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_14611/bat-arls-6/igt@i915_selftest@[email protected]

#### Possible fixes ####

* igt@gem_lmem_swapping@parallel-random-engines:
- bat-atsm-1: [ABORT][10] -> [PASS][11] +1 other test pass
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_8769/bat-atsm-1/igt@[email protected]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_14611/bat-atsm-1/igt@[email protected]

* igt@i915_selftest@live@workarounds:
- bat-dg2-14: [DMESG-FAIL][12] ([i915#12061]) -> [PASS][13] +1 other test pass
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_8769/bat-dg2-14/igt@i915_selftest@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_14611/bat-dg2-14/igt@i915_selftest@[email protected]

[i915#12061]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12061

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_8769 -> IGTPW_14611
* Linux: CI_DRM_18038 -> CI_DRM_18040

CI-20190529: 20190529
CI_DRM_18038: 189174b3312588d97dc467dca7cfb9dce42ab81b @ git://anongit.freedesktop.org/gfx-ci/linux
CI_DRM_18040: 4caa4c7d4ff7bd4d24bca8e795773e460eb8bbfe @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_14611: 14611
IGT_8769: 8769

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_14611/index.html

Signature · 4 lines
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation
#5 lore raw

✗ Xe.CI.FULL: failure for xe_exec_balancer: Report skip when test is unable to run

In reply to Matt Roper
== Series Details ==

== Series Details ==

Series: xe_exec_balancer: Report skip when test is unable to run
URL : https://patchwork.freedesktop.org/series/162088/
State : failure

== Summary ==

CI Bug Log - changes from XEIGT_8769_FULL -> XEIGTPW_14611_FULL
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with XEIGTPW_14611_FULL absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes
introduced in XEIGTPW_14611_FULL, please notify your bug team ([email protected]) to allow them to document this new failure mode, which will reduce false positives in CI.

Participating hosts (2 -> 2)
------------------------------

No changes in participating hosts

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in XEIGTPW_14611_FULL:

### IGT changes ###

#### Possible regressions ####

* igt@xe_exec_balancer@once-parallel-basic:
- shard-lnl: NOTRUN -> [SKIP][1]
[1]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_14611/shard-lnl-4/igt@[email protected]

* igt@xe_exec_system_allocator@process-many-large-mmap-shared-remap:
- shard-lnl: NOTRUN -> [ABORT][2] +23 other tests abort
[2]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_14611/shard-lnl-4/igt@xe_exec_system_allocator@process-many-large-mmap-shared-remap.html

* igt@xe_exec_system_allocator@twice-mmap-remap-ro-dontunmap:
- shard-bmg: NOTRUN -> [ABORT][3] +23 other tests abort
[3]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_14611/shard-bmg-9/igt@[email protected]

Known issues
------------

Here are the changes found in XEIGTPW_14611_FULL that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@kms_ccs@bad-aux-stride-y-tiled-gen12-rc-ccs-cc:
- shard-bmg: NOTRUN -> [SKIP][4] ([Intel XE#2887])
[4]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_14611/shard-bmg-1/igt@[email protected]
- shard-lnl: NOTRUN -> [SKIP][5] ([Intel XE#2887])
[5]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_14611/shard-lnl-3/igt@[email protected]

* igt@kms_content_protection@dp-mst-type-0-suspend-resume:
- shard-lnl: NOTRUN -> [SKIP][6] ([Intel XE#6974])
[6]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_14611/shard-lnl-8/igt@[email protected]
- shard-bmg: NOTRUN -> [SKIP][7] ([Intel XE#6974])
[7]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_14611/shard-bmg-6/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-modesetfrombusy:
- shard-bmg: NOTRUN -> [SKIP][8] ([Intel XE#4141])
[8]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_14611/shard-bmg-1/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-indfb-draw-blt:
- shard-lnl: NOTRUN -> [SKIP][9] ([Intel XE#656]) +1 other test skip
[9]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_14611/shard-lnl-3/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-indfb-draw-blt.html

* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-cur-indfb-draw-blt:
- shard-bmg: NOTRUN -> [SKIP][10] ([Intel XE#2313]) +2 other tests skip
[10]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_14611/shard-bmg-3/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-cur-indfb-draw-blt.html

* igt@kms_frontbuffer_tracking@fbcpsr-tiling-y:
- shard-lnl: NOTRUN -> [SKIP][11] ([Intel XE#1469])
[11]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_14611/shard-lnl-4/igt@[email protected]
- shard-bmg: NOTRUN -> [SKIP][12] ([Intel XE#2352])
[12]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_14611/shard-bmg-5/igt@[email protected]

* igt@xe_configfs@survivability-mode:
- shard-lnl: NOTRUN -> [SKIP][13] ([Intel XE#6010] / [Intel XE#7317])
[13]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_14611/shard-lnl-7/igt@[email protected]

* igt@xe_eudebug_online@pagefault-read-stress:
- shard-lnl: NOTRUN -> [SKIP][14] ([Intel XE#6665])
[14]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_14611/shard-lnl-1/igt@[email protected]
- shard-bmg: NOTRUN -> [SKIP][15] ([Intel XE#6665] / [Intel XE#6681])
[15]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_14611/shard-bmg-9/igt@[email protected]

* igt@xe_evict@evict-beng-threads-small-multi-vm:
- shard-lnl: NOTRUN -> [SKIP][16] ([Intel XE#6540] / [Intel XE#688])
[16]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_14611/shard-lnl-8/igt@[email protected]

* igt@xe_exec_basic@multigpu-no-exec-userptr-invalidate:
- shard-lnl: NOTRUN -> [SKIP][17] ([Intel XE#1392]) +1 other test skip
[17]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_14611/shard-lnl-1/igt@[email protected]
- shard-bmg: NOTRUN -> [SKIP][18] ([Intel XE#2322]) +1 other test skip
[18]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_14611/shard-bmg-9/igt@[email protected]

* igt@xe_exec_fault_mode@once-multi-queue-imm:
- shard-lnl: NOTRUN -> [SKIP][19] ([Intel XE#7136]) +1 other test skip
[19]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_14611/shard-lnl-7/igt@[email protected]
- shard-bmg: NOTRUN -> [SKIP][20] ([Intel XE#7136]) +1 other test skip
[20]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_14611/shard-bmg-4/igt@[email protected]

* igt@xe_exec_multi_queue@few-execs-preempt-mode-close-fd-smem:
- shard-bmg: NOTRUN -> [SKIP][21] ([Intel XE#6874]) +1 other test skip
[21]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_14611/shard-bmg-1/igt@[email protected]

* igt@xe_exec_multi_queue@many-queues-preempt-mode-fault-priority:
- shard-lnl: NOTRUN -> [SKIP][22] ([Intel XE#6874]) +1 other test skip
[22]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_14611/shard-lnl-2/igt@[email protected]

[Intel XE#1392]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1392
[Intel XE#1469]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1469
[Intel XE#2313]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2313
[Intel XE#2322]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2322
[Intel XE#2352]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2352
[Intel XE#2887]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2887
[Intel XE#4141]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4141
[Intel XE#6010]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6010
[Intel XE#6540]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6540
[Intel XE#656]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/656
[Intel XE#6665]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6665
[Intel XE#6681]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6681
[Intel XE#6874]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6874
[Intel XE#688]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/688
[Intel XE#6974]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6974
[Intel XE#7136]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7136
[Intel XE#7317]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7317

Build changes
-------------

* IGT: IGT_8769 -> IGTPW_14611
* Linux: xe-4607-189174b3312588d97dc467dca7cfb9dce42ab81b -> xe-4609-4caa4c7d4ff7bd4d24bca8e795773e460eb8bbfe

IGTPW_14611: 14611
IGT_8769: 8769
xe-4607-189174b3312588d97dc467dca7cfb9dce42ab81b: 189174b3312588d97dc467dca7cfb9dce42ab81b xe-4609-4caa4c7d4ff7bd4d24bca8e795773e460eb8bbfe: 4caa4c7d4ff7bd4d24bca8e795773e460eb8bbfe

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_14611/index.html

author
#6 lore raw

Re: ✗ Xe.CI.FULL: failure for xe_exec_balancer: Report skip when test is unable to run

Quoted 35 lines · Patchwork

== Series Details ==

Series: xe_exec_balancer: Report skip when test is unable to run
URL : https://patchwork.freedesktop.org/series/162088/
State : failure

== Summary ==

CI Bug Log - changes from XEIGT_8769_FULL -> XEIGTPW_14611_FULL
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with XEIGTPW_14611_FULL absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes
introduced in XEIGTPW_14611_FULL, please notify your bug team ([email protected]) to allow them to document this new failure mode, which will reduce false positives in CI.

Participating hosts (2 -> 2)
------------------------------

No changes in participating hosts

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in XEIGTPW_14611_FULL:

Quoted 7 lines

### IGT changes ###

#### Possible regressions ####

* igt@xe_exec_balancer@once-parallel-basic:
- shard-lnl: NOTRUN -> [SKIP][1]
[1]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_14611/shard-lnl-4/igt@[email protected]

Intended skip (cases like this are why the change was made).

Quoted 4 lines

* igt@xe_exec_system_allocator@process-many-large-mmap-shared-remap:
- shard-lnl: NOTRUN -> [ABORT][2] +23 other tests abort
[2]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_14611/shard-lnl-4/igt@xe_exec_system_allocator@process-many-large-mmap-shared-remap.html

https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/7414

Quoted 4 lines

* igt@xe_exec_system_allocator@twice-mmap-remap-ro-dontunmap:
- shard-bmg: NOTRUN -> [ABORT][3] +23 other tests abort
[3]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_14611/shard-bmg-9/igt@[email protected]

Also https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/7414

Patch title updated and pushed to master. Thanks Kamil for the review.

Matt

Quoted 109 lines

Known issues
------------

Here are the changes found in XEIGTPW_14611_FULL that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@kms_ccs@bad-aux-stride-y-tiled-gen12-rc-ccs-cc:
- shard-bmg: NOTRUN -> [SKIP][4] ([Intel XE#2887])
[4]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_14611/shard-bmg-1/igt@[email protected]
- shard-lnl: NOTRUN -> [SKIP][5] ([Intel XE#2887])
[5]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_14611/shard-lnl-3/igt@[email protected]

* igt@kms_content_protection@dp-mst-type-0-suspend-resume:
- shard-lnl: NOTRUN -> [SKIP][6] ([Intel XE#6974])
[6]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_14611/shard-lnl-8/igt@[email protected]
- shard-bmg: NOTRUN -> [SKIP][7] ([Intel XE#6974])
[7]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_14611/shard-bmg-6/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-modesetfrombusy:
- shard-bmg: NOTRUN -> [SKIP][8] ([Intel XE#4141])
[8]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_14611/shard-bmg-1/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-indfb-draw-blt:
- shard-lnl: NOTRUN -> [SKIP][9] ([Intel XE#656]) +1 other test skip
[9]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_14611/shard-lnl-3/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-indfb-draw-blt.html

* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-cur-indfb-draw-blt:
- shard-bmg: NOTRUN -> [SKIP][10] ([Intel XE#2313]) +2 other tests skip
[10]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_14611/shard-bmg-3/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-cur-indfb-draw-blt.html

* igt@kms_frontbuffer_tracking@fbcpsr-tiling-y:
- shard-lnl: NOTRUN -> [SKIP][11] ([Intel XE#1469])
[11]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_14611/shard-lnl-4/igt@[email protected]
- shard-bmg: NOTRUN -> [SKIP][12] ([Intel XE#2352])
[12]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_14611/shard-bmg-5/igt@[email protected]

* igt@xe_configfs@survivability-mode:
- shard-lnl: NOTRUN -> [SKIP][13] ([Intel XE#6010] / [Intel XE#7317])
[13]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_14611/shard-lnl-7/igt@[email protected]

* igt@xe_eudebug_online@pagefault-read-stress:
- shard-lnl: NOTRUN -> [SKIP][14] ([Intel XE#6665])
[14]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_14611/shard-lnl-1/igt@[email protected]
- shard-bmg: NOTRUN -> [SKIP][15] ([Intel XE#6665] / [Intel XE#6681])
[15]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_14611/shard-bmg-9/igt@[email protected]

* igt@xe_evict@evict-beng-threads-small-multi-vm:
- shard-lnl: NOTRUN -> [SKIP][16] ([Intel XE#6540] / [Intel XE#688])
[16]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_14611/shard-lnl-8/igt@[email protected]

* igt@xe_exec_basic@multigpu-no-exec-userptr-invalidate:
- shard-lnl: NOTRUN -> [SKIP][17] ([Intel XE#1392]) +1 other test skip
[17]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_14611/shard-lnl-1/igt@[email protected]
- shard-bmg: NOTRUN -> [SKIP][18] ([Intel XE#2322]) +1 other test skip
[18]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_14611/shard-bmg-9/igt@[email protected]

* igt@xe_exec_fault_mode@once-multi-queue-imm:
- shard-lnl: NOTRUN -> [SKIP][19] ([Intel XE#7136]) +1 other test skip
[19]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_14611/shard-lnl-7/igt@[email protected]
- shard-bmg: NOTRUN -> [SKIP][20] ([Intel XE#7136]) +1 other test skip
[20]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_14611/shard-bmg-4/igt@[email protected]

* igt@xe_exec_multi_queue@few-execs-preempt-mode-close-fd-smem:
- shard-bmg: NOTRUN -> [SKIP][21] ([Intel XE#6874]) +1 other test skip
[21]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_14611/shard-bmg-1/igt@[email protected]

* igt@xe_exec_multi_queue@many-queues-preempt-mode-fault-priority:
- shard-lnl: NOTRUN -> [SKIP][22] ([Intel XE#6874]) +1 other test skip
[22]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_14611/shard-lnl-2/igt@[email protected]

[Intel XE#1392]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1392
[Intel XE#1469]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1469
[Intel XE#2313]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2313
[Intel XE#2322]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2322
[Intel XE#2352]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2352
[Intel XE#2887]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2887
[Intel XE#4141]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4141
[Intel XE#6010]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6010
[Intel XE#6540]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6540
[Intel XE#656]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/656
[Intel XE#6665]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6665
[Intel XE#6681]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6681
[Intel XE#6874]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6874
[Intel XE#688]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/688
[Intel XE#6974]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6974
[Intel XE#7136]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7136
[Intel XE#7317]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7317

Build changes
-------------

* IGT: IGT_8769 -> IGTPW_14611
* Linux: xe-4607-189174b3312588d97dc467dca7cfb9dce42ab81b -> xe-4609-4caa4c7d4ff7bd4d24bca8e795773e460eb8bbfe

IGTPW_14611: 14611
IGT_8769: 8769
xe-4607-189174b3312588d97dc467dca7cfb9dce42ab81b: 189174b3312588d97dc467dca7cfb9dce42ab81b xe-4609-4caa4c7d4ff7bd4d24bca8e795773e460eb8bbfe: 4caa4c7d4ff7bd4d24bca8e795773e460eb8bbfe

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_14611/index.html

Signature · 4 lines
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation
Reviewed-by on v1 1/1
#7 lore raw
In reply to Matt Roper

Hi Matt,
On 2026-02-24 at 13:16:13 -0800, Matt Roper wrote:

please use prefix in subject:

[PATCH i-g-t] tests/intel/xe_exec_balancer: Report skip when test is unable to run

This could be done at merge as it is LGTM

Regards,
Kamil

PS. please also reply to Xe FULL fail with one skip from this.

Quoted 291 lines

The xe_exec_balancer tests require two engines of the same class to be able to execute. Many Intel platforms today do not have two engines of any class so the test bails out and does not do anything, however it returns a 'pass' result in this case which is misleading since the test was unable to exercise the relevant kernel/hardware functionality. Adjust the subtests to track whether they found engines capable of performing the testing; if not, return a 'skip' result that more accurately reflects that nothing was tested.

---
 tests/intel/xe_exec_balancer.c | 178 +++++++++++++++++++++++----------
 1 file changed, 124 insertions(+), 54 deletions(-)
tests/intel/xe_exec_balancer.c +124 -54
index 98e09961e..9cd641b4e 100644
@@ -32,7 +32,7 @@
  *	of a class simultaneously
  * Test category: functionality test
  */
-static void test_all_active(int fd, int gt, int class)
+static bool test_all_active(int fd, int gt, int class)
 {
 	uint32_t vm;
 	uint64_t addr = 0x1a0000;
@@ -58,7 +58,7 @@ static void test_all_active(int fd, int gt, int class)
 
 	num_placements = xe_gt_fill_engines_by_class(fd, gt, class, eci);
 	if (num_placements < 2)
-		return;
+		return false;
 
 	vm = xe_vm_create(fd, 0, 0);
 	bo_size = sizeof(*data) * num_placements;
@@ -110,6 +110,8 @@ static void test_all_active(int fd, int gt, int class)
 	munmap(data, bo_size);
 	gem_close(fd, bo);
 	xe_vm_destroy(fd, vm);
+
+	return true;
 }
 
 #define MAX_N_EXEC_QUEUES	16
@@ -156,7 +158,7 @@ static void test_all_active(int fd, int gt, int class)
  * @parallel-userptr-invalidate:	parallel userptr invalidate
  * @parallel-userptr-invalidate-race:	parallel userptr invalidate racy
  */
-static void
+static bool
 test_exec(int fd, int gt, int class, int n_exec_queues, int n_execs,
 	  unsigned int flags)
 {
@@ -186,7 +188,7 @@ test_exec(int fd, int gt, int class, int n_exec_queues, int n_execs,
 
 	num_placements = xe_gt_fill_engines_by_class(fd, gt, class, eci);
 	if (num_placements < 2)
-		return;
+		return false;
 
 	vm = xe_vm_create(fd, 0, 0);
 	bo_size = sizeof(*data) * n_execs;
@@ -326,6 +328,8 @@ test_exec(int fd, int gt, int class, int n_exec_queues, int n_execs,
 		free(data);
 	}
 	xe_vm_destroy(fd, vm);
+
+	return true;
 }
 
 /**
@@ -365,7 +369,7 @@ test_exec(int fd, int gt, int class, int n_exec_queues, int n_execs,
  * @parallel-userptr-invalidate-race:	parallel userptr invalidate racy
  */
 
-static void
+static bool
 test_cm(int fd, int gt, int class, int n_exec_queues, int n_execs,
 	unsigned int flags)
 {
@@ -399,7 +403,7 @@ test_cm(int fd, int gt, int class, int n_exec_queues, int n_execs,
 
 	num_placements = xe_gt_fill_engines_by_class(fd, gt, class, eci);
 	if (num_placements < 2)
-		return;
+		return false;
 
 	vm = xe_vm_create(fd, DRM_XE_VM_CREATE_FLAG_LR_MODE, 0);
 	bo_size = sizeof(*data) * n_execs;
@@ -557,6 +561,8 @@ test_cm(int fd, int gt, int class, int n_exec_queues, int n_execs,
 		free(data);
 	}
 	xe_vm_destroy(fd, vm);
+
+	return true;
 }
 
 
@@ -591,76 +597,140 @@ int igt_main()
 	igt_fixture()
 		fd = drm_open_driver(DRIVER_XE);
 
-	igt_subtest("virtual-all-active")
-		xe_for_each_gt(fd, gt)
+	igt_subtest("virtual-all-active") {
+		bool has_necessary_engines = false;
+
+		xe_for_each_gt(fd, gt) {
 			xe_for_each_engine_class(class)
-				test_all_active(fd, gt, class);
+				has_necessary_engines |=
+					test_all_active(fd, gt, class);
+		}
+		igt_require(has_necessary_engines);
+	}
 
 	for (const struct section *s = sections; s->name; s++) {
-		igt_subtest_f("once-%s", s->name)
-			xe_for_each_gt(fd, gt)
+		igt_subtest_f("once-%s", s->name) {
+			bool has_necessary_engines = false;
+
+			xe_for_each_gt(fd, gt) {
 				xe_for_each_engine_class(class)
-					test_exec(fd, gt, class, 1, 1,
-						  s->flags);
+					has_necessary_engines |=
+						test_exec(fd, gt, class, 1, 1, s->flags);
+			}
+			igt_require(has_necessary_engines);
+		}
+
+		igt_subtest_f("twice-%s", s->name) {
+			bool has_necessary_engines = false;
 
-		igt_subtest_f("twice-%s", s->name)
-			xe_for_each_gt(fd, gt)
+			xe_for_each_gt(fd, gt) {
 				xe_for_each_engine_class(class)
-					test_exec(fd, gt, class, 1, 2,
-						  s->flags);
+					has_necessary_engines |=
+						test_exec(fd, gt, class, 1, 2, s->flags);
+			}
+			igt_require(has_necessary_engines);
+		}
+
+		igt_subtest_f("many-%s", s->name) {
+			bool has_necessary_engines = false;
 
-		igt_subtest_f("many-%s", s->name)
-			xe_for_each_gt(fd, gt)
+			xe_for_each_gt(fd, gt) {
 				xe_for_each_engine_class(class)
-					test_exec(fd, gt, class, 1,
-						  s->flags & (REBIND | INVALIDATE) ?
-						  64 : 1024,
-						  s->flags);
+					has_necessary_engines |=
+						test_exec(fd, gt, class, 1,
+							  s->flags & (REBIND | INVALIDATE) ?
+							  64 : 1024,
+							  s->flags);
+			}
+			igt_require(has_necessary_engines);
+		}
 
-		igt_subtest_f("many-execqueues-%s", s->name)
-			xe_for_each_gt(fd, gt)
+		igt_subtest_f("many-execqueues-%s", s->name) {
+			bool has_necessary_engines = false;
+
+			xe_for_each_gt(fd, gt) {
 				xe_for_each_engine_class(class)
-					test_exec(fd, gt, class, 16,
-						  s->flags & (REBIND | INVALIDATE) ?
-						  64 : 1024,
-						  s->flags);
+					has_necessary_engines |=
+						test_exec(fd, gt, class, 16,
+							  s->flags & (REBIND | INVALIDATE) ?
+							  64 : 1024,
+							  s->flags);
+			}
+			igt_require(has_necessary_engines);
+		}
+
+		igt_subtest_f("no-exec-%s", s->name) {
+			bool has_necessary_engines = false;
 
-		igt_subtest_f("no-exec-%s", s->name)
-			xe_for_each_gt(fd, gt)
+			xe_for_each_gt(fd, gt) {
 				xe_for_each_engine_class(class)
-					test_exec(fd, gt, class, 1, 0,
-						  s->flags);
+					has_necessary_engines |=
+						test_exec(fd, gt, class, 1, 0,
+							  s->flags);
+			}
+			igt_require(has_necessary_engines);
+		}
 
-		igt_subtest_f("once-cm-%s", s->name)
-			xe_for_each_gt(fd, gt)
+		igt_subtest_f("once-cm-%s", s->name) {
+			bool has_necessary_engines = false;
+
+			xe_for_each_gt(fd, gt) {
 				xe_for_each_engine_class(class)
-					test_cm(fd, gt, class, 1, 1, s->flags);
+					has_necessary_engines |=
+						test_cm(fd, gt, class, 1, 1, s->flags);
+			}
+			igt_require(has_necessary_engines);
+		}
+
+		igt_subtest_f("twice-cm-%s", s->name) {
+			bool has_necessary_engines = false;
 
-		igt_subtest_f("twice-cm-%s", s->name)
-			xe_for_each_gt(fd, gt)
+			xe_for_each_gt(fd, gt) {
 				xe_for_each_engine_class(class)
-					test_cm(fd, gt, class, 1, 2, s->flags);
+					has_necessary_engines |=
+						test_cm(fd, gt, class, 1, 2, s->flags);
+			}
+			igt_require(has_necessary_engines);
+		}
+
+		igt_subtest_f("many-cm-%s", s->name) {
+			bool has_necessary_engines = false;
 
-		igt_subtest_f("many-cm-%s", s->name)
-			xe_for_each_gt(fd, gt)
+			xe_for_each_gt(fd, gt) {
 				xe_for_each_engine_class(class)
-					test_cm(fd, gt, class, 1,
-						s->flags & (REBIND | INVALIDATE) ?
-						64 : 1024,
-						s->flags);
+					has_necessary_engines |=
+						test_cm(fd, gt, class, 1,
+							s->flags & (REBIND | INVALIDATE) ?
+							64 : 1024,
+							s->flags);
+			}
+			igt_require(has_necessary_engines);
+		}
 
-		igt_subtest_f("many-execqueues-cm-%s", s->name)
-			xe_for_each_gt(fd, gt)
+		igt_subtest_f("many-execqueues-cm-%s", s->name) {
+			bool has_necessary_engines = false;
+
+			xe_for_each_gt(fd, gt) {
 				xe_for_each_engine_class(class)
-					test_cm(fd, gt, class, 16,
-						s->flags & (REBIND | INVALIDATE) ?
-						64 : 1024,
-						s->flags);
+					has_necessary_engines |=
+						test_cm(fd, gt, class, 16,
+							s->flags & (REBIND | INVALIDATE) ?
+							64 : 1024,
+							s->flags);
+			}
+			igt_require(has_necessary_engines);
+		}
+
+		igt_subtest_f("no-exec-cm-%s", s->name) {
+			bool has_necessary_engines = false;
 
-		igt_subtest_f("no-exec-cm-%s", s->name)
-			xe_for_each_gt(fd, gt)
+			xe_for_each_gt(fd, gt) {
 				xe_for_each_engine_class(class)
-					test_cm(fd, gt, class, 1, 0, s->flags);
+					has_necessary_engines |=
+						test_cm(fd, gt, class, 1, 0, s->flags);
+			}
+			igt_require(has_necessary_engines);
+		}
 	}
 
 	igt_fixture()
Signature · 1 line
2.53.0