dt-bindings: mtd: st,spear600-smi: convert to DT schema
Subsystems (2)
PATCH v2 1/1 dt-bindings: mtd: st,spear600-smi: convert to DT schema
Convert STMicroelectronics SPEAr600 Serial Memory Interface (SMI) Controller binding to YAML format.
---
Changes in v2:
- Removed allOf ref as it is misleading the existing node.
- Defined pattern properties for the child node.
- Link to v1: https://lore.kernel.org/r/[email protected]
--- .../devicetree/bindings/mtd/spear_smi.txt | 29 -------- .../devicetree/bindings/mtd/st,spear600-smi.yaml | 83 ++++++++++++++++++++++ 2 files changed, 83 insertions(+), 29 deletions(-)
Documentation/devicetree/bindings/mtd/spear_smi.txt deleted +0 -29
@@ -1,29 +0,0 @@ -* SPEAr SMI - -Required properties: -- compatible : "st,spear600-smi" -- reg : Address range of the mtd chip -- #address-cells, #size-cells : Must be present if the device has sub-nodes - representing partitions. -- interrupts: Should contain the STMMAC interrupts -- clock-rate : Functional clock rate of SMI in Hz - -Optional properties: -- st,smi-fast-mode : Flash supports read in fast mode - -Example: - - smi: flash@fc000000 { - compatible = "st,spear600-smi"; - #address-cells = <1>; - #size-cells = <1>; - reg = <0xfc000000 0x1000>; - interrupt-parent = <&vic1>; - interrupts = <12>; - clock-rate = <50000000>; /* 50MHz */ - - flash@f8000000 { - st,smi-fast-mode; - ... - }; - };
Documentation/devicetree/bindings/mtd/st,spear600-smi.yaml new file +83 -0
83 lines not on this page · raw message
---
base-commit: cc3aa43b44bdb43dfbac0fcb51c56594a11338a8
change-id: 20260122-spear-e599dc4e7e32
Best regards,
Signature · 1 line
Akhila YS <[email protected]>
Miquel Raynal
maintainerHello Akhila,
Quoted 4 lines · Akhila YS
Convert STMicroelectronics SPEAr600 Serial Memory Interface (SMI) Controller binding to YAML format.
Signed-off-by Akhila YS <[email protected]>
Gasp :-) Good to see that you actually did fix the issues. Thanks for doing that. But you've been sending a v2 for a patch that has already landed in Torvalds' tree. In this case, there are only 2 possibilities:
- sending a revert of the former patch and then this one
- sending fixes like I did
In no case we can just apply this one as-is.
As it's been reviewed already by Rob, I'll take the 3 fixes that I proposed.
[...]
Documentation/devicetree/bindings/mtd/st,spear600-smi.yaml line 40
Quoted 3 lines
Documentation/devicetree/bindings/mtd/st,spear600-smi.yaml new file +3
-0+ clock-rate: + $ref: /schemas/types.yaml#/definitions/uint32 + description: Functional clock rate of the SMI controller in Hz.
This clock property (which I did not address in my series) is apparently not used anywhere upstream. This is a very legacy property, and my feeling is that it has not been useful for quite some time already (due to the CCF being able to provide a proper clock tree now). Hence we have two choices: considering that it does not need to be described at all in the yaml bindings because it is (very) deprecated property, we might want to just drop it off. Otherwise you may send a patch specifically for this addition, however in this case you need to flag it deprecated, I believe.
Thanks,
Miquèl
Quoted 15 lines · Miquel Raynal
Hello Akhila,
Quoted 4 lines · Akhila YS
Convert STMicroelectronics SPEAr600 Serial Memory Interface (SMI) Controller binding to YAML format.
Signed-off-by Akhila YS <[email protected]>Gasp :-) Good to see that you actually did fix the issues. Thanks for doing that. But you've been sending a v2 for a patch that has already landed in Torvalds' tree. In this case, there are only 2 possibilities:
- sending a revert of the former patch and then this one
- sending fixes like I did
In no case we can just apply this one as-is.
Quoted 2 lines
As it's been reviewed already by Rob, I'll take the 3 fixes that I proposed.
Okay, sure not an issue miquel.
Quoted 6 lines
[...]
Documentation/devicetree/bindings/mtd/st,spear600-smi.yaml line 40
Quoted 3 lines
Documentation/devicetree/bindings/mtd/st,spear600-smi.yaml new file +3
-0+ clock-rate: + $ref: /schemas/types.yaml#/definitions/uint32 + description: Functional clock rate of the SMI controller in Hz.
Quoted 9 lines
This clock property (which I did not address in my series) is apparently not used anywhere upstream. This is a very legacy property, and my feeling is that it has not been useful for quite some time already (due to the CCF being able to provide a proper clock tree now). Hence we have two choices: considering that it does not need to be described at all in the yaml bindings because it is (very) deprecated property, we might want to just drop it off. Otherwise you may send a patch specifically for this addition, however in this case you need to flag it deprecated, I believe.
Okay.
Quoted 3 lines
Thanks,
Miquèl
Signature · 2 lines
Best Regards, Akhila.