Skip to contentSkip to conversation

xfs: remove scratch field from struct xfs_gc_bio

PATCH Applied Damien Le Moal 4 participants 5 messages Feb 25 – Mar 5 XFS filesystem

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xfs: remove scratch field from struct xfs_gc_bio

The scratch field in struct xfs_gc_bio is unused. Remove it.

Fixes 102f444b57b3 ("xfs: rework zone GC buffer management")
---
 fs/xfs/xfs_zone_gc.c | 2 --
 1 file changed, 2 deletions(-)
fs/xfs/xfs_zone_gc.c +0 -2
index 48c6cf584447..d78e29cdcc45 100644
@@ -96,7 +96,6 @@ struct xfs_gc_bio {
 	 */
 	xfs_fsblock_t			old_startblock;
 	xfs_daddr_t			new_daddr;
-	struct xfs_zone_scratch		*scratch;
 
 	/* Are we writing to a sequential write required zone? */
 	bool				is_seq;
@@ -779,7 +778,6 @@ xfs_zone_gc_split_write(
 	ihold(VFS_I(chunk->ip));
 	split_chunk->ip = chunk->ip;
 	split_chunk->is_seq = chunk->is_seq;
-	split_chunk->scratch = chunk->scratch;
 	split_chunk->offset = chunk->offset;
 	split_chunk->len = split_len;
 	split_chunk->old_startblock = chunk->old_startblock;
Signature · 1 line
2.53.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 4 lines · Damien Le Moal

The scratch field in struct xfs_gc_bio is unused. Remove it.

Fixes 102f444b57b3 ("xfs: rework zone GC buffer management")

Looks good to me and assuming the bots don't scream,

--D

Quoted 28 lines
---
 fs/xfs/xfs_zone_gc.c | 2 --
 1 file changed, 2 deletions(-)
fs/xfs/xfs_zone_gc.c +0 -2
index 48c6cf584447..d78e29cdcc45 100644
@@ -96,7 +96,6 @@ struct xfs_gc_bio {
 	 */
 	xfs_fsblock_t			old_startblock;
 	xfs_daddr_t			new_daddr;
-	struct xfs_zone_scratch		*scratch;
 
 	/* Are we writing to a sequential write required zone? */
 	bool				is_seq;
@@ -779,7 +778,6 @@ xfs_zone_gc_split_write(
 	ihold(VFS_I(chunk->ip));
 	split_chunk->ip = chunk->ip;
 	split_chunk->is_seq = chunk->is_seq;
-	split_chunk->scratch = chunk->scratch;
 	split_chunk->offset = chunk->offset;
 	split_chunk->len = split_len;
 	split_chunk->old_startblock = chunk->old_startblock;
Signature · 1 line
2.53.0
maintainer Reviewed-by on v1 1/1
#3 lore raw
In reply to Damien Le Moal
Quoted 4 lines · Damien Le Moal

The scratch field in struct xfs_gc_bio is unused. Remove it.

Fixes 102f444b57b3 ("xfs: rework zone GC buffer management")

Looks good,

Quoted 28 lines
---
 fs/xfs/xfs_zone_gc.c | 2 --
 1 file changed, 2 deletions(-)
fs/xfs/xfs_zone_gc.c +0 -2
index 48c6cf584447..d78e29cdcc45 100644
@@ -96,7 +96,6 @@ struct xfs_gc_bio {
 	 */
 	xfs_fsblock_t			old_startblock;
 	xfs_daddr_t			new_daddr;
-	struct xfs_zone_scratch		*scratch;
 
 	/* Are we writing to a sequential write required zone? */
 	bool				is_seq;
@@ -779,7 +778,6 @@ xfs_zone_gc_split_write(
 	ihold(VFS_I(chunk->ip));
 	split_chunk->ip = chunk->ip;
 	split_chunk->is_seq = chunk->is_seq;
-	split_chunk->scratch = chunk->scratch;
 	split_chunk->offset = chunk->offset;
 	split_chunk->len = split_len;
 	split_chunk->old_startblock = chunk->old_startblock;
Signature · 1 line
2.53.0
maintainer Applied
#4 lore raw
In reply to Damien Le Moal
Quoted 3 lines · Damien Le Moal

The scratch field in struct xfs_gc_bio is unused. Remove it.

Applied to for-next, thanks!

[1/1] xfs: remove scratch field from struct xfs_gc_bio

      commit: 6270b8ac2f41858952074b23c2d3d9aa2fe1bfa9

Best regards,

Signature · 1 line
Carlos Maiolino <[email protected]>