staging: rtl8723bs: split chained assignment in xmit_linux.c
PATCH 1/1 staging: rtl8723bs: split chained assignment in xmit_linux.c
checkpatch reports that multiple assignments should be avoided. Split the chained assignment into two separate statements.
--- drivers/staging/rtl8723bs/os_dep/xmit_linux.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/staging/rtl8723bs/os_dep/xmit_linux.c +4 -4
@@ -6,7 +6,6 @@******************************************************************************/ #include <drv_types.h> -uint rtw_remainder_len (struct pkt_file *pfile) {return (pfile->buf_len - ((SIZE_PTR )(pfile->cur_addr) - (SIZE_PTR )(pfile->buf_start)));
@@ -15,9 +14,10 @@ uint rtw_remainder_len(struct pkt_file *pfile)void _rtw_open_pktfile (struct sk_buff *pktptr,struct pkt_file *pfile) { pfile->pkt = pktptr; - pfile->cur_addr = pfile->buf_start = pktptr->data; - pfile->pkt_len = pfile->buf_len = pktptr->len; - + pfile->buf_start = pktptr->data; + pfile->cur_addr = pfile->buf_start; + pfile->buf_len = pktptr->len; + pfile->pkt_len = pfile->buf_len; pfile->cur_buffer = pfile->buf_start; }
Signature · 1 line
2.53.0
Greg KH
maintainerdrivers/staging/rtl8723bs/os_dep/xmit_linux.c line 11
Quoted 8 lines · Keith Teeple
drivers/staging/rtl8723bs/os_dep/xmit_linux.c +0
-1@@ -6,7 +6,6 @@******************************************************************************/ #include <drv_types.h> -uint rtw_remainder_len (struct pkt_file *pfile) {return (pfile->buf_len - ((SIZE_PTR )(pfile->cur_addr) - (SIZE_PTR )(pfile->buf_start)));
This change has nothing to do with splitting chained assignments :(
drivers/staging/rtl8723bs/os_dep/xmit_linux.c uint rtw_remainder_len(struct pkt_file *pfile) · line 18
Quoted 9 lines · Keith Teeple
drivers/staging/rtl8723bs/os_dep/xmit_linux.c +2
-3@@ -15,9 +14,10 @@ uint rtw_remainder_len(struct pkt_file *pfile)void _rtw_open_pktfile (struct sk_buff *pktptr,struct pkt_file *pfile) { pfile->pkt = pktptr; - pfile->cur_addr = pfile->buf_start = pktptr->data; - pfile->pkt_len = pfile->buf_len = pktptr->len; - + pfile->buf_start = pktptr->data; + pfile->cur_addr = pfile->buf_start;
Please don't do it like this. Do it like this:
pfile->buf_start = pktptr->data; pfile->cur_addr = pktptr->data;
Otherwise we have made the new version harder to read than the original code.
regards,
dan carpenter
Quoted 8 lines
drivers/staging/rtl8723bs/os_dep/xmit_linux.c +2
-0+ pfile->buf_len = pktptr->len; + pfile->pkt_len = pfile->buf_len; pfile->cur_buffer = pfile->buf_start; }Signature · 1 line
2.53.0
Quoted 1 line · Dan Carpenter
On Wed, Feb 25, 2026 at 07:10:19PM -0500, Keith Teeple wrote:
...
Quoted 10 lines
drivers/staging/rtl8723bs/os_dep/xmit_linux.c uint rtw_remainder_len(struct pkt_file *pfile) · line 18
Quoted 8 lines
void
_rtw_open_pktfile(struct sk_buff *pktptr, struct pkt_file *pfile){drivers/staging/rtl8723bs/os_dep/xmit_linux.c +2
-3pfile->pkt = pktptr; - pfile->cur_addr = pfile->buf_start = pktptr->data; - pfile->pkt_len = pfile->buf_len = pktptr->len; - + pfile->buf_start = pktptr->data; + pfile->cur_addr = pfile->buf_start;Please don't do it like this. Do it like this:
+1, good advice!
Quoted 5 lines
pfile->buf_start = pktptr->data; pfile->cur_addr = pktptr->data;Otherwise we have made the new version harder to read than the original code.
Not only read, but prone to subtle mistakes in the future!
Quoted 4 lines
Quoted 4 lines
drivers/staging/rtl8723bs/os_dep/xmit_linux.c +2
-0+ pfile->buf_len = pktptr->len; + pfile->pkt_len = pfile->buf_len; pfile->cur_buffer = pfile->buf_start; }
Signature · 2 lines
With Best Regards, Andy Shevchenko