iommu/dma: Validate page before accessing P2PDMA state
Subsystems (5)
RFC PATCH 1/1 iommu/dma: Validate page before accessing P2PDMA state
When mapping scatter-gather entries that reference reserved memory regions without struct page backing (e.g., bootloader created carveouts), is_pci_p2pdma_page() dereferences the page pointer returned by sg_page() without first verifying its validity.
This causes a kernel paging fault when CONFIG_PCI_P2PDMA is enabled and dma_map_sg_attrs() is called for memory regions that have no associated struct page:
Unable to handle kernel paging request at virtual address fffffc007d100000 ... Call trace: iommu_dma_map_sg+0x118/0x414 dma_map_sg_attrs+0x38/0x44
Fix this by adding a pfn_valid() check before calling is_pci_p2pdma_page(). If the page frame number is invalid, skip the P2PDMA check entirely as such memory cannot be P2PDMA memory anyway.
--- drivers/iommu/dma-iommu.c | 4 ++++ 1 file changed, 4 insertions(+)
drivers/iommu/dma-iommu.c +4 -0
@@ -1423,6 +1423,9 @@ int iommu_dma_map_sg(struct device *dev, struct scatterlist *sg, int nents,size_t s_length = s->length;size_t pad_len = (mask - iova_len +1 ) & mask; +if (!pfn_valid (page_to_pfn (sg_page (s)))) + goto post_pci_p2pdma; +switch (pci_p2pdma_state (&p2pdma_state, dev,sg_page (s))) {case PCI_P2PDMA_MAP_THRU_HOST_BRIDGE :/*
@@ -1449,6 +1452,7 @@ int iommu_dma_map_sg(struct device *dev, struct scatterlist *sg, int nents, goto out_restore_sg; } +post_pci_p2pdma:sg_dma_address (s) = s_iova_off;sg_dma_len (s) = s_length; s->offset -= s_iova_off;
Signature · 1 line
2.25.1
Quoted 4 lines · Ashish Mhetre
When mapping scatter-gather entries that reference reserved memory regions without struct page backing (e.g., bootloader created carveouts),
is_pci_p2pdma_page()dereferences the page pointer returned bysg_page()without first verifying its validity.
I believe this behavior started after commit 88df6ab2f34b ("mm: add folio_is_pci_p2pdma()"). Prior to that change, the is_zone_device_page(page) check would return false when given a non‑existent page pointer.
If any fix is needed, the is_pci_p2pdma_page() must be changed and not iommu.
Thanks
Quoted 46 lines
This causes a kernel paging fault when
CONFIG_PCI_P2PDMAis enabled anddma_map_sg_attrs()is called for memory regions that have no associated struct page:Unable to handle kernel paging request at virtual address fffffc007d100000 ... Call trace: iommu_dma_map_sg+0x118/0x414 dma_map_sg_attrs+0x38/0x44Fix this by adding a
pfn_valid()check before callingis_pci_p2pdma_page(). If the page frame number is invalid, skip the P2PDMA check entirely as such memory cannot be P2PDMA memory anyway.Signed-off-by Ashish Mhetre <[email protected]>--- drivers/iommu/dma-iommu.c | 4 ++++ 1 file changed, 4 insertions(+)drivers/iommu/dma-iommu.c +4
-0@@ -1423,6 +1423,9 @@ int iommu_dma_map_sg(struct device *dev, struct scatterlist *sg, int nents,size_t s_length = s->length;size_t pad_len = (mask - iova_len +1 ) & mask; +if (!pfn_valid (page_to_pfn (sg_page (s)))) + goto post_pci_p2pdma; +switch (pci_p2pdma_state (&p2pdma_state, dev,sg_page (s))) {case PCI_P2PDMA_MAP_THRU_HOST_BRIDGE :/* @@ -1449,6 +1452,7 @@ int iommu_dma_map_sg(struct device *dev, struct scatterlist *sg, int nents, goto out_restore_sg; } +post_pci_p2pdma:sg_dma_address (s) = s_iova_off;sg_dma_len (s) = s_length; s->offset -= s_iova_off;Signature · 1 line
2.25.1
Quoted 11 lines · Leon Romanovsky
Quoted 4 lines · Ashish Mhetre
When mapping scatter-gather entries that reference reserved memory regions without struct page backing (e.g., bootloader created carveouts),
is_pci_p2pdma_page()dereferences the page pointer returned bysg_page()without first verifying its validity.I believe this behavior started after commit
88df6ab2f34b("mm: addfolio_is_pci_p2pdma()"). Prior to that change, theis_zone_device_page(page)check would return false when given a non‑existent page pointer.
Doesn't folio_is_pci_p2pdma() also check for zone device? I see[1] that it does:
static inline bool folio_is_pci_p2pdma(const struct folio *folio)
{
return IS_ENABLED(CONFIG_PCI_P2PDMA) &&
folio_is_zone_device(folio) &&
folio->pgmap->type == MEMORY_DEVICE_PCI_P2PDMA;
}I believe the problem arises due to the page_folio() call in folio_is_pci_p2pdma(page_folio(page)); within is_pci_p2pdma_page(). page_folio() assumes it has a valid struct page to work with. For these carveouts, that isn't true.
Potentially something like the following would stop the crash:
include/linux/memremap.h +2 -1
@@ -197,7 +197,8 @@ static inline void folio_set_zone_device_data(struct folio *folio, void *data)static inline bool is_pci_p2pdma_page (const struct page *page) { -return IS_ENABLED (CONFIG_PCI_P2PDMA ) && +return IS_ENABLED (CONFIG_PCI_P2PDMA ) && page && +pfn_valid (page_to_pfn (page)) &&folio_is_pci_p2pdma (page_folio (page)); }
But my broader question is: why are we calling a page-based API like is_pci_p2pdma_page() on non-struct-page memory in the first place? Could we instead add a helper to verify if the sg_page() return value is actually backed by a struct page? If it isn't, we should arguably skip the P2PDMA logic entirely and fall back to a dma_map_phys style path. Isn't handling these "pageless" physical ranges the primary reason dma_map_phys exists?
+mm list
Thanks,
Praan
[1] https://elixir.bootlin.com/linux/v6.19.3/source/include/linux/memremap.h#L179
Quoted 51 lines
If any fix is needed, the
is_pci_p2pdma_page()must be changed and not iommu.Thanks
Quoted 46 lines
This causes a kernel paging fault when
CONFIG_PCI_P2PDMAis enabled anddma_map_sg_attrs()is called for memory regions that have no associated struct page:Unable to handle kernel paging request at virtual address fffffc007d100000 ... Call trace: iommu_dma_map_sg+0x118/0x414 dma_map_sg_attrs+0x38/0x44Fix this by adding a
pfn_valid()check before callingis_pci_p2pdma_page(). If the page frame number is invalid, skip the P2PDMA check entirely as such memory cannot be P2PDMA memory anyway.Signed-off-by Ashish Mhetre <[email protected]>--- drivers/iommu/dma-iommu.c | 4 ++++ 1 file changed, 4 insertions(+)drivers/iommu/dma-iommu.c +4
-0@@ -1423,6 +1423,9 @@ int iommu_dma_map_sg(struct device *dev, struct scatterlist *sg, int nents,size_t s_length = s->length;size_t pad_len = (mask - iova_len +1 ) & mask; +if (!pfn_valid (page_to_pfn (sg_page (s)))) + goto post_pci_p2pdma; +switch (pci_p2pdma_state (&p2pdma_state, dev,sg_page (s))) {case PCI_P2PDMA_MAP_THRU_HOST_BRIDGE :/* @@ -1449,6 +1452,7 @@ int iommu_dma_map_sg(struct device *dev, struct scatterlist *sg, int nents, goto out_restore_sg; } +post_pci_p2pdma:sg_dma_address (s) = s_iova_off;sg_dma_len (s) = s_length; s->offset -= s_iova_off;Signature · 1 line
2.25.1
Quoted 14 lines · Pranjal Shrivastava
External email: Use caution opening links or attachments
Quoted 10 lines · Leon Romanovsky
Quoted 4 lines · Ashish Mhetre
When mapping scatter-gather entries that reference reserved memory regions without struct page backing (e.g., bootloader created carveouts),
is_pci_p2pdma_page()dereferences the page pointer returned bysg_page()without first verifying its validity.I believe this behavior started after commit
88df6ab2f34b("mm: addfolio_is_pci_p2pdma()"). Prior to that change, theis_zone_device_page(page)check would return false when given a non‑existent page pointer.
Thanks Leon for the review. This crash started after commit 30280eee2db1 ("iommu/dma: support PCI P2PDMA pages in dma-iommu map_sg").
Quoted 22 lines
Doesn't
folio_is_pci_p2pdma()also check for zone device? I see[1] that it does:static inline bool
folio_is_pci_p2pdma(const struct folio *folio){ return IS_ENABLED(CONFIG_PCI_P2PDMA) && folio_is_zone_device(folio) && folio->pgmap->type == MEMORY_DEVICE_PCI_P2PDMA; }I believe the problem arises due to the
page_folio()call in folio_is_pci_p2pdma(page_folio(page)); withinis_pci_p2pdma_page().page_folio()assumes it has a valid struct page to work with. For these carveouts, that isn't true.Potentially something like the following would stop the crash:
include/linux/memremap.h +0
-0
include/linux/memremap.h static inline void folio_set_zone_device_data(struct folio *folio, void *data) · line 204
Quoted 9 lines
include/linux/memremap.h +2
-1@@ -197,7 +197,8 @@ static inline void folio_set_zone_device_data(struct folio *folio, void *data)static inline bool is_pci_p2pdma_page (const struct page *page) { -return IS_ENABLED (CONFIG_PCI_P2PDMA ) && +return IS_ENABLED (CONFIG_PCI_P2PDMA ) && page && +pfn_valid (page_to_pfn (page)) &&folio_is_pci_p2pdma (page_folio (page)); }
Yes, this will also fix the crash.
Quoted 7 lines
But my broader question is: why are we calling a page-based API like
is_pci_p2pdma_page()on non-struct-page memory in the first place? Could we instead add a helper to verify if thesg_page()return value is actually backed by a struct page? If it isn't, we should arguably skip the P2PDMA logic entirely and fall back to adma_map_physstyle path. Isn't handling these "pageless" physical ranges the primary reasondma_map_physexists?
Thanks for the feedback, Pranjal.
To clarify: are you suggesting we handle non-page-backed mappings inside iommu_dma_map_sg (within dma-iommu), or that callers should detect non-page-backed memory and use dma_map_phys instead of dma_map_sg? Former approach sounds better so that existing iommu_dma_map_sg callers don't need changes, but I'd like to confirm your preference.
Quoted 57 lines
+mm list
Thanks,
Praan[1] https://elixir.bootlin.com/linux/v6.19.3/source/include/linux/memremap.h#L179
Quoted 49 lines
If any fix is needed, the
is_pci_p2pdma_page()must be changed and not iommu.Thanks
Quoted 45 lines
This causes a kernel paging fault when
CONFIG_PCI_P2PDMAis enabled anddma_map_sg_attrs()is called for memory regions that have no associated struct page:Unable to handle kernel paging request at virtual address fffffc007d100000 ... Call trace: iommu_dma_map_sg+0x118/0x414 dma_map_sg_attrs+0x38/0x44Fix this by adding a
pfn_valid()check before callingis_pci_p2pdma_page(). If the page frame number is invalid, skip the P2PDMA check entirely as such memory cannot be P2PDMA memory anyway.Signed-off-by Ashish Mhetre <[email protected]>--- drivers/iommu/dma-iommu.c | 4 ++++ 1 file changed, 4 insertions(+)drivers/iommu/dma-iommu.c +4
-1@@ -1423,6 +1423,9 @@ int iommu_dma_map_sg(struct device *dev, struct scatterlist *sg, int nents,size_t s_length = s->length;size_t pad_len = (mask - iova_len +1 ) & mask; +if (!pfn_valid (page_to_pfn (sg_page (s)))) + goto post_pci_p2pdma; +switch (pci_p2pdma_state (&p2pdma_state, dev,sg_page (s))) {case PCI_P2PDMA_MAP_THRU_HOST_BRIDGE :/* @@ -1449,6 +1452,7 @@ int iommu_dma_map_sg(struct device *dev, struct scatterlist *sg, int nents, goto out_restore_sg; } +post_pci_p2pdma:sg_dma_address (s) = s_iova_off;sg_dma_len (s) = s_length; s->offset -= s_iova_off; --2.25.1
Quoted 63 lines · Ashish Mhetre
Quoted 14 lines · Pranjal Shrivastava
External email: Use caution opening links or attachments
Quoted 10 lines · Leon Romanovsky
Quoted 4 lines · Ashish Mhetre
When mapping scatter-gather entries that reference reserved memory regions without struct page backing (e.g., bootloader created carveouts),
is_pci_p2pdma_page()dereferences the page pointer returned bysg_page()without first verifying its validity.I believe this behavior started after commit
88df6ab2f34b("mm: addfolio_is_pci_p2pdma()"). Prior to that change, theis_zone_device_page(page)check would return false when given a non‑existent page pointer.Thanks Leon for the review. This crash started after commit
30280eee2db1("iommu/dma: support PCI P2PDMA pages in dma-iommumap_sg").Quoted 22 lines
Doesn't
folio_is_pci_p2pdma()also check for zone device? I see[1] that it does:static inline bool
folio_is_pci_p2pdma(const struct folio *folio){ return IS_ENABLED(CONFIG_PCI_P2PDMA) && folio_is_zone_device(folio) && folio->pgmap->type == MEMORY_DEVICE_PCI_P2PDMA; }I believe the problem arises due to the
page_folio()call in folio_is_pci_p2pdma(page_folio(page)); withinis_pci_p2pdma_page().page_folio()assumes it has a valid struct page to work with. For these carveouts, that isn't true.Potentially something like the following would stop the crash:
include/linux/memremap.h +0
-0include/linux/memremap.h static inline void folio_set_zone_device_data(struct folio *folio, void *data) · line 204
Quoted 9 lines
include/linux/memremap.h +2
-1@@ -197,7 +197,8 @@ static inline void folio_set_zone_device_data(struct folio *folio, void *data)static inline bool is_pci_p2pdma_page (const struct page *page) { -return IS_ENABLED (CONFIG_PCI_P2PDMA ) && +return IS_ENABLED (CONFIG_PCI_P2PDMA ) && page && +pfn_valid (page_to_pfn (page)) &&folio_is_pci_p2pdma (page_folio (page)); }Yes, this will also fix the crash.
Quoted 7 lines
But my broader question is: why are we calling a page-based API like
is_pci_p2pdma_page()on non-struct-page memory in the first place? Could we instead add a helper to verify if thesg_page()return value is actually backed by a struct page? If it isn't, we should arguably skip the P2PDMA logic entirely and fall back to adma_map_physstyle path. Isn't handling these "pageless" physical ranges the primary reasondma_map_physexists?
Quoted 5 lines
Thanks for the feedback, Pranjal.
To clarify: are you suggesting we handle non-page-backed mappings inside
iommu_dma_map_sg(within dma-iommu), or that callers should detect non-page-backed memory and usedma_map_physinstead ofdma_map_sg?
The latter one.
Quoted 2 lines
Former approach sounds better so that existing
iommu_dma_map_sgcallers don't need changes, but I'd like to confirm your preference.
The bug is in callers which used wrong API, they need to be adapted.
Thanks
Quoted 64 lines · Leon Romanovsky
Quoted 63 lines · Ashish Mhetre
Quoted 14 lines · Pranjal Shrivastava
External email: Use caution opening links or attachments
Quoted 10 lines · Leon Romanovsky
Quoted 4 lines · Ashish Mhetre
When mapping scatter-gather entries that reference reserved memory regions without struct page backing (e.g., bootloader created carveouts),
is_pci_p2pdma_page()dereferences the page pointer returned bysg_page()without first verifying its validity.I believe this behavior started after commit
88df6ab2f34b("mm: addfolio_is_pci_p2pdma()"). Prior to that change, theis_zone_device_page(page)check would return false when given a non‑existent page pointer.Thanks Leon for the review. This crash started after commit
30280eee2db1("iommu/dma: support PCI P2PDMA pages in dma-iommumap_sg").Quoted 22 lines
Doesn't
folio_is_pci_p2pdma()also check for zone device? I see[1] that it does:static inline bool
folio_is_pci_p2pdma(const struct folio *folio){ return IS_ENABLED(CONFIG_PCI_P2PDMA) && folio_is_zone_device(folio) && folio->pgmap->type == MEMORY_DEVICE_PCI_P2PDMA; }I believe the problem arises due to the
page_folio()call in folio_is_pci_p2pdma(page_folio(page)); withinis_pci_p2pdma_page().page_folio()assumes it has a valid struct page to work with. For these carveouts, that isn't true.Potentially something like the following would stop the crash:
include/linux/memremap.h +0
-0include/linux/memremap.h static inline void folio_set_zone_device_data(struct folio *folio, void *data) · line 204
Quoted 9 lines
include/linux/memremap.h +2
-1@@ -197,7 +197,8 @@ static inline void folio_set_zone_device_data(struct folio *folio, void *data)static inline bool is_pci_p2pdma_page (const struct page *page) { -return IS_ENABLED (CONFIG_PCI_P2PDMA ) && +return IS_ENABLED (CONFIG_PCI_P2PDMA ) && page && +pfn_valid (page_to_pfn (page)) &&folio_is_pci_p2pdma (page_folio (page)); }Yes, this will also fix the crash.
Quoted 7 lines
But my broader question is: why are we calling a page-based API like
is_pci_p2pdma_page()on non-struct-page memory in the first place? Could we instead add a helper to verify if thesg_page()return value is actually backed by a struct page? If it isn't, we should arguably skip the P2PDMA logic entirely and fall back to adma_map_physstyle path. Isn't handling these "pageless" physical ranges the primary reasondma_map_physexists?
Quoted 8 lines
Quoted 5 lines
Thanks for the feedback, Pranjal.
To clarify: are you suggesting we handle non-page-backed mappings inside
iommu_dma_map_sg(within dma-iommu), or that callers should detect non-page-backed memory and usedma_map_physinstead ofdma_map_sg?The latter one.
Yup, I meant the latter.
Quoted 4 lines
Quoted 2 lines
Former approach sounds better so that existing
iommu_dma_map_sgcallers don't need changes, but I'd like to confirm your preference.The bug is in callers which used wrong API, they need to be adapted.
Yes, the thing is, if the caller already knows that the region to be mapped is NOT struct page-backed, then why does it use dma_map_sg variants?
Thanks
Praan
Quoted 76 lines · Pranjal Shrivastava
Quoted 64 lines · Leon Romanovsky
Quoted 63 lines · Ashish Mhetre
Quoted 14 lines · Pranjal Shrivastava
External email: Use caution opening links or attachments
Quoted 10 lines · Leon Romanovsky
Quoted 4 lines · Ashish Mhetre
When mapping scatter-gather entries that reference reserved memory regions without struct page backing (e.g., bootloader created carveouts),
is_pci_p2pdma_page()dereferences the page pointer returned bysg_page()without first verifying its validity.I believe this behavior started after commit
88df6ab2f34b("mm: addfolio_is_pci_p2pdma()"). Prior to that change, theis_zone_device_page(page)check would return false when given a non‑existent page pointer.Thanks Leon for the review. This crash started after commit
30280eee2db1("iommu/dma: support PCI P2PDMA pages in dma-iommumap_sg").Quoted 22 lines
Doesn't
folio_is_pci_p2pdma()also check for zone device? I see[1] that it does:static inline bool
folio_is_pci_p2pdma(const struct folio *folio){ return IS_ENABLED(CONFIG_PCI_P2PDMA) && folio_is_zone_device(folio) && folio->pgmap->type == MEMORY_DEVICE_PCI_P2PDMA; }I believe the problem arises due to the
page_folio()call in folio_is_pci_p2pdma(page_folio(page)); withinis_pci_p2pdma_page().page_folio()assumes it has a valid struct page to work with. For these carveouts, that isn't true.Potentially something like the following would stop the crash:
include/linux/memremap.h +0
-0include/linux/memremap.h static inline void folio_set_zone_device_data(struct folio *folio, void *data) · line 204
Quoted 9 lines
include/linux/memremap.h +2
-1@@ -197,7 +197,8 @@ static inline void folio_set_zone_device_data(struct folio *folio, void *data)static inline bool is_pci_p2pdma_page (const struct page *page) { -return IS_ENABLED (CONFIG_PCI_P2PDMA ) && +return IS_ENABLED (CONFIG_PCI_P2PDMA ) && page && +pfn_valid (page_to_pfn (page)) &&folio_is_pci_p2pdma (page_folio (page)); }Yes, this will also fix the crash.
Quoted 7 lines
But my broader question is: why are we calling a page-based API like
is_pci_p2pdma_page()on non-struct-page memory in the first place? Could we instead add a helper to verify if thesg_page()return value is actually backed by a struct page? If it isn't, we should arguably skip the P2PDMA logic entirely and fall back to adma_map_physstyle path. Isn't handling these "pageless" physical ranges the primary reasondma_map_physexists?Quoted 8 lines
Quoted 5 lines
Thanks for the feedback, Pranjal.
To clarify: are you suggesting we handle non-page-backed mappings inside
iommu_dma_map_sg(within dma-iommu), or that callers should detect non-page-backed memory and usedma_map_physinstead ofdma_map_sg?The latter one.
Yup, I meant the latter.
Quoted 8 lines
Quoted 4 lines
Quoted 2 lines
Former approach sounds better so that existing
iommu_dma_map_sgcallers don't need changes, but I'd like to confirm your preference.The bug is in callers which used wrong API, they need to be adapted.
Yes, the thing is, if the caller already knows that the region to be mapped is NOT struct page-backed, then why does it use
dma_map_sgvariants?
Before dma_map_phys() was added, there was no reliable way to DMA‑map such memory, and using dma_map_sg() was a workaround that happened to work. I'm not sure whether it worked by design or by accident, but the correct approach now is to use dma_map_phys().
Thanks
Quoted 3 lines
Thanks
Praan
Quoted 76 lines · Leon Romanovsky
External email: Use caution opening links or attachments
Quoted 72 lines · Pranjal Shrivastava
Quoted 60 lines · Leon Romanovsky
Quoted 59 lines · Ashish Mhetre
Quoted 14 lines · Pranjal Shrivastava
External email: Use caution opening links or attachments
Quoted 10 lines · Leon Romanovsky
Quoted 4 lines · Ashish Mhetre
When mapping scatter-gather entries that reference reserved memory regions without struct page backing (e.g., bootloader created carveouts),
is_pci_p2pdma_page()dereferences the page pointer returned bysg_page()without first verifying its validity.I believe this behavior started after commit
88df6ab2f34b("mm: addfolio_is_pci_p2pdma()"). Prior to that change, theis_zone_device_page(page)check would return false when given a non‑existent page pointer.Thanks Leon for the review. This crash started after commit
30280eee2db1("iommu/dma: support PCI P2PDMA pages in dma-iommumap_sg").Quoted 22 lines
Doesn't
folio_is_pci_p2pdma()also check for zone device? I see[1] that it does:static inline bool
folio_is_pci_p2pdma(const struct folio *folio){ return IS_ENABLED(CONFIG_PCI_P2PDMA) && folio_is_zone_device(folio) && folio->pgmap->type == MEMORY_DEVICE_PCI_P2PDMA; }I believe the problem arises due to the
page_folio()call in folio_is_pci_p2pdma(page_folio(page)); withinis_pci_p2pdma_page().page_folio()assumes it has a valid struct page to work with. For these carveouts, that isn't true.Potentially something like the following would stop the crash:
include/linux/memremap.h +0
-0include/linux/memremap.h static inline void folio_set_zone_device_data(struct folio *folio, void *data) · line 204
Quoted 9 lines
include/linux/memremap.h +2
-1@@ -197,7 +197,8 @@ static inline void folio_set_zone_device_data(struct folio *folio, void *data)static inline bool is_pci_p2pdma_page (const struct page *page) { -return IS_ENABLED (CONFIG_PCI_P2PDMA ) && +return IS_ENABLED (CONFIG_PCI_P2PDMA ) && page && +pfn_valid (page_to_pfn (page)) &&folio_is_pci_p2pdma (page_folio (page)); }Yes, this will also fix the crash.
Quoted 7 lines
But my broader question is: why are we calling a page-based API like
is_pci_p2pdma_page()on non-struct-page memory in the first place? Could we instead add a helper to verify if thesg_page()return value is actually backed by a struct page? If it isn't, we should arguably skip the P2PDMA logic entirely and fall back to adma_map_physstyle path. Isn't handling these "pageless" physical ranges the primary reasondma_map_physexists?Quoted 7 lines
Quoted 5 lines
Thanks for the feedback, Pranjal.
To clarify: are you suggesting we handle non-page-backed mappings inside
iommu_dma_map_sg(within dma-iommu), or that callers should detect non-page-backed memory and usedma_map_physinstead ofdma_map_sg?The latter one.
Yup, I meant the latter.
Quoted 2 lines
Quoted 2 lines
Former approach sounds better so that existing
iommu_dma_map_sgcallers don't need changes, but I'd like to confirm your preference.
Quoted 8 lines
Quoted 4 lines
Quoted 1 line
The bug is in callers which used wrong API, they need to be adapted.
Yes, the thing is, if the caller already knows that the region to be mapped is NOT struct page-backed, then why does it use
dma_map_sgvariants?Before
dma_map_phys()was added, there was no reliable way to DMA‑map such memory, and usingdma_map_sg()was a workaround that happened to work. I'm not sure whether it worked by design or by accident, but the correct approach now is to usedma_map_phys().
Thanks Leon and Pranjal for the detailed feedback. I'll update our callers to use dma_map_phys() for non-page-backed buffers.
One question: would it make sense to add a check in iommu_dma_map_sg to fail gracefully when non-page-backed buffers are passed, instead of crashing the kernel?
Thanks,
Ashish Mhetre
Quoted 4 lines
Thanks
Quoted 2 lines
Thanks
Praan
Robin Murphy
maintainerQuoted 89 lines · Ashish Mhetre
Quoted 77 lines · Leon Romanovsky
External email: Use caution opening links or attachments
Quoted 73 lines · Pranjal Shrivastava
Quoted 61 lines · Leon Romanovsky
Quoted 60 lines · Ashish Mhetre
Quoted 14 lines · Pranjal Shrivastava
External email: Use caution opening links or attachments
Quoted 10 lines · Leon Romanovsky
Quoted 4 lines · Ashish Mhetre
When mapping scatter-gather entries that reference reserved memory regions without struct page backing (e.g., bootloader created carveouts),
is_pci_p2pdma_page()dereferences the page pointer returned bysg_page()without first verifying its validity.I believe this behavior started after commit
88df6ab2f34b("mm: addfolio_is_pci_p2pdma()"). Prior to that change, theis_zone_device_page(page)check would return false when given a non‑existent page pointer.Thanks Leon for the review. This crash started after commit
30280eee2db1("iommu/dma: support PCI P2PDMA pages in dma-iommumap_sg").Quoted 23 lines
Doesn't
folio_is_pci_p2pdma()also check for zone device? I see[1] that it does:static inline bool
folio_is_pci_p2pdma(const struct folio *folio){
returnIS_ENABLED(CONFIG_PCI_P2PDMA)&&folio_is_zone_device(folio)&&folio->pgmap->type==MEMORY_DEVICE_PCI_P2PDMA; }I believe the problem arises due to the
page_folio()call in folio_is_pci_p2pdma(page_folio(page)); withinis_pci_p2pdma_page().page_folio()assumes it has a valid struct page to work with. For these carveouts, that isn't true.Potentially something like the following would stop the crash:
include/linux/memremap.h +0
-0include/linux/memremap.h static inline void · line 204
Quoted 9 lines
include/linux/memremap.h +2
-1@@ -197,7 +197,8 @@ static inline void folio_set_zone_device_data(struct folio *folio, void *data) static inline bool is_pci_p2pdma_page(const struct page *page) { - return IS_ENABLED(CONFIG_PCI_P2PDMA) && + return IS_ENABLED(CONFIG_PCI_P2PDMA) && page && + pfn_valid(page_to_pfn(page)) && folio_is_pci_p2pdma(page_folio(page)); }Yes, this will also fix the crash.
Quoted 7 lines
But my broader question is: why are we calling a page-based API like
is_pci_p2pdma_page()on non-struct-page memory in the first place? Could we instead add a helper to verify if thesg_page()return value is actually backed by a struct page? If it isn't, we should arguably skip the P2PDMA logic entirely and fall back to adma_map_physstyle path. Isn't handling these "pageless" physical ranges the primary reasondma_map_physexists?Quoted 7 lines
Quoted 5 lines
Thanks for the feedback, Pranjal.
To clarify: are you suggesting we handle non-page-backed mappings inside
iommu_dma_map_sg(within dma-iommu), or that callers should detect non-page-backed memory and usedma_map_physinstead ofdma_map_sg?The latter one.
Yup, I meant the latter.
Quoted 2 lines
Quoted 2 lines
Former approach sounds better so that existing
iommu_dma_map_sgcallers don't need changes, but I'd like to confirm your preference.Quoted 8 lines
Quoted 4 lines
Quoted 1 line
The bug is in callers which used wrong API, they need to be adapted.
Yes, the thing is, if the caller already knows that the region to be mapped is NOT struct page-backed, then why does it use
dma_map_sgvariants?Before
dma_map_phys()was added, there was no reliable way to DMA‑map such memory, and usingdma_map_sg()was a workaround that happened to work. I'm not sure whether it worked by design or by accident, but the correct approach now is to usedma_map_phys().
Quoted 6 lines
Thanks Leon and Pranjal for the detailed feedback. I'll update our callers to use
dma_map_phys()for non-page-backed buffers.One question: would it make sense to add a check in
iommu_dma_map_sgto fail gracefully when non-page-backed buffers are passed, instead of crashing the kernel?
No, it is the responsibility of drivers not to abuse kernel APIs inappropriately. Checking for misuse adds overhead that penalises correct users. dma_map_page/sg on non-page-backed memory has never been valid, and it would only have been system-configuration-dependent luck that it wasn't already blowing up before. I guess dma-debug could add additional checks on these APIs similarly to debug_dma_map_single(), but the fact that we've never even considered checking for made-up bogus struct page pointers only goes to show just how wrong a thing to do it is.
Thanks,
Robin.
Quoted 77 lines · Ashish Mhetre
Quoted 74 lines · Leon Romanovsky
External email: Use caution opening links or attachments
Quoted 70 lines · Pranjal Shrivastava
Quoted 60 lines · Leon Romanovsky
Quoted 59 lines · Ashish Mhetre
Quoted 14 lines · Pranjal Shrivastava
External email: Use caution opening links or attachments
Quoted 10 lines · Leon Romanovsky
Quoted 4 lines · Ashish Mhetre
When mapping scatter-gather entries that reference reserved memory regions without struct page backing (e.g., bootloader created carveouts),
is_pci_p2pdma_page()dereferences the page pointer returned bysg_page()without first verifying its validity.I believe this behavior started after commit
88df6ab2f34b("mm: addfolio_is_pci_p2pdma()"). Prior to that change, theis_zone_device_page(page)check would return false when given a non‑existent page pointer.Thanks Leon for the review. This crash started after commit
30280eee2db1("iommu/dma: support PCI P2PDMA pages in dma-iommumap_sg").Quoted 22 lines
Doesn't
folio_is_pci_p2pdma()also check for zone device? I see[1] that it does:static inline bool
folio_is_pci_p2pdma(const struct folio *folio){ return IS_ENABLED(CONFIG_PCI_P2PDMA) && folio_is_zone_device(folio) && folio->pgmap->type == MEMORY_DEVICE_PCI_P2PDMA; }I believe the problem arises due to the
page_folio()call in folio_is_pci_p2pdma(page_folio(page)); withinis_pci_p2pdma_page().page_folio()assumes it has a valid struct page to work with. For these carveouts, that isn't true.Potentially something like the following would stop the crash:
include/linux/memremap.h +0
-0include/linux/memremap.h static inline void folio_set_zone_device_data(struct folio *folio, void *data) · line 204
Quoted 9 lines
include/linux/memremap.h +2
-1@@ -197,7 +197,8 @@ static inline void folio_set_zone_device_data(struct folio *folio, void *data)static inline bool is_pci_p2pdma_page (const struct page *page) { -return IS_ENABLED (CONFIG_PCI_P2PDMA ) && +return IS_ENABLED (CONFIG_PCI_P2PDMA ) && page && +pfn_valid (page_to_pfn (page)) &&folio_is_pci_p2pdma (page_folio (page)); }Yes, this will also fix the crash.
Quoted 7 lines
But my broader question is: why are we calling a page-based API like
is_pci_p2pdma_page()on non-struct-page memory in the first place? Could we instead add a helper to verify if thesg_page()return value is actually backed by a struct page? If it isn't, we should arguably skip the P2PDMA logic entirely and fall back to adma_map_physstyle path. Isn't handling these "pageless" physical ranges the primary reasondma_map_physexists?Quoted 7 lines
Quoted 5 lines
Thanks for the feedback, Pranjal.
To clarify: are you suggesting we handle non-page-backed mappings inside
iommu_dma_map_sg(within dma-iommu), or that callers should detect non-page-backed memory and usedma_map_physinstead ofdma_map_sg?The latter one.
Yup, I meant the latter.
Quoted 8 lines
Quoted 8 lines
Quoted 6 lines
Quoted 3 lines
Quoted 2 lines
Former approach sounds better so that existing
iommu_dma_map_sgcallers don't need changes, but I'd like to confirm your preference.The bug is in callers which used wrong API, they need to be adapted.
Yes, the thing is, if the caller already knows that the region to be mapped is NOT struct page-backed, then why does it use
dma_map_sgvariants?Before
dma_map_phys()was added, there was no reliable way to DMA‑map such memory, and usingdma_map_sg()was a workaround that happened to
Ack.
Quoted 10 lines
Quoted 2 lines
work. I'm not sure whether it worked by design or by accident, but the correct approach now is to use
dma_map_phys().Thanks Leon and Pranjal for the detailed feedback. I'll update our callers to use
dma_map_phys()for non-page-backed buffers.One question: would it make sense to add a check in
iommu_dma_map_sgto fail gracefully when non-page-backed buffers are passed, instead of crashing the kernel?
In my opinion, the answer is no, since this is almost like the "should the kernel protect developers from themselves" debate.. we should be a little dramatic to make sure the developer doesn't call the wrong API. Sure, we could return a DMA_MAPPING_ERROR or something but a silent DMA_MAPPING_ERROR can be ignored by a lazy driver resulting in a much harder-to-debug scenario than a straight-forward crash.
The question is, are we sure to use scatterlists to represent non-paged memory?
If no, then why are we even calling the dma_map_sg* API? struct scatterlist has a field "page_link" [1] which is literally the struct page with a few bits representing something else.
If yes, then we could maybe encode some information (similar to SG_CHAIN) representing if the sg is backed by a struct page. And then in the *sg_map APIs, we could fallback to the dma_phys API if it isn't struct paged-backed. (This would be quite some re-work and not limited to the DMA API alone).
But as Leon pointed out that the use of sg for non-paged memory started as a "work-around" since there was no equivalent API to dma_map_phys earlier. Since that's the status quo, I'm leaning towards no.
But I think this gives us a nice opportunity to discuss if we really *need* to have scatterlists to represent non-paged memory. I remember some similar discussion happened during tcp_devmem reviews [2].
Adding Jason for his thoughts as well..
Thanks,
Praan
[1] https://elixir.bootlin.com/linux/v6.19.3/source/include/linux/scatterlist.h#L12
[2] https://lore.kernel.org/netdev/[email protected]/
Quoted 2 lines · Pranjal Shrivastava
The question is, are we sure to use scatterlists to represent non-paged memory?
This is absolutely illegal and a driver bug to put non-struct page memory into a scatter list. It was never an acceptable "work around". What driver is doing this??
If you want to improve robustness add some pfn_valid/etc checks under the CONFING DMA DEBUG and throw warns for these mistakes.
Jason
Quoted 23 lines · Pranjal Shrivastava
Quoted 11 lines · Leon Romanovsky
Quoted 4 lines · Ashish Mhetre
When mapping scatter-gather entries that reference reserved memory regions without struct page backing (e.g., bootloader created carveouts),
is_pci_p2pdma_page()dereferences the page pointer returned bysg_page()without first verifying its validity.I believe this behavior started after commit
88df6ab2f34b("mm: addfolio_is_pci_p2pdma()"). Prior to that change, theis_zone_device_page(page)check would return false when given a non‑existent page pointer.Doesn't
folio_is_pci_p2pdma()also check for zone device? I see[1] that it does:static inline bool
folio_is_pci_p2pdma(const struct folio *folio){ return IS_ENABLED(CONFIG_PCI_P2PDMA) && folio_is_zone_device(folio) && folio->pgmap->type == MEMORY_DEVICE_PCI_P2PDMA; }
Quoted 4 lines
I believe the problem arises due to the
page_folio()call in folio_is_pci_p2pdma(page_folio(page)); withinis_pci_p2pdma_page().page_folio()assumes it has a valid struct page to work with. For these carveouts, that isn't true.
Yes, i came to the same conclusion, just explained why it worked before.
Quoted 8 lines
Potentially something like the following would stop the crash:
include/linux/memremap.h +0
-0
include/linux/memremap.h static inline void folio_set_zone_device_data(struct folio *folio, void *data) · line 201
Quoted 6 lines
include/linux/memremap.h +2
-1@@ -197,7 +197,8 @@ static inline void folio_set_zone_device_data(struct folio *folio, void *data)static inline bool is_pci_p2pdma_page (const struct page *page) { - return IS_ENABLED(CONFIG_PCI_P2PDMA) && +return IS_ENABLED (CONFIG_PCI_P2PDMA ) && page && + pfn_valid(page_to_pfn(page)) &&
pfn_valid() is a relatively expensive function [1] to invoke in the data path, and is_pci_p2pdma_page() ends up being called in these execution flows.
[1] https://elixir.bootlin.com/linux/v6.19.3/source/include/linux/mmzone.h#L2167
Quoted 6 lines
include/linux/memremap.h +0
-0folio_is_pci_p2pdma (page_folio (page)); }But my broader question is: why are we calling a page-based API like
is_pci_p2pdma_page()on non-struct-page memory in the first place?
+1
Quoted 2 lines
Could we instead add a helper to verify if the
sg_page()return value is actually backed by a struct page?
According to the SG design, callers should store only struct page pointers. There is one known user that violates this requirement: dmabuf, which is gradually being migrated away from this behavior [2].
[2] https://lore.kernel.org/all/[email protected]/
Quoted 3 lines
If it isn't, we should arguably skip the P2PDMA logic entirely and fall back to a
dma_map_physstyle path. Isn't handling these "pageless" physical ranges the primary reasondma_map_physexists?
Right. dma_map_sg() is indeed the wrong API to use for memory that is not backed by struct page pointers.
Thanks
Quoted 60 lines
+mm list
Thanks,
Praan[1] https://elixir.bootlin.com/linux/v6.19.3/source/include/linux/memremap.h#L179
Quoted 51 lines
If any fix is needed, the
is_pci_p2pdma_page()must be changed and not iommu.Thanks
Quoted 46 lines
This causes a kernel paging fault when
CONFIG_PCI_P2PDMAis enabled anddma_map_sg_attrs()is called for memory regions that have no associated struct page:Unable to handle kernel paging request at virtual address fffffc007d100000 ... Call trace: iommu_dma_map_sg+0x118/0x414 dma_map_sg_attrs+0x38/0x44Fix this by adding a
pfn_valid()check before callingis_pci_p2pdma_page(). If the page frame number is invalid, skip the P2PDMA check entirely as such memory cannot be P2PDMA memory anyway.Signed-off-by Ashish Mhetre <[email protected]>--- drivers/iommu/dma-iommu.c | 4 ++++ 1 file changed, 4 insertions(+)drivers/iommu/dma-iommu.c +4
-0@@ -1423,6 +1423,9 @@ int iommu_dma_map_sg(struct device *dev, struct scatterlist *sg, int nents,size_t s_length = s->length;size_t pad_len = (mask - iova_len +1 ) & mask; +if (!pfn_valid (page_to_pfn (sg_page (s)))) + goto post_pci_p2pdma; +switch (pci_p2pdma_state (&p2pdma_state, dev,sg_page (s))) {case PCI_P2PDMA_MAP_THRU_HOST_BRIDGE :/* @@ -1449,6 +1452,7 @@ int iommu_dma_map_sg(struct device *dev, struct scatterlist *sg, int nents, goto out_restore_sg; } +post_pci_p2pdma:sg_dma_address (s) = s_iova_off;sg_dma_len (s) = s_length; s->offset -= s_iova_off;Signature · 1 line
2.25.1
Quoted 24 lines · Leon Romanovsky
Quoted 23 lines · Pranjal Shrivastava
Quoted 11 lines · Leon Romanovsky
Quoted 4 lines · Ashish Mhetre
When mapping scatter-gather entries that reference reserved memory regions without struct page backing (e.g., bootloader created carveouts),
is_pci_p2pdma_page()dereferences the page pointer returned bysg_page()without first verifying its validity.I believe this behavior started after commit
88df6ab2f34b("mm: addfolio_is_pci_p2pdma()"). Prior to that change, theis_zone_device_page(page)check would return false when given a non‑existent page pointer.Doesn't
folio_is_pci_p2pdma()also check for zone device? I see[1] that it does:static inline bool
folio_is_pci_p2pdma(const struct folio *folio){ return IS_ENABLED(CONFIG_PCI_P2PDMA) && folio_is_zone_device(folio) && folio->pgmap->type == MEMORY_DEVICE_PCI_P2PDMA; }
Quoted 7 lines
Quoted 4 lines
I believe the problem arises due to the
page_folio()call in folio_is_pci_p2pdma(page_folio(page)); withinis_pci_p2pdma_page().page_folio()assumes it has a valid struct page to work with. For these carveouts, that isn't true.Yes, i came to the same conclusion, just explained why it worked before.
Ack.
Quoted 9 lines
Quoted 9 lines
Potentially something like the following would stop the crash:
include/linux/memremap.h +0
-0@@ -197,7 +197,8 @@ static inline void folio_set_zone_device_data(struct folio *folio, void *data)
Quoted 9 lines
include/linux/memremap.h static inline void folio_set_zone_device_data(struct folio *folio, void *data) · line 201
Quoted 5 lines
include/linux/memremap.h +2
-1static inline bool is_pci_p2pdma_page (const struct page *page) { - return IS_ENABLED(CONFIG_PCI_P2PDMA) && +return IS_ENABLED (CONFIG_PCI_P2PDMA ) && page && + pfn_valid(page_to_pfn(page)) &&
pfn_valid()is a relatively expensive function [1] to invoke in the data path, andis_pci_p2pdma_page()ends up being called in these execution flows.
Right, that makes sense. Ideally, it shouldn't be there at either of the places (iommu_dma_map_sg or is_pci_p2pdma_page()).
Quoted 20 lines
[1] https://elixir.bootlin.com/linux/v6.19.3/source/include/linux/mmzone.h#L2167
Quoted 6 lines
include/linux/memremap.h +0
-0folio_is_pci_p2pdma (page_folio (page)); }But my broader question is: why are we calling a page-based API like
is_pci_p2pdma_page()on non-struct-page memory in the first place?+1
Quoted 2 lines
Could we instead add a helper to verify if the
sg_page()return value is actually backed by a struct page?According to the SG design, callers should store only struct page pointers. There is one known user that violates this requirement: dmabuf, which is gradually being migrated away from this behavior [2].
Quoted 9 lines
Quoted 3 lines
If it isn't, we should arguably skip the P2PDMA logic entirely and fall back to a
dma_map_physstyle path. Isn't handling these "pageless" physical ranges the primary reasondma_map_physexists?Right.
dma_map_sg()is indeed the wrong API to use for memory that is not backed by struct page pointers.Thanks
[--->8---]
Thanks,
Praan