amd-xgbe: fix MAC_TCR_SS register width for 2.5G and 10M speeds
Subsystems (3)
Raju Rangoju
maintainerPATCH 1/1 amd-xgbe: fix MAC_TCR_SS register width for 2.5G and 10M speeds
Extend the MAC_TCR_SS (Speed Select) register field width from 2 bits to 3 bits to properly support all speed settings.
The MAC_TCR register's SS field encoding requires 3 bits to represent all supported speeds:
- 0x00: 10Gbps (XGMII)
- 0x02: 2.5Gbps (GMII) / 100Mbps
- 0x03: 1Gbps / 10Mbps
- 0x06: 2.5Gbps (XGMII) - P100a only
With only 2 bits, values 0x04-0x07 cannot be represented, which breaks 2.5G XGMII mode on newer platforms and causes incorrect speed select values to be programmed.
--- drivers/net/ethernet/amd/xgbe/xgbe-common.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/amd/xgbe/xgbe-common.h +1 -1
@@ -431,7 +431,7 @@#define MAC_SSIR_SSINC_INDEX 16#define MAC_SSIR_SSINC_WIDTH 8#define MAC_TCR_SS_INDEX 29 -#define MAC_TCR_SS_WIDTH 2 +#define MAC_TCR_SS_WIDTH 3#define MAC_TCR_TE_INDEX 0#define MAC_TCR_TE_WIDTH 1#define MAC_TCR_VNE_INDEX 24
Signature · 1 line
2.34.1
This patch was applied to netdev/net.git (main) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <[email protected]>:
Quoted 11 lines · On Thu, 26 Feb 2026 22:37:53 +0530 you wrote:
Extend the
MAC_TCR_SS(Speed Select) register field width from 2 bits to 3 bits to properly support all speed settings.The
MAC_TCRregister's SS field encoding requires 3 bits to represent all supported speeds:
-0x00: 10Gbps (XGMII)
-0x02: 2.5Gbps (GMII) / 100Mbps
-0x03: 1Gbps / 10Mbps
-0x06: 2.5Gbps (XGMII) - P100a only[...]
Here is the summary with links:
- [net] amd-xgbe: fix MAC_TCR_SS register width for 2.5G and 10M speeds
https://git.kernel.org/netdev/net/c/9439a661c2e8
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html