Skip to contentSkip to conversation

clk: qcom: sc7280: add missing SDCC1 clocks

PATCH Applied Ajit Singh 3 participants 5 messages Feb 26 – Apr 29

Subsystems (3)
lore
Share & tools
lore

Ajit Singh

author
#0 lore raw

PATCH 1/1 clk: qcom: sc7280: add missing SDCC1 clocks

Add GCC_SDCC1_AHB_CLK and GCC_SDCC1_APPS_CLK gate clocks. Required on platforms where SDCC1 is used for eMMC.

---
 drivers/clk/qcom/clock-sc7280.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/clk/qcom/clock-sc7280.c +2 -0
index 7b6ed826023..acdaccf7462 100644
@@ -155,6 +155,8 @@ static const struct gate_clk sc7280_clks[] = {
 	GATE_CLK(GCC_UFS_1_CLKREF_EN, 0x8c000, BIT(0)),
 	GATE_CLK(GCC_SDCC2_AHB_CLK, 0x14008, BIT(0)),
 	GATE_CLK(GCC_SDCC2_APPS_CLK, 0x14004, BIT(0)),
+	GATE_CLK(GCC_SDCC1_AHB_CLK,  0x75004, BIT(0)),
+	GATE_CLK(GCC_SDCC1_APPS_CLK, 0x75008, BIT(0)),
 };
 
 static int sc7280_enable(struct clk *clk)
Signature · 1 line
2.50.1 (Apple Git-155)
Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · Ajit Singh

Add GCC_SDCC1_AHB_CLK and GCC_SDCC1_APPS_CLK gate clocks. Required on platforms where SDCC1 is used for eMMC.

Quoted 17 lines
---
 drivers/clk/qcom/clock-sc7280.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/clk/qcom/clock-sc7280.c +2 -0
index 7b6ed826023..acdaccf7462 100644
@@ -155,6 +155,8 @@ static const struct gate_clk sc7280_clks[] = {
 	GATE_CLK(GCC_UFS_1_CLKREF_EN, 0x8c000, BIT(0)),
 	GATE_CLK(GCC_SDCC2_AHB_CLK, 0x14008, BIT(0)),
 	GATE_CLK(GCC_SDCC2_APPS_CLK, 0x14004, BIT(0)),
+	GATE_CLK(GCC_SDCC1_AHB_CLK,  0x75004, BIT(0)),
+	GATE_CLK(GCC_SDCC1_APPS_CLK, 0x75008, BIT(0)),
 };
 
 static int sc7280_enable(struct clk *clk)
Signature · 1 line
// Casey (she/her)
Reviewed-by on v1 1/1
#3 lore raw
In reply to Ajit Singh
Quoted 9 lines · Ajit Singh

Add GCC_SDCC1_AHB_CLK and GCC_SDCC1_APPS_CLK gate clocks. Required on platforms where SDCC1 is used for eMMC.

---
 drivers/clk/qcom/clock-sc7280.c | 2 ++
 1 file changed, 2 insertions(+)

-Sumit

Quoted 17 lines
drivers/clk/qcom/clock-sc7280.c +2 -0
index 7b6ed826023..acdaccf7462 100644
@@ -155,6 +155,8 @@ static const struct gate_clk sc7280_clks[] = {
 	GATE_CLK(GCC_UFS_1_CLKREF_EN, 0x8c000, BIT(0)),
 	GATE_CLK(GCC_SDCC2_AHB_CLK, 0x14008, BIT(0)),
 	GATE_CLK(GCC_SDCC2_APPS_CLK, 0x14004, BIT(0)),
+	GATE_CLK(GCC_SDCC1_AHB_CLK,  0x75004, BIT(0)),
+	GATE_CLK(GCC_SDCC1_APPS_CLK, 0x75008, BIT(0)),
 };
 
 static int sc7280_enable(struct clk *clk)
Signature · 1 line
2.50.1 (Apple Git-155)
#4 lore raw
In reply to Ajit Singh
Quoted 1 line · Ajit Singh

clk: qcom: sc7280: add missing SDCC1 clocks

Applied, thanks!

First and last time I use b4 review, the commit shas are wrong but you can find the patches in https://source.denx.de/u-boot/custodians/u-boot-snapdragon/-/commits/casey/qcom-main-13Apr2026?ref_type=heads

Apologies

[1/1] clk: qcom: sc7280: add missing SDCC1 clocks

      https://source.denx.de/u-boot/custodians/u-boot-snapdragon/-/commit/e3da8a860343

Best regards,

Signature · 1 line
// Casey (she/they)