Skip to contentSkip to conversation

bus: Remove Baikal SoC pieces

PATCH In review Andy Shevchenko 3 participants 7 messages Feb 27 – Mar 12 Device tree bindings

lore
Share & tools
lore
#0 lore raw

cover bus: Remove Baikal SoC pieces

Baikal SoC and platform support won't be finalised, remove stale pieces.

Andy Shevchenko (2):
bus: Remove not-going-to-be-supported code for Baikal SoC
dt-bindings: bus: Remove unused bindings

 .../bindings/bus/baikal,bt1-apb.yaml          |  90 ----
 .../bindings/bus/baikal,bt1-axi.yaml          | 107 -----
 drivers/bus/Kconfig                           |  30 --
 drivers/bus/Makefile                          |   2 -
 drivers/bus/bt1-apb.c                         | 396 ------------------
 drivers/bus/bt1-axi.c                         | 292 -------------
 6 files changed, 917 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/bus/baikal,bt1-apb.yaml
 delete mode 100644 Documentation/devicetree/bindings/bus/baikal,bt1-axi.yaml
 delete mode 100644 drivers/bus/bt1-apb.c
 delete mode 100644 drivers/bus/bt1-axi.c
Signature · 1 line
2.50.1
#1 lore raw

PATCH 1/2 bus: Remove not-going-to-be-supported code for Baikal SoC

As noticed in the discussion [1] the Baikal SoC and platforms are not going to be finalized, hence remove stale code.

---
 drivers/bus/Kconfig   |  30 ----
 drivers/bus/Makefile  |   2 -
 drivers/bus/bt1-apb.c | 396 ------------------------------------------
 drivers/bus/bt1-axi.c | 292 -------------------------------
 4 files changed, 720 deletions(-)
 delete mode 100644 drivers/bus/bt1-apb.c
 delete mode 100644 drivers/bus/bt1-axi.c
drivers/bus/Kconfig +0 -30
index 2a1b46f07080..5a7361c81be5 100644
@@ -38,36 +38,6 @@ config BRCMSTB_GISB_ARB
 	  arbiter. This driver provides timeout and target abort error handling
 	  and internal bus master decoding.
 
-config BT1_APB
-	bool "Baikal-T1 APB-bus driver"
-	depends on MIPS_BAIKAL_T1 || COMPILE_TEST
-	select REGMAP_MMIO
-	help
-	  Baikal-T1 AXI-APB bridge is used to access the SoC subsystem CSRs.
-	  IO requests are routed to this bus by means of the DW AMBA 3 AXI
-	  Interconnect. In case of any APB protocol collisions, slave device
-	  not responding on timeout an IRQ is raised with an erroneous address
-	  reported to the APB terminator (APB Errors Handler Block). This
-	  driver provides the interrupt handler to detect the erroneous
-	  address, prints an error message about the address fault, updates an
-	  errors counter. The counter and the APB-bus operations timeout can be
-	  accessed via corresponding sysfs nodes.
-
-config BT1_AXI
-	bool "Baikal-T1 AXI-bus driver"
-	depends on MIPS_BAIKAL_T1 || COMPILE_TEST
-	select MFD_SYSCON
-	help
-	  AXI3-bus is the main communication bus connecting all high-speed
-	  peripheral IP-cores with RAM controller and with MIPS P5600 cores on
-	  Baikal-T1 SoC. Traffic arbitration is done by means of DW AMBA 3 AXI
-	  Interconnect (so called AXI Main Interconnect) routing IO requests
-	  from one SoC block to another. This driver provides a way to detect
-	  any bus protocol errors and device not responding situations by
-	  means of an embedded on top of the interconnect errors handler
-	  block (EHB). AXI Interconnect QoS arbitration tuning is currently
-	  unsupported.
-
 config MOXTET
 	tristate "CZ.NIC Turris Mox module configuration bus"
 	depends on SPI_MASTER && OF
drivers/bus/Makefile +0 -2
index 8e693fe8a03a..768a27e96276 100644
@@ -13,8 +13,6 @@ obj-$(CONFIG_MOXTET)		+= moxtet.o
 # DPAA2 fsl-mc bus
 obj-$(CONFIG_FSL_MC_BUS)	+= fsl-mc/
 
-obj-$(CONFIG_BT1_APB)		+= bt1-apb.o
-obj-$(CONFIG_BT1_AXI)		+= bt1-axi.o
 obj-$(CONFIG_IMX_AIPSTZ)	+= imx-aipstz.o
 obj-$(CONFIG_IMX_WEIM)		+= imx-weim.o
 obj-$(CONFIG_INTEL_IXP4XX_EB)	+= intel-ixp4xx-eb.o
drivers/bus/bt1-apb.c deleted +0 -396

396 lines not on this page · raw message

drivers/bus/bt1-axi.c deleted +0 -292

292 lines not on this page · raw message

Signature · 1 line
2.50.1
Reviewed-by on v1 1/2
#2 lore raw

Re: [PATCH v1 1/2] bus: Remove not-going-to-be-supported code for Baikal SoC

Quoted 5 lines · Andy Shevchenko

As noticed in the discussion [1] the Baikal SoC and platforms are not going to be finalized, hence remove stale code.

Quoted 9 lines
---
 drivers/bus/Kconfig   |  30 ----
 drivers/bus/Makefile  |   2 -
 drivers/bus/bt1-apb.c | 396 ------------------------------------------
 drivers/bus/bt1-axi.c | 292 -------------------------------
 4 files changed, 720 deletions(-)
 delete mode 100644 drivers/bus/bt1-apb.c
 delete mode 100644 drivers/bus/bt1-axi.c

Thanks.

Signature · 1 line
~Randy
#3 lore raw

PATCH 2/2 dt-bindings: bus: Remove unused bindings

In reply to Andy Shevchenko

As stated in [1] the Baikal platforms are not supported and the respective driver code has just been removed. Remove unused bindings.

---
 .../bindings/bus/baikal,bt1-apb.yaml          |  90 ---------------
 .../bindings/bus/baikal,bt1-axi.yaml          | 107 ------------------
 2 files changed, 197 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/bus/baikal,bt1-apb.yaml
 delete mode 100644 Documentation/devicetree/bindings/bus/baikal,bt1-axi.yaml
Documentation/devicetree/bindings/bus/baikal,bt1-apb.yaml deleted +0 -90
deleted file mode 100644
index 37ba3337f944..000000000000
@@ -1,90 +0,0 @@
-# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
-# Copyright (C) 2020 BAIKAL ELECTRONICS, JSC
-%YAML 1.2
----
-$id: http://devicetree.org/schemas/bus/baikal,bt1-apb.yaml#
-$schema: http://devicetree.org/meta-schemas/core.yaml#
-
-title: Baikal-T1 APB-bus
-
-maintainers:
-  - Serge Semin <[email protected]>
-
-description: |
-  Baikal-T1 CPU or DMAC MMIO requests are handled by the AMBA 3 AXI Interconnect
-  which routes them to the AXI-APB bridge. This interface is a single master
-  multiple slaves bus in turn serializing IO accesses and routing them to the
-  addressed APB slave devices. In case of any APB protocol collisions, slave
-  device not responding on timeout an IRQ is raised with an erroneous address
-  reported to the APB terminator (APB Errors Handler Block).
-
-allOf:
-  - $ref: /schemas/simple-bus.yaml#
-
-properties:
-  compatible:
-    contains:
-      const: baikal,bt1-apb
-
-  reg:
-    items:
-      - description: APB EHB MMIO registers
-      - description: APB MMIO region with no any device mapped
-
-  reg-names:
-    items:
-      - const: ehb
-      - const: nodev
-
-  interrupts:
-    maxItems: 1
-
-  clocks:
-    items:
-      - description: APB reference clock
-
-  clock-names:
-    items:
-      - const: pclk
-
-  resets:
-    items:
-      - description: APB domain reset line
-
-  reset-names:
-    items:
-      - const: prst
-
-unevaluatedProperties: false
-
-required:
-  - compatible
-  - reg
-  - reg-names
-  - interrupts
-  - clocks
-  - clock-names
-
-examples:
-  - |
-    #include <dt-bindings/interrupt-controller/mips-gic.h>
-
-    bus@1f059000 {
-      compatible = "baikal,bt1-apb", "simple-bus";
-      reg = <0x1f059000 0x1000>,
-            <0x1d000000 0x2040000>;
-      reg-names = "ehb", "nodev";
-      #address-cells = <1>;
-      #size-cells = <1>;
-
-      ranges;
-
-      interrupts = <GIC_SHARED 16 IRQ_TYPE_LEVEL_HIGH>;
-
-      clocks = <&ccu_sys 1>;
-      clock-names = "pclk";
-
-      resets = <&ccu_sys 1>;
-      reset-names = "prst";
-    };
-...
Documentation/devicetree/bindings/bus/baikal,bt1-axi.yaml deleted +0 -107

107 lines not on this page · raw message

Signature · 1 line
2.50.1
Reviewed-by on v1 2/2
#4 lore raw

Re: [PATCH v1 2/2] dt-bindings: bus: Remove unused bindings

Quoted 4 lines · Andy Shevchenko

As stated in [1] the Baikal platforms are not supported and the respective driver code has just been removed. Remove unused bindings.

Quoted 9 lines
---
 .../bindings/bus/baikal,bt1-apb.yaml          |  90 ---------------
 .../bindings/bus/baikal,bt1-axi.yaml          | 107 ------------------
 2 files changed, 197 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/bus/baikal,bt1-apb.yaml
 delete mode 100644 Documentation/devicetree/bindings/bus/baikal,bt1-axi.yaml

Thanks.

Signature · 1 line
~Randy
maintainer
#5 lore raw
In reply to Andy Shevchenko
Quoted 5 lines · Andy Shevchenko

Baikal SoC and platform support won't be finalised, remove stale pieces.

Andy Shevchenko (2):
bus: Remove not-going-to-be-supported code for Baikal SoC
dt-bindings: bus: Remove unused bindings

As there doesn't seem to be a maintainer for drivers/bus/, I just took both patches.

Rob

#6 lore raw
Quoted 9 lines · Rob Herring
Quoted 5 lines · Andy Shevchenko

Baikal SoC and platform support won't be finalised, remove stale pieces.

Andy Shevchenko (2):
bus: Remove not-going-to-be-supported code for Baikal SoC
dt-bindings: bus: Remove unused bindings

As there doesn't seem to be a maintainer for drivers/bus/, I just took both patches.

Merci!

Signature · 2 lines
With Best Regards,
Andy Shevchenko