drm/gem-shmem: Track page accessed/dirty status
Subsystems (4)
Thomas Zimmermann
maintainerv4 cover drm/gem-shmem: Track page accessed/dirty status
Track page access/dirty status in gem-shmem for better integration with the overall memory management. Gem-shmem has long had two flag bits in struct drm_gem_shmem_object, named pages_mark_accessed_on_put and pages_mark_dirty_on_put, but never used them much; except for some odd cases in drivers. Therefore pages in gem-shmem where never marked correctly. (Other DRM memory managers do some course-grain tracking at least).
Patches 1 to 4 prepare the mmap page-fault handler for tracking page status easily. The pages are already available; only the mmap handling needs to be adapted. The way the shmem code interacts with huge-page support is also not optimal, hence refactor it slightly.
Patch 5 adds tracking access and dirty status in mmap. With the earlier patches, this change simply falls into place.
Patch 6 adds tracking access and dirty status in vmap. Because there's no fault handling here, we refer to the existing status bits in struct drm_gem_shmem_object. Each page's status will be updated by the page release in drm_gem_put_pages(). The imagination driver requires a small fix to make it work correctly.
Tested with CONFIG_VM=y by running animations on DRM's bochs driver for several hours. This uses gem-shmem's mmap and vmap extensively.
v4:
- mark folio as accessed on VM_FAULT_NOPAGE (Boris)
- validate state in mkwrite (Boris)
v3:
- rewrite for VM_PFNMAP
- do more preparational patches
v2:
- fix possible OOB access into page array (Matthew)
- simplify fault-handler error handling (Boris)
- simplify internal interfaces (Matthew)
Thomas Zimmermann (6):
drm/gem-shmem: Use obj directly where appropriate in fault handler drm/gem-shmem: Test for existence of page in mmap fault handler drm/gem-shmem: Return vm_fault_t from drm_gem_shmem_try_map_pmd() drm/gem-shmem: Refactor drm_gem_shmem_try_map_pmd() drm/gem-shmem: Track folio accessed/dirty status in mmap drm/gem-shmem: Track folio accessed/dirty status in vmap
drivers/gpu/drm/drm_gem_shmem_helper.c | 79 +++++++++++++++++--------- drivers/gpu/drm/imagination/pvr_gem.c | 6 +- 2 files changed, 55 insertions(+), 30 deletions(-)
base-commit: 1c44015babd759b8e5234084dffcc08a0b784333
Signature · 1 line
2.52.0
Thomas Zimmermann
maintainerPATCH v4 1/6 drm/gem-shmem: Use obj directly where appropriate in fault handler
Replace shmem->base with obj in several places. It is the same value, but the latter is easier to read.
--- drivers/gpu/drm/drm_gem_shmem_helper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/drm_gem_shmem_helper.c +2 -2
@@ -584,7 +584,7 @@ static vm_fault_t drm_gem_shmem_fault(struct vm_fault *vmf)/* Offset to faulty address in the VMA. */ page_offset = vmf->pgoff - vma->vm_pgoff; -dma_resv_lock (shmem->base.resv,NULL ); +dma_resv_lock (obj->resv,NULL ); if (page_offset >= num_pages || drm_WARN_ON_ONCE(obj->dev, !shmem->pages) ||
@@ -602,7 +602,7 @@ static vm_fault_t drm_gem_shmem_fault(struct vm_fault *vmf) ret =vmf_insert_pfn (vma, vmf->address, pfn); out: -dma_resv_unlock (shmem->base.resv); +dma_resv_unlock (obj->resv);return ret; }
Signature · 1 line
2.52.0
Thomas Zimmermann
maintainerPATCH v4 2/6 drm/gem-shmem: Test for existence of page in mmap fault handler
In reply to Thomas ZimmermannNot having a page pointer in the mmap fault handler is an error. Test for this situation and return VM_FAULT_SIGBUS if so. Also replace several lookups of the page with a local variable.
--- drivers/gpu/drm/drm_gem_shmem_helper.c | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-)
drivers/gpu/drm/drm_gem_shmem_helper.c +12 -12
@@ -574,31 +574,31 @@ static vm_fault_t drm_gem_shmem_fault(struct vm_fault *vmf) {struct vm_area_struct *vma = vmf->vma;struct drm_gem_object *obj = vma->vm_private_data; +struct drm_device *dev = obj->dev;struct drm_gem_shmem_object *shmem =to_drm_gem_shmem_obj (obj);loff_t num_pages = obj->size >>PAGE_SHIFT ; -vm_fault_t ret; +vm_fault_t ret =VM_FAULT_SIGBUS ;struct page **pages = shmem->pages; -pgoff_t page_offset; +pgoff_t page_offset = vmf->pgoff - vma->vm_pgoff;/* page offset within VMA */ +struct page *page;unsigned long pfn; -/* Offset to faulty address in the VMA. */ - page_offset = vmf->pgoff - vma->vm_pgoff; -dma_resv_lock (obj->resv,NULL ); -if (page_offset >= num_pages || -drm_WARN_ON_ONCE (obj->dev, !shmem->pages) || - shmem->madv <0 ) { - ret =VM_FAULT_SIGBUS ; +if (page_offset >= num_pages ||drm_WARN_ON_ONCE (dev, !shmem->pages) || + shmem->madv <0 ) + goto out; + + page = pages[page_offset]; +if (drm_WARN_ON_ONCE (dev, !page)) goto out; - } -if (drm_gem_shmem_try_map_pmd (vmf, vmf->address, pages[page_offset])) { +if (drm_gem_shmem_try_map_pmd (vmf, vmf->address, page)) { ret =VM_FAULT_NOPAGE ; goto out; } - pfn =page_to_pfn (pages[page_offset]); + pfn =page_to_pfn (page); ret =vmf_insert_pfn (vma, vmf->address, pfn); out:
Signature · 1 line
2.52.0
Thomas Zimmermann
maintainerPATCH v4 3/6 drm/gem-shmem: Return vm_fault_t from drm_gem_shmem_try_map_pmd()
In reply to Thomas ZimmermannReturn the exact VM_FAULT_ mask from drm_gem_shmem_try_map_pmd(). Gives the caller better insight into the result. Return 0 if nothing was done.
If the caller sees VM_FAULT_NOPAGE, drm_gem_shmem_try_map_pmd() added a PMD entry to the page table. As before, return early from the page-fault handler in that case.
--- drivers/gpu/drm/drm_gem_shmem_helper.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-)
drivers/gpu/drm/drm_gem_shmem_helper.c +6 -8
@@ -550,8 +550,8 @@ int drm_gem_shmem_dumb_create(struct drm_file *file, struct drm_device *dev, }EXPORT_SYMBOL_GPL (drm_gem_shmem_dumb_create); -static bool drm_gem_shmem_try_map_pmd (struct vm_fault *vmf,unsigned long addr, -struct page *page) +static vm_fault_t drm_gem_shmem_try_map_pmd (struct vm_fault *vmf,unsigned long addr, +struct page *page) {#ifdef CONFIG_ARCH_SUPPORTS_PMD_PFNMAP unsigned long pfn =page_to_pfn (page);
@@ -562,12 +562,11 @@ static bool drm_gem_shmem_try_map_pmd(struct vm_fault *vmf, unsigned long addr, pmd_none(*vmf->pmd) && folio_test_pmd_mappable(page_folio(page))) { pfn &=PMD_MASK >>PAGE_SHIFT ; -if (vmf_insert_pfn_pmd (vmf, pfn, false) ==VM_FAULT_NOPAGE ) -return true; +return vmf_insert_pfn_pmd (vmf, pfn, false); }#endif -return false; +return 0 ; }static vm_fault_t drm_gem_shmem_fault (struct vm_fault *vmf)
@@ -593,10 +592,9 @@ static vm_fault_t drm_gem_shmem_fault(struct vm_fault *vmf)if (drm_WARN_ON_ONCE (dev, !page)) goto out; -if (drm_gem_shmem_try_map_pmd (vmf, vmf->address, page)) { - ret =VM_FAULT_NOPAGE ; + ret =drm_gem_shmem_try_map_pmd (vmf, vmf->address, page); +if (ret ==VM_FAULT_NOPAGE ) goto out; - } pfn =page_to_pfn (page); ret =vmf_insert_pfn (vma, vmf->address, pfn);
Signature · 1 line
2.52.0
Thomas Zimmermann
maintainerPATCH v4 4/6 drm/gem-shmem: Refactor drm_gem_shmem_try_map_pmd()
In reply to Thomas ZimmermannThe current mmap page-fault handler requires some changes before it can track folio access.
Call to folio_test_pmd_mappable() into the mmap page-fault handler before calling drm_gem_shmem_try_map_pmd(). The folio will become useful for tracking the access status.
Also rename drm_gem_shmem_try_map_pmd() to _try_insert_pfn_pmd() and only pass the page fault and page-frame number. The new name and parameters make it similar to vmf_insert_pfn_pmd().
No functional changes. If PMD mapping fails or is not supported, insert a regular PFN as before.
--- drivers/gpu/drm/drm_gem_shmem_helper.c | 25 ++++++++++++------------- 1 file changed, 12 insertions(+), 13 deletions(-)
drivers/gpu/drm/drm_gem_shmem_helper.c +12 -13
@@ -550,17 +550,14 @@ int drm_gem_shmem_dumb_create(struct drm_file *file, struct drm_device *dev, }EXPORT_SYMBOL_GPL (drm_gem_shmem_dumb_create); -static vm_fault_t drm_gem_shmem_try_map_pmd (struct vm_fault *vmf,unsigned long addr, -struct page *page) +static vm_fault_t drm_gem_shmem_try_insert_pfn_pmd (struct vm_fault *vmf,unsigned long pfn) {#ifdef CONFIG_ARCH_SUPPORTS_PMD_PFNMAP -unsigned long pfn =page_to_pfn (page);unsigned long paddr = pfn <<PAGE_SHIFT ; -bool aligned = (addr & ~PMD_MASK ) == (paddr & ~PMD_MASK ); +bool aligned = (vmf->address & ~PMD_MASK ) == (paddr & ~PMD_MASK ); -if (aligned && -pmd_none (*vmf->pmd) && -folio_test_pmd_mappable (page_folio (page))) { +if (aligned &&pmd_none (*vmf->pmd)) { +/* Read-only mapping; split upon write fault */ pfn &=PMD_MASK >>PAGE_SHIFT ;return vmf_insert_pfn_pmd (vmf, pfn, false); }
@@ -580,6 +577,7 @@ static vm_fault_t drm_gem_shmem_fault(struct vm_fault *vmf)struct page **pages = shmem->pages;pgoff_t page_offset = vmf->pgoff - vma->vm_pgoff;/* page offset within VMA */ struct page *page; +struct folio *folio;unsigned long pfn;dma_resv_lock (obj->resv,NULL );
@@ -591,15 +589,16 @@ static vm_fault_t drm_gem_shmem_fault(struct vm_fault *vmf) page = pages[page_offset];if (drm_WARN_ON_ONCE (dev, !page)) goto out; - - ret =drm_gem_shmem_try_map_pmd (vmf, vmf->address, page); -if (ret ==VM_FAULT_NOPAGE ) - goto out; + folio =page_folio (page); pfn =page_to_pfn (page); - ret =vmf_insert_pfn (vma, vmf->address, pfn); - out: +if (folio_test_pmd_mappable (folio)) + ret =drm_gem_shmem_try_insert_pfn_pmd (vmf, pfn); +if (ret !=VM_FAULT_NOPAGE ) + ret =vmf_insert_pfn (vma, vmf->address, pfn); + +out:dma_resv_unlock (obj->resv);return ret;
Signature · 1 line
2.52.0
Thomas Zimmermann
maintainerPATCH v4 5/6 drm/gem-shmem: Track folio accessed/dirty status in mmap
In reply to Thomas ZimmermannInvoke folio_mark_accessed() in mmap page faults to add the folio to the memory manager's LRU list. Userspace invokes mmap to get the memory for software rendering. Compositors do the same when creating the final on-screen image, so keeping the pages in LRU makes sense. Avoids paging out graphics buffers when under memory pressure.
In pfn_mkwrite, further invoke the folio_mark_dirty() to add the folio for writeback should the underlying file be paged out from system memory. This rarely happens in practice, yet it would corrupt the buffer content.
This has little effect on a system's hardware-accelerated rendering, which only mmaps for an initial setup of textures, meshes, shaders, etc.
v4:
- test for VM_FAULT_NOPAGE before marking folio as accessed (Boris)
- test page-array bounds in mkwrite handler (Boris)
v3:
- rewrite for VM_PFNMAP
v2:
- adapt to changes in drm_gem_shmem_try_mmap_pmd()
--- drivers/gpu/drm/drm_gem_shmem_helper.c | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+)
drivers/gpu/drm/drm_gem_shmem_helper.c +22 -0
@@ -598,6 +598,9 @@ static vm_fault_t drm_gem_shmem_fault(struct vm_fault *vmf)if (ret !=VM_FAULT_NOPAGE ) ret =vmf_insert_pfn (vma, vmf->address, pfn); +if (ret ==VM_FAULT_NOPAGE ) +folio_mark_accessed (folio); + out:dma_resv_unlock (obj->resv);
@@ -638,10 +641,29 @@ static void drm_gem_shmem_vm_close(struct vm_area_struct *vma)drm_gem_vm_close (vma); } +static vm_fault_t drm_gem_shmem_pfn_mkwrite (struct vm_fault *vmf) +{ +struct vm_area_struct *vma = vmf->vma; +struct drm_gem_object *obj = vma->vm_private_data; +struct drm_gem_shmem_object *shmem =to_drm_gem_shmem_obj (obj); +loff_t num_pages = obj->size >>PAGE_SHIFT ; +pgoff_t page_offset = vmf->pgoff - vma->vm_pgoff;/* page offset within VMA */ + +if (drm_WARN_ON (obj->dev, !shmem->pages || page_offset >= num_pages)) +return VM_FAULT_SIGBUS ; + +file_update_time (vma->vm_file); + +folio_mark_dirty (page_folio (shmem->pages[page_offset])); + +return 0 ; +} +const struct vm_operations_struct drm_gem_shmem_vm_ops = { .fault = drm_gem_shmem_fault, .open = drm_gem_shmem_vm_open, .close = drm_gem_shmem_vm_close, + .pfn_mkwrite = drm_gem_shmem_pfn_mkwrite, };EXPORT_SYMBOL_GPL (drm_gem_shmem_vm_ops);
Signature · 1 line
2.52.0
Re: [PATCH v4 5/6] drm/gem-shmem: Track folio accessed/dirty status in mmap
Hi Thomas,
Thanks for your patch.
I'm working on DSI support for RZ/G3E from this morning rebasing on top of next-20260311 I'm seeing that weston hang on my side:
Reverting this patch fix the issue.
(git revert 28e3918179aa)
I'm wondering if anyone encountered this issue?
Thanks in advance.
Kind Regards,
Tommaso
Quoted 74 lines · Thomas Zimmermann
Invoke
folio_mark_accessed()in mmap page faults to add the folio to the memory manager's LRU list. Userspace invokes mmap to get the memory for software rendering. Compositors do the same when creating the final on-screen image, so keeping the pages in LRU makes sense. Avoids paging out graphics buffers when under memory pressure.In
pfn_mkwrite, further invoke thefolio_mark_dirty()to add the folio for writeback should the underlying file be paged out from system memory. This rarely happens in practice, yet it would corrupt the buffer content.This has little effect on a system's hardware-accelerated rendering, which only mmaps for an initial setup of textures, meshes, shaders, etc.
v4:
- test forVM_FAULT_NOPAGEbefore marking folio as accessed (Boris)
- test page-array bounds in mkwrite handler (Boris)
v3:
- rewrite forVM_PFNMAP
v2:
- adapt to changes indrm_gem_shmem_try_mmap_pmd()Signed-off-by Thomas Zimmermann <[email protected]>Reviewed-by Boris Brezillon <[email protected]>--- drivers/gpu/drm/drm_gem_shmem_helper.c | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+)drivers/gpu/drm/drm_gem_shmem_helper.c +22
-0@@ -598,6 +598,9 @@ static vm_fault_t drm_gem_shmem_fault(struct vm_fault *vmf)if (ret !=VM_FAULT_NOPAGE ) ret =vmf_insert_pfn (vma, vmf->address, pfn); +if (ret ==VM_FAULT_NOPAGE ) +folio_mark_accessed (folio); + out:dma_resv_unlock (obj->resv);@@ -638,10 +641,29 @@ static void drm_gem_shmem_vm_close(struct vm_area_struct *vma)drm_gem_vm_close (vma); } +static vm_fault_t drm_gem_shmem_pfn_mkwrite (struct vm_fault *vmf) +{ +struct vm_area_struct *vma = vmf->vma; +struct drm_gem_object *obj = vma->vm_private_data; +struct drm_gem_shmem_object *shmem =to_drm_gem_shmem_obj (obj); +loff_t num_pages = obj->size >>PAGE_SHIFT ; +pgoff_t page_offset = vmf->pgoff - vma->vm_pgoff;/* page offset within VMA */ + +if (drm_WARN_ON (obj->dev, !shmem->pages || page_offset >= num_pages)) +return VM_FAULT_SIGBUS ; + +file_update_time (vma->vm_file); + +folio_mark_dirty (page_folio (shmem->pages[page_offset])); + +return 0 ; +} +const struct vm_operations_struct drm_gem_shmem_vm_ops = { .fault = drm_gem_shmem_fault, .open = drm_gem_shmem_vm_open, .close = drm_gem_shmem_vm_close, + .pfn_mkwrite = drm_gem_shmem_pfn_mkwrite, };EXPORT_SYMBOL_GPL (drm_gem_shmem_vm_ops);Signature · 1 line
2.52.0
RE: [PATCH v4 5/6] drm/gem-shmem: Track folio accessed/dirty status in mmap
Hi Tommaso,
Quoted 8 lines
-----Original Message-----
From: Tommaso Merciai <[email protected]>
Sent: 12 March 2026 17:37
Subject: Re: [PATCH v4 5/6] drm/gem-shmem: Track folio accessed/dirty status in mmapHi Thomas,
Thanks for your patch.
Quoted 8 lines
I'm working on DSI support for RZ/G3E from this morning rebasing on top of next-20260311 I'm seeing that weston hang on my side:
Reverting this patch fix the issue.
(git revert28e3918179aa)I'm wondering if anyone encountered this issue?
Thanks in advance.
I am also seeing same issue on RZ/G3L with weston.
Cheers,
Biju
Quoted 80 lines
Kind Regards,
TommasoQuoted 75 lines · Thomas Zimmermann
Invoke
folio_mark_accessed()in mmap page faults to add the folio to the memory manager's LRU list. Userspace invokes mmap to get the memory for software rendering. Compositors do the same when creating the final on-screen image, so keeping the pages in LRU makes sense. Avoids paging out graphics buffers when under memory pressure.In
pfn_mkwrite, further invoke thefolio_mark_dirty()to add the folio for writeback should the underlying file be paged out from system memory. This rarely happens in practice, yet it would corrupt the buffer content.This has little effect on a system's hardware-accelerated rendering, which only mmaps for an initial setup of textures, meshes, shaders, etc.
v4:
- test forVM_FAULT_NOPAGEbefore marking folio as accessed (Boris)
- test page-array bounds in mkwrite handler (Boris)
v3:
- rewrite forVM_PFNMAP
v2:
- adapt to changes indrm_gem_shmem_try_mmap_pmd()Signed-off-by Thomas Zimmermann <[email protected]>Reviewed-by Boris Brezillon <[email protected]>--- drivers/gpu/drm/drm_gem_shmem_helper.c | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+)drivers/gpu/drm/drm_gem_shmem_helper.c +22
-1@@ -598,6 +598,9 @@ static vm_fault_t drm_gem_shmem_fault(struct vm_fault *vmf)if (ret !=VM_FAULT_NOPAGE ) ret =vmf_insert_pfn (vma, vmf->address, pfn); +if (ret ==VM_FAULT_NOPAGE ) +folio_mark_accessed (folio); + out:dma_resv_unlock (obj->resv);@@ -638,10 +641,29 @@ static void drm_gem_shmem_vm_close(struct vm_area_struct *vma)drm_gem_vm_close (vma); } +static vm_fault_t drm_gem_shmem_pfn_mkwrite (struct vm_fault *vmf) { +struct vm_area_struct *vma = vmf->vma; +struct drm_gem_object *obj = vma->vm_private_data; +struct drm_gem_shmem_object *shmem =to_drm_gem_shmem_obj (obj); +loff_t num_pages = obj->size >>PAGE_SHIFT ; +pgoff_t page_offset = vmf->pgoff - vma->vm_pgoff;/* page offset +within VMA */ + +if (drm_WARN_ON (obj->dev, !shmem->pages || page_offset >= num_pages)) +return VM_FAULT_SIGBUS ; + +file_update_time (vma->vm_file); + +folio_mark_dirty (page_folio (shmem->pages[page_offset])); + +return 0 ; +} +const struct vm_operations_struct drm_gem_shmem_vm_ops = { .fault = drm_gem_shmem_fault, .open = drm_gem_shmem_vm_open, .close = drm_gem_shmem_vm_close, + .pfn_mkwrite = drm_gem_shmem_pfn_mkwrite, };EXPORT_SYMBOL_GPL (drm_gem_shmem_vm_ops); --2.52.0
RE: [PATCH v4 5/6] drm/gem-shmem: Track folio accessed/dirty status in mmap
Quoted 25 lines
-----Original Message-----
From: dri-devel <[email protected]> On Behalf Of Biju Das
Sent: 12 March 2026 17:47
To: Tommaso Merciai <[email protected]>; Thomas Zimmermann <[email protected]>
Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]
Subject: RE: [PATCH v4 5/6] drm/gem-shmem: Track folio accessed/dirty status in mmapHi Tommaso,
Quoted 12 lines
-----Original Message-----
From: Tommaso Merciai <[email protected]>
Sent: 12 March 2026 17:37
Subject: Re: [PATCH v4 5/6] drm/gem-shmem: Track folio accessed/dirty status in mmapHi Thomas,
Thanks for your patch.I'm working on DSI support for RZ/G3E from this morning rebasing on top of next-20260311 I'm seeing that weston hang on my side:
Quoted 8 lines
Quoted 5 lines
Reverting this patch fix the issue.
(git revert28e3918179aa)I'm wondering if anyone encountered this issue?
Thanks in advance.I am also seeing same issue on RZ/G3L with weston.
Just add I am using mesa with panfrost(Mali-G31) on RZ/G3L.
Disabling Mali-G31 renders weston desktop during boot.
Looks like this patch is creating some hang in panfrost driver during weston launch.
Cheers,
Biju
Quoted 86 lines
Cheers,
BijuQuoted 80 lines
Kind Regards,
TommasoQuoted 75 lines · Thomas Zimmermann
Invoke
folio_mark_accessed()in mmap page faults to add the folio to the memory manager's LRU list. Userspace invokes mmap to get the memory for software rendering. Compositors do the same when creating the final on-screen image, so keeping the pages in LRU makes sense. Avoids paging out graphics buffers when under memory pressure.In
pfn_mkwrite, further invoke thefolio_mark_dirty()to add the folio for writeback should the underlying file be paged out from system memory. This rarely happens in practice, yet it would corrupt the buffer content.This has little effect on a system's hardware-accelerated rendering, which only mmaps for an initial setup of textures, meshes, shaders, etc.
v4:
- test forVM_FAULT_NOPAGEbefore marking folio as accessed (Boris)
- test page-array bounds in mkwrite handler (Boris)
v3:
- rewrite forVM_PFNMAP
v2:
- adapt to changes indrm_gem_shmem_try_mmap_pmd()Signed-off-by Thomas Zimmermann <[email protected]>Reviewed-by Boris Brezillon <[email protected]>--- drivers/gpu/drm/drm_gem_shmem_helper.c | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+)drivers/gpu/drm/drm_gem_shmem_helper.c +22
-1@@ -598,6 +598,9 @@ static vm_fault_t drm_gem_shmem_fault(struct vm_fault *vmf)if (ret !=VM_FAULT_NOPAGE ) ret =vmf_insert_pfn (vma, vmf->address, pfn); +if (ret ==VM_FAULT_NOPAGE ) +folio_mark_accessed (folio); + out:dma_resv_unlock (obj->resv);@@ -638,10 +641,29 @@ static void drm_gem_shmem_vm_close(struct vm_area_struct *vma)drm_gem_vm_close (vma); } +static vm_fault_t drm_gem_shmem_pfn_mkwrite (struct vm_fault *vmf) { +struct vm_area_struct *vma = vmf->vma; +struct drm_gem_object *obj = vma->vm_private_data; +struct drm_gem_shmem_object *shmem =to_drm_gem_shmem_obj (obj); +loff_t num_pages = obj->size >>PAGE_SHIFT ; +pgoff_t page_offset = vmf->pgoff - vma->vm_pgoff;/* page offset +within VMA */ + +if (drm_WARN_ON (obj->dev, !shmem->pages || page_offset >= num_pages)) +return VM_FAULT_SIGBUS ; + +file_update_time (vma->vm_file); + +folio_mark_dirty (page_folio (shmem->pages[page_offset])); + +return 0 ; +} +const struct vm_operations_struct drm_gem_shmem_vm_ops = { .fault = drm_gem_shmem_fault, .open = drm_gem_shmem_vm_open, .close = drm_gem_shmem_vm_close, + .pfn_mkwrite = drm_gem_shmem_pfn_mkwrite, };EXPORT_SYMBOL_GPL (drm_gem_shmem_vm_ops); --2.52.0
Thomas Zimmermann
maintainerRe: [PATCH v4 5/6] drm/gem-shmem: Track folio accessed/dirty status in mmap
Hi
Am 13.03.26 um 07:44 schrieb Biju Das:
Quoted 24 lines
Quoted 24 lines
-----Original Message-----
From: dri-devel <[email protected]> On Behalf Of Biju Das
Sent: 12 March 2026 17:47
To: Tommaso Merciai <[email protected]>; Thomas Zimmermann <[email protected]>
Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]
Subject: RE: [PATCH v4 5/6] drm/gem-shmem: Track folio accessed/dirty status in mmapHi Tommaso,
Quoted 12 lines
-----Original Message-----
From: Tommaso Merciai <[email protected]>
Sent: 12 March 2026 17:37
Subject: Re: [PATCH v4 5/6] drm/gem-shmem: Track folio accessed/dirty status in mmapHi Thomas,
Thanks for your patch.I'm working on DSI support for RZ/G3E from this morning rebasing on top of next-20260311 I'm seeing that weston hang on my side:
Quoted 8 lines
Quoted 7 lines
Quoted 5 lines
Reverting this patch fix the issue.
(git revert28e3918179aa)I'm wondering if anyone encountered this issue?
Thanks in advance.I am also seeing same issue on RZ/G3L with weston.
Just add I am using mesa with panfrost(Mali-G31) on RZ/G3L.
I ran the tests with bochs. I don't have panfrost hardware to test with, but nothing in the driver sticks out as problematic. Only the gem open/close logic looks a bit awkward. The mmap code appears to be identical.
Quoted 5 lines
Disabling Mali-G31 renders weston desktop during boot.
Looks like this patch is creating some hang in panfrost driver during weston launch.
Does either of you see any warnings in the kernel messages?
Quoted 2 lines
Cheers,
[...]
Quoted 3 lines
drivers/gpu/drm/drm_gem_shmem_helper.c +3
-0+if (ret ==VM_FAULT_NOPAGE ) +folio_mark_accessed (folio); +
[...]
[...]
Quoted 2 lines
drivers/gpu/drm/drm_gem_shmem_helper.c +2
-0+if (drm_WARN_ON (obj->dev, !shmem->pages || page_offset >= num_pages)) +return VM_FAULT_SIGBUS ;
[...]
Quoted 1 line
drivers/gpu/drm/drm_gem_shmem_helper.c +1
-0+file_update_time (vma->vm_file);
[...]
Review
Quoted 2 lines
(quoted diff) +2
-0+ + folio_mark_dirty(page_folio(shmem->pages[page_offset]));
Out-commenting either of these should work. Could you please go through them one by one and test if out-commenting either makes a difference?
Best regards
Thomas
Quoted 16 lines
drivers/gpu/drm/drm_gem_shmem_helper.c +5
-1+ +return 0 ; +} +const struct vm_operations_struct drm_gem_shmem_vm_ops = { .fault = drm_gem_shmem_fault, .open = drm_gem_shmem_vm_open, .close = drm_gem_shmem_vm_close, + .pfn_mkwrite = drm_gem_shmem_pfn_mkwrite, };EXPORT_SYMBOL_GPL (drm_gem_shmem_vm_ops); --2.52.0
Signature · 6 lines
-- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)
RE: [PATCH v4 5/6] drm/gem-shmem: Track folio accessed/dirty status in mmap
Quoted 53 lines
-----Original Message-----
From: Thomas Zimmermann <[email protected]>
Sent: 13 March 2026 08:01
Subject: Re: [PATCH v4 5/6] drm/gem-shmem: Track folio accessed/dirty status in mmapHi
Am 13.03.26 um 07:44 schrieb Biju Das:
Quoted 29 lines
Quoted 29 lines
-----Original Message-----
From: dri-devel <[email protected]> On Behalf Of Biju Das
Sent: 12 March 2026 17:47
To: Tommaso Merciai <[email protected]>; Thomas Zimmermann <[email protected]>
Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]
Subject: RE: [PATCH v4 5/6] drm/gem-shmem: Track folio accessed/dirty status in mmapHi Tommaso,
Quoted 12 lines
-----Original Message-----
From: Tommaso Merciai <[email protected]>
Sent: 12 March 2026 17:37
Subject: Re: [PATCH v4 5/6] drm/gem-shmem: Track folio accessed/dirty status in mmapHi Thomas,
Thanks for your patch.I'm working on DSI support for RZ/G3E from this morning rebasing on top of next-20260311 I'm seeing that weston hang on my side:
Quoted 8 lines
Quoted 7 lines
Quoted 5 lines
Reverting this patch fix the issue.
(git revert28e3918179aa)I'm wondering if anyone encountered this issue? Thanks in advance.
I am also seeing same issue on RZ/G3L with weston.
Just add I am using mesa with panfrost(Mali-G31) on RZ/G3L.
I ran the tests with bochs. I don't have panfrost hardware to test with, but nothing in the driver sticks out as problematic. Only the gem open/close logic looks a bit awkward. The mmap code appears to be identical.
Quoted 1 line
Quoted 6 lines
Quoted 4 lines
Disabling Mali-G31 renders weston desktop during boot.
Looks like this patch is creating some hang in panfrost driver during weston launch.
Does either of you see any warnings in the kernel messages?
There is no kernel messages
[ OK ] Finished Virtual Console Setup. [ OK ] Started User Manager for UID 1000. [ OK ] Started Session c1 of User weston.
Cheers,
Biju
RE: [PATCH v4 5/6] drm/gem-shmem: Track folio accessed/dirty status in mmap
In reply to Thomas ZimmermannHi Thomas,
Quoted 10 lines
-----Original Message-----
From: Thomas Zimmermann <[email protected]>
Sent: 13 March 2026 08:01
Subject: Re: [PATCH v4 5/6] drm/gem-shmem: Track folio accessed/dirty status in mmapdrivers/gpu/drm/drm_gem_shmem_helper.c static void drm_gem_shmem_vm_close(struct vm_area_struct *vma) · line 666
Quoted 5 lines
const struct vm_operations_struct drm_gem_shmem_vm_ops = { .fault = drm_gem_shmem_fault, .open = drm_gem_shmem_vm_open, .close = drm_gem_shmem_vm_close,drivers/gpu/drm/drm_gem_shmem_helper.c +1
-0+ .pfn_mkwrite = drm_gem_shmem_pfn_mkwrite,
Commenting this makes weston to work. Kmscube works without this change.
Cheers,
Biju
Re: [PATCH v4 5/6] drm/gem-shmem: Track folio accessed/dirty status in mmap
In reply to Biju DasQuoted 101 lines · On Fri, 13 Mar 2026 06:44:25 +0000 Biju Das <[email protected]> wrote:
Quoted 23 lines
-----Original Message-----
From: dri-devel <[email protected]> On Behalf Of Biju Das
Sent: 12 March 2026 17:47
To: Tommaso Merciai <[email protected]>; Thomas Zimmermann <[email protected]>
Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]
Subject: RE: [PATCH v4 5/6] drm/gem-shmem: Track folio accessed/dirty status in mmapHi Tommaso,
Quoted 12 lines
-----Original Message-----
From: Tommaso Merciai <[email protected]>
Sent: 12 March 2026 17:37
Subject: Re: [PATCH v4 5/6] drm/gem-shmem: Track folio accessed/dirty status in mmapHi Thomas,
Thanks for your patch.I'm working on DSI support for RZ/G3E from this morning rebasing on top of next-20260311 I'm seeing that weston hang on my side:
Quoted 8 lines
Quoted 5 lines
Reverting this patch fix the issue.
(git revert28e3918179aa)I'm wondering if anyone encountered this issue?
Thanks in advance.I am also seeing same issue on RZ/G3L with weston.
Just add I am using mesa with panfrost(Mali-G31) on RZ/G3L.
Disabling Mali-G31 renders weston desktop during boot.
Looks like this patch is creating some hang in panfrost driver during weston launch.
Cheers,
BijuQuoted 57 lines
Cheers,
BijuQuoted 51 lines
Kind Regards,
TommasoQuoted 46 lines · Thomas Zimmermann
Invoke
folio_mark_accessed()in mmap page faults to add the folio to the memory manager's LRU list. Userspace invokes mmap to get the memory for software rendering. Compositors do the same when creating the final on-screen image, so keeping the pages in LRU makes sense. Avoids paging out graphics buffers when under memory pressure.In
pfn_mkwrite, further invoke thefolio_mark_dirty()to add the folio for writeback should the underlying file be paged out from system memory. This rarely happens in practice, yet it would corrupt the buffer content.This has little effect on a system's hardware-accelerated rendering, which only mmaps for an initial setup of textures, meshes, shaders, etc.
v4:
- test forVM_FAULT_NOPAGEbefore marking folio as accessed (Boris)
- test page-array bounds in mkwrite handler (Boris)
v3:
- rewrite forVM_PFNMAP
v2:
- adapt to changes indrm_gem_shmem_try_mmap_pmd()Signed-off-by Thomas Zimmermann <[email protected]>Reviewed-by Boris Brezillon <[email protected]>--- drivers/gpu/drm/drm_gem_shmem_helper.c | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+)drivers/gpu/drm/drm_gem_shmem_helper.c +3
-0@@ -598,6 +598,9 @@ static vm_fault_t drm_gem_shmem_fault(struct vm_fault *vmf)if (ret !=VM_FAULT_NOPAGE ) ret =vmf_insert_pfn (vma, vmf->address, pfn); +if (ret ==VM_FAULT_NOPAGE ) +folio_mark_accessed (folio); + out:dma_resv_unlock (obj->resv);@@ -638,10 +641,29 @@ static void drm_gem_shmem_vm_close(struct vm_area_struct *vma)drm_gem_vm_close (vma); }
Quoted 14 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
drivers/gpu/drm/drm_gem_shmem_helper.c +6
-0+static vm_fault_t drm_gem_shmem_pfn_mkwrite (struct vm_fault *vmf) { +struct vm_area_struct *vma = vmf->vma; +struct drm_gem_object *obj = vma->vm_private_data; +struct drm_gem_shmem_object *shmem =to_drm_gem_shmem_obj (obj); +loff_t num_pages = obj->size >>PAGE_SHIFT ; +pgoff_t page_offset = vmf->pgoff - vma->vm_pgoff;/* page offset Quoted 8 lines
Quoted 8 lines
drivers/gpu/drm/drm_gem_shmem_helper.c static void drm_gem_shmem_vm_close(struct vm_area_struct *vma) · line 657
Quoted 8 lines
drivers/gpu/drm/drm_gem_shmem_helper.c +8
-0+within VMA */ + +if (drm_WARN_ON (obj->dev, !shmem->pages || page_offset >= num_pages)) +return VM_FAULT_SIGBUS ; + +file_update_time (vma->vm_file); + +folio_mark_dirty (page_folio (shmem->pages[page_offset]));
Do we need a folio_mark_dirty_lock() here?
Quoted 15 lines
Quoted 15 lines
Quoted 15 lines
Quoted 15 lines
drivers/gpu/drm/drm_gem_shmem_helper.c +5
-1+ +return 0 ; +} +const struct vm_operations_struct drm_gem_shmem_vm_ops = { .fault = drm_gem_shmem_fault, .open = drm_gem_shmem_vm_open, .close = drm_gem_shmem_vm_close, + .pfn_mkwrite = drm_gem_shmem_pfn_mkwrite, };EXPORT_SYMBOL_GPL (drm_gem_shmem_vm_ops); --2.52.0
Thomas Zimmermann
maintainerRe: [PATCH v4 5/6] drm/gem-shmem: Track folio accessed/dirty status in mmap
Hi
Am 13.03.26 um 11:18 schrieb Boris Brezillon:
[...]
Quoted 7 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
drivers/gpu/drm/drm_gem_shmem_helper.c static void drm_gem_shmem_vm_close(struct vm_area_struct *vma) · line 657
Quoted 6 lines
drivers/gpu/drm/drm_gem_shmem_helper.c +6
-0+if (drm_WARN_ON (obj->dev, !shmem->pages || page_offset >= num_pages)) +return VM_FAULT_SIGBUS ; + +file_update_time (vma->vm_file); + +folio_mark_dirty (page_folio (shmem->pages[page_offset]));Do we need a
folio_mark_dirty_lock()here?
There is a helper for that with some documentation. [1]
[1] https://elixir.bootlin.com/linux/v6.19.7/source/mm/page-writeback.c#L2826
Best regards
Thomas
Quoted 16 lines
Quoted 16 lines
Quoted 16 lines
Quoted 16 lines
Quoted 16 lines
drivers/gpu/drm/drm_gem_shmem_helper.c +5
-1+ +return 0 ; +} +const struct vm_operations_struct drm_gem_shmem_vm_ops = { .fault = drm_gem_shmem_fault, .open = drm_gem_shmem_vm_open, .close = drm_gem_shmem_vm_close, + .pfn_mkwrite = drm_gem_shmem_pfn_mkwrite, };EXPORT_SYMBOL_GPL (drm_gem_shmem_vm_ops); --2.52.0
Signature · 6 lines
-- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)
RE: [PATCH v4 5/6] drm/gem-shmem: Track folio accessed/dirty status in mmap
Hi Thomas,
Quoted 17 lines
-----Original Message-----
From: Thomas Zimmermann <[email protected]>
Sent: 13 March 2026 10:30
Subject: Re: [PATCH v4 5/6] drm/gem-shmem: Track folio accessed/dirty status in mmapHi
Am 13.03.26 um 11:18 schrieb Boris Brezillon:
[...]Quoted 7 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
drivers/gpu/drm/drm_gem_shmem_helper.c static void drm_gem_shmem_vm_close(struct vm_area_struct *vma) · line 657
Quoted 6 lines
drivers/gpu/drm/drm_gem_shmem_helper.c +6
-0+if (drm_WARN_ON (obj->dev, !shmem->pages || page_offset >= num_pages)) +return VM_FAULT_SIGBUS ; + +file_update_time (vma->vm_file); + +folio_mark_dirty (page_folio (shmem->pages[page_offset]));Do we need a
folio_mark_dirty_lock()here?
Quoted 4 lines
There is a helper for that with some documentation. [1]
[1]
https://elixir.bootlin.com/linux/v6.19.7/source/mm/page-writeback.c#L2826
FYI, I commented all the calls in the patch, it does not solve the issue.
Commenting the callback below fixed the issue.
//.pfn_mkwrite = drm_gem_shmem_pfn_mkwrite,
Cheers,
Biju
Quoted 25 lines
Quoted 13 lines
Quoted 13 lines
Quoted 13 lines
Quoted 13 lines
Quoted 13 lines
drivers/gpu/drm/drm_gem_shmem_helper.c +5
-0+ +return 0 ; +} +const struct vm_operations_struct drm_gem_shmem_vm_ops = { .fault = drm_gem_shmem_fault, .open = drm_gem_shmem_vm_open, .close = drm_gem_shmem_vm_close, + .pfn_mkwrite = drm_gem_shmem_pfn_mkwrite, };EXPORT_SYMBOL_GPL (drm_gem_shmem_vm_ops);Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
--
2.52.0--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com
GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)
Re: [PATCH v4 5/6] drm/gem-shmem: Track folio accessed/dirty status in mmap
In reply to Thomas ZimmermannQuoted 12 lines · On Fri, 13 Mar 2026 11:29:47 +0100 Thomas Zimmermann <[email protected]>…
Hi
Am 13.03.26 um 11:18 schrieb Boris Brezillon:
[...]Quoted 7 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
drivers/gpu/drm/drm_gem_shmem_helper.c static void drm_gem_shmem_vm_close(struct vm_area_struct *vma) · line 657
Quoted 6 lines
drivers/gpu/drm/drm_gem_shmem_helper.c +6
-0+if (drm_WARN_ON (obj->dev, !shmem->pages || page_offset >= num_pages)) +return VM_FAULT_SIGBUS ; + +file_update_time (vma->vm_file); + +folio_mark_dirty (page_folio (shmem->pages[page_offset]));Do we need a
folio_mark_dirty_lock()here?
Quoted 1 line
There is a helper for that with some documentation. [1]
I know, I meant using that version instead of folio_mark_dirty().
Re: [PATCH v4 5/6] drm/gem-shmem: Track folio accessed/dirty status in mmap
In reply to Thomas ZimmermannQuoted 12 lines · On Fri, 13 Mar 2026 11:29:47 +0100 Thomas Zimmermann <[email protected]>…
Hi
Am 13.03.26 um 11:18 schrieb Boris Brezillon:
[...]Quoted 7 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
drivers/gpu/drm/drm_gem_shmem_helper.c static void drm_gem_shmem_vm_close(struct vm_area_struct *vma) · line 657
Quoted 6 lines
drivers/gpu/drm/drm_gem_shmem_helper.c +6
-0+if (drm_WARN_ON (obj->dev, !shmem->pages || page_offset >= num_pages)) +return VM_FAULT_SIGBUS ; + +file_update_time (vma->vm_file); + +folio_mark_dirty (page_folio (shmem->pages[page_offset]));Do we need a
folio_mark_dirty_lock()here?
Quoted 1 line
There is a helper for that with some documentation. [1]
This [1] seems to solve the problem for me. Still unsure about the folio_mark_dirty_lock vs folio_mark_dirty though.
RE: [PATCH v4 5/6] drm/gem-shmem: Track folio accessed/dirty status in mmap
Quoted 22 lines
-----Original Message-----
From: dri-devel <[email protected]> On Behalf Of Boris Brezillon
Sent: 13 March 2026 11:57
Subject: Re: [PATCH v4 5/6] drm/gem-shmem: Track folio accessed/dirty status in mmapQuoted 12 lines · On Fri, 13 Mar 2026 11:29:47 +0100 Thomas Zimmermann <[email protected]>…
Hi
Am 13.03.26 um 11:18 schrieb Boris Brezillon:
[...]Quoted 7 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Review
Quoted 6 lines
(quoted diff) +6
-0+ if (drm_WARN_ON(obj->dev, !shmem->pages || page_offset >= num_pages)) + return VM_FAULT_SIGBUS; + + file_update_time(vma->vm_file); + + folio_mark_dirty(page_folio(shmem->pages[page_offset]));Do we need a
folio_mark_dirty_lock()here?
Quoted 6 lines
Quoted 1 line
There is a helper for that with some documentation. [1]
This [1] seems to solve the problem for me. Still unsure about the
folio_mark_dirty_lockvsfolio_mark_dirtythough.
FYI, I used folio_mark_dirty_lock() still it does not solve the issue with weston hang.
Cheers,
Biju
Re: [PATCH v4 5/6] drm/gem-shmem: Track folio accessed/dirty status in mmap
Quoted 20 lines · On Fri, 13 Mar 2026 12:04:25 +0000 Biju Das <[email protected]> wrote:
Quoted 20 lines
-----Original Message-----
From: dri-devel <[email protected]> On Behalf Of Boris Brezillon
Sent: 13 March 2026 11:57
Subject: Re: [PATCH v4 5/6] drm/gem-shmem: Track folio accessed/dirty status in mmapQuoted 12 lines · On Fri, 13 Mar 2026 11:29:47 +0100 Thomas Zimmermann <[email protected]>…
Hi
Am 13.03.26 um 11:18 schrieb Boris Brezillon:
[...]Quoted 7 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Review
Quoted 6 lines
(quoted diff) +6
-0+ if (drm_WARN_ON(obj->dev, !shmem->pages || page_offset >= num_pages)) + return VM_FAULT_SIGBUS; + + file_update_time(vma->vm_file); + + folio_mark_dirty(page_folio(shmem->pages[page_offset]));Do we need a
folio_mark_dirty_lock()here?
Quoted 8 lines
Quoted 6 lines
Quoted 1 line
There is a helper for that with some documentation. [1]
This [1] seems to solve the problem for me. Still unsure about the
folio_mark_dirty_lockvsfolio_mark_dirtythough.FYI, I used
folio_mark_dirty_lock()still it does not solve the issue with weston hang.
The patch I pointed to has nothing to do with folio_mark_dirty_lock(), It's a bug caused by huge page mapping changes.
Re: [PATCH v4 5/6] drm/gem-shmem: Track folio accessed/dirty status in mmap
Quoted 28 lines · On Fri, 13 Mar 2026 13:18:35 +0100 Boris Brezillon…
Quoted 25 lines · On Fri, 13 Mar 2026 12:04:25 +0000 Biju Das <[email protected]> wrote:
Quoted 25 lines
-----Original Message-----
From: dri-devel <[email protected]> On Behalf Of Boris Brezillon
Sent: 13 March 2026 11:57
Subject: Re: [PATCH v4 5/6] drm/gem-shmem: Track folio accessed/dirty status in mmapQuoted 12 lines · On Fri, 13 Mar 2026 11:29:47 +0100 Thomas Zimmermann <[email protected]>…
Hi
Am 13.03.26 um 11:18 schrieb Boris Brezillon:
[...]Quoted 7 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Review
Quoted 6 lines
(quoted diff) +6
-0+ if (drm_WARN_ON(obj->dev, !shmem->pages || page_offset >= num_pages)) + return VM_FAULT_SIGBUS; + + file_update_time(vma->vm_file); + + folio_mark_dirty(page_folio(shmem->pages[page_offset]));Do we need a
folio_mark_dirty_lock()here?Quoted 1 line
There is a helper for that with some documentation. [1]
This [1] seems to solve the problem for me. Still unsure about the
folio_mark_dirty_lockvsfolio_mark_dirtythough.
Quoted 6 lines
Quoted 3 lines
Quoted 1 line
FYI, I used
folio_mark_dirty_lock()still it does not solve the issue with weston hang.The patch I pointed to has nothing to do with
folio_mark_dirty_lock(), It's a bug caused by huge page mapping changes.
Scratch that. I had a bunch of other changes on top, and it hangs again now that I dropped those.
Re: [PATCH v4 5/6] drm/gem-shmem: Track folio accessed/dirty status in mmap
Quoted 33 lines · On Fri, 13 Mar 2026 13:43:28 +0100 Boris Brezillon…
Quoted 30 lines · On Fri, 13 Mar 2026 13:18:35 +0100 Boris Brezillon…
Quoted 27 lines · On Fri, 13 Mar 2026 12:04:25 +0000 Biju Das <[email protected]> wrote:
Quoted 26 lines
-----Original Message-----
From: dri-devel <[email protected]> On Behalf Of Boris Brezillon
Sent: 13 March 2026 11:57
Subject: Re: [PATCH v4 5/6] drm/gem-shmem: Track folio accessed/dirty status in mmapQuoted 12 lines · On Fri, 13 Mar 2026 11:29:47 +0100 Thomas Zimmermann <[email protected]>…
Hi
Am 13.03.26 um 11:18 schrieb Boris Brezillon:
[...]Quoted 7 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Review
Quoted 6 lines
(quoted diff) +6
-0+ if (drm_WARN_ON(obj->dev, !shmem->pages || page_offset >= num_pages)) + return VM_FAULT_SIGBUS; + + file_update_time(vma->vm_file); + + folio_mark_dirty(page_folio(shmem->pages[page_offset]));Do we need a
folio_mark_dirty_lock()here?Quoted 1 line
There is a helper for that with some documentation. [1]
This [1] seems to solve the problem for me. Still unsure about the
folio_mark_dirty_lockvsfolio_mark_dirtythough.
Quoted 7 lines
Quoted 4 lines
Quoted 1 line
FYI, I used
folio_mark_dirty_lock()still it does not solve the issue with weston hang.The patch I pointed to has nothing to do with
folio_mark_dirty_lock(), It's a bug caused by huge page mapping changes.Scratch that. I had a bunch of other changes on top, and it hangs again now that I dropped those.
Seems like it's the combination of huge pages and mkwrite that's causing issues, if I disable huge pages, it doesn't hang...
Re: [PATCH v4 5/6] drm/gem-shmem: Track folio accessed/dirty status in mmap
Quoted 38 lines · On Fri, 13 Mar 2026 13:55:21 +0100 Boris Brezillon…
Quoted 35 lines · On Fri, 13 Mar 2026 13:43:28 +0100 Boris Brezillon…
Quoted 32 lines · On Fri, 13 Mar 2026 13:18:35 +0100 Boris Brezillon…
Quoted 28 lines · On Fri, 13 Mar 2026 12:04:25 +0000 Biju Das <[email protected]> wrote:
Quoted 20 lines
-----Original Message-----
From: dri-devel <[email protected]> On Behalf Of Boris Brezillon
Sent: 13 March 2026 11:57
Subject: Re: [PATCH v4 5/6] drm/gem-shmem: Track folio accessed/dirty status in mmapQuoted 12 lines · On Fri, 13 Mar 2026 11:29:47 +0100 Thomas Zimmermann <[email protected]>…
Hi
Am 13.03.26 um 11:18 schrieb Boris Brezillon:
[...]Quoted 7 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Review
Quoted 6 lines
(quoted diff) +6
-0+ if (drm_WARN_ON(obj->dev, !shmem->pages || page_offset >= num_pages)) + return VM_FAULT_SIGBUS; + + file_update_time(vma->vm_file); + + folio_mark_dirty(page_folio(shmem->pages[page_offset]));Do we need a
folio_mark_dirty_lock()here?Quoted 6 lines
Quoted 1 line
There is a helper for that with some documentation. [1]
This [1] seems to solve the problem for me. Still unsure about the
folio_mark_dirty_lockvsfolio_mark_dirtythough.FYI, I used
folio_mark_dirty_lock()still it does not solve the issue with weston hang.
Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
The patch I pointed to has nothing to do with
folio_mark_dirty_lock(), It's a bug caused by huge page mapping changes.Scratch that. I had a bunch of other changes on top, and it hangs again now that I dropped those.
Seems like it's the combination of huge pages and mkwrite that's causing issues, if I disable huge pages, it doesn't hang...
I managed to have it working with the following diff. I still need to check why the "map-RO-split+RW-on-demand" approach doesn't work (races between huge_fault and pfn_mkwrite?), but I think it's okay to map the real thing writable on the first attempt anyway (we're not trying to do CoW here, since we're always pointing to the same page, it's just the permissions that change). Note that there's still the race fixed by
https://yhbt.net/lore/dri-devel/[email protected]/
in this diff, I just tried to keep the diffstat minimal.
--->8---
drivers/gpu/drm/drm_gem_shmem_helper.c +6 -3
@@ -561,9 +561,8 @@ static vm_fault_t drm_gem_shmem_try_insert_pfn_pmd(struct vm_fault *vmf, unsignebool aligned = (vmf->address & ~PMD_MASK ) == (paddr & ~PMD_MASK );if (aligned &&pmd_none (*vmf->pmd)) { -/* Read-only mapping; split upon write fault */ pfn &=PMD_MASK >>PAGE_SHIFT ; -return vmf_insert_pfn_pmd (vmf, pfn, false); +return vmf_insert_pfn_pmd (vmf, pfn, vmf->flags &FAULT_FLAG_WRITE ); }#endif
@@ -597,8 +596,12 @@ static vm_fault_t drm_gem_shmem_fault(struct vm_fault *vmf) pfn =page_to_pfn (page); -if (folio_test_pmd_mappable (folio)) +if (folio_test_pmd_mappable (folio)) { ret =drm_gem_shmem_try_insert_pfn_pmd (vmf, pfn); +if (ret ==VM_FAULT_NOPAGE && vmf->flags &FAULT_FLAG_WRITE ) +folio_mark_dirty (folio); + } +if (ret !=VM_FAULT_NOPAGE ) ret =vmf_insert_pfn (vma, vmf->address, pfn);
RE: [PATCH v4 5/6] drm/gem-shmem: Track folio accessed/dirty status in mmap
Hi Boris Brezillon,
Quoted 57 lines
-----Original Message-----
From: dri-devel <[email protected]> On Behalf Of Boris Brezillon
Sent: 13 March 2026 17:46
Subject: Re: [PATCH v4 5/6] drm/gem-shmem: Track folio accessed/dirty status in mmapQuoted 40 lines · On Fri, 13 Mar 2026 13:55:21 +0100 Boris Brezillon…
Quoted 37 lines · On Fri, 13 Mar 2026 13:43:28 +0100 Boris Brezillon…
Quoted 34 lines · On Fri, 13 Mar 2026 13:18:35 +0100 Boris Brezillon…
Quoted 30 lines · On Fri, 13 Mar 2026 12:04:25 +0000 Biju Das <[email protected]> wrote:
Quoted 22 lines
-----Original Message-----
From: dri-devel <[email protected]> On Behalf Of Boris Brezillon
Sent: 13 March 2026 11:57
Subject: Re: [PATCH v4 5/6] drm/gem-shmem: Track folio accessed/dirty status in mmapQuoted 12 lines · On Fri, 13 Mar 2026 11:29:47 +0100 Thomas Zimmermann <[email protected]>…
Hi
Am 13.03.26 um 11:18 schrieb Boris Brezillon:
[...]Quoted 7 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Review
Quoted 6 lines
(quoted diff) +6
-0+ if (drm_WARN_ON(obj->dev, !shmem->pages || page_offset >= num_pages)) + return VM_FAULT_SIGBUS; + + file_update_time(vma->vm_file); + + folio_mark_dirty(page_folio(shmem->pages[page_offset]));Do we need a
folio_mark_dirty_lock()here?Quoted 6 lines
Quoted 1 line
There is a helper for that with some documentation. [1]
This [1] seems to solve the problem for me. Still unsure about the
folio_mark_dirty_lockvsfolio_mark_dirtythough.FYI, I used
folio_mark_dirty_lock()still it does not solve the issue with weston hang.Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
The patch I pointed to has nothing to do with
folio_mark_dirty_lock(), It's a bug caused by huge page mapping changes.Scratch that. I had a bunch of other changes on top, and it hangs again now that I dropped those.
Seems like it's the combination of huge pages and mkwrite that's causing issues, if I disable huge pages, it doesn't hang...
Quoted 6 lines
I managed to have it working with the following diff. I still need to check why the "map-RO-split+RW- on-demand" approach doesn't work (races between
huge_faultandpfn_mkwrite?), but I think it's okay to map the real thing writable on the first attempt anyway (we're not trying to do CoW here, since we're always pointing to the same page, it's just the permissions that change). Note that there's still the race fixed by https://yhbt.net/lore/dri-devel/[email protected]/
in this diff, I just tried to keep the diffstat minimal.
I confirm with this diff, weston is now coming up on RZ/V2L SMARC EVK.
I am just using drm-misc-next + this diff + arm64 defconfig + Poky (Yocto Project Reference Distro) 5.0.11 + Mesa
Cheers,
Biju
Quoted 32 lines
--->8---
drivers/gpu/drm/drm_gem_shmem_helper.c +7
-3@@ -561,9 +561,8 @@ static vm_fault_t drm_gem_shmem_try_insert_pfn_pmd(struct vm_fault *vmf, unsignebool aligned = (vmf->address & ~PMD_MASK ) == (paddr & ~PMD_MASK );if (aligned &&pmd_none (*vmf->pmd)) { -/* Read-only mapping; split upon write fault */ pfn &=PMD_MASK >>PAGE_SHIFT ; -return vmf_insert_pfn_pmd (vmf, pfn, false); +return vmf_insert_pfn_pmd (vmf, pfn, vmf->flags & +FAULT_FLAG_WRITE ); }#endif @@ -597,8 +596,12 @@ static vm_fault_t drm_gem_shmem_fault(struct vm_fault *vmf) pfn =page_to_pfn (page); -if (folio_test_pmd_mappable (folio)) +if (folio_test_pmd_mappable (folio)) { ret =drm_gem_shmem_try_insert_pfn_pmd (vmf, pfn); +if (ret ==VM_FAULT_NOPAGE && vmf->flags &FAULT_FLAG_WRITE ) +folio_mark_dirty (folio); + } +if (ret !=VM_FAULT_NOPAGE ) ret =vmf_insert_pfn (vma, vmf->address, pfn);
RE: [PATCH v4 5/6] drm/gem-shmem: Track folio accessed/dirty status in mmap
Hi All,
Quoted 112 lines
-----Original Message-----
From: Biju Das
Sent: 14 March 2026 09:43
Subject: RE: [PATCH v4 5/6] drm/gem-shmem: Track folio accessed/dirty status in mmapHi Boris Brezillon,
Quoted 62 lines
-----Original Message-----
From: dri-devel <[email protected]> On Behalf Of Boris Brezillon
Sent: 13 March 2026 17:46
Subject: Re: [PATCH v4 5/6] drm/gem-shmem: Track folio accessed/dirty status in mmapQuoted 43 lines · On Fri, 13 Mar 2026 13:55:21 +0100 Boris Brezillon…
Quoted 40 lines · On Fri, 13 Mar 2026 13:43:28 +0100 Boris Brezillon…
Quoted 37 lines · On Fri, 13 Mar 2026 13:18:35 +0100 Boris Brezillon…
Quoted 33 lines · On Fri, 13 Mar 2026 12:04:25 +0000 Biju Das <[email protected]> wrote:
Quoted 24 lines
-----Original Message-----
From: dri-devel <[email protected]> On Behalf Of Boris Brezillon
Sent: 13 March 2026 11:57
Subject: Re: [PATCH v4 5/6] drm/gem-shmem: Track folio accessed/dirty status in mmapQuoted 14 lines · On Fri, 13 Mar 2026 11:29:47 +0100 Thomas Zimmermann <[email protected]>…
Hi
Am 13.03.26 um 11:18 schrieb Boris Brezillon:
[...]Quoted 9 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
+ if (drm_WARN_ON(obj->dev, !shmem->pages || page_offset >= num_pages))
+ return VM_FAULT_SIGBUS;
+
+ file_update_time(vma->vm_file);
+
+
+folio_mark_dirty(page_folio(shmem->pages[page_offse
+t]));Do we need a
folio_mark_dirty_lock()here?Quoted 7 lines
Quoted 1 line
There is a helper for that with some documentation. [1]
This [1] seems to solve the problem for me. Still unsure about the
folio_mark_dirty_lockvsfolio_mark_dirtythough.[1]https://yhbt.net/lore/dri-devel/20260312155027.1682606-1- [email protected]/
FYI, I used
folio_mark_dirty_lock()still it does not solve the issue with weston hang.Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
The patch I pointed to has nothing to do with
folio_mark_dirty_lock(), It's a bug caused by huge page mapping changes.Scratch that. I had a bunch of other changes on top, and it hangs again now that I dropped those.
Seems like it's the combination of huge pages and mkwrite that's causing issues, if I disable huge pages, it doesn't hang...
Quoted 9 lines
I managed to have it working with the following diff. I still need to check why the "map-RO-split+RW- on-demand" approach doesn't work (races between
huge_faultandpfn_mkwrite?), but I think it's okay to map the real thing writable on the first attempt anyway (we're not trying to do CoW here, since we're always pointing to the same page, it's just the permissions that change). Note that there's still the race fixed by
https://yhbt.net/lore/dri-devel/20260312155027.1682606-1-pedrodemargom
[email protected]/ in this diff, I just tried to keep the diffstat minimal.I confirm with this diff, weston is now coming up on RZ/V2L SMARC EVK.
I am just using drm-misc-next + this diff + arm64 defconfig + Poky (Yocto Project Reference Distro) 5.0.11 + Mesa
Cheers,
BijuQuoted 25 lines
--->8---
drivers/gpu/drm/drm_gem_shmem_helper.c +2
-2@@ -561,9 +561,8 @@ static vm_fault_t drm_gem_shmem_try_insert_pfn_pmd(struct vm_fault *vmf, unsignebool aligned = (vmf->address & ~PMD_MASK ) == (paddr & ~PMD_MASK );if (aligned &&pmd_none (*vmf->pmd)) { -/* Read-only mapping; split upon write fault */ pfn &=PMD_MASK >>PAGE_SHIFT ; -return vmf_insert_pfn_pmd (vmf, pfn, false); +return vmf_insert_pfn_pmd (vmf, pfn, vmf->flags & +FAULT_FLAG_WRITE ); }#endif @@ -597,8 +596,12 @@ static vm_fault_t drm_gem_shmem_fault(struct vm_fault *vmf) pfn =page_to_pfn (page);
Quoted 10 lines
drivers/gpu/drm/drm_gem_shmem_helper.c static vm_fault_t drm_gem_shmem_fault(struct vm_fault *vmf) · line 606
Quoted 10 lines
drivers/gpu/drm/drm_gem_shmem_helper.c +5
-1-if (folio_test_pmd_mappable (folio)) +if (folio_test_pmd_mappable (folio)) { ret =drm_gem_shmem_try_insert_pfn_pmd (vmf, pfn); +if (ret ==VM_FAULT_NOPAGE && vmf->flags &FAULT_FLAG_WRITE ) +folio_mark_dirty (folio); + } +if (ret !=VM_FAULT_NOPAGE ) ret =vmf_insert_pfn (vma, vmf->address, pfn);
Any patch available to fix the weston issue? Still the issue is present with drm-misc-next Please let me know.
Cheers,
Biju
Re: [PATCH v4 5/6] drm/gem-shmem: Track folio accessed/dirty status in mmap
Quoted 114 lines · On Thu, 19 Mar 2026 14:17:31 +0000 Biju Das <[email protected]> wrote:
Hi All,
Quoted 112 lines
-----Original Message-----
From: Biju Das
Sent: 14 March 2026 09:43
Subject: RE: [PATCH v4 5/6] drm/gem-shmem: Track folio accessed/dirty status in mmapHi Boris Brezillon,
Quoted 62 lines
-----Original Message-----
From: dri-devel <[email protected]> On Behalf Of Boris Brezillon
Sent: 13 March 2026 17:46
Subject: Re: [PATCH v4 5/6] drm/gem-shmem: Track folio accessed/dirty status in mmapQuoted 43 lines · On Fri, 13 Mar 2026 13:55:21 +0100 Boris Brezillon…
Quoted 40 lines · On Fri, 13 Mar 2026 13:43:28 +0100 Boris Brezillon…
Quoted 37 lines · On Fri, 13 Mar 2026 13:18:35 +0100 Boris Brezillon…
Quoted 33 lines · On Fri, 13 Mar 2026 12:04:25 +0000 Biju Das <[email protected]> wrote:
Quoted 24 lines
-----Original Message-----
From: dri-devel <[email protected]> On Behalf Of Boris Brezillon
Sent: 13 March 2026 11:57
Subject: Re: [PATCH v4 5/6] drm/gem-shmem: Track folio accessed/dirty status in mmapQuoted 14 lines · On Fri, 13 Mar 2026 11:29:47 +0100 Thomas Zimmermann <[email protected]>…
Hi
Am 13.03.26 um 11:18 schrieb Boris Brezillon:
[...]Quoted 9 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
+ if (drm_WARN_ON(obj->dev, !shmem->pages || page_offset >= num_pages))
+ return VM_FAULT_SIGBUS;
+
+ file_update_time(vma->vm_file);
+
+
+folio_mark_dirty(page_folio(shmem->pages[page_offse
+t]));Do we need a
folio_mark_dirty_lock()here?Quoted 7 lines
Quoted 1 line
There is a helper for that with some documentation. [1]
This [1] seems to solve the problem for me. Still unsure about the
folio_mark_dirty_lockvsfolio_mark_dirtythough.[1]https://yhbt.net/lore/dri-devel/20260312155027.1682606-1- [email protected]/
FYI, I used
folio_mark_dirty_lock()still it does not solve the issue with weston hang.Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
The patch I pointed to has nothing to do with
folio_mark_dirty_lock(), It's a bug caused by huge page mapping changes.Scratch that. I had a bunch of other changes on top, and it hangs again now that I dropped those.
Seems like it's the combination of huge pages and mkwrite that's causing issues, if I disable huge pages, it doesn't hang...
Quoted 9 lines
I managed to have it working with the following diff. I still need to check why the "map-RO-split+RW- on-demand" approach doesn't work (races between
huge_faultandpfn_mkwrite?), but I think it's okay to map the real thing writable on the first attempt anyway (we're not trying to do CoW here, since we're always pointing to the same page, it's just the permissions that change). Note that there's still the race fixed by
https://yhbt.net/lore/dri-devel/20260312155027.1682606-1-pedrodemargom
[email protected]/ in this diff, I just tried to keep the diffstat minimal.I confirm with this diff, weston is now coming up on RZ/V2L SMARC EVK.
I am just using drm-misc-next + this diff + arm64 defconfig + Poky (Yocto Project Reference Distro) 5.0.11 + Mesa
Cheers,
BijuQuoted 25 lines
--->8---
drivers/gpu/drm/drm_gem_shmem_helper.c +2
-2@@ -561,9 +561,8 @@ static vm_fault_t drm_gem_shmem_try_insert_pfn_pmd(struct vm_fault *vmf, unsignebool aligned = (vmf->address & ~PMD_MASK ) == (paddr & ~PMD_MASK );if (aligned &&pmd_none (*vmf->pmd)) { -/* Read-only mapping; split upon write fault */ pfn &=PMD_MASK >>PAGE_SHIFT ; -return vmf_insert_pfn_pmd (vmf, pfn, false); +return vmf_insert_pfn_pmd (vmf, pfn, vmf->flags & +FAULT_FLAG_WRITE ); }#endif @@ -597,8 +596,12 @@ static vm_fault_t drm_gem_shmem_fault(struct vm_fault *vmf) pfn =page_to_pfn (page);
Quoted 13 lines
Quoted 10 lines
drivers/gpu/drm/drm_gem_shmem_helper.c static vm_fault_t drm_gem_shmem_fault(struct vm_fault *vmf) · line 606
Quoted 10 lines
drivers/gpu/drm/drm_gem_shmem_helper.c +5
-1-if (folio_test_pmd_mappable (folio)) +if (folio_test_pmd_mappable (folio)) { ret =drm_gem_shmem_try_insert_pfn_pmd (vmf, pfn); +if (ret ==VM_FAULT_NOPAGE && vmf->flags &FAULT_FLAG_WRITE ) +folio_mark_dirty (folio); + } +if (ret !=VM_FAULT_NOPAGE ) ret =vmf_insert_pfn (vma, vmf->address, pfn);Any patch available to fix the weston issue? Still the issue is present with drm-misc-next Please let me know.
Not yet. I want to land [1] first. I'll try to post an official version of the proposed fix tomorrow, though I'd really like to have some inputs from the MM maintainers before claiming this is the right fix...
RE: [PATCH v4 5/6] drm/gem-shmem: Track folio accessed/dirty status in mmap
Hi Boris,
Quoted 143 lines
-----Original Message-----
From: dri-devel <[email protected]> On Behalf Of Boris Brezillon
Sent: 19 March 2026 14:50
Subject: Re: [PATCH v4 5/6] drm/gem-shmem: Track folio accessed/dirty status in mmapQuoted 96 lines · On Thu, 19 Mar 2026 14:17:31 +0000 Biju Das <[email protected]> wrote:
Hi All,
Quoted 94 lines
-----Original Message-----
From: Biju Das
Sent: 14 March 2026 09:43
Subject: RE: [PATCH v4 5/6] drm/gem-shmem: Track folio accessed/dirty status in mmapHi Boris Brezillon,
Quoted 65 lines
-----Original Message-----
From: dri-devel <[email protected]> On Behalf Of Boris Brezillon
Sent: 13 March 2026 17:46
Subject: Re: [PATCH v4 5/6] drm/gem-shmem: Track folio accessed/dirty status in mmapQuoted 46 lines · On Fri, 13 Mar 2026 13:55:21 +0100 Boris Brezillon…
Quoted 43 lines · On Fri, 13 Mar 2026 13:43:28 +0100 Boris Brezillon…
Quoted 40 lines · On Fri, 13 Mar 2026 13:18:35 +0100 Boris Brezillon…
Quoted 36 lines · On Fri, 13 Mar 2026 12:04:25 +0000 Biju Das <[email protected]> wrote:
Quoted 26 lines
-----Original Message-----
From: dri-devel <[email protected]> On Behalf Of Boris Brezillon
Sent: 13 March 2026 11:57
Subject: Re: [PATCH v4 5/6] drm/gem-shmem: Track folio accessed/dirty status in mmapQuoted 15 lines · On Fri, 13 Mar 2026 11:29:47 +0100 Thomas Zimmermann <[email protected]>…
Hi
Am 13.03.26 um 11:18 schrieb Boris Brezillon:
[...]Quoted 10 lines
Quoted 9 lines
Quoted 9 lines
+ if (drm_WARN_ON(obj->dev, !shmem->pages || page_offset >= num_pages))
+ return VM_FAULT_SIGBUS;
+
+ file_update_time(vma->vm_file);
+
+
+folio_mark_dirty(page_folio(shmem->pages[page_o
+ffse
+t]));Do we need a
folio_mark_dirty_lock()here?Quoted 8 lines
Quoted 2 lines
There is a helper for that with some documentation.
[1]This [1] seems to solve the problem for me. Still unsure about the
folio_mark_dirty_lockvsfolio_mark_dirtythough.[1]https://yhbt.net/lore/dri-devel/20260312155027.168260 6-1- [email protected]/
FYI, I used
folio_mark_dirty_lock()still it does not solve the issue with weston hang.Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
The patch I pointed to has nothing to do with
folio_mark_dirty_lock(), It's a bug caused by huge page mapping changes.Scratch that. I had a bunch of other changes on top, and it hangs again now that I dropped those.
Seems like it's the combination of huge pages and mkwrite that's causing issues, if I disable huge pages, it doesn't hang...
Quoted 10 lines
I managed to have it working with the following diff. I still need to check why the "map-RO-split+RW- on-demand" approach doesn't work (races between
huge_faultandpfn_mkwrite?), but I think it's okay to map the real thing writable on the first attempt anyway (we're not trying to do CoW here, since we're always pointing to the same page, it's just the permissions that change). Note that there's still the race fixed by
https://yhbt.net/lore/dri-devel/20260312155027.1682606-1-pedrodema
rgom [email protected]/ in this diff, I just tried to keep the diffstat minimal.I confirm with this diff, weston is now coming up on RZ/V2L SMARC EVK.
I am just using drm-misc-next + this diff + arm64 defconfig + Poky (Yocto Project Reference Distro)
5.0.11 + MesaCheers,
BijuQuoted 1 line
Quoted 7 lines
Quoted 7 lines
drivers/gpu/drm/drm_gem_shmem_helper.c static vm_fault_t drm_gem_shmem_try_insert_pfn_pmd(struct vm_fault *vmf,
Quoted 7 lines
--->8---
drivers/gpu/drm/drm_gem_shmem_helper.c +0
-0@@ -561,9 +561,8 @@ static vm_fault_t drm_gem_shmem_try_insert_pfn_pmd(struct vm_fault *vmf,unsigne
Quoted 17 lines
Quoted 17 lines
Quoted 17 lines
drivers/gpu/drm/drm_gem_shmem_helper.c +2
-2bool aligned = (vmf->address & ~PMD_MASK ) == (paddr & ~PMD_MASK );if (aligned &&pmd_none (*vmf->pmd)) { -/* Read-only mapping; split upon write fault */ pfn &=PMD_MASK >>PAGE_SHIFT ; -return vmf_insert_pfn_pmd (vmf, pfn, false); +return vmf_insert_pfn_pmd (vmf, pfn, vmf->flags & +FAULT_FLAG_WRITE ); }#endif @@ -597,8 +596,12 @@ static vm_fault_t drm_gem_shmem_fault(struct vm_fault *vmf) pfn =page_to_pfn (page);Quoted 13 lines
Quoted 10 lines
drivers/gpu/drm/drm_gem_shmem_helper.c static vm_fault_t drm_gem_shmem_fault(struct vm_fault *vmf) · line 606
Quoted 10 lines
drivers/gpu/drm/drm_gem_shmem_helper.c +5
-1-if (folio_test_pmd_mappable (folio)) +if (folio_test_pmd_mappable (folio)) { ret =drm_gem_shmem_try_insert_pfn_pmd (vmf, pfn); +if (ret ==VM_FAULT_NOPAGE && vmf->flags &FAULT_FLAG_WRITE ) +folio_mark_dirty (folio); + } +if (ret !=VM_FAULT_NOPAGE ) ret =vmf_insert_pfn (vma, vmf->address, pfn);Any patch available to fix the weston issue? Still the issue is present with drm-misc-next Please let me know.
Quoted 5 lines
Not yet. I want to land [1] first. I'll try to post an official version of the proposed fix tomorrow, though I'd really like to have some inputs from the MM maintainers before claiming this is the right fix...
Thanks for the update.
Cheers,
Biju
Thomas Zimmermann
maintainerRe: [PATCH v4 5/6] drm/gem-shmem: Track folio accessed/dirty status in mmap
In reply to Boris BrezillonHi Boris,
thanks for investigating this problem.
Am 13.03.26 um 18:45 schrieb Boris Brezillon:
Quoted 71 lines
Quoted 32 lines · On Fri, 13 Mar 2026 13:55:21 +0100 Boris Brezillon…
Quoted 29 lines · On Fri, 13 Mar 2026 13:43:28 +0100 Boris Brezillon…
Quoted 26 lines · On Fri, 13 Mar 2026 13:18:35 +0100 Boris Brezillon…
Quoted 23 lines · On Fri, 13 Mar 2026 12:04:25 +0000 Biju Das <[email protected]> wrote:
Quoted 23 lines
-----Original Message-----
From: dri-devel <[email protected]> On Behalf Of Boris Brezillon
Sent: 13 March 2026 11:57
Subject: Re: [PATCH v4 5/6] drm/gem-shmem: Track folio accessed/dirty status in mmapQuoted 4 lines · On Fri, 13 Mar 2026 11:29:47 +0100 Thomas Zimmermann <[email protected]>…
Hi
Am 13.03.26 um 11:18 schrieb Boris Brezillon:
[...]Quoted 8 lines
Quoted 7 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Review
Quoted 6 lines
(quoted diff) +6
-0+ if (drm_WARN_ON(obj->dev, !shmem->pages || page_offset >= num_pages)) + return VM_FAULT_SIGBUS; + + file_update_time(vma->vm_file); + + folio_mark_dirty(page_folio(shmem->pages[page_offset]));Do we need a
folio_mark_dirty_lock()here?There is a helper for that with some documentation. [1]
This [1] seems to solve the problem for me. Still unsure about the
folio_mark_dirty_lockvsfolio_mark_dirtythough.Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
Quoted 2 lines
Quoted 1 line
FYI, I used
folio_mark_dirty_lock()still it does not solve the issue with weston hang.The patch I pointed to has nothing to do with
folio_mark_dirty_lock(), It's a bug caused by huge page mapping changes.Scratch that. I had a bunch of other changes on top, and it hangs again now that I dropped those.
Seems like it's the combination of huge pages and mkwrite that's causing issues, if I disable huge pages, it doesn't hang...
I managed to have it working with the following diff. I still need to check why the "map-RO-split+RW-on-demand" approach doesn't work (races between
huge_faultandpfn_mkwrite?), but I think it's okay to map the real thing writable on the first attempt anyway (we're not trying to do CoW here, since we're always pointing to the same page, it's just the permissions that change). Note that there's still the race fixed by
https://yhbt.net/lore/dri-devel/[email protected]/
in this diff, I just tried to keep the diffstat minimal.--->8---
drivers/gpu/drm/drm_gem_shmem_helper.c +1
-2@@ -561,9 +561,8 @@ static vm_fault_t drm_gem_shmem_try_insert_pfn_pmd(struct vm_fault *vmf, unsignebool aligned = (vmf->address & ~PMD_MASK ) == (paddr & ~PMD_MASK );if (aligned &&pmd_none (*vmf->pmd)) { -/* Read-only mapping; split upon write fault */ pfn &=PMD_MASK >>PAGE_SHIFT ; -return vmf_insert_pfn_pmd (vmf, pfn, false); +return vmf_insert_pfn_pmd (vmf, pfn, vmf->flags &FAULT_FLAG_WRITE ); }#endif @@ -597,8 +596,12 @@ static vm_fault_t drm_gem_shmem_fault(struct vm_fault *vmf) pfn =page_to_pfn (page);
drivers/gpu/drm/drm_gem_shmem_helper.c static vm_fault_t drm_gem_shmem_fault(struct vm_fault *vmf) · line 606
Quoted 10 lines
drivers/gpu/drm/drm_gem_shmem_helper.c +5
-1-if (folio_test_pmd_mappable (folio)) +if (folio_test_pmd_mappable (folio)) { ret =drm_gem_shmem_try_insert_pfn_pmd (vmf, pfn); +if (ret ==VM_FAULT_NOPAGE && vmf->flags &FAULT_FLAG_WRITE ) +folio_mark_dirty (folio); + } +if (ret !=VM_FAULT_NOPAGE ) ret =vmf_insert_pfn (vma, vmf->address, pfn);
All these branches with NOPAGE seem confusing. Can we change the overall logic here? Something like:
if (folio_test_pmd_mappable()) {
ret = try_insert_pfn_pmd()
if (ret == VM_FAULT_NOPAGE) {
folio_mark_accessed()
if (flags & FLAG_WRITE)
folio_mark_dirty()
goto out;
}
}
ret = vmf_insert_pfn()
if (ret == NOPAGE)
folio_mark_accesed()
out:
...
This would keep the huge-page code within the first branch. And if it fails, it still does the regular page fault.
Best regards
Thomas
Quoted 1 line
Signature · 6 lines
-- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)
Re: [PATCH v4 5/6] drm/gem-shmem: Track folio accessed/dirty status in mmap
Quoted 104 lines · On Mon, 16 Mar 2026 09:45:49 +0100 Thomas Zimmermann <[email protected]>…
Hi Boris,
thanks for investigating this problem.
Am 13.03.26 um 18:45 schrieb Boris Brezillon:
Quoted 71 lines
Quoted 32 lines · On Fri, 13 Mar 2026 13:55:21 +0100 Boris Brezillon…
Quoted 29 lines · On Fri, 13 Mar 2026 13:43:28 +0100 Boris Brezillon…
Quoted 26 lines · On Fri, 13 Mar 2026 13:18:35 +0100 Boris Brezillon…
Quoted 23 lines · On Fri, 13 Mar 2026 12:04:25 +0000 Biju Das <[email protected]> wrote:
Quoted 23 lines
-----Original Message-----
From: dri-devel <[email protected]> On Behalf Of Boris Brezillon
Sent: 13 March 2026 11:57
Subject: Re: [PATCH v4 5/6] drm/gem-shmem: Track folio accessed/dirty status in mmapQuoted 4 lines · On Fri, 13 Mar 2026 11:29:47 +0100 Thomas Zimmermann <[email protected]>…
Hi
Am 13.03.26 um 11:18 schrieb Boris Brezillon:
[...]Quoted 8 lines
Quoted 7 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
+ if (drm_WARN_ON(obj->dev, !shmem->pages || page_offset >= num_pages))
+ return VM_FAULT_SIGBUS;
+
+ file_update_time(vma->vm_file);
+
+ folio_mark_dirty(page_folio(shmem->pages[page_offset]));Do we need a
folio_mark_dirty_lock()here?There is a helper for that with some documentation. [1]
This [1] seems to solve the problem for me. Still unsure about the
folio_mark_dirty_lockvsfolio_mark_dirtythough.Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
Quoted 2 lines
Quoted 1 line
FYI, I used
folio_mark_dirty_lock()still it does not solve the issue with weston hang.The patch I pointed to has nothing to do with
folio_mark_dirty_lock(), It's a bug caused by huge page mapping changes.Scratch that. I had a bunch of other changes on top, and it hangs again now that I dropped those.
Seems like it's the combination of huge pages and mkwrite that's causing issues, if I disable huge pages, it doesn't hang...
I managed to have it working with the following diff. I still need to check why the "map-RO-split+RW-on-demand" approach doesn't work (races between
huge_faultandpfn_mkwrite?), but I think it's okay to map the real thing writable on the first attempt anyway (we're not trying to do CoW here, since we're always pointing to the same page, it's just the permissions that change). Note that there's still the race fixed by
https://yhbt.net/lore/dri-devel/[email protected]/
in this diff, I just tried to keep the diffstat minimal.--->8---
drivers/gpu/drm/drm_gem_shmem_helper.c +1
-2@@ -561,9 +561,8 @@ static vm_fault_t drm_gem_shmem_try_insert_pfn_pmd(struct vm_fault *vmf, unsignebool aligned = (vmf->address & ~PMD_MASK ) == (paddr & ~PMD_MASK );if (aligned &&pmd_none (*vmf->pmd)) { -/* Read-only mapping; split upon write fault */ pfn &=PMD_MASK >>PAGE_SHIFT ; -return vmf_insert_pfn_pmd (vmf, pfn, false); +return vmf_insert_pfn_pmd (vmf, pfn, vmf->flags &FAULT_FLAG_WRITE ); }#endif @@ -597,8 +596,12 @@ static vm_fault_t drm_gem_shmem_fault(struct vm_fault *vmf) pfn =page_to_pfn (page);drivers/gpu/drm/drm_gem_shmem_helper.c static vm_fault_t drm_gem_shmem_fault(struct vm_fault *vmf) · line 606
Quoted 10 lines
drivers/gpu/drm/drm_gem_shmem_helper.c +5
-1-if (folio_test_pmd_mappable (folio)) +if (folio_test_pmd_mappable (folio)) { ret =drm_gem_shmem_try_insert_pfn_pmd (vmf, pfn); +if (ret ==VM_FAULT_NOPAGE && vmf->flags &FAULT_FLAG_WRITE ) +folio_mark_dirty (folio); + } +if (ret !=VM_FAULT_NOPAGE ) ret =vmf_insert_pfn (vma, vmf->address, pfn);All these branches with NOPAGE seem confusing. Can we change the overall logic here? Something like:
if (
folio_test_pmd_mappable()) {
ret =try_insert_pfn_pmd()
if (ret ==VM_FAULT_NOPAGE) {
folio_mark_accessed()
if (flags &FLAG_WRITE)
folio_mark_dirty()
goto out;
}
}ret =
vmf_insert_pfn()
if (ret == NOPAGE)
folio_mark_accesed()
Quoted 6 lines
out:
...This would keep the huge-page code within the first branch. And if it fails, it still does the regular page fault.
Well, in practice that's not what we want anyway (see the other fix for the huge_fault vs regular fault race), so I'd still be inclined to have the folio_mark_accessed() handled in the common path and have the pmd vs regular pfn insertion in some if/else branches. Something like that:
if (pmd_insert)
ret = drm_gem_shmem_try_insert_pfn_pmd(vmf, pfn);
else
ret = vmf_insert_pfn(vma, vmf->address, pfn);
if (ret == VM_FAULT_NOPAGE) {
folio_mark_accesed(folio);
/* Normal pages are mapped RO, and remapped RW afterwards. */
if (pmd_insert && vmf->flags & FAULT_FLAG_WRITE)
folio_mark_dirty(folio);
}Thomas Zimmermann
maintainerRe: [PATCH v4 5/6] drm/gem-shmem: Track folio accessed/dirty status in mmap
Hi
Am 16.03.26 um 10:36 schrieb Boris Brezillon:
[...]
Quoted 7 lines
Quoted 2 lines
This would keep the huge-page code within the first branch. And if it fails, it still does the regular page fault.
Well, in practice that's not what we want anyway (see the other fix for the
huge_faultvs regular fault race), so I'd still be inclined to have thefolio_mark_accessed()handled in the common path and have the pmd vs regular pfn insertion in some if/else branches. Something like that:
Quoted 10 lines
if (pmd_insert)
ret = drm_gem_shmem_try_insert_pfn_pmd(vmf, pfn);
else
ret = vmf_insert_pfn(vma, vmf->address, pfn);
if (ret == VM_FAULT_NOPAGE) {
folio_mark_accesed(folio);
/* Normal pages are mapped RO, and remapped RW afterwards. */
if (pmd_insert && vmf->flags & FAULT_FLAG_WRITE)This style mixes conditions from different branching depths. The first outermost branch uses pmd_insert to compute ret. Any then both have changed places, so that ret is in the outer branch and pmd_insert is in the inner branch. This is hard to maintain. It is already confusing now and will be even more so to anyone locking at that code later on.
Best regards
Thomas
Quoted 2 lines
folio_mark_dirty(folio); }
Signature · 6 lines
-- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)
Re: [PATCH v4 5/6] drm/gem-shmem: Track folio accessed/dirty status in mmap
Quoted 19 lines · On Mon, 16 Mar 2026 11:22:49 +0100 Thomas Zimmermann <[email protected]>…
Hi
Am 16.03.26 um 10:36 schrieb Boris Brezillon:
[...]Quoted 15 lines
Quoted 2 lines
This would keep the huge-page code within the first branch. And if it fails, it still does the regular page fault.
Well, in practice that's not what we want anyway (see the other fix for the
huge_faultvs regular fault race), so I'd still be inclined to have thefolio_mark_accessed()handled in the common path and have the pmd vs regular pfn insertion in some if/else branches. Something like that:if (pmd_insert) ret = drm_gem_shmem_try_insert_pfn_pmd(vmf, pfn); else ret = vmf_insert_pfn(vma, vmf->address, pfn); if (ret == VM_FAULT_NOPAGE) { folio_mark_accesed(folio);
Quoted 8 lines
Quoted 2 lines
/* Normal pages are mapped RO, and remapped RW afterwards. */ if (pmd_insert && vmf->flags & FAULT_FLAG_WRITE)This style mixes conditions from different branching depths. The first outermost branch uses
pmd_insertto compute ret. Any then both have changed places, so that ret is in the outer branch andpmd_insertis in the inner branch. This is hard to maintain. It is already confusing now and will be even more so to anyone locking at that code later on.
I guess that's another occurrence of us disagreeing on what's easy/uneasy to maintain :P. I find it way easier to group things by functionality (here that would be folio state tracking) at the cost of having conditionals repeated (I trust the compiler to do the proper optimization) than having multiple paths doing exactly the same thing. The latter easily leads to one path being updated while the other path is left behind when new features/fixes are proposed.
Re: [PATCH v4 5/6] drm/gem-shmem: Track folio accessed/dirty status in mmap
In reply to Thomas ZimmermannQuoted 56 lines · On Mon, 16 Mar 2026 09:45:49 +0100 Thomas Zimmermann <[email protected]>…
Hi Boris,
thanks for investigating this problem.
Am 13.03.26 um 18:45 schrieb Boris Brezillon:
Quoted 51 lines
Quoted 32 lines · On Fri, 13 Mar 2026 13:55:21 +0100 Boris Brezillon…
Quoted 29 lines · On Fri, 13 Mar 2026 13:43:28 +0100 Boris Brezillon…
Quoted 26 lines · On Fri, 13 Mar 2026 13:18:35 +0100 Boris Brezillon…
Quoted 23 lines · On Fri, 13 Mar 2026 12:04:25 +0000 Biju Das <[email protected]> wrote:
Quoted 23 lines
-----Original Message-----
From: dri-devel <[email protected]> On Behalf Of Boris Brezillon
Sent: 13 March 2026 11:57
Subject: Re: [PATCH v4 5/6] drm/gem-shmem: Track folio accessed/dirty status in mmapQuoted 4 lines · On Fri, 13 Mar 2026 11:29:47 +0100 Thomas Zimmermann <[email protected]>…
Hi
Am 13.03.26 um 11:18 schrieb Boris Brezillon:
[...]Quoted 8 lines
Quoted 7 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
+ if (drm_WARN_ON(obj->dev, !shmem->pages || page_offset >= num_pages))
+ return VM_FAULT_SIGBUS;
+
+ file_update_time(vma->vm_file);
+
+ folio_mark_dirty(page_folio(shmem->pages[page_offset]));Do we need a
folio_mark_dirty_lock()here?There is a helper for that with some documentation. [1]
This [1] seems to solve the problem for me. Still unsure about the
folio_mark_dirty_lockvsfolio_mark_dirtythough.Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
Quoted 2 lines
Quoted 1 line
FYI, I used
folio_mark_dirty_lock()still it does not solve the issue with weston hang.The patch I pointed to has nothing to do with
folio_mark_dirty_lock(), It's a bug caused by huge page mapping changes.Scratch that. I had a bunch of other changes on top, and it hangs again now that I dropped those.
Seems like it's the combination of huge pages and mkwrite that's causing issues, if I disable huge pages, it doesn't hang...
I managed to have it working with the following diff. I still need to check why the "map-RO-split+RW-on-demand" approach doesn't work (races between
huge_faultandpfn_mkwrite?), but I think it's okay to map the real thing writable on the first attempt anyway (we're not trying to do CoW here, since we're always pointing to the same page, it's just the permissions that change). Note that there's still the race fixed by
https://yhbt.net/lore/dri-devel/[email protected]/
in this diff, I just tried to keep the diffstat minimal.
^ "that's not present in this diff"
sorry for the confusion.
Aside from that, I've been looking more closely at the code in mm/memory.c, and other implementations of .pfn_mkwrite(), and I'm still not confident that:
- we can call folio_mark_dirty() without the folio lock held in that path unless we have the GEM resv lock held (the pte lock is released, and I'm not sure there's anything else holding on the folio).
- we can claim that the huge vs normal-page paths are race-free. That's probably okay as long as we only do the dirty bookkeeping in pfn_mkwrite (we might flag the folio dirty before we know the writeable mapping has been setup propertly, but that's probably okay). What worries me a bit is the fact most implementations call their fault handler from pfn_mkwrite() and do the page table update from there. There's also this comment [1] that makes me doubt we're doing the right thing here.
Would be good if someone from MM could chime in and shed some light on what's supposed to happen in pfn_mkwrite (Matthew, perhaps?).
[1]https://elixir.bootlin.com/linux/v6.17.2/source/fs/xfs/xfs_file.c#L1899
Thomas Zimmermann
maintainerRe: [PATCH v4 5/6] drm/gem-shmem: Track folio accessed/dirty status in mmap
In reply to Biju DasHi
Am 12.03.26 um 18:46 schrieb Biju Das:
Quoted 15 lines
Hi Tommaso,
Quoted 13 lines
-----Original Message-----
From: Tommaso Merciai <[email protected]>
Sent: 12 March 2026 17:37
Subject: Re: [PATCH v4 5/6] drm/gem-shmem: Track folio accessed/dirty status in mmapHi Thomas,
Thanks for your patch.I'm working on DSI support for RZ/G3E from this morning rebasing on top of next-20260311 I'm seeing that weston hang on my side:
Reverting this patch fix the issue.
(git revert28e3918179aa)
Just a guess, but maybe vm_file is NULL. The attached patch should handle this. Could either of you please test?
Best regards
Thomas
Quoted 90 lines
Quoted 3 lines
I'm wondering if anyone encountered this issue?
Thanks in advance.I am also seeing same issue on RZ/G3L with weston.
Cheers,
BijuQuoted 79 lines
Kind Regards,
TommasoQuoted 75 lines · Thomas Zimmermann
Invoke
folio_mark_accessed()in mmap page faults to add the folio to the memory manager's LRU list. Userspace invokes mmap to get the memory for software rendering. Compositors do the same when creating the final on-screen image, so keeping the pages in LRU makes sense. Avoids paging out graphics buffers when under memory pressure.In
pfn_mkwrite, further invoke thefolio_mark_dirty()to add the folio for writeback should the underlying file be paged out from system memory. This rarely happens in practice, yet it would corrupt the buffer content.This has little effect on a system's hardware-accelerated rendering, which only mmaps for an initial setup of textures, meshes, shaders, etc.
v4:
- test forVM_FAULT_NOPAGEbefore marking folio as accessed (Boris)
- test page-array bounds in mkwrite handler (Boris)
v3:
- rewrite forVM_PFNMAP
v2:
- adapt to changes indrm_gem_shmem_try_mmap_pmd()Signed-off-by Thomas Zimmermann <[email protected]>Reviewed-by Boris Brezillon <[email protected]>--- drivers/gpu/drm/drm_gem_shmem_helper.c | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+)drivers/gpu/drm/drm_gem_shmem_helper.c +22
-1@@ -598,6 +598,9 @@ static vm_fault_t drm_gem_shmem_fault(struct vm_fault *vmf)if (ret !=VM_FAULT_NOPAGE ) ret =vmf_insert_pfn (vma, vmf->address, pfn); +if (ret ==VM_FAULT_NOPAGE ) +folio_mark_accessed (folio); + out:dma_resv_unlock (obj->resv);@@ -638,10 +641,29 @@ static void drm_gem_shmem_vm_close(struct vm_area_struct *vma)drm_gem_vm_close (vma); } +static vm_fault_t drm_gem_shmem_pfn_mkwrite (struct vm_fault *vmf) { +struct vm_area_struct *vma = vmf->vma; +struct drm_gem_object *obj = vma->vm_private_data; +struct drm_gem_shmem_object *shmem =to_drm_gem_shmem_obj (obj); +loff_t num_pages = obj->size >>PAGE_SHIFT ; +pgoff_t page_offset = vmf->pgoff - vma->vm_pgoff;/* page offset +within VMA */ + +if (drm_WARN_ON (obj->dev, !shmem->pages || page_offset >= num_pages)) +return VM_FAULT_SIGBUS ; + +file_update_time (vma->vm_file); + +folio_mark_dirty (page_folio (shmem->pages[page_offset])); + +return 0 ; +} +const struct vm_operations_struct drm_gem_shmem_vm_ops = { .fault = drm_gem_shmem_fault, .open = drm_gem_shmem_vm_open, .close = drm_gem_shmem_vm_close, + .pfn_mkwrite = drm_gem_shmem_pfn_mkwrite, };EXPORT_SYMBOL_GPL (drm_gem_shmem_vm_ops); --2.52.0
Signature · 6 lines
-- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)
From e64346c6b3d946e4424066d888cb41fe60eb9d88 Mon Sep 17 00:00:00 2001
From: Thomas Zimmermann <[email protected]>
Date: Fri, 13 Mar 2026 09:29:26 +0100
Subject: [PATCH] test for vm_file before updating file access time
--- drivers/gpu/drm/drm_gem_shmem_helper.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/drm_gem_shmem_helper.c +2 -1
@@ -656,7 +656,8 @@ static vm_fault_t drm_gem_shmem_pfn_mkwrite(struct vm_fault *vmf)if (drm_WARN_ON (obj->dev, !shmem->pages || page_offset >= num_pages))return VM_FAULT_SIGBUS ; -file_update_time (vma->vm_file); +if (vma->vm_file) +file_update_time (vma->vm_file);folio_mark_dirty (page_folio (shmem->pages[page_offset]));
Signature · 1 line
2.53.0
RE: [PATCH v4 5/6] drm/gem-shmem: Track folio accessed/dirty status in mmap
Quoted 20 lines
-----Original Message-----
From: Thomas Zimmermann <[email protected]>
Sent: 13 March 2026 08:34
Subject: Re: [PATCH v4 5/6] drm/gem-shmem: Track folio accessed/dirty status in mmapHi
Am 12.03.26 um 18:46 schrieb Biju Das:
Quoted 11 lines
Hi Tommaso,
Quoted 9 lines
-----Original Message-----
From: Tommaso Merciai <[email protected]>
Sent: 12 March 2026 17:37
Subject: Re: [PATCH v4 5/6] drm/gem-shmem: Track folio accessed/dirty status in mmapHi Thomas,
Thanks for your patch.
Quoted 8 lines
Quoted 5 lines
Quoted 5 lines
I'm working on DSI support for RZ/G3E from this morning rebasing on top of next-20260311 I'm seeing that weston hang on my side:
Reverting this patch fix the issue.
(git revert28e3918179aa)Just a guess, but maybe
vm_fileis NULL. The attached patch should handle this. Could either of you please test?
No Luck. I will try to enable some print in panfrost driver.
oot@smarc-rzv2l:~# systemctl status weston
* weston.service - Weston, a Wayland compositor, as a system service
Loaded: loaded (/usr/lib/systemd/system/weston.service; enabled; preset: enabled)
Active: active (running) since Sat 2000-01-01 00:00:06 UTC; 56s ago
TriggeredBy: * weston.socket
Docs: man:weston(1)
man:weston.ini(5)
http://wayland.freedesktop.org/
Main PID: 238 (weston)
Tasks: 0 (limit: 1796)
Memory: 2.4M (peak: 2.9M)
CPU: 140ms
CGroup: /system.slice/weston.service
> 238 /usr/bin/weston --modules=systemd-notify.soJan 01 00:00:01 smarc-rzv2l systemd[1]: Starting Weston, a Wayland compositor, as a system service... Jan 01 00:00:06 smarc-rzv2l systemd[1]: Started Weston, a Wayland compositor, as a system service.
root@smarc-rzv2l:~#
Re: [PATCH v4 5/6] drm/gem-shmem: Track folio accessed/dirty status in mmap
In reply to Thomas ZimmermannHi Thomas,
Quoted 13 lines · Thomas Zimmermann
Hi
Am 12.03.26 um 18:46 schrieb Biju Das:
Quoted 10 lines
Hi Tommaso,
Quoted 8 lines
-----Original Message-----
From: Tommaso Merciai <[email protected]>
Sent: 12 March 2026 17:37
Subject: Re: [PATCH v4 5/6] drm/gem-shmem: Track folio accessed/dirty status in mmapHi Thomas,
Thanks for your patch.
Quoted 7 lines
Quoted 5 lines
Quoted 5 lines
I'm working on DSI support for RZ/G3E from this morning rebasing on top of next-20260311 I'm seeing that weston hang on my side:
Reverting this patch fix the issue.
(git revert28e3918179aa)Just a guess, but maybe
vm_fileis NULL. The attached patch should handle this. Could either of you please test?
Same here, no luck.
Thanks for sharing.
Kind Regards,
Tommaso
Quoted 99 lines
Best regards
ThomasQuoted 93 lines
Quoted 3 lines
I'm wondering if anyone encountered this issue?
Thanks in advance.I am also seeing same issue on RZ/G3L with weston.
Cheers,
BijuQuoted 82 lines
Kind Regards,
TommasoQuoted 78 lines · Thomas Zimmermann
Invoke
folio_mark_accessed()in mmap page faults to add the folio to the memory manager's LRU list. Userspace invokes mmap to get the memory for software rendering. Compositors do the same when creating the final on-screen image, so keeping the pages in LRU makes sense. Avoids paging out graphics buffers when under memory pressure.In
pfn_mkwrite, further invoke thefolio_mark_dirty()to add the folio for writeback should the underlying file be paged out from system memory. This rarely happens in practice, yet it would corrupt the buffer content.This has little effect on a system's hardware-accelerated rendering, which only mmaps for an initial setup of textures, meshes, shaders, etc.
v4:
- test forVM_FAULT_NOPAGEbefore marking folio as accessed (Boris)
- test page-array bounds in mkwrite handler (Boris)
v3:
- rewrite forVM_PFNMAP
v2:
- adapt to changes indrm_gem_shmem_try_mmap_pmd()Signed-off-by Thomas Zimmermann <[email protected]>Reviewed-by Boris Brezillon <[email protected]>---
drivers/gpu/drm/drm_gem_shmem_helper.c| 22 ++++++++++++++++++++++1 file changed, 22 insertions(+)drivers/gpu/drm/drm_gem_shmem_helper.c +3
-0@@ -598,6 +598,9 @@ static vm_fault_t drm_gem_shmem_fault(struct vm_fault *vmf) if (ret != VM_FAULT_NOPAGE) ret = vmf_insert_pfn(vma, vmf->address, pfn); + if (ret == VM_FAULT_NOPAGE) + folio_mark_accessed(folio); +out:
dma_resv_unlock(obj->resv);drivers/gpu/drm/drm_gem_shmem_helper.c +19
-0@@ -638,10 +641,29 @@ static void drm_gem_shmem_vm_close(struct vm_area_struct *vma) drm_gem_vm_close(vma); } +static vm_fault_t drm_gem_shmem_pfn_mkwrite (struct vm_fault *vmf) { + struct vm_area_struct *vma = vmf->vma; + struct drm_gem_object *obj = vma->vm_private_data; + struct drm_gem_shmem_object *shmem = to_drm_gem_shmem_obj(obj); + loff_t num_pages = obj->size >> PAGE_SHIFT; + pgoff_t page_offset = vmf->pgoff - vma->vm_pgoff; /* page offset +within VMA */ + + if (drm_WARN_ON(obj->dev, !shmem->pages || page_offset >= num_pages)) + return VM_FAULT_SIGBUS; + + file_update_time(vma->vm_file); + + folio_mark_dirty(page_folio(shmem->pages[page_offset])); + + return 0; +} + const struct vm_operations_struct drm_gem_shmem_vm_ops = { .fault = drm_gem_shmem_fault, .open = drm_gem_shmem_vm_open, .close = drm_gem_shmem_vm_close, + .pfn_mkwrite = drm_gem_shmem_pfn_mkwrite, };
EXPORT_SYMBOL_GPL(drm_gem_shmem_vm_ops);Signature · 1 line
2.52.0
Thomas Zimmermann
maintainerPATCH v4 6/6 drm/gem-shmem: Track folio accessed/dirty status in vmap
In reply to Thomas ZimmermannOn successful vmap, set the page_mark_accessed_on_put and _dirty_on_put flags in the gem-shmem object. Signals that the contained pages require LRU and dirty tracking when they are being released back to SHMEM. Clear these flags on put, so that the buffer remains quiet until the next call to vmap. There's no means of handling dirty status in vmap as there's no write-only mapping available.
Both flags, _accessed_on_put and _dirty_on_put, have always been part of the gem-shmem object, but never used much. So most drivers did not track the page status correctly.
Only the v3d and imagination drivers make limited use of _dirty_on_put. In the case of imagination, move the flag setting from init to cleanup. This ensures writeback of modified pages but does not interfere with the internal vmap/vunmap calls. V3d already implements this behaviour.
--- drivers/gpu/drm/drm_gem_shmem_helper.c | 4 ++++ drivers/gpu/drm/imagination/pvr_gem.c | 6 ++++-- 2 files changed, 8 insertions(+), 2 deletions(-)
drivers/gpu/drm/drm_gem_shmem_helper.c +4 -0
@@ -265,6 +265,8 @@ void drm_gem_shmem_put_pages_locked(struct drm_gem_shmem_object *shmem) shmem->pages_mark_dirty_on_put, shmem->pages_mark_accessed_on_put); shmem->pages =NULL ; + shmem->pages_mark_accessed_on_put = false; + shmem->pages_mark_dirty_on_put = false; } }EXPORT_SYMBOL_GPL (drm_gem_shmem_put_pages_locked);
@@ -397,6 +399,8 @@ int drm_gem_shmem_vmap_locked(struct drm_gem_shmem_object *shmem, }else {iosys_map_set_vaddr (map, shmem->vaddr);refcount_set (&shmem->vmap_use_count,1 ); + shmem->pages_mark_accessed_on_put = true; + shmem->pages_mark_dirty_on_put = true; } }
drivers/gpu/drm/imagination/pvr_gem.c +4 -2
@@ -25,7 +25,10 @@static void pvr_gem_object_free (struct drm_gem_object *obj) { -drm_gem_shmem_object_free (obj); +struct drm_gem_shmem_object *shmem_obj =to_drm_gem_shmem_obj (obj); + + shmem_obj->pages_mark_dirty_on_put = true; +drm_gem_shmem_free (shmem_obj); }static struct dma_buf *pvr_gem_export (struct drm_gem_object *obj,int flags)
@@ -363,7 +366,6 @@ pvr_gem_object_create(struct pvr_device *pvr_dev, size_t size, u64 flags)if (IS_ERR (shmem_obj))return ERR_CAST (shmem_obj); - shmem_obj->pages_mark_dirty_on_put = true; shmem_obj->map_wc = !(flags &PVR_BO_CPU_CACHED ); pvr_obj =shmem_gem_to_pvr_gem (shmem_obj); pvr_obj->flags = flags;
Signature · 1 line
2.52.0