FAILED: Patch "drm/i915/psr: Reject async flips when selective fetch is enabled" failed to apply to 6.12-stable tree
Sasha Levin
maintainerThe patch below does not apply to the 6.12-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.
Thanks,
Sasha
------------------ original commit in Linus's tree ------------------
From a5f0cc8e0cd4007370af6985cb152001310cf20c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Ville=20Syrj=C3=A4l=C3=A4?= <[email protected]>
Date: Wed, 5 Nov 2025 19:10:15 +0200
Subject: [PATCH] drm/i915/psr: Reject async flips when selective fetch is
enabled
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
The selective fetch code doesn't handle asycn flips correctly. There is a nonsense check for async flips in intel_psr2_sel_fetch_config_valid() but that only gets called for modesets/fastsets and thus does nothing for async flips.
Currently intel_async_flip_check_hw() is very unhappy as the selective fetch code pulls in planes that are not even async flips capable.
Reject async flips when selective fetch is enabled, until someone fixes this properly (ie. disable selective fetch while async flips are being issued).
--- drivers/gpu/drm/i915/display/intel_display.c | 8 ++++++++ drivers/gpu/drm/i915/display/intel_psr.c | 6 ------ 2 files changed, 8 insertions(+), 6 deletions(-)
drivers/gpu/drm/i915/display/intel_display.c +8 -0
@@ -6002,6 +6002,14 @@ static int intel_async_flip_check_uapi(struct intel_atomic_state *state,return -EINVAL ; } +/* FIXME: selective fetch should be disabled for async flips */ +if (new_crtc_state->enable_psr2_sel_fetch) { +drm_dbg_kms (display->drm, +"[CRTC:%d:%s] async flip disallowed with PSR2 selective fetch\n" , + crtc->base.base.id, crtc->base.name); +return -EINVAL ; + } +for_each_oldnew_intel_plane_in_state (state, plane, old_plane_state, new_plane_state, i) {if (plane->pipe != crtc->pipe)
drivers/gpu/drm/i915/display/intel_psr.c +0 -6
@@ -1301,12 +1301,6 @@ static bool intel_psr2_sel_fetch_config_valid(struct intel_dp *intel_dp,return false; } -if (crtc_state->uapi.async_flip) { -drm_dbg_kms (display->drm, -"PSR2 sel fetch not enabled, async flip enabled\n" ); -return false; - } -return crtc_state->enable_psr2_sel_fetch = true; }
Signature · 1 line
2.51.0