FAILED: Patch "ocfs2: fix reflink preserve cleanup issue" failed to apply to 5.10-stable tree
Subsystems (2)
Sasha Levin
maintainerThe patch below does not apply to the 5.10-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.
Thanks,
Sasha
------------------ original commit in Linus's tree ------------------
From 5138c936c2c82c9be8883921854bc6f7e1177d8c Mon Sep 17 00:00:00 2001
From: Heming Zhao <[email protected]>
Date: Wed, 10 Dec 2025 09:57:24 +0800
Subject: [PATCH] ocfs2: fix reflink preserve cleanup issue
commit c06c303832ec ("ocfs2: fix xattr array entry __counted_by error") doesn't handle all cases and the cleanup job for preserved xattr entries still has bug:
- the 'last' pointer should be shifted by one unit after cleanup an array entry.
- current code logic doesn't cleanup the first entry when xh_count is 1.
Note, commit c06c303832ec is also a bug fix for 0fe9b66c65f3.
--- fs/ocfs2/xattr.c | 4 ++++ 1 file changed, 4 insertions(+)
fs/ocfs2/xattr.c +4 -0
@@ -6395,6 +6395,10 @@ static int ocfs2_reflink_xattr_header(handle_t *handle, (void *)last - (void *)xe);memset (last,0 ,sizeof (struct ocfs2_xattr_entry )); + last = &new_xh->xh_entries[le16_to_cpu (new_xh->xh_count)] -1 ; + }else { +memset (xe,0 ,sizeof (struct ocfs2_xattr_entry )); + last =NULL ; }/*
Signature · 1 line
2.51.0