pinctrl: microchip-mssio: Fix missing return in probe
Subsystems (4)
PATCH 1/1 pinctrl: microchip-mssio: Fix missing return in probe
In mpfs_pinctrl_probe(), when pctrl->regmap fails, it just print out an error message without return, which could lead serious errors.
Fixes 488d704ed7b7 ("pinctrl: add polarfire soc mssio pinctrl driver")
Signed-off-by Felix Gu <[email protected]>
--- drivers/pinctrl/microchip/pinctrl-mpfs-mssio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pinctrl/microchip/pinctrl-mpfs-mssio.c +1 -1
@@ -686,7 +686,7 @@ static int mpfs_pinctrl_probe(struct platform_device *pdev) pctrl->regmap =device_node_to_regmap (pdev->dev.parent->of_node);if (IS_ERR (pctrl->regmap)) -dev_err_probe (dev,PTR_ERR (pctrl->regmap),"Failed to find syscon regmap\n" ); +return dev_err_probe (dev,PTR_ERR (pctrl->regmap),"Failed to find syscon regmap\n" ); pctrl->sysreg_regmap =syscon_regmap_lookup_by_compatible ("microchip,mpfs-sysreg-scb" );if (IS_ERR (pctrl->sysreg_regmap))
---
base-commit: 3fa5e5702a82d259897bd7e209469bc06368bf31
change-id: 20260303-mssio-7343495a184f
Best regards,
Signature · 1 line
Felix Gu <[email protected]>
Quoted 5 lines · Felix Gu
In
mpfs_pinctrl_probe(), whenpctrl->regmapfails, it just print out an error message without return, which could lead serious errors.Fixes 488d704ed7b7 ("pinctrl: add polarfire soc mssio pinctrl driver")Signed-off-by Felix Gu <[email protected]>
Reviewed-by Conor Dooley <[email protected]>
Linus Walleij
maintainerQuoted 5 lines · Felix Gu
In
mpfs_pinctrl_probe(), whenpctrl->regmapfails, it just print out an error message without return, which could lead serious errors.Fixes 488d704ed7b7 ("pinctrl: add polarfire soc mssio pinctrl driver")Signed-off-by Felix Gu <[email protected]>
Patch applied as nonurgent fix.
Yours,
Linus Walleij