Skip to contentSkip to conversation

tests/kms_invalid_mode: add prints when test skips

PATCH Superseded sumit kishore 3 participants 3 messages Mar 2 – Mar 3

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tests/kms_invalid_mode: add prints when test skips

add debug print to display the reason for test skip

---
 tests/kms_invalid_mode.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
tests/kms_invalid_mode.c +3 -1
index 5edffb649..8ba488812 100644
@@ -266,7 +266,9 @@ test_output(data_t *data)
 	 * sure everything is really getting rejected?
 	 */
 	mode = *igt_output_get_mode(output);
-	igt_require(data->adjust_mode(data, &mode));
+	igt_require_f(data->adjust_mode(data, &mode),
+		"Skipping as %s has scaling properties\n", igt_output_name(output));
+
 
 	igt_create_fb(data->drm_fd,
 		      max_t(uint16_t, mode.hdisplay, 64),
Signature · 1 line
2.43.0
#1 lore raw

Hi Sumit,

Quoted 8 lines

-----Original Message-----
From: igt-dev <[email protected]> On Behalf Of sumit kishore
Sent: Monday, March 2, 2026 4:54 PM
To: [email protected]
Cc: Joshi, Kunal1 <[email protected]>; Kishore, Sumit <[email protected]>
Subject: [PATCH i-g-t v1] tests/kms_invalid_mode: add prints when test skips

Title should start with a capital letter "Add" not "add"

Quoted 13 lines

add debug print to display the reason for test skip

---
 tests/kms_invalid_mode.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
tests/kms_invalid_mode.c index renamed from tests/kms_invalid_mode.c +0 -0

5edffb649..8ba488812 100644

tests/kms_invalid_mode.c test_output(data_t *data) · line 271

Quoted 7 lines
tests/kms_invalid_mode.c +2 -1
@@ -266,7 +266,9 @@ test_output(data_t *data)
 	 * sure everything is really getting rejected?
 	 */
 	mode = *igt_output_get_mode(output);
-	igt_require(data->adjust_mode(data, &mode));
+	igt_require_f(data->adjust_mode(data, &mode),
+		"Skipping as %s has scaling properties\n",
 igt_output_name(output));

This skip message isn't quite accurate. Only clock-too-high subtest checks for scaling property. All other adjust_mode functions simply return true.

Imho, It would be better to add the debug message directly in that function.

Regards,
Pranay

Quoted 6 lines
tests/kms_invalid_mode.c +1 -0
+
 
 	igt_create_fb(data->drm_fd,

max_t(uint16_t, mode.hdisplay, 64),
--
2.43.0

#2 lore raw
Quoted 20 lines · Pranay

Hi Sumit,

Quoted 8 lines

-----Original Message-----
From: igt-dev <[email protected]> On Behalf Of sumit kishore
Sent: Monday, March 2, 2026 4:54 PM
To: [email protected]
Cc: Joshi, Kunal1 <[email protected]>; Kishore, Sumit <[email protected]>
Subject: [PATCH i-g-t v1] tests/kms_invalid_mode: add prints when test skips

Title should start with a capital letter "Add" not "add"

Quoted 8 lines

add debug print to display the reason for test skip

---
 tests/kms_invalid_mode.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
Quoted 13 lines

tests/kms_invalid_mode.c test_output(data_t *data) · line 271

Quoted 12 lines
tests/kms_invalid_mode.c index renamed from tests/kms_invalid_mode.c +0 -0

5edffb649..8ba488812 100644

tests/kms_invalid_mode.c +2 -1
@@ -266,7 +266,9 @@ test_output(data_t *data)
 	 * sure everything is really getting rejected?
 	 */
 	mode = *igt_output_get_mode(output);
-	igt_require(data->adjust_mode(data, &mode));
+	igt_require_f(data->adjust_mode(data, &mode),
+		"Skipping as %s has scaling properties\n",
 igt_output_name(output));

This skip message isn't quite accurate. Only clock-too-high subtest checks for scaling property. All other adjust_mode functions simply return true.

That check is pretty much outdated anyway. The kernel will reject the mode if the vrefresh doesn't match any of the connector's fixed modes. So we should probably just remove the check.

Quoted 11 lines

Imho, It would be better to add the debug message directly in that function.

Regards,
Pranay

Quoted 6 lines
tests/kms_invalid_mode.c +1 -0
+
 
 	igt_create_fb(data->drm_fd,

max_t(uint16_t, mode.hdisplay, 64),
--
2.43.0

Signature · 2 lines
Ville Syrjälä
Intel