Skip to contentSkip to conversation

staging: rtl8723bs: fix bitwise OR operator spacing

PATCH Superseded Jose A. Perez de Azpillaga 2 participants 2 messages Mar 2 Staging

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: rtl8723bs: fix bitwise OR operator spacing

Fix spaces between bitwise OR operations rtw_action_frame_parse() for better readability.

---
 drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/rtl8723bs/core/rtw_ieee80211.c +2 -2
index dbd4bcc8cd28..446e4051b9ae 100644
@@ -1123,8 +1123,8 @@ int rtw_action_frame_parse(const u8 *frame, u32 frame_len, u8 *category, u8 *act
 
 	fc = le16_to_cpu(((struct ieee80211_hdr_3addr *)frame)->frame_control);
 
-	if ((fc & (IEEE80211_FCTL_FTYPE|IEEE80211_FCTL_STYPE))
-		!= (IEEE80211_FTYPE_MGMT|IEEE80211_STYPE_ACTION)
+	if ((fc & (IEEE80211_FCTL_FTYPE | IEEE80211_FCTL_STYPE))
+		!= (IEEE80211_FTYPE_MGMT | IEEE80211_STYPE_ACTION)
 	) {
 		return false;
 	}
Signature · 1 line
2.53.0
#1 lore raw
Quoted 13 lines · Jose A. Perez de Azpillaga

Fix spaces between bitwise OR operations rtw_action_frame_parse() for better readability.

---
 drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/rtl8723bs/core/rtw_ieee80211.c +0 -0
index dbd4bcc8cd28..446e4051b9ae 100644

drivers/staging/rtl8723bs/core/rtw_ieee80211.c int rtw_action_frame_parse(const u8 *frame, u32 frame_len, u8 *category, u8 *act · line 1130

Quoted 10 lines
drivers/staging/rtl8723bs/core/rtw_ieee80211.c +2 -2
@@ -1123,8 +1123,8 @@ int rtw_action_frame_parse(const u8 *frame, u32 frame_len, u8 *category, u8 *act
 
 	fc = le16_to_cpu(((struct ieee80211_hdr_3addr *)frame)->frame_control);
 
-	if ((fc & (IEEE80211_FCTL_FTYPE|IEEE80211_FCTL_STYPE))
-		!= (IEEE80211_FTYPE_MGMT|IEEE80211_STYPE_ACTION)
+	if ((fc & (IEEE80211_FCTL_FTYPE | IEEE80211_FCTL_STYPE))
+		!= (IEEE80211_FTYPE_MGMT | IEEE80211_STYPE_ACTION)
 	) {
 		return false;
 	}

Since you're editing this if statement it's preferred that you tidy it up according to kernel standards that'd be:

	if ((fc & (IEEE80211_FCTL_FTYPE | IEEE80211_FCTL_STYPE)) !=
	    (IEEE80211_FTYPE_MGMT | IEEE80211_STYPE_ACTION))
	    	return false;

Thanks,

ET