staging: iio: ad7816: Replace sprintf with sysfs_emit
Subsystems (4)
PATCH 1/1 staging: iio: ad7816: Replace sprintf with sysfs_emit
As stated in Documentation/filesystems/sysfs.rst:
'New implementations of show() methods should only use sysfs_emit() or sysfs_emit_at() when formatting the value to be returned to user space.'
Replace sprintf with sysfs_emit in the following sysfs show functions:
- ad7816_show_mode()
- ad7816_show_available_modes()
- ad7816_show_channel()
- ad7816_show_value()
- ad7816_show_oti()
--- drivers/staging/iio/adc/ad7816.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)
drivers/staging/iio/adc/ad7816.c +8 -8
@@ -124,8 +124,8 @@ static ssize_t ad7816_show_mode(struct device *dev,struct ad7816_chip_info *chip =iio_priv (indio_dev);if (chip->mode) -return sprintf (buf,"power-save\n" ); -return sprintf (buf,"full\n" ); +return sysfs_emit (buf,"power-save\n" ); +return sysfs_emit (buf,"full\n" ); } static ssize_t ad7816_store_mode(struct device *dev,
@@ -156,7 +156,7 @@ static ssize_t ad7816_show_available_modes(struct device *dev,struct device_attribute *attr, char *buf) { - return sprintf(buf, "full\npower-save\n"); + return sysfs_emit(buf, "full\npower-save\n"); } static IIO_DEVICE_ATTR(available_modes, 0444, ad7816_show_available_modes,
@@ -169,7 +169,7 @@ static ssize_t ad7816_show_channel(struct device *dev,struct iio_dev *indio_dev =dev_to_iio_dev (dev);struct ad7816_chip_info *chip =iio_priv (indio_dev); -return sprintf (buf,"%d\n" , chip->channel_id); +return sysfs_emit (buf,"%d\n" , chip->channel_id); } static ssize_t ad7816_store_channel(struct device *dev,
@@ -231,9 +231,9 @@ static ssize_t ad7816_show_value(struct device *dev, data &=AD7816_TEMP_FLOAT_MASK ;if (value <0 ) data =BIT (AD7816_TEMP_FLOAT_OFFSET ) - data; -return sprintf (buf,"%d.%.2d\n" , value, data *25 ); +return sysfs_emit (buf,"%d.%.2d\n" , value, data *25 ); } -return sprintf (buf,"%u\n" , data); +return sysfs_emit (buf,"%u\n" , data); } static IIO_DEVICE_ATTR(value, 0444, ad7816_show_value, NULL, 0);
@@ -281,9 +281,9 @@ static ssize_t ad7816_show_oti(struct device *dev, value =AD7816_BOUND_VALUE_MIN + (chip->oti_data[chip->channel_id] -AD7816_BOUND_VALUE_BASE ); -return sprintf (buf,"%d\n" , value); +return sysfs_emit (buf,"%d\n" , value); } -return sprintf (buf,"%u\n" , chip->oti_data[chip->channel_id]); +return sysfs_emit (buf,"%u\n" , chip->oti_data[chip->channel_id]); } static inline ssize_t ad7816_set_oti(struct device *dev,
Signature · 1 line
2.47.3
Jonathan Cameron
maintainerQuoted 4 lines · On Sun, 01 Mar 2026 21:28:26 +0000 Bruno Martins <[email protected]> wrote:
As stated in
Documentation/filesystems/sysfs.rst:
'New implementations ofshow()methods should only usesysfs_emit()orsysfs_emit_at()when formatting the value to be returned to user space.'
Quoted 8 lines
Replace sprintf with
sysfs_emitin the following sysfs show functions:
-ad7816_show_mode()
-ad7816_show_available_modes()
-ad7816_show_channel()
-ad7816_show_value()
-ad7816_show_oti()Signed-off-by Bruno Martins <[email protected]>
Hi Bruno,
I've applied this but want to note that the majority if not all of these are non standard ABI that will ultimately need to be replaced with standard IIO ABI as part of getting this driver ready to move out of staging.
Still, in the meantime your patch removes some bad practice that might get copied so fair enough!
Applied to the testing branch of iio.git which will become togreg once the bots have let me know if they found anything.
Jonathan
Quoted 61 lines
--- drivers/staging/iio/adc/ad7816.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)drivers/staging/iio/adc/ad7816.c +8
-8@@ -124,8 +124,8 @@ static ssize_t ad7816_show_mode(struct device *dev,struct ad7816_chip_info *chip =iio_priv (indio_dev);if (chip->mode) -return sprintf (buf,"power-save\n" ); -return sprintf (buf,"full\n" ); +return sysfs_emit (buf,"power-save\n" ); +return sysfs_emit (buf,"full\n" ); } static ssize_t ad7816_store_mode(struct device *dev,@@ -156,7 +156,7 @@ static ssize_t ad7816_show_available_modes(struct device *dev,struct device_attribute *attr, char *buf) { - return sprintf(buf, "full\npower-save\n"); + return sysfs_emit(buf, "full\npower-save\n"); } static IIO_DEVICE_ATTR(available_modes, 0444, ad7816_show_available_modes,@@ -169,7 +169,7 @@ static ssize_t ad7816_show_channel(struct device *dev,struct iio_dev *indio_dev =dev_to_iio_dev (dev);struct ad7816_chip_info *chip =iio_priv (indio_dev); -return sprintf (buf,"%d\n" , chip->channel_id); +return sysfs_emit (buf,"%d\n" , chip->channel_id); } static ssize_t ad7816_store_channel(struct device *dev,@@ -231,9 +231,9 @@ static ssize_t ad7816_show_value(struct device *dev, data &=AD7816_TEMP_FLOAT_MASK ;if (value <0 ) data =BIT (AD7816_TEMP_FLOAT_OFFSET ) - data; -return sprintf (buf,"%d.%.2d\n" , value, data *25 ); +return sysfs_emit (buf,"%d.%.2d\n" , value, data *25 ); } -return sprintf (buf,"%u\n" , data); +return sysfs_emit (buf,"%u\n" , data); } static IIO_DEVICE_ATTR(value, 0444, ad7816_show_value, NULL, 0);@@ -281,9 +281,9 @@ static ssize_t ad7816_show_oti(struct device *dev, value =AD7816_BOUND_VALUE_MIN + (chip->oti_data[chip->channel_id] -AD7816_BOUND_VALUE_BASE ); -return sprintf (buf,"%d\n" , value); +return sysfs_emit (buf,"%d\n" , value); } -return sprintf (buf,"%u\n" , chip->oti_data[chip->channel_id]); +return sysfs_emit (buf,"%u\n" , chip->oti_data[chip->channel_id]); } static inline ssize_t ad7816_set_oti(struct device *dev,