w1: ds2490: drop redundant device reference
PATCH 1/1 w1: ds2490: drop redundant device reference
Driver core holds a reference to the USB interface and its parent USB device while the interface is bound to a driver and there is no need to take additional references unless the structures are needed after disconnect.
Drop the redundant device reference to reduce cargo culting, make it easier to spot drivers where an extra reference is needed, and reduce the risk of memory leaks when drivers fail to release it.
--- drivers/w1/masters/ds2490.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-)
drivers/w1/masters/ds2490.c +3 -8
@@ -1022,11 +1022,8 @@ static int ds_probe(struct usb_interface *intf,if (!dev)return -ENOMEM ; - dev->udev =usb_get_dev (udev); -if (!dev->udev) { - err = -ENOMEM ; - goto err_out_free; - } + dev->udev = udev; +memset (dev->ep,0 ,sizeof (dev->ep));usb_set_intfdata (intf, dev);
@@ -1085,9 +1082,8 @@ static int ds_probe(struct usb_interface *intf, err_out_clear:usb_set_intfdata (intf,NULL ); -usb_put_dev (dev->udev); -err_out_free:kfree (dev); +return err; }
@@ -1107,7 +1103,6 @@ static void ds_disconnect(struct usb_interface *intf)usb_set_intfdata (intf,NULL ); -usb_put_dev (dev->udev);kfree (dev); }
Signature · 1 line
2.52.0
Quoted 10 lines · Johan Hovold
Driver core holds a reference to the USB interface and its parent USB device while the interface is bound to a driver and there is no need to take additional references unless the structures are needed after disconnect.
Drop the redundant device reference to reduce cargo culting, make it easier to spot drivers where an extra reference is needed, and reduce the risk of memory leaks when drivers fail to release it.
[...]
Applied, thanks!
[1/1] w1: ds2490: drop redundant device reference
https://git.kernel.org/krzk/linux-w1/c/f2c1ae05fe82030537b36012551a5cac28d00254
Best regards,
Signature · 1 line
Krzysztof Kozlowski <[email protected]>